[GitHub] [roller] dependabot[bot] opened a new pull request, #120: Bump spring-web from 5.3.20 to 6.0.0 in /app
dependabot[bot] opened a new pull request, #120: URL: https://github.com/apache/roller/pull/120 Bumps [spring-web](https://github.com/spring-projects/spring-framework) from 5.3.20 to 6.0.0. Release notes Sourced from https://github.com/spring-projects/spring-framework/releases";>spring-web's releases. v6.0.0 See https://github.com/spring-projects/spring-framework/wiki/What%27s-New-in-Spring-Framework-6.x";>What's New in Spring Framework 6.x and https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-6.x";>Upgrading to Spring Framework 6.x for upgrade instructions and details of new features. :star: New Features Avoid direct URL construction and URL equality checks https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29486";>#29486 Simplify creating RFC 7807 responses from functional endpoints https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29462";>#29462 Allow test classes to provide runtime hints via declarative mechanisms https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29455";>#29455 :notebook_with_decorative_cover: Documentation Align javadoc of DefaultParameterNameDiscoverer with its behavior https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29494";>#29494 Document AOT support in the TestContext framework https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29482";>#29482 Document Ahead of Time processing in the reference guide https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29350";>#29350 :hammer: Dependency Upgrades Upgrade to Reactor 2022.0.0 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29465";>#29465 :heart: Contributors Thank you to all the contributors who worked on this release: https://github.com/ophiuhus";>@ophiuhus and https://github.com/wilkinsona";>@wilkinsona v6.0.0-RC4 :star: New Features Introduce DataFieldMaxValueIncrementer for SQL Server sequences https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29447";>#29447 Introduce findAllAnnotationsOnBean variant on ListableBeanFactory https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29446";>#29446 Introduce support for Jakarta WebSocket 2.1 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29436";>#29436 Allow @ControllerAdvice in WebFlux to handle exceptions before a handler is selected https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/22991";>#22991 :lady_beetle: Bug Fixes Bean with unresolved generics do not use fallback algorithms with AOT https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29454";>#29454 TomcatRequestUpgradeStrategy is not compatible with Tomcat 10.1 https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/29434";>#29434 Autowiring of a generic type produced by a factory bean fails after AOT processing https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29385";>#29385 :notebook_with_decorative_cover: Documentation Reference PDF containing full docs not available https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/28451";>#28451 :hammer: Dependency Upgrades Revisit Servlet API baseline: Servlet 6.0 in the build, Servlet 5.0 compatibility at runtime https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29435";>#29435 Upgrade to Context Propagation 1.0.0 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29442";>#29442 Upgrade to Jackson 2.14.0 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29351";>#29351 Upgrade to Micrometer 1.10.0 https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/29441";>#29441 ... (truncated) Commits https://github.com/spring-projects/spring-framework/commit/5a30a43b753a971ac8bf4005a8ccddeaff439d7e";>5a30a43 Release v6.0.0 https://github.com/spring-projects/spring-framework/commit/42856bab164dd0b9d92dbb1cd42acce66d491ffa";>42856ba Add milestone repo for optional Netty 5 support https://github.com/spring-projects/spring-framework/commit/9be6cea012b2c5ac55e862329ccb9103e978f3d2";>9be6cea Polishing deprecated methods https://github.com/spring-projects/spring-framework/commit/37b439182e4aacf48b33d9c1ad3201a2ef5a6f13";>37b4391 Align javadoc of DefaultParameterNameDiscoverer with its behavior https://github.com/spring-projects/spring-framework/commit/09a58a55bf7882f24352c0bb2ecf742c14c22cc3";>09a58a5 Polish https://github.com/spring-projects/spring-framework/commit/10f4ad1a44a7031b84a9f43578a5d37135ad21da";>10f4ad1 Assert
[GitHub] [roller] mbien commented on pull request #119: minor dependency updates + test-summary workflow action
mbien commented on PR #119: URL: https://github.com/apache/roller/pull/119#issuecomment-1344814362 some notes on dependency bumps: - Spring 6 is released but it requires JDK 17, so I kept it at 5.x for now since Roller is using 11 still - Struts [2.5.30](https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.30) and later has some breaking changes, so I kept it at 2.5.29 for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #119: minor dependency updates + test-summary workflow action
mbien commented on PR #119: URL: https://github.com/apache/roller/pull/119#issuecomment-1344809941 there you go. Some test annotations were missing. Whats interesting however is that the tests run in a different order on github than they do on my system locally. Once the MediaFile test started running first, it failed since it didn't boostrap roller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #119: minor dependency updates + test-summary workflow action
mbien commented on PR #119: URL: https://github.com/apache/roller/pull/119#issuecomment-1344790720 ok thats weird. I can't explain right now why this PR started failing. Can't reproduce this issue locally and I basically reverted everything already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #114: Merged CodeQL workflow into main workflow.
mbien commented on PR #114: URL: https://github.com/apache/roller/pull/114#issuecomment-1314286969 closing in favor of #119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien closed pull request #114: Merged CodeQL workflow into main workflow.
mbien closed pull request #114: Merged CodeQL workflow into main workflow. URL: https://github.com/apache/roller/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request, #119: minor dependency updates + test-summary workflow action
mbien opened a new pull request, #119: URL: https://github.com/apache/roller/pull/119 - the test-summary action has [been green lit by infra](https://issues.apache.org/jira/browse/INFRA-23445) for CI use and works fairly well for the NetBeans project where we use it since then. The only annoyance is that it ignores errors, while it will pick up junit failures, but a PR is pending for that. It writes test result report directly to the workflow summary page (not to checks, which felt like a workaround anyway). - test runners should have geckodriver preinstalled, lets see if we can simply set a path to it. - minor maven dependency updates - gh action version updates since they cause warnings - bump JDK 18 to 19 in the test matrix tested locally.. lets see if everything builds with CI too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #118: Upgrade to Jakarta Eclipselink + other minor dependency bumps
mbien merged PR #118: URL: https://github.com/apache/roller/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request, #118: Upgrade to Jakarta Eclipselink + other minor dependency bumps
mbien opened a new pull request, #118: URL: https://github.com/apache/roller/pull/118 - jakarta namespace update allows roller to use eclipse link 3.x. - minor dependency updates (asm, lucene, spring, jquery-ui webjar) struts wasn't updated due to some breaking changes, see: - https://github.com/apache/struts/pull/496 - https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] dependabot[bot] opened a new pull request, #117: Bump struts2-core from 2.5.29 to 2.5.30 in /app
dependabot[bot] opened a new pull request, #117: URL: https://github.com/apache/roller/pull/117 Bumps [struts2-core](https://github.com/apache/struts) from 2.5.29 to 2.5.30. Commits See full diff in https://github.com/apache/struts/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/roller/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #116: upload dev build + add JDK 18 to the matrix + version bumps.
mbien commented on pull request #116: URL: https://github.com/apache/roller/pull/116#issuecomment-1086509966 verified that it works. It will only upload the artifact during integration, not during PR checks to conserve resources. example at bottom of the page: https://github.com/apache/roller/actions/runs/2080694025 link to all builds for master branch: https://github.com/apache/roller/actions/workflows/main.yml?query=branch%3Amaster retention is set to 90 days -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #116: upload dev build + add JDK 18 to the matrix + version bumps.
mbien merged pull request #116: URL: https://github.com/apache/roller/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #116: upload dev build + add JDK 18 to the matrix + version bumps.
mbien opened a new pull request #116: URL: https://github.com/apache/roller/pull/116 upload a dev build as CI step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #115: dependency updates, added bouncycastle, minor log level update.
mbien merged pull request #115: URL: https://github.com/apache/roller/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #115: dependency updates, added bouncycastle, minor log level update.
mbien commented on pull request #115: URL: https://github.com/apache/roller/pull/115#issuecomment-1086409287 merging (without review) to make it easier for users to build roller with the spring fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #115: dependency updates, added bouncycastle, minor log level update.
mbien opened a new pull request #115: URL: https://github.com/apache/roller/pull/115 - **notable dependency update: spring 5.3.18** with **security** fixes for "[spring4shell](https://security.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-2436751)" - bouncy castle was added so that the popular Argon2 pw encoder can be used available (non legacy) encoders: bcrypt, pbkdf2, scrypt, argon2 **Reminder how to change the encoder:** `passwds.encryption.algorithm=argon2`, default remains `pbkdf2` automatic migration happens on next pw change **If one of the (very, very) old legacy codecs is still in use, roller will need a hint for migration** `passwds.encryption.lazyUpgradeFrom=` possible options: `plaintext, MD5, SHA-1` can be left empty if the db doesn't contain any legacy encoded pws @snoopdave might be a good time for another point release :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] snoopdave merged pull request #112: Minor fixes in Velocity Templates and dependency updates
snoopdave merged pull request #112: URL: https://github.com/apache/roller/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #114: Merged CodeQL workflow into main workflow.
mbien commented on pull request #114: URL: https://github.com/apache/roller/pull/114#issuecomment-1002724702 looks like the CodeQL alerts are going to be reset (reported as new issues, while the old are removed) since the job is started from a different file. but the aggregation is working: https://github.com/apache/roller/pull/114/checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #114: Merged CodeQL workflow into main workflow.
mbien opened a new pull request #114: URL: https://github.com/apache/roller/pull/114 followup on https://github.com/apache/roller/pull/113 This is a workaround which ensures that the test reports end up in the correct workflow. example: JUnit reports of: https://github.com/apache/roller/actions/runs/1627718913 ended up here: https://github.com/apache/roller/actions/runs/1627718912 If there is just one workflow, they can't end up in the wrong one :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] snoopdave commented on pull request #112: Minor fixes in Velocity Templates and dependency updates
snoopdave commented on pull request #112: URL: https://github.com/apache/roller/pull/112#issuecomment-1001742386 Cool. I'm all for it if it makes things easier for folks using Netbeans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #113: Added github actions for basic build/test setup.
mbien commented on pull request #113: URL: https://github.com/apache/roller/pull/113#issuecomment-1001671302 https://github.com/mikepenz/action-junit-report/issues/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #113: Added github actions for basic build/test setup.
mbien commented on pull request #113: URL: https://github.com/apache/roller/pull/113#issuecomment-1001670124 oh haha. It published it in he CodeQL action https://github.com/apache/roller/actions/runs/1627718912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #113: Added github actions for basic build/test setup.
mbien commented on pull request #113: URL: https://github.com/apache/roller/pull/113#issuecomment-1001666008 it builds and tests but it didn't upload the test report (it should appear on the list on the left i think) https://github.com/apache/roller/actions/runs/1627718913 Don't know why because I tested it on my wip branch and it worked fine. (but its not so important tbh, the full log is recorded anyway in case something fails) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #113: Added github actions for basic build/test setup.
mbien merged pull request #113: URL: https://github.com/apache/roller/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #113: Added github actions for basic build/test setup.
mbien commented on pull request #113: URL: https://github.com/apache/roller/pull/113#issuecomment-1001661717 awesome. I merge it, lets see if everything builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #112: Minor fixes in Velocity Templates and dependency updates
mbien commented on pull request #112: URL: https://github.com/apache/roller/pull/112#issuecomment-1001653162 > Velocity changes LGTM. Do the Netbeans changes allow you to debug tests in the IDE? Its mostly for registering non-standard maven goals. like jetty:run, or the selenium tests which have to specify a path to the "geckodriver". Pressing the run/debug button on Roller webapp or the Selenium tests will do the right thing. Debugging junit did actually work before already since netbeans knows how to use that plugin. There is also a "display-dependency-updates" action registered for the root project to quickly check if something can be updated. I am not feeling strongly about it. If you don't want it in the repository I can leave it out and put nbactions.xml on gitignore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #113: Added github actions for basic build/test setup.
mbien commented on pull request #113: URL: https://github.com/apache/roller/pull/113#issuecomment-1001002706 added step for selenium tests (didn't know that geckodriver could run headless). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #113: Added github actions for basic build/test setup.
mbien commented on pull request #113: URL: https://github.com/apache/roller/pull/113#issuecomment-1000996443 i think the junit report will start working once the yaml is in master. should look like this: https://github.com/mbien/roller/runs/4631232068?check_suite_focus=true and if something fails: https://github.com/mbien/roller/runs/4631155838?check_suite_focus=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #113: Added github actions for basic build/test setup.
mbien opened a new pull request #113: URL: https://github.com/apache/roller/pull/113 - builds/tests on JDK 11 and 17 - uploads junit report - disabled a failing test for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #112: Minor fixes in Velocity Templates and dependency updates
mbien opened a new pull request #112: URL: https://github.com/apache/roller/pull/112 - Apache Rome had a release - templates should use `$foreach.index` in loops, old `$velocityCount` isn't working anymore - another stream was left open - Registered some maven actions for NetBeans -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #111: bugfix: SearchServlet forgot to copy the user to WeblogPageRequest.
mbien merged pull request #111: URL: https://github.com/apache/roller/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #110: updated container setup.
mbien merged pull request #110: URL: https://github.com/apache/roller/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #110: updated container setup.
mbien commented on pull request #110: URL: https://github.com/apache/roller/pull/110#issuecomment-1000630935 perfect. I changed the containerfile to checkout tags/roller-6.1.0 instead of master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] snoopdave commented on pull request #110: updated container setup.
snoopdave commented on pull request #110: URL: https://github.com/apache/roller/pull/110#issuecomment-1000410331 @mbien I pushed a roller-6.1.0 tag today and cleaned up all the old RC tags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #111: bugfix: SearchServlet forgot to copy the user to WeblogPageRequest.
mbien commented on pull request #111: URL: https://github.com/apache/roller/pull/111#issuecomment-198303 @gregh3269 this should fix the issue you mentioned on the dev list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #110: updated container setup.
mbien commented on pull request #110: URL: https://github.com/apache/roller/pull/110#issuecomment-148169 @snoopdave could we get a roller-6.1.0 tag for the recent release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #111: bugfix: SearchServlet forgot to copy the user to WeblogPageRequest.
mbien opened a new pull request #111: URL: https://github.com/apache/roller/pull/111 Template model of the search results page always thought the user was not logged in. fix is here f1f80002ace0c5983bb4f7437110b4216e62cba9 other commit tries to improve readability a little bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #110: updated container setup.
mbien opened a new pull request #110: URL: https://github.com/apache/roller/pull/110 - fixed urls - upgraded to jdk17 and latest lib versions - better signal handling (made sure container stop signal propagates to tomcat) i leave this as draft until we have a tag for 6.1, so i can change the git checkout line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] snoopdave merged pull request #109: Dependency update to log4j2 2.17.
snoopdave merged pull request #109: URL: https://github.com/apache/roller/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] snoopdave merged pull request #108: Omit answer from CommentServlet response.
snoopdave merged pull request #108: URL: https://github.com/apache/roller/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #109: Dependency update to log4j2 2.17.
mbien opened a new pull request #109: URL: https://github.com/apache/roller/pull/109 + minor struts and spring version bump https://logging.apache.org/log4j/2.x/changes-report.html#a2.17.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #108: Omit answer from CommentServlet response.
mbien opened a new pull request #108: URL: https://github.com/apache/roller/pull/108 static response is good enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #107: Dependency update to log4j2 2.16.
mbien merged pull request #107: URL: https://github.com/apache/roller/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #107: Dependency update to log4j2 2.16.
mbien opened a new pull request #107: URL: https://github.com/apache/roller/pull/107 another log4j2 version bump - disables JNDI by default - removes support for msg lookups https://logging.apache.org/log4j/2.x/changes-report.html#a2.16.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #106: maven dependency updates
mbien merged pull request #106: URL: https://github.com/apache/roller/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #106: maven dependency updates
mbien merged pull request #106: URL: https://github.com/apache/roller/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien closed pull request #104: Inefficient Usage of Java Collections
mbien closed pull request #104: URL: https://github.com/apache/roller/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #106: maven dependency updates
mbien opened a new pull request #106: URL: https://github.com/apache/roller/pull/106 highlights: - log4j 2.15.0 (fixes security vulnerability[1][2]) - lucene 9 (artifact name changed) - spring security 5.6 - jquery-ui 1.13 via webjar - other minor version bumps [1] https://www.lunasec.io/docs/blog/log4j-zero-day/ [2] https://github.com/apache/logging-log4j2/pull/608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #100: Translation: Simplified Chinese
mbien merged pull request #100: URL: https://github.com/apache/roller/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #100: Translation: Simplified Chinese
mbien commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-966101262 excellent, i see the matching author information now. @silkriver thank you for the contribution and patience. The next PR should be easier :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] silkriver commented on pull request #100: Translation: Simplified Chinese
silkriver commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-96593 @mbien ok I tried again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #100: Translation: Simplified Chinese
mbien commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-964884542 @silkriver unfortunately i still see the same email address ``` git fetch origin pull/100/head:chinese_local git checkout chinese_local git log commit 793d5e2d60afdae1e953d222724d050ccae7cf70 (HEAD -> chinese_local) Author: silkriver Date: Sun Jul 18 19:37:06 2021 +0800 Translation: Simplified Chinese ... ``` could you try: `git commit --amend --author="Luo Cheng "` and force push again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #100: Translation: Simplified Chinese
mbien commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-952290892 @silkriver could you change the email on the commit to the same email you used on the ICLA? Feel free to force push to the branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] adityasharma7 commented on pull request #100: Translation: Simplified Chinese
adityasharma7 commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-951761437 I am able to find Luo Cheng with email yuqi...@hotmail.com -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #100: Translation: Simplified Chinese
mbien commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-951167191 @adityasharma7 yeah i still can't access those with my apache id. I don't want to bother the admins too much since its not so important. Can you check if we can merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] silkriver commented on pull request #100: Translation: Simplified Chinese
silkriver commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-951001153 Just updated my profile to display the public email. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] adityasharma7 commented on pull request #100: Translation: Simplified Chinese
adityasharma7 commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-950573068 @silkriver Could you please share the email address with which you have signed the ICLA? Also, it would be good if you could set the email in your git config (though not a requirement) for easy access `git config user.email john...@example.com` Refer https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup > I can't find your nickname on the list https://people.apache.org/committer-index.html @mbien This is for committers only. You could find the unlisted CLAs at https://whimsy.apache.org/officers/unlistedclas.cgi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #100: Translation: Simplified Chinese
mbien commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-950193361 @silkriver did everything work fine? I can't find your nickname on the list https://people.apache.org/committer-index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #105: Small Code Optimizations + Dependency Updates
mbien merged pull request #105: URL: https://github.com/apache/roller/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #105: Small Code Optimizations + Dependency Updates
mbien commented on pull request #105: URL: https://github.com/apache/roller/pull/105#issuecomment-950191829 @snoopdave no worries dave, thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #105: Small Code Optimizations + Dependency Updates
mbien opened a new pull request #105: URL: https://github.com/apache/roller/pull/105 a set of refactorings for better performance or more concise / easier to read code + minor version dependency updates most of it was done by using the jackpot code inspection rules found here: https://github.com/mbien/jackpot-inspections -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #101: MediaFileView.jsp delete folder JS error fix
mbien merged pull request #101: URL: https://github.com/apache/roller/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #103: "/tags/" appears twice in the cache key.
mbien merged pull request #103: URL: https://github.com/apache/roller/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #104: Inefficient Usage of Java Collections
mbien commented on pull request #104: URL: https://github.com/apache/roller/pull/104#issuecomment-919713678 hello @DittoTool i took a quick look, and beside it not compiling: * 850c7a5 getWeblogHandleLetterMap() can't be changed since it is a public service and returns an alphabetically sorted index * 7e46a11 RollerPermission would need more work, but since roller has very few permissions, it wouldn't really make a difference performance wise. Additionally: the permissions are persisted as comma separated String, so changing the order randomly might lead to other problems and would need more investigation and testing. * b24e89c is example code which uses a hardcoded list of 3 items. please don't claim that you tested a PR when the changes don't compile (i will give you the benefit of the doubt and assume that the commit is missing something). (i can't find dittotool on the apache contributors list https://people.apache.org/committer-index.html, so you might have to sign the CLA first before contributing to an apache project: https://www.apache.org/licenses/contributor-agreements.html ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] DittoTool opened a new pull request #104: Inefficient Usage of Java Collections
DittoTool opened a new pull request #104: URL: https://github.com/apache/roller/pull/104 Hi, We find that there are several inefficient usages of Java Collections: 1. The contains method is invoked upon a list object. We recommend replacing it with a HashSet. 2. There is no iteration occurring upon a TreeMap, thus the insertion order does not matter. We recommend replacing it with a HashMap. We discovered the above inefficient usage of containers by our tool Ditto. The patch is submitted. Could you please check and accept it? We have tested the patch on our PC. The patched program works well. Bests Ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #103: "/tags/" appears twice in the cache key.
mbien opened a new pull request #103: URL: https://github.com/apache/roller/pull/103 Small fix. Did not impact functionality, just the way cache keys were generated. bug introduced in 7d07a84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #102: CodeQL fixes
mbien commented on pull request #102: URL: https://github.com/apache/roller/pull/102#issuecomment-917782955 @snoopdave thanks for taking a look. As mentioned in the PR I just manually closed the two additional CodeQL alerts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #102: CodeQL fixes
mbien merged pull request #102: URL: https://github.com/apache/roller/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #102: CodeQL fixes
mbien opened a new pull request #102: URL: https://github.com/apache/roller/pull/102 todo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #101: MediaFileView.jsp delete folder JS error fix
mbien opened a new pull request #101: URL: https://github.com/apache/roller/pull/101 As noticed by Greg Huber on the mailing list, deleting a folder in the media file view results in a JS error. (although the folder is still deleted) this fixes it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #97: EncodePreTagsPlugin
mbien merged pull request #97: URL: https://github.com/apache/roller/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #98: Velocity property warning fixes
mbien merged pull request #98: URL: https://github.com/apache/roller/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #96: Deprections, compiler warning fixes, local refactorings and JDK 17 support
mbien merged pull request #96: URL: https://github.com/apache/roller/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #96: Deprections, compiler warning fixes, local refactorings and JDK 17 support
mbien commented on pull request #96: URL: https://github.com/apache/roller/pull/96#issuecomment-894860204 > Works for me. I built and ran on JDK17 and did not notice any problems. > > I did notice one error in tests but I think it is fixed in master: > > ``` > [ERROR] Errors: > [ERROR] SingleThreadedFeedUpdaterTest.testUpdateSubscription:72 » Updater Error fetchi... > ``` hmm. This test usually fails when rollerblogger.org is temporary unreachable since it relies on its feed. I tested this PR again and everything was green except the IPBanListTest, but the test itself has some file-io race conditions on my system - but this would be unrelated to this PR. Going to integrate this but keep an eye on the test :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #94: Media page css fixes
mbien merged pull request #94: URL: https://github.com/apache/roller/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien edited a comment on pull request #97: EncodePreTagsPlugin
mbien edited a comment on pull request #97: URL: https://github.com/apache/roller/pull/97#issuecomment-894356245 > LGTM you are too fast for me Dave, now its fixed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #97: EncodePreTagsPlugin
mbien commented on pull request #97: URL: https://github.com/apache/roller/pull/97#issuecomment-894356245 > LGTM you are too fast for me Dave, now its fixed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #97: EncodePreTagsPlugin
mbien commented on pull request #97: URL: https://github.com/apache/roller/pull/97#issuecomment-893061819 just found a bug while writing a blog entry :) I always forget that a Matcher doesn't like '$'' signs in the input by default. Have to fix this first - should be easy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #97: EncodePreTagsPlugin
mbien commented on pull request #97: URL: https://github.com/apache/roller/pull/97#issuecomment-893061819 just found a bug while writing a blog entry :) I always forget that a Matcher doesn't like '$'' signs in the input by default. Have to fix this first - should be easy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] silkriver commented on pull request #100: Translation: Simplified Chinese
silkriver commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-889653531 OK, I have send the documents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #100: Translation: Simplified Chinese
mbien commented on pull request #100: URL: https://github.com/apache/roller/pull/100#issuecomment-889313850 hello @silkriver. Thank you for the translation. However before you can contribute to an Apache project you would have to sign the Apache contributor agreement (ICLA) found here: https://www.apache.org/licenses/contributor-agreements.html#clas and submit it to Apache via email https://www.apache.org/licenses/contributor-agreements.html#submitting after that I can merge your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #99: Updated: the header to show the tagline only when its available
mbien merged pull request #99: URL: https://github.com/apache/roller/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #99: Updated: the header to show the tagline only when its available
mbien commented on pull request #99: URL: https://github.com/apache/roller/pull/99#issuecomment-885491493 lgtm, integrating -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] silkriver opened a new pull request #100: Translation: Simplified Chinese
silkriver opened a new pull request #100: URL: https://github.com/apache/roller/pull/100 Made a full translation of simplified Chinese -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] ymaheshwari1 commented on pull request #99: Updated: the header to show the tagline only when its available
ymaheshwari1 commented on pull request #99: URL: https://github.com/apache/roller/pull/99#issuecomment-882030135 Hi @mbien I am checking other themes for the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #99: Updated: the header to show the tagline only when its available
mbien commented on pull request #99: URL: https://github.com/apache/roller/pull/99#issuecomment-882027301 Hi Yash, have you checked if this can also happen with the other themes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] ymaheshwari1 opened a new pull request #99: Updated: the header to show the tagline only when its available
ymaheshwari1 opened a new pull request #99: URL: https://github.com/apache/roller/pull/99 Added an if condition to check whether the weblog has a tagline defined or not and if there is a tagline present then only displaying the tagline. Before: Tagline is always displayed.  After: Tagline is only displayed when its defined  If tagline is not present then nothing is displayed.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #98: Velocity property warning fixes
mbien opened a new pull request #98: URL: https://github.com/apache/roller/pull/98 fixes usage of deprecated velocity properties. I extracted the warnings out of JFR logs and did a project wide search and replace. Log level for velocity can be set to info again I suppose. The other commits fix an encoding issue and add a smaller security improvement for session cookies. here the extracted list: ``` deprecation: configuration key 'class.resource.loader.cache' has been deprecated in favor of 'resource.loader.class.cache' deprecation: configuration key 'class.resource.loader.class' has been deprecated in favor of 'resource.loader.class.class' deprecation: configuration key 'class.resource.loader.description' has been deprecated in favor of 'resource.loader.class.description' deprecation: configuration key 'class.resource.loader.modificationCheckInterval' has been deprecated in favor of 'resource.loader.class.modificationCheckInterval' deprecation: configuration key 'roller.resource.loader.cache' has been deprecated in favor of 'resource.loader.roller.cache' deprecation: configuration key 'roller.resource.loader.class' has been deprecated in favor of 'resource.loader.roller.class' deprecation: configuration key 'roller.resource.loader.description' has been deprecated in favor of 'resource.loader.roller.description' deprecation: configuration key 'roller.resource.loader.modificationCheckInterval' has been deprecated in favor of 'resource.loader.roller.modificationCheckInterval' deprecation: configuration key 'roller.resource.loader.public.name' has been deprecated in favor of 'resource.loader.roller.public.name' deprecation: configuration key 'webapp.resource.loader.cache' has been deprecated in favor of 'resource.loader.webapp.cache' deprecation: configuration key 'webapp.resource.loader.class' has been deprecated in favor of 'resource.loader.webapp.class' deprecation: configuration key 'webapp.resource.loader.description' has been deprecated in favor of 'resource.loader.webapp.description' deprecation: configuration key 'webapp.resource.loader.modificationCheckInterval' has been deprecated in favor of 'resource.loader.webapp.modificationCheckInterval' deprecation: configuration key 'webapp.resource.loader.path' has been deprecated in favor of 'resource.loader.webapp.path' deprecation: configuration key 'theme.resource.loader.cache' has been deprecated in favor of 'resource.loader.theme.cache' deprecation: configuration key 'theme.resource.loader.class' has been deprecated in favor of 'resource.loader.theme.class' deprecation: configuration key 'theme.resource.loader.description' has been deprecated in favor of 'resource.loader.theme.description' deprecation: configuration key 'theme.resource.loader.modificationCheckInterval' has been deprecated in favor of 'resource.loader.theme.modificationCheckInterval' deprecation: configuration key 'theme.resource.loader.public.name' has been deprecated in favor of 'resource.loader.theme.public.name' deprecation: configuration key 'runtime.introspector.uberspect' has been deprecated in favor of 'introspector.uberspect.class' deprecation: configuration key 'velocimacro.library' has been deprecated in favor of 'velocimacro.library.path' deprecation: configuration key 'velocimacro.permissions.allow.inline' has been deprecated in favor of 'velocimacro.inline.allow' deprecation: configuration key 'velocimacro.permissions.allow.inline.local.scope' has been deprecated in favor of 'velocimacro.inline.local_scope' deprecation: configuration key 'input.encoding' has been deprecated in favor of 'resource.default_encoding' deprecation: configuration key 'resource.loader' has been deprecated in favor of 'resource.loaders' deprecation: configuration key 'modificationCheckInterval' has been deprecated in favor of 'modification_check_interval' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #97: EscapeSourceCodePlugin
mbien opened a new pull request #97: URL: https://github.com/apache/roller/pull/97 Simple weblog entry plugin which can be used to escape angle brackets from text within pre tags. It understands the common pattern of pre and code tag in succession which is used by javascript source code highlighters and doesn't escape code tags directly following pre. Hopefully useful for programmers which like to blog in html mode and simply paste code into pre tags without breaking the page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien opened a new pull request #96: Deprections, compiler warning fixes, local refactorings and JDK 17 support
mbien opened a new pull request #96: URL: https://github.com/apache/roller/pull/96 Worked myself though the compiler warnings. This looks like a lot of changes, but the individual changes are all very local. * since most of the rawtype warnings were on Collections, I updated a lot of the code to use more modern APIs instead of only fixing the warnings (e.g List.of, streams, ...) * extracted common reflection code to a utility class * got rid of some deprecations * some cleanup and improvements (~400 lines less code) * JDK 17 support (runs still on 11) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #95: Updated: the main menu to have proper space when displaying permission message
mbien merged pull request #95: URL: https://github.com/apache/roller/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #95: Updated: the main menu to have proper space when displaying permission message
mbien commented on pull request #95: URL: https://github.com/apache/roller/pull/95#issuecomment-876927933 good catch! merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] ymaheshwari1 opened a new pull request #95: Updated: the main menu to have proper space when displaying permission message
ymaheshwari1 opened a new pull request #95: URL: https://github.com/apache/roller/pull/95 Added space between the permission message. Before:  After:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #93: fix for PropertyNotFoundException when started in WildFly
mbien merged pull request #93: URL: https://github.com/apache/roller/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #93: fix for PropertyNotFoundException when started in WildFly
mbien commented on pull request #93: URL: https://github.com/apache/roller/pull/93#issuecomment-873673405 integrating since trivial + #64 was already reviewed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #92: Replaced deprecated rome-fetcher with java 11 HttpClient
mbien merged pull request #92: URL: https://github.com/apache/roller/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien merged pull request #84: Improve input validation
mbien merged pull request #84: URL: https://github.com/apache/roller/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] mbien commented on pull request #84: Improve input validation
mbien commented on pull request #84: URL: https://github.com/apache/roller/pull/84#issuecomment-873671658 thank you for the review @snoopdave -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] snoopdave commented on pull request #84: Improve input validation
snoopdave commented on pull request #84: URL: https://github.com/apache/roller/pull/84#issuecomment-873665571 Lot's of good changes here. I went through commit-by-commit and did not see any problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] snoopdave merged pull request #90: Parse referrer URL instead of using string value directly.
snoopdave merged pull request #90: URL: https://github.com/apache/roller/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
