I'm going to cancel this vote. Thanks to all who helped review.
Greg had some concerns about Struts actions, but Kohei and I could not
reproduce them. Are they still an issue?
Also, Sebb raised some concerns about our NOTICE and LICENSE files. I'm not
sure if they are quite right yet.
I'll create a Roller 5.2.3 RC3 release as soon these issues are resolved.
Thanks,
Dave
On Mon, Jun 10, 2019 at 5:54 AM sebb wrote:
> On Sun, 9 Jun 2019 at 19:07, Dave wrote:
> >
> > Thanks folks for the testing and voting. I'm going to close this vote and
> > start a new one for v5.2.3 RC2 with some additional fixes.
>
> Please can you look at https://issues.apache.org/jira/browse/ROL-2138 ?
>
> The current NOTICE and LICENSE files do not meet ASF policy.
>
> I think this is a release blocker, and would vote -1 but I am not on the
> PMC.
>
> > I'm still wondering what's going on with the actions that were not
> working
> > for Greg.
> >
> > Dave
> >
> >
> > On Sun, Jun 9, 2019 at 3:56 AM Kohei Nozaki wrote:
> >
> > > Hi Dave, thank you for handling the new release.
> > >
> > > I've checked a diff at
> > > https://github.com/apache/roller/compare/roller-5.2.2...roller-5.2.x
> and
> > > quickly tried the new build
> (roller-release-5.2.3-rc-1-standard.tar.gz), it
> > > looks good to me. +1
> > >
> > > I didn't see the entryAdd and entryEdit symptoms with the new build.
> > >
> > > Regards,
> > > Kohei
> > >
> > > > On Jun 8, 2019, at 6:44, Dave wrote:
> > > >
> > > > Hi Greg,
> > > >
> > > > Thanks for testing out the RC. Really appreciate it. I am able to use
> > > both
> > > > saveDraft and publish from entryAdd and entryEdit, no errors. Could
> there
> > > > be something in your environment that is causing them to fail?
> > > >
> > > > BTW, I did take your advice and switched away from globals in the
> > > > bootstrap-ui branch.
> > > >
> > > > Cheers,
> > > > Dave
> > > >
> > > >
> > > > On Wed, Jun 5, 2019 at 10:09 AM Dave wrote:
> > > >
> > > >> Thanks Greg, I'll take a look.
> > > >>
> > > >> Dave
> > > >>
> > > >>
> > > >> On Wed, Jun 5, 2019 at 4:19 AM Greg Huber
> wrote:
> > > >>
> > > >>> I am getting for
> > > >>>
> > > >>> http://127.0.0.1:8080/roller/roller-ui/authoring/entryAdd.rol
> > > >>>
> > > >>> Method saveDraft for action entryAdd is not allowed!
> > > >>> Method publish for action entryAdd is not allowed!
> > > >>>
> > > >>> also on other actions
> > > >>> Method saveDraft for action entryEdit is not allowed!
> > > >>>
> > > >>> they are in the namespace:
> > > >>> namespace /roller-ui/authoring
> > > >>>
> > > >>> So not sure why it is not working now?
> > > >>>
> > > >>> Cheers Greg
> > > >>>
> > > >>> ##
> > > >>> although its better to add them to the action rather than
> globals
> > > >>> eg
> > > >>> > > >>>
> > > >>> class="org.apache.roller.weblogger.ui.struts2.editor.EntryEdit">
> > > >>> ...
> > > >>> save, saveDraft,...
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>> On Sun, 2 Jun 2019 at 22:13, Dave wrote:
> > > >>>
> > > I have prepared a release candidate for Roller 5.2.3, a minor
> bug-fix
> > > release. You can find the list of fixes and improvements JIRA
> here:
> > >
> > > https://issues.apache.org/jira/projects/ROL/versions/12344883
> > >
> > > IMPORTANT NOTE: for users of Remember-Me. Due to security
> concerns,
> > > Remember-Me is now disabled by default. If you want to use it, you
> > > will
> > > need to enable it and provide a secret key for it in your Roller
> > > >>> properties
> > > file, for example:
> > >
> > > rememberme.enabled=true
> > > rememberme.key=reallyreallysecretsecret
> > >
> > > Release Candidate #1 files are here:
> > >
> https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.3/
> > >
> > > Please take a look and cast your vote. I plan to hold this vote
> open
> > > >>> for 7
> > > days.
> > >
> > > Thanks,
> > > Dave
> > >
> > > >>>
> > > >>
> > >
> > >
>
