[GitHub] [roller] gregh3269 commented on pull request #124: Upgrade to struts 6.1.2
gregh3269 commented on PR #124: URL: https://github.com/apache/roller/pull/124#issuecomment-1495450849 Yes. The plugin needs some updates. If you compare branches you can see what's needed. Relatively simple in comparison to redoing bootstrap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] gregh3269 commented on pull request #124: Upgrade to struts 6.1.2
gregh3269 commented on PR #124: URL: https://github.com/apache/roller/pull/124#issuecomment-1493876478 Looking more into this there does not seem much of a lifeboat wrt the plugin. The general consensus is it is not possible upgrade this version of bootstrap (no surprise) . Seems a lot of changes on every major release, not the best use of resources. I did some testing and its not too difficult modify 4.0.1 to work with for example 6.1.2. A lot easier than upgrading bootstrap. See branch 4.0.2-struts-6.1.2. How to go forward with this is another question, maybe importing the code into roller?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] gregh3269 commented on pull request #124: Upgrade to struts 6.1.2
gregh3269 commented on PR #124: URL: https://github.com/apache/roller/pull/124#issuecomment-148108 Your are probably right here. Looking into this more, I did not realise the dependency soup with the bootstrap plugin. Plugin v5.00 uses bootstrap v5.2.0 where roller is using v3.4.1. Now I realise Dave email. I will close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [roller] gregh3269 commented on pull request #124: Upgrade to struts 6.1.2
gregh3269 commented on PR #124: URL: https://github.com/apache/roller/pull/124#issuecomment-1480909793 Checking the page the id has extra underscores. I will check if this is intentional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
