[GitHub] [roller] snoopdave commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
snoopdave commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150 URL: https://github.com/apache/roller/pull/37#issuecomment-527244134 Yes, I think it would be good to get those changes into 5.2.x as well and I'd be willing to help out with another 5.2.x release when we're ready. It's up to you if you want to add webjars to 5.2.x or do it the old way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [roller] snoopdave commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
snoopdave commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150 URL: https://github.com/apache/roller/pull/37#issuecomment-527117017 This a a good idea to update jQuery and the right way to do it is by changing the Webjars dependency the Roller app's pom.xml file. This is what is in there now: ` org.webjars jquery 3.3.1 org.webjars jquery-ui 1.12.1 ` The webjars dependecies are imported into the web pages via head.jsp. We should remove the jQuery files from Roller's repo by removing these direrectories `app/src/main/webapp/roller-ui/js/jquery*` and we should remove the references to that directory in all of the JSP files that you changed. All of those files should instead get the jQuery dependency from head.jsp which is included in all JSP files (via Struts / Tiles). This will make it easier to upgrade jQuery in the future because we will only need to change `pom.xml` and `head.jsp`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
