Re: [VOTE] Release Apache Roller 5.2.3
+1 (obviously!) We still need one more PMC vote to get this release out. Dave On Tue, Jul 2, 2019 at 3:24 AM Greg Huber wrote: > +1 (b). > > Cheers Greg > > On Sun, 30 Jun 2019 at 14:43, Dave wrote: > > > Please vote to release Apache Roller 5.2.3. > > > > I've prepared a third release candidate for 5.2.3 that corrects the > > LICENSE and NOTICE files, thanks to Aditya and Sebb. > > You can find the full list of fixes and improvements in the release notes > > below. > > > > IMPORTANT NOTE: for users of Remember-Me. Due to security concerns, > > Remember-Me is now disabled by default. If you want to use it, you will > > need to enable it and provide a secret key for it in your Roller > > properties file, for example: > > > > rememberme.enabled=true > > rememberme.key=reallyreallysecretsecret > > > > Release Candidate #3 files are here: > > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.3/ > > > > Please take a look and cast your vote. I plan to hold this vote open > until > > next weekend. > > > > Thanks, > > Dave > > > > > > Release notes: > > > > Bug > > [ROL-2100] - HTTPS Scheme Enforcement feature removed > > [ROL-2127] - Automatic database upgrade fails > > [ROL-2129] - duplicate index on roller_oauthconsumer as Primary Key > > [ROL-2132] - Remember-me fails when LDAP used for auth > > [ROL-2135] - Comment Authenticator fix > > [ROL-2138] - NOTICE file does not have standard content > > [ROL-2143] - Fix mvn jetty:run > > > > Improvement > > [ROL-2137] - Require rememberme.key to be set > > > > Test > > [ROL-2142] - Skip RSS/Atom feed fetcher tests on Java 1.7 > > >
Re: [VOTE] Release Apache Roller 5.2.3
+1 (b). Cheers Greg On Sun, 30 Jun 2019 at 14:43, Dave wrote: > Please vote to release Apache Roller 5.2.3. > > I've prepared a third release candidate for 5.2.3 that corrects the > LICENSE and NOTICE files, thanks to Aditya and Sebb. > You can find the full list of fixes and improvements in the release notes > below. > > IMPORTANT NOTE: for users of Remember-Me. Due to security concerns, > Remember-Me is now disabled by default. If you want to use it, you will > need to enable it and provide a secret key for it in your Roller > properties file, for example: > > rememberme.enabled=true > rememberme.key=reallyreallysecretsecret > > Release Candidate #3 files are here: > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.3/ > > Please take a look and cast your vote. I plan to hold this vote open until > next weekend. > > Thanks, > Dave > > > Release notes: > > Bug > [ROL-2100] - HTTPS Scheme Enforcement feature removed > [ROL-2127] - Automatic database upgrade fails > [ROL-2129] - duplicate index on roller_oauthconsumer as Primary Key > [ROL-2132] - Remember-me fails when LDAP used for auth > [ROL-2135] - Comment Authenticator fix > [ROL-2138] - NOTICE file does not have standard content > [ROL-2143] - Fix mvn jetty:run > > Improvement > [ROL-2137] - Require rememberme.key to be set > > Test > [ROL-2142] - Skip RSS/Atom feed fetcher tests on Java 1.7 >
Re: [VOTE] Release Apache Roller 5.2.3
+1 Thanks Dave :) Thanks and Regards, Aditya Sharma On Sun, 30 Jun 2019 at 19:13, Dave wrote: > Please vote to release Apache Roller 5.2.3. > > I've prepared a third release candidate for 5.2.3 that corrects the > LICENSE and NOTICE files, thanks to Aditya and Sebb. > You can find the full list of fixes and improvements in the release notes > below. > > IMPORTANT NOTE: for users of Remember-Me. Due to security concerns, > Remember-Me is now disabled by default. If you want to use it, you will > need to enable it and provide a secret key for it in your Roller > properties file, for example: > > rememberme.enabled=true > rememberme.key=reallyreallysecretsecret > > Release Candidate #3 files are here: > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.3/ > > Please take a look and cast your vote. I plan to hold this vote open until > next weekend. > > Thanks, > Dave > > > Release notes: > > Bug > [ROL-2100] - HTTPS Scheme Enforcement feature removed > [ROL-2127] - Automatic database upgrade fails > [ROL-2129] - duplicate index on roller_oauthconsumer as Primary Key > [ROL-2132] - Remember-me fails when LDAP used for auth > [ROL-2135] - Comment Authenticator fix > [ROL-2138] - NOTICE file does not have standard content > [ROL-2143] - Fix mvn jetty:run > > Improvement > [ROL-2137] - Require rememberme.key to be set > > Test > [ROL-2142] - Skip RSS/Atom feed fetcher tests on Java 1.7 >
[VOTE] Release Apache Roller 5.2.3
Please vote to release Apache Roller 5.2.3. I've prepared a third release candidate for 5.2.3 that corrects the LICENSE and NOTICE files, thanks to Aditya and Sebb. You can find the full list of fixes and improvements in the release notes below. IMPORTANT NOTE: for users of Remember-Me. Due to security concerns, Remember-Me is now disabled by default. If you want to use it, you will need to enable it and provide a secret key for it in your Roller properties file, for example: rememberme.enabled=true rememberme.key=reallyreallysecretsecret Release Candidate #3 files are here: https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.3/ Please take a look and cast your vote. I plan to hold this vote open until next weekend. Thanks, Dave Release notes: Bug [ROL-2100] - HTTPS Scheme Enforcement feature removed [ROL-2127] - Automatic database upgrade fails [ROL-2129] - duplicate index on roller_oauthconsumer as Primary Key [ROL-2132] - Remember-me fails when LDAP used for auth [ROL-2135] - Comment Authenticator fix [ROL-2138] - NOTICE file does not have standard content [ROL-2143] - Fix mvn jetty:run Improvement [ROL-2137] - Require rememberme.key to be set Test [ROL-2142] - Skip RSS/Atom feed fetcher tests on Java 1.7
Re: [VOTE] Release Apache Roller 5.2.3 bug fix release
Vote cancelled. I'm going to try to get a couple more bug fixes in before 5.2.3. Thanks, Dave On Thu, Jan 31, 2019 at 5:13 PM Dave wrote: > Thanks Jason! I left a comment on the PR. > > Dave > > > On Wed, Jan 30, 2019 at 12:51 PM Jason Pyeron wrote: > >> > -Original Message- >> > From: Greg Huber >> > Sent: Tuesday, January 29, 2019 3:24 AM >> > >> > Checking the logs, did not get any errors (or previous) on the upgrade. >> > >> > Testing with >> > 510-to-520-migration.sql >> > >> > I changed roller.database.version to 510 and restarted, roller changed >> it >> > to 523. >> > >> > INFO 2019-01-29 08:11:53,972 DatabaseInstaller:upgradeDatabase - >> Database >> > is old, beginning upgrade to version 523 >> > >> > Not sure how to check if it has actually run (mariadb) >> > alter table weblogentry modify updatetime datetime(3) not null; >> > Reduces the time stamps to milliseconds? >> > >> > if I dump the table: >> > CREATE TABLE IF NOT EXISTS `weblogentry` ( >> > `pubtime` datetime DEFAULT NULL, >> > `updatetime` datetime NOT NULL, >> > ) ENGINE=MyISAM DEFAULT CHARSET=latin1; >> > >> > +1 (b) >> > >> > Cheers Greg >> > >> > On Sun, 27 Jan 2019 at 17:01, Dave wrote: >> > >> > > Hi Roller community, >> > > >> > > I propose that we release the current contents of the Roller 5.2.x >> > branch >> > > as Roller 5.2.3 because database upgrade (via web UI auto-upgrade) is >> > > broken. This is the fix: >> > > >> > >Database upgrading does not work >> > >https://issues.apache.org/jira/browse/ROL-2127 >> >> I found an issue with Oracle DB >> >> https://issues.apache.org/jira/browse/ROL-2129 >> >> I made a pull request. >> >> -Jason >> >>
Re: [VOTE] Release Apache Roller 5.2.3 bug fix release
Thanks Jason! I left a comment on the PR. Dave On Wed, Jan 30, 2019 at 12:51 PM Jason Pyeron wrote: > > -Original Message- > > From: Greg Huber > > Sent: Tuesday, January 29, 2019 3:24 AM > > > > Checking the logs, did not get any errors (or previous) on the upgrade. > > > > Testing with > > 510-to-520-migration.sql > > > > I changed roller.database.version to 510 and restarted, roller changed it > > to 523. > > > > INFO 2019-01-29 08:11:53,972 DatabaseInstaller:upgradeDatabase - > Database > > is old, beginning upgrade to version 523 > > > > Not sure how to check if it has actually run (mariadb) > > alter table weblogentry modify updatetime datetime(3) not null; > > Reduces the time stamps to milliseconds? > > > > if I dump the table: > > CREATE TABLE IF NOT EXISTS `weblogentry` ( > > `pubtime` datetime DEFAULT NULL, > > `updatetime` datetime NOT NULL, > > ) ENGINE=MyISAM DEFAULT CHARSET=latin1; > > > > +1 (b) > > > > Cheers Greg > > > > On Sun, 27 Jan 2019 at 17:01, Dave wrote: > > > > > Hi Roller community, > > > > > > I propose that we release the current contents of the Roller 5.2.x > > branch > > > as Roller 5.2.3 because database upgrade (via web UI auto-upgrade) is > > > broken. This is the fix: > > > > > >Database upgrading does not work > > >https://issues.apache.org/jira/browse/ROL-2127 > > I found an issue with Oracle DB > > https://issues.apache.org/jira/browse/ROL-2129 > > I made a pull request. > > -Jason > >
RE: [VOTE] Release Apache Roller 5.2.3 bug fix release
> -Original Message- > From: Greg Huber > Sent: Tuesday, January 29, 2019 3:24 AM > > Checking the logs, did not get any errors (or previous) on the upgrade. > > Testing with > 510-to-520-migration.sql > > I changed roller.database.version to 510 and restarted, roller changed it > to 523. > > INFO 2019-01-29 08:11:53,972 DatabaseInstaller:upgradeDatabase - Database > is old, beginning upgrade to version 523 > > Not sure how to check if it has actually run (mariadb) > alter table weblogentry modify updatetime datetime(3) not null; > Reduces the time stamps to milliseconds? > > if I dump the table: > CREATE TABLE IF NOT EXISTS `weblogentry` ( > `pubtime` datetime DEFAULT NULL, > `updatetime` datetime NOT NULL, > ) ENGINE=MyISAM DEFAULT CHARSET=latin1; > > +1 (b) > > Cheers Greg > > On Sun, 27 Jan 2019 at 17:01, Dave wrote: > > > Hi Roller community, > > > > I propose that we release the current contents of the Roller 5.2.x > branch > > as Roller 5.2.3 because database upgrade (via web UI auto-upgrade) is > > broken. This is the fix: > > > >Database upgrading does not work > >https://issues.apache.org/jira/browse/ROL-2127 I found an issue with Oracle DB https://issues.apache.org/jira/browse/ROL-2129 I made a pull request. -Jason
Re: [VOTE] Release Apache Roller 5.2.3 bug fix release
Checking the logs, did not get any errors (or previous) on the upgrade. Testing with 510-to-520-migration.sql I changed roller.database.version to 510 and restarted, roller changed it to 523. INFO 2019-01-29 08:11:53,972 DatabaseInstaller:upgradeDatabase - Database is old, beginning upgrade to version 523 Not sure how to check if it has actually run (mariadb) alter table weblogentry modify updatetime datetime(3) not null; Reduces the time stamps to milliseconds? if I dump the table: CREATE TABLE IF NOT EXISTS `weblogentry` ( `pubtime` datetime DEFAULT NULL, `updatetime` datetime NOT NULL, ) ENGINE=MyISAM DEFAULT CHARSET=latin1; +1 (b) Cheers Greg On Sun, 27 Jan 2019 at 17:01, Dave wrote: > Hi Roller community, > > I propose that we release the current contents of the Roller 5.2.x branch > as Roller 5.2.3 because database upgrade (via web UI auto-upgrade) is > broken. This is the fix: > >Database upgrading does not work >https://issues.apache.org/jira/browse/ROL-2127 > > Here's are the release files: >https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.3/ > > Please vote +1 to release or -1 with reasons not to release. > > Thanks, > Dave >
[VOTE] Release Apache Roller 5.2.3 bug fix release
Hi Roller community, I propose that we release the current contents of the Roller 5.2.x branch as Roller 5.2.3 because database upgrade (via web UI auto-upgrade) is broken. This is the fix: Database upgrading does not work https://issues.apache.org/jira/browse/ROL-2127 Here's are the release files: https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.3/ Please vote +1 to release or -1 with reasons not to release. Thanks, Dave
