Re: [PR] Validate tz [roller]

[via GitHub]

snoopdave merged PR #134:
URL: https://github.com/apache/roller/pull/134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Validate tz [roller]

[via GitHub]

snoopdave commented on code in PR #134:
URL: https://github.com/apache/roller/pull/134#discussion_r1479181862


##
app/src/main/java/org/apache/roller/weblogger/pojos/WeblogBookmarkFolder.java:
##
@@ -188,4 +189,9 @@ public List retrieveBookmarks() throws 
WebloggerException {
 return bmgr.getBookmarks(this);
 }
 
+public void sanitize() {
+// Conditionally sanitize fields not validated by Struts Validator
+setName(HTMLSanitizer.conditionallySanitize(getName()));
+}

Review Comment:
   I think you're right and that is a better approach. I will adjust.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Validate tz [roller]

[via GitHub]

mbien commented on code in PR #134:
URL: https://github.com/apache/roller/pull/134#discussion_r1477694217


##
app/src/main/java/org/apache/roller/weblogger/pojos/WeblogBookmarkFolder.java:
##
@@ -188,4 +189,9 @@ public List retrieveBookmarks() throws 
WebloggerException {
 return bmgr.getBookmarks(this);
 }
 
+public void sanitize() {
+// Conditionally sanitize fields not validated by Struts Validator
+setName(HTMLSanitizer.conditionallySanitize(getName()));
+}

Review Comment:
   question: can't this be done in the setters? This would ensure that the 
fields are always clean without having to call the method. Or is this due to 
serialization or something like that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org