Re: [VOTE] Release rc-1 as Roller 6.0.1
Dear Dave, Thank you for your patience, the translation of the 'User Guide' document from ODT to AsciiDoc. With this translation, all our ODT documents are converted to AsciiDoc. Here is a link to this discussion - https://s.apache.org/cn6te So, it seems we are good to proceed with our next release. Please let me know if need any further information or assistance. - Best regards, Swapnil M Mane, www.apache.org On Mon, Apr 20, 2020 at 6:36 PM Dave wrote: > > Hi Swapnil, > > Yes, that's a great reason to wait a bit. Thanks! > > Dave > > > On Mon, Apr 20, 2020 at 1:10 AM Swapnil M Mane > wrote: > > > Thank you Dave, > > As we have canceled this Vote thread, can you please give me this week > > time to wrap the ASCII doc thing, > > (I am planning to work on this task this weekend). > > and after this, we can have vote for the new release, thoughts? > > > > Best regards, > > Swapnil M Mane, > > www.apache.org > > > > On Sat, Apr 18, 2020 at 8:57 PM Dave wrote: > > > > > > Hi Greg, > > > > > > I fixed a couple of these and have questions about the others. See inline > > > below: > > > > > > > > > On Mon, Apr 13, 2020 at 4:07 AM Greg Huber wrote: > > > > > > > > > > > ## > > > > > > > > > > http://127.0.0.1:8080/roller/roller-ui/authoring/weblogConfig.rol?weblog=testuser > > > > Missing value for createWebsite.timeZone > > > > > > > > > > Fixed. > > > > > > > > > > ## > > > > Remember me seems to have gone? > > > > > > > > > > Remember Me is working for me. You do now have to specify a > > rememberme.key > > > that is NOT "springRocks" because that is the old default, but I think > > that > > > was in 6.0.0 already. You want something unique and secret. > > > > > > > > > > > > > ## > > > > http://127.0.0.1:8080/roller/roller-ui/admin/globalConfig.rol > > > > Editor Pages are these still valid? > > > > Editor Pages : editor-text.jsp,editor-rte.jsp,editor-xinha.jsp > > > > > > > > > > I'm not sure why you are seeing this. The default in > > runtimeConfigDefs.xml > > > is "editor-text.jsp,editor-summernote.jsp" which is correct. The RTE and > > > Xinha editors are gone. Are you using an existing database for your > > testing > > > of 6.0.1 rc1? > > > > > > > > > > > > > ## > > > > Duplicate /n when editing a comment > > > > org.apache.roller.weblogger.ui.struts2.ajax.CommentDataServlet > > > > String content = Utilities.escapeHTML(c.getContent()); > > > > content = WordUtils.wrap(content, 72); > > > > content = StringEscapeUtils.escapeEcmaScript(content); > > > > It would be better to leave the wrapping to the ui. ie remove > > > > WordUtils.wrap(content, 72); > > > > > > > > > > Fixed. > > > > > > Thanks for the review Greg. > > > > > > Dave > > > > > > > > > > > > > > > > On 10/04/2020 21:42, Dave wrote: > > > > > I have prepared a release candidate for a Roller 6.0.1 release based > > on > > > > > latest code in the roller-6.0.x branch. This release will be a > > minor bug > > > > > fix release. It fixes two bugs, which you can see here: > > > > > > > > > > https://issues.apache.org/jira/projects/ROL/versions/12347761 > > > > > > > > > > A release candidate files for this release are available here: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.1/ > > > > > > > > > > Please vote +1 to release or -1 with reason(s) not to release. > > > > > > > > > > I plan to leave this vote open until April 19 to allow folks time to > > > > test. > > > > > > > > > > Thanks, > > > > > Dave > > > > > > > > > > >
Re: [VOTE] Release rc-1 as Roller 6.0.1
Hi Swapnil, Yes, that's a great reason to wait a bit. Thanks! Dave On Mon, Apr 20, 2020 at 1:10 AM Swapnil M Mane wrote: > Thank you Dave, > As we have canceled this Vote thread, can you please give me this week > time to wrap the ASCII doc thing, > (I am planning to work on this task this weekend). > and after this, we can have vote for the new release, thoughts? > > Best regards, > Swapnil M Mane, > www.apache.org > > On Sat, Apr 18, 2020 at 8:57 PM Dave wrote: > > > > Hi Greg, > > > > I fixed a couple of these and have questions about the others. See inline > > below: > > > > > > On Mon, Apr 13, 2020 at 4:07 AM Greg Huber wrote: > > > > > > > > ## > > > > > > > http://127.0.0.1:8080/roller/roller-ui/authoring/weblogConfig.rol?weblog=testuser > > > Missing value for createWebsite.timeZone > > > > > > > Fixed. > > > > > > > ## > > > Remember me seems to have gone? > > > > > > > Remember Me is working for me. You do now have to specify a > rememberme.key > > that is NOT "springRocks" because that is the old default, but I think > that > > was in 6.0.0 already. You want something unique and secret. > > > > > > > > > ## > > > http://127.0.0.1:8080/roller/roller-ui/admin/globalConfig.rol > > > Editor Pages are these still valid? > > > Editor Pages : editor-text.jsp,editor-rte.jsp,editor-xinha.jsp > > > > > > > I'm not sure why you are seeing this. The default in > runtimeConfigDefs.xml > > is "editor-text.jsp,editor-summernote.jsp" which is correct. The RTE and > > Xinha editors are gone. Are you using an existing database for your > testing > > of 6.0.1 rc1? > > > > > > > > > ## > > > Duplicate /n when editing a comment > > > org.apache.roller.weblogger.ui.struts2.ajax.CommentDataServlet > > > String content = Utilities.escapeHTML(c.getContent()); > > > content = WordUtils.wrap(content, 72); > > > content = StringEscapeUtils.escapeEcmaScript(content); > > > It would be better to leave the wrapping to the ui. ie remove > > > WordUtils.wrap(content, 72); > > > > > > > Fixed. > > > > Thanks for the review Greg. > > > > Dave > > > > > > > > > > > On 10/04/2020 21:42, Dave wrote: > > > > I have prepared a release candidate for a Roller 6.0.1 release based > on > > > > latest code in the roller-6.0.x branch. This release will be a > minor bug > > > > fix release. It fixes two bugs, which you can see here: > > > > > > > > https://issues.apache.org/jira/projects/ROL/versions/12347761 > > > > > > > > A release candidate files for this release are available here: > > > > > > > > https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.1/ > > > > > > > > Please vote +1 to release or -1 with reason(s) not to release. > > > > > > > > I plan to leave this vote open until April 19 to allow folks time to > > > test. > > > > > > > > Thanks, > > > > Dave > > > > > > > >
Re: [VOTE] Release rc-1 as Roller 6.0.1
Thank you Dave, As we have canceled this Vote thread, can you please give me this week time to wrap the ASCII doc thing, (I am planning to work on this task this weekend). and after this, we can have vote for the new release, thoughts? Best regards, Swapnil M Mane, www.apache.org On Sat, Apr 18, 2020 at 8:57 PM Dave wrote: > > Hi Greg, > > I fixed a couple of these and have questions about the others. See inline > below: > > > On Mon, Apr 13, 2020 at 4:07 AM Greg Huber wrote: > > > > > ## > > > > http://127.0.0.1:8080/roller/roller-ui/authoring/weblogConfig.rol?weblog=testuser > > Missing value for createWebsite.timeZone > > > > Fixed. > > > > ## > > Remember me seems to have gone? > > > > Remember Me is working for me. You do now have to specify a rememberme.key > that is NOT "springRocks" because that is the old default, but I think that > was in 6.0.0 already. You want something unique and secret. > > > > > ## > > http://127.0.0.1:8080/roller/roller-ui/admin/globalConfig.rol > > Editor Pages are these still valid? > > Editor Pages : editor-text.jsp,editor-rte.jsp,editor-xinha.jsp > > > > I'm not sure why you are seeing this. The default in runtimeConfigDefs.xml > is "editor-text.jsp,editor-summernote.jsp" which is correct. The RTE and > Xinha editors are gone. Are you using an existing database for your testing > of 6.0.1 rc1? > > > > > ## > > Duplicate /n when editing a comment > > org.apache.roller.weblogger.ui.struts2.ajax.CommentDataServlet > > String content = Utilities.escapeHTML(c.getContent()); > > content = WordUtils.wrap(content, 72); > > content = StringEscapeUtils.escapeEcmaScript(content); > > It would be better to leave the wrapping to the ui. ie remove > > WordUtils.wrap(content, 72); > > > > Fixed. > > Thanks for the review Greg. > > Dave > > > > > > On 10/04/2020 21:42, Dave wrote: > > > I have prepared a release candidate for a Roller 6.0.1 release based on > > > latest code in the roller-6.0.x branch. This release will be a minor bug > > > fix release. It fixes two bugs, which you can see here: > > > > > > https://issues.apache.org/jira/projects/ROL/versions/12347761 > > > > > > A release candidate files for this release are available here: > > > > > > https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.1/ > > > > > > Please vote +1 to release or -1 with reason(s) not to release. > > > > > > I plan to leave this vote open until April 19 to allow folks time to > > test. > > > > > > Thanks, > > > Dave > > > > >
Re: [VOTE] Release rc-1 as Roller 6.0.1
Hi Greg, I fixed a couple of these and have questions about the others. See inline below: On Mon, Apr 13, 2020 at 4:07 AM Greg Huber wrote: > > ## > > http://127.0.0.1:8080/roller/roller-ui/authoring/weblogConfig.rol?weblog=testuser > Missing value for createWebsite.timeZone > Fixed. > ## > Remember me seems to have gone? > Remember Me is working for me. You do now have to specify a rememberme.key that is NOT "springRocks" because that is the old default, but I think that was in 6.0.0 already. You want something unique and secret. > ## > http://127.0.0.1:8080/roller/roller-ui/admin/globalConfig.rol > Editor Pages are these still valid? > Editor Pages : editor-text.jsp,editor-rte.jsp,editor-xinha.jsp > I'm not sure why you are seeing this. The default in runtimeConfigDefs.xml is "editor-text.jsp,editor-summernote.jsp" which is correct. The RTE and Xinha editors are gone. Are you using an existing database for your testing of 6.0.1 rc1? > ## > Duplicate /n when editing a comment > org.apache.roller.weblogger.ui.struts2.ajax.CommentDataServlet > String content = Utilities.escapeHTML(c.getContent()); > content = WordUtils.wrap(content, 72); > content = StringEscapeUtils.escapeEcmaScript(content); > It would be better to leave the wrapping to the ui. ie remove > WordUtils.wrap(content, 72); > Fixed. Thanks for the review Greg. Dave > On 10/04/2020 21:42, Dave wrote: > > I have prepared a release candidate for a Roller 6.0.1 release based on > > latest code in the roller-6.0.x branch. This release will be a minor bug > > fix release. It fixes two bugs, which you can see here: > > > > https://issues.apache.org/jira/projects/ROL/versions/12347761 > > > > A release candidate files for this release are available here: > > > > https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.1/ > > > > Please vote +1 to release or -1 with reason(s) not to release. > > > > I plan to leave this vote open until April 19 to allow folks time to > test. > > > > Thanks, > > Dave > > >
Re: [VOTE] Release rc-1 as Roller 6.0.1
Thanks Greg. I'm going to cancel this vote and look into the issues you've raised. Dave On Mon, Apr 13, 2020 at 4:07 AM Greg Huber wrote: > +1 with some notes below. > > Cheers Greg > > ## > > > http://127.0.0.1:8080/roller/roller-ui/authoring/weblogConfig.rol?weblog=testuser > > Missing value for createWebsite.timeZone > > ## > > Remember me seems to have gone? > > ## > > http://127.0.0.1:8080/roller/roller-ui/admin/globalConfig.rol > > Editor Pages are these still valid? > > Editor Pages : editor-text.jsp,editor-rte.jsp,editor-xinha.jsp > > ## > > Duplicate /n when editing a comment > > org.apache.roller.weblogger.ui.struts2.ajax.CommentDataServlet > > String content = Utilities.escapeHTML(c.getContent()); > content = WordUtils.wrap(content, 72); > content = StringEscapeUtils.escapeEcmaScript(content); > > It would be better to leave the wrapping to the ui. ie remove > WordUtils.wrap(content, 72); > > > On 10/04/2020 21:42, Dave wrote: > > I have prepared a release candidate for a Roller 6.0.1 release based on > > latest code in the roller-6.0.x branch. This release will be a minor bug > > fix release. It fixes two bugs, which you can see here: > > > > https://issues.apache.org/jira/projects/ROL/versions/12347761 > > > > A release candidate files for this release are available here: > > > > https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.1/ > > > > Please vote +1 to release or -1 with reason(s) not to release. > > > > I plan to leave this vote open until April 19 to allow folks time to > test. > > > > Thanks, > > Dave > > >
Re: [VOTE] Release rc-1 as Roller 6.0.1
+1 with some notes below. Cheers Greg ## http://127.0.0.1:8080/roller/roller-ui/authoring/weblogConfig.rol?weblog=testuser Missing value for createWebsite.timeZone ## Remember me seems to have gone? ## http://127.0.0.1:8080/roller/roller-ui/admin/globalConfig.rol Editor Pages are these still valid? Editor Pages : editor-text.jsp,editor-rte.jsp,editor-xinha.jsp ## Duplicate /n when editing a comment org.apache.roller.weblogger.ui.struts2.ajax.CommentDataServlet String content = Utilities.escapeHTML(c.getContent()); content = WordUtils.wrap(content, 72); content = StringEscapeUtils.escapeEcmaScript(content); It would be better to leave the wrapping to the ui. ie remove WordUtils.wrap(content, 72); On 10/04/2020 21:42, Dave wrote: I have prepared a release candidate for a Roller 6.0.1 release based on latest code in the roller-6.0.x branch. This release will be a minor bug fix release. It fixes two bugs, which you can see here: https://issues.apache.org/jira/projects/ROL/versions/12347761 A release candidate files for this release are available here: https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.1/ Please vote +1 to release or -1 with reason(s) not to release. I plan to leave this vote open until April 19 to allow folks time to test. Thanks, Dave
