[jira] [Commented] (S2GRAPH-28) _to option gives wrong result on query.
[
https://issues.apache.org/jira/browse/S2GRAPH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15721643#comment-15721643
]
Daewon Jeong commented on S2GRAPH-28:
-
his issue has been reflected.
> _to option gives wrong result on query.
> ---
>
> Key: S2GRAPH-28
> URL: https://issues.apache.org/jira/browse/S2GRAPH-28
> Project: S2Graph
> Issue Type: Bug
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
> Labels: bug, newbie, query
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> following is steps to reproduce bug.
> # create service.
> {noformat}
> curl -XPOST localhost:9000/graphs/createService -H 'Content-Type:
> Application/json' -d '
> {"serviceName": "s2graph-test"}
> '
> {noformat}
> # create label.
> {noformat}
> curl -XPOST alpha-s2graph.daumkakao.io:9000/graphs/createLabel -H
> 'Content-Type: Application/json' -d '
> {
> "label": "friend",
> "srcServiceName": "s2graph-test",
> "srcColumnName": "user_id",
> "srcColumnType": "string",
> "tgtServiceName": "s2graph-test",
> "tgtColumnName": "user_id",
> "tgtColumnType": "string",
> "indices": [],
> "props": [],
> "serviceName": "s2graph-test",
> "consistencyLevel": "strong"
> }
> '
> {noformat}
> # insert test data.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/insert -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817379, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # delete above relation.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/delete -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817380, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # select index edges.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10
> }]
> }]
> }
> '
> {noformat}
> this gives no edges which is expected.
> then with "_to" specified, then it gives deleted edge.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10,
> "_to": "4cc8ad306899f5669204"
> }]
> }]
> }
> '
> {noformat}
> I think after delete operation finished, there should be no edge left even
> with "_to" option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (S2GRAPH-28) _to option gives wrong result on query.
[
https://issues.apache.org/jira/browse/S2GRAPH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158427#comment-15158427
]
ASF GitHub Bot commented on S2GRAPH-28:
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-s2graph/pull/13
> _to option gives wrong result on query.
> ---
>
> Key: S2GRAPH-28
> URL: https://issues.apache.org/jira/browse/S2GRAPH-28
> Project: S2Graph
> Issue Type: Bug
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
> Labels: bug, newbie, query
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> following is steps to reproduce bug.
> # create service.
> {noformat}
> curl -XPOST localhost:9000/graphs/createService -H 'Content-Type:
> Application/json' -d '
> {"serviceName": "s2graph-test"}
> '
> {noformat}
> # create label.
> {noformat}
> curl -XPOST alpha-s2graph.daumkakao.io:9000/graphs/createLabel -H
> 'Content-Type: Application/json' -d '
> {
> "label": "friend",
> "srcServiceName": "s2graph-test",
> "srcColumnName": "user_id",
> "srcColumnType": "string",
> "tgtServiceName": "s2graph-test",
> "tgtColumnName": "user_id",
> "tgtColumnType": "string",
> "indices": [],
> "props": [],
> "serviceName": "s2graph-test",
> "consistencyLevel": "strong"
> }
> '
> {noformat}
> # insert test data.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/insert -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817379, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # delete above relation.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/delete -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817380, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # select index edges.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10
> }]
> }]
> }
> '
> {noformat}
> this gives no edges which is expected.
> then with "_to" specified, then it gives deleted edge.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10,
> "_to": "4cc8ad306899f5669204"
> }]
> }]
> }
> '
> {noformat}
> I think after delete operation finished, there should be no edge left even
> with "_to" option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (S2GRAPH-28) _to option gives wrong result on query.
[
https://issues.apache.org/jira/browse/S2GRAPH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158424#comment-15158424
]
ASF GitHub Bot commented on S2GRAPH-28:
---
Github user emeth-kim commented on the pull request:
https://github.com/apache/incubator-s2graph/pull/13#issuecomment-187576232
+1
> _to option gives wrong result on query.
> ---
>
> Key: S2GRAPH-28
> URL: https://issues.apache.org/jira/browse/S2GRAPH-28
> Project: S2Graph
> Issue Type: Bug
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
> Labels: bug, newbie, query
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> following is steps to reproduce bug.
> # create service.
> {noformat}
> curl -XPOST localhost:9000/graphs/createService -H 'Content-Type:
> Application/json' -d '
> {"serviceName": "s2graph-test"}
> '
> {noformat}
> # create label.
> {noformat}
> curl -XPOST alpha-s2graph.daumkakao.io:9000/graphs/createLabel -H
> 'Content-Type: Application/json' -d '
> {
> "label": "friend",
> "srcServiceName": "s2graph-test",
> "srcColumnName": "user_id",
> "srcColumnType": "string",
> "tgtServiceName": "s2graph-test",
> "tgtColumnName": "user_id",
> "tgtColumnType": "string",
> "indices": [],
> "props": [],
> "serviceName": "s2graph-test",
> "consistencyLevel": "strong"
> }
> '
> {noformat}
> # insert test data.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/insert -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817379, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # delete above relation.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/delete -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817380, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # select index edges.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10
> }]
> }]
> }
> '
> {noformat}
> this gives no edges which is expected.
> then with "_to" specified, then it gives deleted edge.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10,
> "_to": "4cc8ad306899f5669204"
> }]
> }]
> }
> '
> {noformat}
> I think after delete operation finished, there should be no edge left even
> with "_to" option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (S2GRAPH-28) _to option gives wrong result on query.
[
https://issues.apache.org/jira/browse/S2GRAPH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127714#comment-15127714
]
ASF GitHub Bot commented on S2GRAPH-28:
---
Github user daewon commented on the pull request:
https://github.com/apache/incubator-s2graph/pull/13#issuecomment-178389915
+1
> _to option gives wrong result on query.
> ---
>
> Key: S2GRAPH-28
> URL: https://issues.apache.org/jira/browse/S2GRAPH-28
> Project: S2Graph
> Issue Type: Bug
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
> Labels: bug, newbie, query
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> following is steps to reproduce bug.
> # create service.
> {noformat}
> curl -XPOST localhost:9000/graphs/createService -H 'Content-Type:
> Application/json' -d '
> {"serviceName": "s2graph-test"}
> '
> {noformat}
> # create label.
> {noformat}
> curl -XPOST alpha-s2graph.daumkakao.io:9000/graphs/createLabel -H
> 'Content-Type: Application/json' -d '
> {
> "label": "friend",
> "srcServiceName": "s2graph-test",
> "srcColumnName": "user_id",
> "srcColumnType": "string",
> "tgtServiceName": "s2graph-test",
> "tgtColumnName": "user_id",
> "tgtColumnType": "string",
> "indices": [],
> "props": [],
> "serviceName": "s2graph-test",
> "consistencyLevel": "strong"
> }
> '
> {noformat}
> # insert test data.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/insert -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817379, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # delete above relation.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/delete -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817380, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # select index edges.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10
> }]
> }]
> }
> '
> {noformat}
> this gives no edges which is expected.
> then with "_to" specified, then it gives deleted edge.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10,
> "_to": "4cc8ad306899f5669204"
> }]
> }]
> }
> '
> {noformat}
> I think after delete operation finished, there should be no edge left even
> with "_to" option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (S2GRAPH-28) _to option gives wrong result on query.
[
https://issues.apache.org/jira/browse/S2GRAPH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109725#comment-15109725
]
ASF GitHub Bot commented on S2GRAPH-28:
---
Github user SteamShon commented on the pull request:
https://github.com/apache/incubator-s2graph/pull/13#issuecomment-173399514
+ 1 for this PR passed all TCs
> _to option gives wrong result on query.
> ---
>
> Key: S2GRAPH-28
> URL: https://issues.apache.org/jira/browse/S2GRAPH-28
> Project: S2Graph
> Issue Type: Bug
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
> Labels: bug, newbie, query
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> following is steps to reproduce bug.
> # create service.
> {noformat}
> curl -XPOST localhost:9000/graphs/createService -H 'Content-Type:
> Application/json' -d '
> {"serviceName": "s2graph-test"}
> '
> {noformat}
> # create label.
> {noformat}
> curl -XPOST alpha-s2graph.daumkakao.io:9000/graphs/createLabel -H
> 'Content-Type: Application/json' -d '
> {
> "label": "friend",
> "srcServiceName": "s2graph-test",
> "srcColumnName": "user_id",
> "srcColumnType": "string",
> "tgtServiceName": "s2graph-test",
> "tgtColumnName": "user_id",
> "tgtColumnType": "string",
> "indices": [],
> "props": [],
> "serviceName": "s2graph-test",
> "consistencyLevel": "strong"
> }
> '
> {noformat}
> # insert test data.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/insert -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817379, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # delete above relation.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/delete -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817380, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # select index edges.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10
> }]
> }]
> }
> '
> {noformat}
> this gives no edges which is expected.
> then with "_to" specified, then it gives deleted edge.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10,
> "_to": "4cc8ad306899f5669204"
> }]
> }]
> }
> '
> {noformat}
> I think after delete operation finished, there should be no edge left even
> with "_to" option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (S2GRAPH-28) _to option gives wrong result on query.
[
https://issues.apache.org/jira/browse/S2GRAPH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109699#comment-15109699
]
ASF GitHub Bot commented on S2GRAPH-28:
---
Github user SteamShon commented on a diff in the pull request:
https://github.com/apache/incubator-s2graph/pull/13#discussion_r50336167
--- Diff:
s2core/src/test/scala/com/kakao/s2graph/core/Integrate/QueryTest.scala ---
@@ -367,6 +368,40 @@ class QueryTest extends IntegrateCommon with
BeforeAndAfterEach {
edgesTo.reverse should be(ascOrderByTo)
}
--- End diff --
another nice addition on our test cases. and I agree that changing
insertEdgesSync into mutateEdgesSync is better.
> _to option gives wrong result on query.
> ---
>
> Key: S2GRAPH-28
> URL: https://issues.apache.org/jira/browse/S2GRAPH-28
> Project: S2Graph
> Issue Type: Bug
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
> Labels: bug, newbie, query
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> following is steps to reproduce bug.
> # create service.
> {noformat}
> curl -XPOST localhost:9000/graphs/createService -H 'Content-Type:
> Application/json' -d '
> {"serviceName": "s2graph-test"}
> '
> {noformat}
> # create label.
> {noformat}
> curl -XPOST alpha-s2graph.daumkakao.io:9000/graphs/createLabel -H
> 'Content-Type: Application/json' -d '
> {
> "label": "friend",
> "srcServiceName": "s2graph-test",
> "srcColumnName": "user_id",
> "srcColumnType": "string",
> "tgtServiceName": "s2graph-test",
> "tgtColumnName": "user_id",
> "tgtColumnType": "string",
> "indices": [],
> "props": [],
> "serviceName": "s2graph-test",
> "consistencyLevel": "strong"
> }
> '
> {noformat}
> # insert test data.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/insert -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817379, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # delete above relation.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/delete -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817380, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # select index edges.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10
> }]
> }]
> }
> '
> {noformat}
> this gives no edges which is expected.
> then with "_to" specified, then it gives deleted edge.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10,
> "_to": "4cc8ad306899f5669204"
> }]
> }]
> }
> '
> {noformat}
> I think after delete operation finished, there should be no edge left even
> with "_to" option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (S2GRAPH-28) _to option gives wrong result on query.
[
https://issues.apache.org/jira/browse/S2GRAPH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109697#comment-15109697
]
ASF GitHub Bot commented on S2GRAPH-28:
---
Github user SteamShon commented on a diff in the pull request:
https://github.com/apache/incubator-s2graph/pull/13#discussion_r50335981
--- Diff:
s2core/src/main/scala/com/kakao/s2graph/core/storage/hbase/AsynchbaseQueryBuilder.scala
---
@@ -220,7 +220,7 @@ class AsynchbaseQueryBuilder(storage:
AsynchbaseStorage)(implicit ec: ExecutionC
parentEdge <- prevStepEdgesOpt.get
} yield parentEdge
-fetch(queryRequest, prevStepScore, isInnerCall = true, parentEdges)
+fetch(queryRequest, prevStepScore, isInnerCall = false,
parentEdges)
--- End diff --
nice catch. do you think we should remove isInnerCall paramerter on fetch
method also? just curious.
> _to option gives wrong result on query.
> ---
>
> Key: S2GRAPH-28
> URL: https://issues.apache.org/jira/browse/S2GRAPH-28
> Project: S2Graph
> Issue Type: Bug
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
> Labels: bug, newbie, query
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> following is steps to reproduce bug.
> # create service.
> {noformat}
> curl -XPOST localhost:9000/graphs/createService -H 'Content-Type:
> Application/json' -d '
> {"serviceName": "s2graph-test"}
> '
> {noformat}
> # create label.
> {noformat}
> curl -XPOST alpha-s2graph.daumkakao.io:9000/graphs/createLabel -H
> 'Content-Type: Application/json' -d '
> {
> "label": "friend",
> "srcServiceName": "s2graph-test",
> "srcColumnName": "user_id",
> "srcColumnType": "string",
> "tgtServiceName": "s2graph-test",
> "tgtColumnName": "user_id",
> "tgtColumnType": "string",
> "indices": [],
> "props": [],
> "serviceName": "s2graph-test",
> "consistencyLevel": "strong"
> }
> '
> {noformat}
> # insert test data.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/insert -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817379, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # delete above relation.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/delete -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817380, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # select index edges.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10
> }]
> }]
> }
> '
> {noformat}
> this gives no edges which is expected.
> then with "_to" specified, then it gives deleted edge.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10,
> "_to": "4cc8ad306899f5669204"
> }]
> }]
> }
> '
> {noformat}
> I think after delete operation finished, there should be no edge left even
> with "_to" option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (S2GRAPH-28) _to option gives wrong result on query.
[
https://issues.apache.org/jira/browse/S2GRAPH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106620#comment-15106620
]
ASF GitHub Bot commented on S2GRAPH-28:
---
GitHub user HyunsungJo opened a pull request:
https://github.com/apache/incubator-s2graph/pull/13
[S2GRAPH-28] bug fix in '_to' query
- This resolves S2GRAPH-28.
- Renamed ```insertEdgesSync``` to ```mutateEdgesSync``` since deletions
are also handled by this function.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyunsungJo/incubator-s2graph S2GRAPH-28
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
commit 0ff60f4bfabfec05a4768e277dbb8d610f07b972
Author: jojo
Date: 2016-01-19T11:30:10Z
[S2GRAPH-28] bug fix in _to option
commit 2083dca49cff46fa9c20eb98c025b73114d55941
Author: jojo
Date: 2016-01-19T11:30:10Z
[S2GRAPH-28] bug fix in _to option
commit 83c6db669198621389ddb90ce68b1b11fadad415
Author: jojo
Date: 2016-01-19T11:36:56Z
Merge branch 'S2GRAPH-28' of
https://github.com/HyunsungJo/incubator-s2graph into S2GRAPH-28
commit 506e9781f6409fc9fabae6fd90dc3897e37fe8a0
Author: jojo
Date: 2016-01-19T11:38:12Z
remove unrequired code..
commit 1cfc2e7d63f98ea2273cc3fce0303bfb84c4dc83
Author: jojo
Date: 2016-01-19T11:38:42Z
Merge branch 'S2GRAPH-28' of
https://github.com/HyunsungJo/incubator-s2graph into S2GRAPH-28
> _to option gives wrong result on query.
> ---
>
> Key: S2GRAPH-28
> URL: https://issues.apache.org/jira/browse/S2GRAPH-28
> Project: S2Graph
> Issue Type: Bug
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
> Labels: bug, newbie, query
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> following is steps to reproduce bug.
> # create service.
> {noformat}
> curl -XPOST localhost:9000/graphs/createService -H 'Content-Type:
> Application/json' -d '
> {"serviceName": "s2graph-test"}
> '
> {noformat}
> # create label.
> {noformat}
> curl -XPOST alpha-s2graph.daumkakao.io:9000/graphs/createLabel -H
> 'Content-Type: Application/json' -d '
> {
> "label": "friend",
> "srcServiceName": "s2graph-test",
> "srcColumnName": "user_id",
> "srcColumnType": "string",
> "tgtServiceName": "s2graph-test",
> "tgtColumnName": "user_id",
> "tgtColumnType": "string",
> "indices": [],
> "props": [],
> "serviceName": "s2graph-test",
> "consistencyLevel": "strong"
> }
> '
> {noformat}
> # insert test data.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/insert -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817379, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # delete above relation.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/delete -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817380, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # select index edges.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10
> }]
> }]
> }
> '
> {noformat}
> this gives no edges which is expected.
> then with "_to" specified, then it gives deleted edge.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10,
> "_to": "4cc8ad306899f5669204"
> }]
> }]
> }
> '
> {noformat}
> I think after delete operation finished, there should be no edge left even
> with "_to" option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (S2GRAPH-28) _to option gives wrong result on query.
[
https://issues.apache.org/jira/browse/S2GRAPH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101308#comment-15101308
]
DOYUNG YOON commented on S2GRAPH-28:
problem with this bug is hard coded value for isInnerCall for public method on
query builder.
easy fix would be just change isInnerCall = true to isInnerCall = false.
https://github.com/apache/incubator-s2graph/blob/master/s2core/src/main/scala/com/kakao/s2graph/core/storage/hbase/AsynchbaseQueryBuilder.scala#L223
> _to option gives wrong result on query.
> ---
>
> Key: S2GRAPH-28
> URL: https://issues.apache.org/jira/browse/S2GRAPH-28
> Project: S2Graph
> Issue Type: Bug
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
> Labels: bug, newbie, query
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> following is steps to reproduce bug.
> # create service.
> {noformat}
> curl -XPOST localhost:9000/graphs/createService -H 'Content-Type:
> Application/json' -d '
> {"serviceName": "s2graph-test"}
> '
> {noformat}
> # create label.
> {noformat}
> curl -XPOST alpha-s2graph.daumkakao.io:9000/graphs/createLabel -H
> 'Content-Type: Application/json' -d '
> {
> "label": "friend",
> "srcServiceName": "s2graph-test",
> "srcColumnName": "user_id",
> "srcColumnType": "string",
> "tgtServiceName": "s2graph-test",
> "tgtColumnName": "user_id",
> "tgtColumnType": "string",
> "indices": [],
> "props": [],
> "serviceName": "s2graph-test",
> "consistencyLevel": "strong"
> }
> '
> {noformat}
> # insert test data.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/insert -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817379, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # delete above relation.
> {noformat}
> curl -XPOST localhost:9000/graphs/edges/delete -H 'Content-Type:
> Application/json' -d '
> [
> {"timestamp": 1451374817380, "from": "4c9343846613f6693107", "to":
> "4cc8ad306899f5669204", "label": "friend"}
> ]
> '
> {noformat}
> # select index edges.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10
> }]
> }]
> }
> '
> {noformat}
> this gives no edges which is expected.
> then with "_to" specified, then it gives deleted edge.
> {noformat}
> curl -XPOST localhost:9000/graphs/getEdges -H 'Content-Type:
> Application/json' -d '
> {
> "srcVertices": [{
> "serviceName": "s2graph-test",
> "columnName": "user_id",
> "id": "4c9343846613f6693107"
> }],
> "steps": [{
> "step": [{
> "label": "path_friend",
> "direction": "out",
> "offset": 0,
> "limit": 10,
> "_to": "4cc8ad306899f5669204"
> }]
> }]
> }
> '
> {noformat}
> I think after delete operation finished, there should be no edge left even
> with "_to" option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
