Re: Opinion on the directional index feature provided in ISSUE-123

2016-11-28 Thread daewon
@Do-yung Thank you for your comments.
I will wait for some feedback and make an ISSUE for this discussion in
S2Graph-JIRA.

On Mon, Nov 28, 2016 at 4:24 PM DO YUNG YOON  wrote:

> Hi Daewon.
>
> As far as I understand, you are suggesting to drop `dir` column in
> LabelIndex model and let user to specify direction on each option?
>
> I agree that `dir` should be deprecated since what user logically think for
> query is based on indexName, not (indexName, dir) pair.
> I have +1 on this suggestion.
>
> On Mon, Nov 28, 2016 at 3:06 PM daewon  wrote:
>
> > S2GRAPH-123(https://issues.apache.org/jira/browse/S2GRAPH-123) I have
> > opinion on the directional index feature provided in this issue. The
> > current implementation creates an 'index edge' according to the 'dir'
> > column value (in or out) in the 'label_indices' table. The current
> > implementation chooses the first 'index' in 'indices' when querying
> without
> > a proper 'index' name. If the problem is that the query does not give the
> > proper index name at the time of the query in the one-step query to the
> out
> > direction, then the query in the two-step query in the direction of in.
> > Also, since the existing indexes are changed, 'index_id' is changed for
> > newly added indexes. Therefore, there is no way to perform migration when
> > you want to no longer use the index for in direction in the label used
> > previously. So I suggest changing the implementation as shown below.
> > 'Index' is used for both directions as before, but it changes its
> behavior
> > by referring to the value of the 'option' field. {   "In": {
> >  "StoreDegree": true,  "StoreIndex": false},   "Out": {
> >"StoreDegree": false,"StoreIndex": true   } } If no option
> > is given for each direction, it assumes that all values ​​are set to
> > 'true'. Thank you.
> >
>


Re: Opinion on the directional index feature provided in ISSUE-123

2016-11-27 Thread DO YUNG YOON
Hi Daewon.

As far as I understand, you are suggesting to drop `dir` column in
LabelIndex model and let user to specify direction on each option?

I agree that `dir` should be deprecated since what user logically think for
query is based on indexName, not (indexName, dir) pair.
I have +1 on this suggestion.

On Mon, Nov 28, 2016 at 3:06 PM daewon  wrote:

> S2GRAPH-123(https://issues.apache.org/jira/browse/S2GRAPH-123) I have
> opinion on the directional index feature provided in this issue. The
> current implementation creates an 'index edge' according to the 'dir'
> column value (in or out) in the 'label_indices' table. The current
> implementation chooses the first 'index' in 'indices' when querying without
> a proper 'index' name. If the problem is that the query does not give the
> proper index name at the time of the query in the one-step query to the out
> direction, then the query in the two-step query in the direction of in.
> Also, since the existing indexes are changed, 'index_id' is changed for
> newly added indexes. Therefore, there is no way to perform migration when
> you want to no longer use the index for in direction in the label used
> previously. So I suggest changing the implementation as shown below.
> 'Index' is used for both directions as before, but it changes its behavior
> by referring to the value of the 'option' field. {   "In": {
>  "StoreDegree": true,  "StoreIndex": false},   "Out": {
>"StoreDegree": false,"StoreIndex": true   } } If no option
> is given for each direction, it assumes that all values ​​are set to
> 'true'. Thank you.
>