Re: Passing Java system properties to YARN containers of Samza Job

[Tommy Becker]

You should also prefix the names of the API keys with "sensitive.". This will 
mask the values when the config is logged and in the AM UI.

On 12/09/2015 01:19 AM, Yi Pan wrote:

Hi, Gordon,

Try to use --config X.Y.Z=value from the command line to run run-job.sh

On Tue, Dec 8, 2015 at 5:57 PM, Gordon Tai 
 wrote:



Hi Rad,

Our Samza jobs run on on-premiere clusters, on top of YARN and Kafka. So
IAM roles won't be an option either.

BR,

On 9 December 2015 at 04:09, Rad Gruchalski 
 wrote:



Gordon,

If your tasks run on EC2, you should use IAM roles.
https://www.youtube.com/watch?v=XuRM4Id6uDY










Kind regards,
Radek Gruchalski
ra...@gruchalski.com (mailto:ra...@gruchalski.com) 
(mailto:
ra...@gruchalski.com)
de.linkedin.com/in/radgruchalski/ (
http://de.linkedin.com/in/radgruchalski/)

Confidentiality:
This communication is intended for the above-named person and may be
confidential and/or legally privileged.
If it has come to you in error you must take no action based on it, nor
must you copy or show it to anyone; please delete/destroy and inform the
sender immediately.



On Tuesday, 8 December 2015 at 18:57, Gordon Tai wrote:



Hi,

Is there any convenient way to pass custom Java system properties to


Samza


jobs?
Specifically, since the system properties I wish to pass are
aws.accessKeyId and aws.secretKey for AWS credentials (






http://docs.aws.amazon.com/AWSSdkDocsJava/latest/DeveloperGuide/credentials.html


),


writing
them into the Samza job config file doesn't seem like a good idea.
Any help is great, thanks!

BR,
Gordon

--
*Gordon Tai* | Data Engineer | gor...@vm5.com | 
http://www.vm5.com



*VMFIVE CONFIDENTIAL*
This message, including any attachments, may contain information that


is


confidential, proprietary, privileged or otherwise protected by law,


and


is


intended only for the parties involved in the subject discussed


therein.


If


you have received this e-mail by mistake, please immediately delete the
message and notify the sender of such incident. Please be noted that


any


unauthorized use, dissemination, distribution or copying of this email


is


strictly prohibited.











--
*Gordon Tai* | Data Engineer | gor...@vm5.com | 
http://www.vm5.com



*VMFIVE CONFIDENTIAL*
This message, including any attachments, may contain information that is
confidential, proprietary, privileged or otherwise protected by law, and is
intended only for the parties involved in the subject discussed therein. If
you have received this e-mail by mistake, please immediately delete the
message and notify the sender of such incident. Please be noted that any
unauthorized use, dissemination, distribution or copying of this email is
strictly prohibited.






--
Tommy Becker
Senior Software Engineer

Digitalsmiths
A TiVo Company

www.digitalsmiths.com
tobec...@tivo.com



This email and any attachments may contain confidential and privileged material 
for the sole use of the intended recipient. Any review, copying, or 
distribution of this email (or any attachments) by others is prohibited. If you 
are not the intended recipient, please contact the sender immediately and 
permanently delete this email and any attachments. No employee or agent of TiVo 
Inc. is authorized to conclude any binding agreement on behalf of TiVo Inc. by 
email. Binding agreements with TiVo Inc. may only be made by a signed written 
agreement.

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

[Jake Maes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41106/#review109571
---

Ship it!



samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 
(line 38)


nit: this message will no longer be valid after we fully deprecate 
yarn.container.count. It would be more future-proof to say "Container count 
larger than 1..."


- Jake Maes


On Dec. 9, 2015, 6:41 a.m., Tao Feng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41106/
> ---
> 
> (Updated Dec. 9, 2015, 6:41 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> 1. throws runtime exception if user sets yarn.container.count or 
> job.container.count larger than 1 for ProcessJobFactory; 
> 2. update per Yi's comment
> 
> 
> Diffs
> -
> 
>   
> samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 
> 0792a59cb7b042220c8dbfc0713c5ef42e93ab25 
> 
> Diff: https://reviews.apache.org/r/41106/diff/
> 
> 
> Testing
> ---
> 
> 1. ./gradlew clean build
> 2. ./gradlew checkstyleMain checkstyleTest
> 3. manual test open source hello samza and verify that by giving 
> yarn.container.count or job.container.count with value greater than 1 for 
> ProcessJobFactory, the test will throw the desired exception.
> 
> 
> Thanks,
> 
> Tao Feng
> 
>

Re: [VOTE] Samza 0.10.0 Release Candidate 2

[xinyu liu]

+1 on my side. I also ran the gradle build and unit tests without failure.

Thanks,
Xinyu

On Wed, Dec 9, 2015 at 9:54 AM, Tao Feng  wrote:

> +1 from my side(non-binding). I download the package and successfully run
> all the unit tests without failure.
>
> On Tue, Dec 8, 2015 at 3:38 PM, Yi Pan  wrote:
>
> > Hey all,
> >
> >
> > This is a call for a vote on a release of Apache Samza 0.10.0. Thanks to
> > everyone who has contributed to this release. We are very glad to see
> some
> > new contributors in this release.
> >
> >
> > The release candidate can be downloaded from here:
> >
> >
> > http://home.apache.org/~nickpan47/samza-0.10.0-rc2/
> >
> >
> > The release candidate is signed with pgp key 911402D8, which is
> >
> > included in the repository's KEYS file:
> >
> >
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=blob;f=KEYS;h=66cbd15cddbbd798c3529e9a8b7f052aab0037a7
> >
> >
> > and can also be found on keyservers:
> >
> > http://pgp.mit.edu/pks/lookup?op=get=0x911402D8
> >
> >
> > The git tag is release-0.10.0-rc2 and signed with the same pgp key:
> >
> >
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=4a37a3c4754b94805646522fc6644f2dd998e828
> >
> >
> > Test binaries have been published to Maven's staging repository, and are
> >
> > available here:
> >
> >
> > https://repository.apache.org/content/repositories/orgapachesamza-1011/
> >
> >
> > Note that the binaries were built with JDK7 without incident. This is the
> > first version of Samza that does not support JDK6 any more.
> >
> >
> > 128 issues were resolved for this release:
> >
> >
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SAMZA%20AND%20fixVersion%20%3D%200.10.0%20AND%20status%20in%20(Resolved%2C%20Closed)
> >
> >
> > The vote will be open for 72 hours ( end in 4:00pm Friday, 12/11/2015 ).
> >
> > Please download the release candidate, check the hashes/signature, build
> it
> >
> > and test it, and then please vote:
> >
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove (and reason why)
> >
> >
> > +1 from my side for the release.
> >
> >
> > Yi Pan
> >
> > nickpa...@gmail.com
> >
>

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

[Boris Shkolnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41106/#review109619
---

Ship it!


- Boris Shkolnik


On Dec. 9, 2015, 6:41 a.m., Tao Feng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41106/
> ---
> 
> (Updated Dec. 9, 2015, 6:41 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> 1. throws runtime exception if user sets yarn.container.count or 
> job.container.count larger than 1 for ProcessJobFactory; 
> 2. update per Yi's comment
> 
> 
> Diffs
> -
> 
>   
> samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 
> 0792a59cb7b042220c8dbfc0713c5ef42e93ab25 
> 
> Diff: https://reviews.apache.org/r/41106/diff/
> 
> 
> Testing
> ---
> 
> 1. ./gradlew clean build
> 2. ./gradlew checkstyleMain checkstyleTest
> 3. manual test open source hello samza and verify that by giving 
> yarn.container.count or job.container.count with value greater than 1 for 
> ProcessJobFactory, the test will throw the desired exception.
> 
> 
> Thanks,
> 
> Tao Feng
> 
>

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

[Tao Feng]

> On Dec. 9, 2015, 6:06 p.m., Jake Maes wrote:
> > samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala,
> >  line 38
> > 
> >
> > nit: this message will no longer be valid after we fully deprecate 
> > yarn.container.count. It would be more future-proof to say "Container count 
> > larger than 1..."

Thanks for the suggestion. I will send out an updated RB later today.


- Tao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41106/#review109571
---


On Dec. 9, 2015, 6:41 a.m., Tao Feng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41106/
> ---
> 
> (Updated Dec. 9, 2015, 6:41 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> 1. throws runtime exception if user sets yarn.container.count or 
> job.container.count larger than 1 for ProcessJobFactory; 
> 2. update per Yi's comment
> 
> 
> Diffs
> -
> 
>   
> samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 
> 0792a59cb7b042220c8dbfc0713c5ef42e93ab25 
> 
> Diff: https://reviews.apache.org/r/41106/diff/
> 
> 
> Testing
> ---
> 
> 1. ./gradlew clean build
> 2. ./gradlew checkstyleMain checkstyleTest
> 3. manual test open source hello samza and verify that by giving 
> yarn.container.count or job.container.count with value greater than 1 for 
> ProcessJobFactory, the test will throw the desired exception.
> 
> 
> Thanks,
> 
> Tao Feng
> 
>

Re: Passing Java system properties to YARN containers of Samza Job

[Boris Shkolnik]

I am not sure about AWS credentials, but, in general, you can use task.opts
config value to pass any java level settings, which will be passed to each
container jvm.

On Tue, Dec 8, 2015 at 9:57 AM, Gordon Tai  wrote:

> Hi,
>
> Is there any convenient way to pass custom Java system properties to Samza
> jobs?
> Specifically, since the system properties I wish to pass are
> aws.accessKeyId and aws.secretKey for AWS credentials  (
>
> http://docs.aws.amazon.com/AWSSdkDocsJava/latest/DeveloperGuide/credentials.html
> ),
> writing
> them into the Samza job config file doesn't seem like a good idea.
> Any help is great, thanks!
>
> BR,
> Gordon
>
> --
> *Gordon Tai* | Data Engineer | gor...@vm5.com | http://www.vm5.com
>
>
>
> *VMFIVE CONFIDENTIAL*
> This message, including any attachments, may contain information that is
> confidential, proprietary, privileged or otherwise protected by law, and is
> intended only for the parties involved in the subject discussed therein. If
> you have received this e-mail by mistake, please immediately delete the
> message and notify the sender of such incident. Please be noted that any
> unauthorized use, dissemination, distribution or copying of this email is
> strictly prohibited.
>

Re: [VOTE] Samza 0.10.0 Release Candidate 2

[Jacob Maes]

+1 [non binding].

Ran

> ./gradlew build,
> ./bin/check-all.sh, and
> ./bin/integration-tests.sh /tmp/samza-tests

from my Mac and all were successful.

I saw some checkstyle errors when I used gradle 2.9, but it was fine with
gradle 2.2 and 2.3. I created SAMZA-837 for gradle 2.9 compatibility.

On Wed, Dec 9, 2015 at 12:15 PM, xinyu liu  wrote:

> +1 on my side. I also ran the gradle build and unit tests without failure.
>
> Thanks,
> Xinyu
>
> On Wed, Dec 9, 2015 at 9:54 AM, Tao Feng  wrote:
>
> > +1 from my side(non-binding). I download the package and successfully run
> > all the unit tests without failure.
> >
> > On Tue, Dec 8, 2015 at 3:38 PM, Yi Pan  wrote:
> >
> > > Hey all,
> > >
> > >
> > > This is a call for a vote on a release of Apache Samza 0.10.0. Thanks
> to
> > > everyone who has contributed to this release. We are very glad to see
> > some
> > > new contributors in this release.
> > >
> > >
> > > The release candidate can be downloaded from here:
> > >
> > >
> > > http://home.apache.org/~nickpan47/samza-0.10.0-rc2/
> > >
> > >
> > > The release candidate is signed with pgp key 911402D8, which is
> > >
> > > included in the repository's KEYS file:
> > >
> > >
> > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=blob;f=KEYS;h=66cbd15cddbbd798c3529e9a8b7f052aab0037a7
> > >
> > >
> > > and can also be found on keyservers:
> > >
> > > http://pgp.mit.edu/pks/lookup?op=get=0x911402D8
> > >
> > >
> > > The git tag is release-0.10.0-rc2 and signed with the same pgp key:
> > >
> > >
> > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=4a37a3c4754b94805646522fc6644f2dd998e828
> > >
> > >
> > > Test binaries have been published to Maven's staging repository, and
> are
> > >
> > > available here:
> > >
> > >
> > >
> https://repository.apache.org/content/repositories/orgapachesamza-1011/
> > >
> > >
> > > Note that the binaries were built with JDK7 without incident. This is
> the
> > > first version of Samza that does not support JDK6 any more.
> > >
> > >
> > > 128 issues were resolved for this release:
> > >
> > >
> > >
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SAMZA%20AND%20fixVersion%20%3D%200.10.0%20AND%20status%20in%20(Resolved%2C%20Closed)
> > >
> > >
> > > The vote will be open for 72 hours ( end in 4:00pm Friday, 12/11/2015
> ).
> > >
> > > Please download the release candidate, check the hashes/signature,
> build
> > it
> > >
> > > and test it, and then please vote:
> > >
> > >
> > > [ ] +1 approve
> > >
> > > [ ] +0 no opinion
> > >
> > > [ ] -1 disapprove (and reason why)
> > >
> > >
> > > +1 from my side for the release.
> > >
> > >
> > > Yi Pan
> > >
> > > nickpa...@gmail.com
> > >
> >
>

Re: Review Request 40933: SAMZA-829: Add YARN configure doc to allow clean shutdown for large state jobs

[Boris Shkolnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40933/#review109673
---

Ship it!


Ship It!

- Boris Shkolnik


On Dec. 3, 2015, 11:10 p.m., Yi Pan (Data Infrastructure) wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40933/
> ---
> 
> (Updated Dec. 3, 2015, 11:10 p.m.)
> 
> 
> Review request for samza, Jake Maes and Jon Bringhurst.
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> SAMZA-829: Add YARN configure doc to allow clean shutdown for large state jobs
> 
> 
> Diffs
> -
> 
>   docs/learn/documentation/versioned/yarn/yarn-host-affinity.md 
> 108dfbc914d572334878b7e3718de5e541b8c6a6 
> 
> Diff: https://reviews.apache.org/r/40933/diff/
> 
> 
> Testing
> ---
> 
> Locally tested. Configure variables verified in LinkedIn tests.
> 
> 
> Thanks,
> 
> Yi Pan (Data Infrastructure)
> 
>

Re: [VOTE] Samza 0.10.0 Release Candidate 2

[Boris Shkolnik]

I've opened a ticket to track this rocksdb:test failure:

   1. SAMZA-836 


On Wed, Dec 9, 2015 at 7:11 PM, Boris Shkolnik  wrote:

> +1 (non-binding).
> One note. I failed for me couple of times with the test below, but it
> might've been related to some old versions of rocksdbjni, but I am not
> sure. I've run it couple of more times and it ran fine.
>
>
> On Wed, Dec 9, 2015 at 12:15 PM, xinyu liu  wrote:
>
>> +1 on my side. I also ran the gradle build and unit tests without failure.
>>
>> Thanks,
>> Xinyu
>>
>> On Wed, Dec 9, 2015 at 9:54 AM, Tao Feng  wrote:
>>
>> > +1 from my side(non-binding). I download the package and successfully
>> run
>> > all the unit tests without failure.
>> >
>> > On Tue, Dec 8, 2015 at 3:38 PM, Yi Pan  wrote:
>> >
>> > > Hey all,
>> > >
>> > >
>> > > This is a call for a vote on a release of Apache Samza 0.10.0. Thanks
>> to
>> > > everyone who has contributed to this release. We are very glad to see
>> > some
>> > > new contributors in this release.
>> > >
>> > >
>> > > The release candidate can be downloaded from here:
>> > >
>> > >
>> > > http://home.apache.org/~nickpan47/samza-0.10.0-rc2/
>> > >
>> > >
>> > > The release candidate is signed with pgp key 911402D8, which is
>> > >
>> > > included in the repository's KEYS file:
>> > >
>> > >
>> > >
>> > >
>> >
>> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=blob;f=KEYS;h=66cbd15cddbbd798c3529e9a8b7f052aab0037a7
>> > >
>> > >
>> > > and can also be found on keyservers:
>> > >
>> > > http://pgp.mit.edu/pks/lookup?op=get=0x911402D8
>> > >
>> > >
>> > > The git tag is release-0.10.0-rc2 and signed with the same pgp key:
>> > >
>> > >
>> > >
>> > >
>> >
>> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=4a37a3c4754b94805646522fc6644f2dd998e828
>> > >
>> > >
>> > > Test binaries have been published to Maven's staging repository, and
>> are
>> > >
>> > > available here:
>> > >
>> > >
>> > >
>> https://repository.apache.org/content/repositories/orgapachesamza-1011/
>> > >
>> > >
>> > > Note that the binaries were built with JDK7 without incident. This is
>> the
>> > > first version of Samza that does not support JDK6 any more.
>> > >
>> > >
>> > > 128 issues were resolved for this release:
>> > >
>> > >
>> > >
>> > >
>> >
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SAMZA%20AND%20fixVersion%20%3D%200.10.0%20AND%20status%20in%20(Resolved%2C%20Closed)
>> > >
>> > >
>> > > The vote will be open for 72 hours ( end in 4:00pm Friday, 12/11/2015
>> ).
>> > >
>> > > Please download the release candidate, check the hashes/signature,
>> build
>> > it
>> > >
>> > > and test it, and then please vote:
>> > >
>> > >
>> > > [ ] +1 approve
>> > >
>> > > [ ] +0 no opinion
>> > >
>> > > [ ] -1 disapprove (and reason why)
>> > >
>> > >
>> > > +1 from my side for the release.
>> > >
>> > >
>> > > Yi Pan
>> > >
>> > > nickpa...@gmail.com
>> > >
>> >
>>
>
>

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

[Tao Feng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41106/
---

(Updated Dec. 10, 2015, 4:34 a.m.)


Review request for samza.


Repository: samza


Description (updated)
---

update per Jake's comment


Diffs (updated)
-

  samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 
0792a59cb7b042220c8dbfc0713c5ef42e93ab25 

Diff: https://reviews.apache.org/r/41106/diff/


Testing
---

1. ./gradlew clean build
2. ./gradlew checkstyleMain checkstyleTest
3. manual test open source hello samza and verify that by giving 
yarn.container.count or job.container.count with value greater than 1 for 
ProcessJobFactory, the test will throw the desired exception.


Thanks,

Tao Feng

Re: [VOTE] Samza 0.10.0 Release Candidate 2

[Chris Riccomini]

+1 binding

On Wed, Dec 9, 2015 at 7:16 PM, Boris Shkolnik  wrote:

> I've opened a ticket to track this rocksdb:test failure:
>
>1. SAMZA-836 
>
>
> On Wed, Dec 9, 2015 at 7:11 PM, Boris Shkolnik  wrote:
>
> > +1 (non-binding).
> > One note. I failed for me couple of times with the test below, but it
> > might've been related to some old versions of rocksdbjni, but I am not
> > sure. I've run it couple of more times and it ran fine.
> >
> >
> > On Wed, Dec 9, 2015 at 12:15 PM, xinyu liu 
> wrote:
> >
> >> +1 on my side. I also ran the gradle build and unit tests without
> failure.
> >>
> >> Thanks,
> >> Xinyu
> >>
> >> On Wed, Dec 9, 2015 at 9:54 AM, Tao Feng  wrote:
> >>
> >> > +1 from my side(non-binding). I download the package and successfully
> >> run
> >> > all the unit tests without failure.
> >> >
> >> > On Tue, Dec 8, 2015 at 3:38 PM, Yi Pan  wrote:
> >> >
> >> > > Hey all,
> >> > >
> >> > >
> >> > > This is a call for a vote on a release of Apache Samza 0.10.0.
> Thanks
> >> to
> >> > > everyone who has contributed to this release. We are very glad to
> see
> >> > some
> >> > > new contributors in this release.
> >> > >
> >> > >
> >> > > The release candidate can be downloaded from here:
> >> > >
> >> > >
> >> > > http://home.apache.org/~nickpan47/samza-0.10.0-rc2/
> >> > >
> >> > >
> >> > > The release candidate is signed with pgp key 911402D8, which is
> >> > >
> >> > > included in the repository's KEYS file:
> >> > >
> >> > >
> >> > >
> >> > >
> >> >
> >>
> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=blob;f=KEYS;h=66cbd15cddbbd798c3529e9a8b7f052aab0037a7
> >> > >
> >> > >
> >> > > and can also be found on keyservers:
> >> > >
> >> > > http://pgp.mit.edu/pks/lookup?op=get=0x911402D8
> >> > >
> >> > >
> >> > > The git tag is release-0.10.0-rc2 and signed with the same pgp key:
> >> > >
> >> > >
> >> > >
> >> > >
> >> >
> >>
> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=4a37a3c4754b94805646522fc6644f2dd998e828
> >> > >
> >> > >
> >> > > Test binaries have been published to Maven's staging repository, and
> >> are
> >> > >
> >> > > available here:
> >> > >
> >> > >
> >> > >
> >> https://repository.apache.org/content/repositories/orgapachesamza-1011/
> >> > >
> >> > >
> >> > > Note that the binaries were built with JDK7 without incident. This
> is
> >> the
> >> > > first version of Samza that does not support JDK6 any more.
> >> > >
> >> > >
> >> > > 128 issues were resolved for this release:
> >> > >
> >> > >
> >> > >
> >> > >
> >> >
> >>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SAMZA%20AND%20fixVersion%20%3D%200.10.0%20AND%20status%20in%20(Resolved%2C%20Closed)
> >> > >
> >> > >
> >> > > The vote will be open for 72 hours ( end in 4:00pm Friday,
> 12/11/2015
> >> ).
> >> > >
> >> > > Please download the release candidate, check the hashes/signature,
> >> build
> >> > it
> >> > >
> >> > > and test it, and then please vote:
> >> > >
> >> > >
> >> > > [ ] +1 approve
> >> > >
> >> > > [ ] +0 no opinion
> >> > >
> >> > > [ ] -1 disapprove (and reason why)
> >> > >
> >> > >
> >> > > +1 from my side for the release.
> >> > >
> >> > >
> >> > > Yi Pan
> >> > >
> >> > > nickpa...@gmail.com
> >> > >
> >> >
> >>
> >
> >
>

Re: Review Request 40857: SAMZA 826 Fix string format issue with log message in ContainerUtil

[Boris Shkolnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40857/#review109674
---

Ship it!


Ship It!

- Boris Shkolnik


On Dec. 2, 2015, 7:53 a.m., Aleksandar Bircakovic wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40857/
> ---
> 
> (Updated Dec. 2, 2015, 7:53 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> The '%s' replaced with '{}'
> 
> 
> Diffs
> -
> 
>   samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerUtil.java 
> 1fb6a5f 
> 
> Diff: https://reviews.apache.org/r/40857/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleksandar Bircakovic
> 
>

Re: Review Request 41106: SAMZA-833: ProcessJob mishandling containers

[Jake Maes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41106/#review109687
---

Ship it!


Ship It!

- Jake Maes


On Dec. 10, 2015, 4:34 a.m., Tao Feng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41106/
> ---
> 
> (Updated Dec. 10, 2015, 4:34 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> update per Jake's comment
> 
> 
> Diffs
> -
> 
>   
> samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 
> 0792a59cb7b042220c8dbfc0713c5ef42e93ab25 
> 
> Diff: https://reviews.apache.org/r/41106/diff/
> 
> 
> Testing
> ---
> 
> 1. ./gradlew clean build
> 2. ./gradlew checkstyleMain checkstyleTest
> 3. manual test open source hello samza and verify that by giving 
> yarn.container.count or job.container.count with value greater than 1 for 
> ProcessJobFactory, the test will throw the desired exception.
> 
> 
> Thanks,
> 
> Tao Feng
> 
>

Review Request 41144: SAMZA-587: Create SystemConsumer and SystemProducer for ActiveMQ

[Ben Damer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41144/
---

Review request for samza.


Repository: samza


Description
---

Integration with ActiveMQ. Supports consuming from and producing messages to 
ActiveMQ queues.


Diffs
-

  build.gradle 0541def1b3ee15dceeb354840815ac140515 
  gradle/dependency-versions.gradle 52e25aa53a1edc85d478b48898621b26508ad4bb 
  samza-activemq/src/main/java/org/apache/samza/config/ActiveMQConfig.java 
PRE-CREATION 
  
samza-activemq/src/main/java/org/apache/samza/system/activemq/ActiveMQAdmin.java
 PRE-CREATION 
  
samza-activemq/src/main/java/org/apache/samza/system/activemq/ActiveMQConsumer.java
 PRE-CREATION 
  
samza-activemq/src/main/java/org/apache/samza/system/activemq/ActiveMQProducer.java
 PRE-CREATION 
  
samza-activemq/src/main/java/org/apache/samza/system/activemq/ActiveMQProducerMetrics.java
 PRE-CREATION 
  
samza-activemq/src/main/java/org/apache/samza/system/activemq/ActiveMQSystemFactory.java
 PRE-CREATION 
  
samza-activemq/src/test/java/org/apache/samza/system/activemq/ActiveMQConsumerTest.java
 PRE-CREATION 
  
samza-activemq/src/test/java/org/apache/samza/system/activemq/ActiveMQProducerTest.java
 PRE-CREATION 
  
samza-activemq/src/test/java/org/apache/samza/system/activemq/ActiveMQTestHelper.java
 PRE-CREATION 
  settings.gradle 4c1aa107a11d413777e69bc4e48847b811aff7d2 

Diff: https://reviews.apache.org/r/41144/diff/


Testing
---

Unit tests for producer and consumer.


Thanks,

Ben Damer

Re: [VOTE] Samza 0.10.0 Release Candidate 2

[Tao Feng]

+1 from my side(non-binding). I download the package and successfully run
all the unit tests without failure.

On Tue, Dec 8, 2015 at 3:38 PM, Yi Pan  wrote:

> Hey all,
>
>
> This is a call for a vote on a release of Apache Samza 0.10.0. Thanks to
> everyone who has contributed to this release. We are very glad to see some
> new contributors in this release.
>
>
> The release candidate can be downloaded from here:
>
>
> http://home.apache.org/~nickpan47/samza-0.10.0-rc2/
>
>
> The release candidate is signed with pgp key 911402D8, which is
>
> included in the repository's KEYS file:
>
>
>
> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=blob;f=KEYS;h=66cbd15cddbbd798c3529e9a8b7f052aab0037a7
>
>
> and can also be found on keyservers:
>
> http://pgp.mit.edu/pks/lookup?op=get=0x911402D8
>
>
> The git tag is release-0.10.0-rc2 and signed with the same pgp key:
>
>
>
> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=4a37a3c4754b94805646522fc6644f2dd998e828
>
>
> Test binaries have been published to Maven's staging repository, and are
>
> available here:
>
>
> https://repository.apache.org/content/repositories/orgapachesamza-1011/
>
>
> Note that the binaries were built with JDK7 without incident. This is the
> first version of Samza that does not support JDK6 any more.
>
>
> 128 issues were resolved for this release:
>
>
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SAMZA%20AND%20fixVersion%20%3D%200.10.0%20AND%20status%20in%20(Resolved%2C%20Closed)
>
>
> The vote will be open for 72 hours ( end in 4:00pm Friday, 12/11/2015 ).
>
> Please download the release candidate, check the hashes/signature, build it
>
> and test it, and then please vote:
>
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove (and reason why)
>
>
> +1 from my side for the release.
>
>
> Yi Pan
>
> nickpa...@gmail.com
>