Review Request 44420: SAMZA-888: SamzaContainer initializes ExponentialSleepStrategy with randInt that is inclusive of 0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44420/ --- Review request for samza. Repository: samza Description --- SAMZA-888: SamzaContainer initializes ExponentialSleepStrategy with randInt that is inclusive of 0 Diffs - samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala e3d0b6cb4181e58c1526efecd6fb58cdd69d8fad Diff: https://reviews.apache.org/r/44420/diff/ Testing --- ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest Thanks, Tao Feng
Re: Review Request 44418: SAMZA-887: Use cached JobModel everywhere in the Samza AM container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44418/ --- (Updated March 5, 2016, 7:08 a.m.) Review request for samza. Summary (updated) - SAMZA-887: Use cached JobModel everywhere in the Samza AM container Repository: samza Description --- SAMZA-877: Use cached JobModel everywhere in the Samza AM container Diffs - samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java 0c6329ede9b3df4dc05125729b5b44ba2c98803a Diff: https://reviews.apache.org/r/44418/diff/ Testing --- ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest Thanks, Tao Feng
Review Request 44418: SAMZA-877: Use cached JobModel everywhere in the Samza AM container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44418/ --- Review request for samza. Repository: samza Description --- SAMZA-877: Use cached JobModel everywhere in the Samza AM container Diffs - samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java 0c6329ede9b3df4dc05125729b5b44ba2c98803a Diff: https://reviews.apache.org/r/44418/diff/ Testing --- ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest Thanks, Tao Feng
Re: Review Request 44293: SAMZA-883 Improve logging for container handling and kafka abdication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44293/ --- (Updated March 5, 2016, 5:20 a.m.) Review request for samza. Repository: samza Description --- SAMZA-883 Improve logging for container handling and kafka refresh Diffs (updated) - samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 9aa98184f8ab186eff226482f894e8842b9525e5 samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala b37375360bcad8e089d95e8e3da63a1b9aab samza-kafka/src/main/scala/org/apache/samza/util/ClientUtilTopicMetadataStore.scala 0f91622c0c4c270a376f8b91b3e785cca57bc9dd samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala ece0359d1a31e65113f4832dd3baddb788cecef4 samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java 54db5e5b2b1b109d202e814809adbfd2bc84fb4b samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerUtil.java 91fae98c074e1648e7168fb8e76d6e1e656816fc Diff: https://reviews.apache.org/r/44293/diff/ Testing --- Manual testing and log verification (made sure they weren't verbose) Thanks, Jake Maes
Review Request 44405: SAMZA-882 - Detect partition count changes in input streams
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44405/ --- Review request for samza, Boris Shkolnik, Jake Maes, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). Bugs: SAMZA-882 https://issues.apache.org/jira/browse/SAMZA-882 Repository: samza Description --- Adding loop.done in stream metadata cache Adding comments in Test Adding configuration to the docs Fixing the swallowed exception from Scala immutable map Updating config docs Fixed some comments and javadoc Diffs - docs/learn/documentation/versioned/jobs/configuration-table.html 2745a22daf3626db56da2bedad07690751a34a27 samza-api/src/main/java/org/apache/samza/system/ExtendedSystemAdmin.java PRE-CREATION samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 4f3e9a297ce2c0df0f5f25e0aad62f7bed774cd6 samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala 06a96ad6ed786c22924017f894413bfa1ea34c06 samza-core/src/main/scala/org/apache/samza/coordinator/StreamPartitionCountMonitor.scala PRE-CREATION samza-core/src/main/scala/org/apache/samza/system/StreamMetadataCache.scala 155c3d16d33d9bb9cd5410d786004c1bf2a57ed3 samza-core/src/main/scala/org/apache/samza/util/Util.scala bd0fe5fc8128c59fa6d08941ad88eed66dda622b samza-core/src/test/scala/org/apache/samza/coordinator/TestJobCoordinator.scala 9ab1dd516871b1755ef64fa25cea47491ad781e2 samza-core/src/test/scala/org/apache/samza/coordinator/TestStreamPartitionCountMonitor.scala PRE-CREATION samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 9dc436a40afd7190626a8be0d716c70e0fe83c7a samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocator.java e2b45d7577dea5a4a71af22521c93a7fd75eaefc samza-yarn/src/test/java/org/apache/samza/job/yarn/TestHostAwareContainerAllocator.java 269d82479650b3bc2890d250da0391d34104b1eb samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaTaskManager.java 88d9f24d16fc3d9842b387cfc22edaf1dfa6fd06 Diff: https://reviews.apache.org/r/44405/diff/ Testing --- ./gradlew clean build Tested with a simple Samza job using hello-samza -> Verified that the metrics gauge is getting updated and published correctly. Thanks, Navina Ramesh
Re: Review Request 44399: SAMZA-884: upgrade Jackson to 1.9.13 in hello-samza latest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44399/#review122117 --- Ship it! Ship It! - Navina Ramesh On March 4, 2016, 6:21 p.m., Yi Pan (Data Infrastructure) wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44399/ > --- > > (Updated March 4, 2016, 6:21 p.m.) > > > Review request for samza, Jake Maes, Navina Ramesh, Jagadish Venkatraman, and > Xinyu Liu. > > > Repository: samza-hello-samza > > > Description > --- > > SAMZA-884: upgrade Jackson to 1.9.13 in hello-samza latest > > > Diffs > - > > build.gradle cbbd2b3789800582eff37585e9cf8d5f560a7638 > pom.xml 552c2a9894f1c0aa3b0bac5fd4c5c0c6324b89f9 > > Diff: https://reviews.apache.org/r/44399/diff/ > > > Testing > --- > > Locally build and deployed w/ ./gradlew and mvn > > > Thanks, > > Yi Pan (Data Infrastructure) > >
Review Request 44399: SAMZA-884: upgrade Jackson to 1.9.13 in hello-samza latest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44399/ --- Review request for samza, Jake Maes, Navina Ramesh, Jagadish Venkatraman, and Xinyu Liu. Repository: samza-hello-samza Description --- SAMZA-884: upgrade Jackson to 1.9.13 in hello-samza latest Diffs - build.gradle cbbd2b3789800582eff37585e9cf8d5f560a7638 pom.xml 552c2a9894f1c0aa3b0bac5fd4c5c0c6324b89f9 Diff: https://reviews.apache.org/r/44399/diff/ Testing --- Locally build and deployed w/ ./gradlew and mvn Thanks, Yi Pan (Data Infrastructure)
