Re: Review Request 46465: Move Samza to use pull requests

2016-06-23 Thread Navina Ramesh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46465/#review139320
---



Still reviewing..


samza_merge_pr.py (line 401)


I don't think this assumption is correct. Also, we always want to merge a 
PR to the master branch. 
Hence, "latest_branch" should always be "master" , right?


- Navina Ramesh


On April 21, 2016, 12:28 a.m., Jagadish Venkatraman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46465/
> ---
> 
> (Updated April 21, 2016, 12:28 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> The current process for code reviews and check­ins in Samza involves multiple 
> manual steps
> and is cumbersome. This change is to move Samza to rely on pull requests.
> 
> Here's a writeup that explains the motivation for this design:
> https://issues.apache.org/jira/secure/attachment/12799869/MovingSamzatoPullRequests.pdf
> 
> This change also adds the ./samza_merge_pr.py tool 
> -This tool will automate all of git / jira interactions and manual steps that 
> we have currently in the committer workflow.) 
> -This is also a step towards standardizing commit messages in the Samza 
> project (so that they are generated consistently by the tool)
> 
> 
> Kafka and Spark have similar tools, and we've adapted those:
> https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py
> https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py
> 
> 
> Diffs
> -
> 
>   samza_merge_pr.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46465/diff/
> 
> 
> Testing
> ---
> 
> Tested with running the tool on a test repository. Here's what a sample run 
> looks like:
> 
> ?  samza-clone git:(master) ./samza_merge_pr.py
> git rev-parse --abbrev-ref HEAD
> Which pull request would you like to merge? (e.g. 34): 2
> Commit title [Fix1]:
> 
> === Pull Request #2 ===
> PR title  Fix1
> Commit title  Fix1
> Sourcevjagadish1989/fix1
> Targetmaster
> URL   https://api.github.com/repos/vjagadish/samza-clone/pulls/2
> 
> Proceed with merging pull request #2? (y/n): y
> git fetch apache-github pull/2/head:PR_TOOL_MERGE_PR_2
> From https://github.com/vjagadish/samza-clone
>  * [new ref] refs/pull/2/head -> PR_TOOL_MERGE_PR_2
> git fetch apache-github master:PR_TOOL_MERGE_PR_2_MASTER
> From https://github.com/vjagadish/samza-clone
>  * [new branch]  master -> PR_TOOL_MERGE_PR_2_MASTER
> git checkout PR_TOOL_MERGE_PR_2_MASTER
> Switched to branch 'PR_TOOL_MERGE_PR_2_MASTER'
> ['git', 'merge', 'PR_TOOL_MERGE_PR_2', '--squash']
> Automatic merge went well; stopped before committing as requested
> ['git', 'log', 'HEAD..PR_TOOL_MERGE_PR_2', '--pretty=format:%an <%ae>']
> Enter primary author in the format of "name " [vjagadish1989 
> ]:
> Enter reviewers in the format of "name1 , name2 ":
> ['git', 'log', 'HEAD..PR_TOOL_MERGE_PR_2', '--pretty=format:%h [%an] %s']
> List pull request commits in squashed commit message? (y/n): y
> ['git', 'commit', '--author="vjagadish1989 "', '-m', 
> u'Fix1', '-m', u'', '-m', 'Author: vjagadish1989 
> \nAuthor: Jagadish Venkatraman 
> ', '-m', u'Closes #2 from vjagadish1989/fix1 and 
> squashes the following commits:', '-m', '8451b71 [vjagadish1989] bo\n68f989b 
> [vjagadish1989] fix\nf2ae42c [vjagadish1989] .\n58aa24c [vjagadish1989] more 
> changes\n3c4701e [Jagadish Venkatraman] improve docs']
> 
> Merge complete (local ref PR_TOOL_MERGE_PR_2_MASTER). Push to apache-github? 
> (y/n): y
> git push apache-github PR_TOOL_MERGE_PR_2_MASTER:master
> Counting objects: 14, done.
> Delta compression using up to 8 threads.
> Compressing objects: 100% (4/4), done.
> Writing objects: 100% (4/4), 518 bytes | 0 bytes/s, done.
> Total 4 (delta 3), reused 0 (delta 0)
> To https://github.com/vjagadish/samza-clone.git
>0ad9df7..0194dcf  PR_TOOL_MERGE_PR_2_MASTER -> master
> git rev-parse PR_TOOL_MERGE_PR_2_MASTER
> git rev-parse --abbrev-ref HEAD
> Restoring head pointer to master
> git checkout master
> Switched to branch 'master'
> git branch
> Deleting local branch PR_TOOL_MERGE_PR_1
> git branch -D PR_TOOL_MERGE_PR_1
> Deleting local branch PR_TOOL_MERGE_PR_2
> git branch -D PR_TOOL_MERGE_PR_2
> Deleting local branch PR_TOOL_MERGE_PR_2_MASTER
> git branch -D PR_TOOL_MERGE_PR_2_MASTER
> Pull request #2 merged!
> Merge hash: 0194dcf0
> 
> Would you like to pick 0194dcf0 into another branch? (y/n): n
> 
> Would you like to update an associated JIRA? (y/n): y
> Enter a JIRA id []: SAMZA-934
> === JIRA SAMZA-934 ===
>

[GitHub] samza pull request #13: removing git pull unsupported line from README

2016-06-23 Thread navina 
Github user navina closed the pull request at:

https://github.com/apache/samza/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] samza pull request #13: removing git pull unsupported line from README

2016-06-23 Thread Navina Ramesh 
Please ignore. This was test!

On Thu, Jun 23, 2016 at 5:43 PM, navina  wrote:

> GitHub user navina opened a pull request:
>
> https://github.com/apache/samza/pull/13
>
> removing git pull unsupported line from README
>
> Testing pull requests!
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/navina/samza test-branch
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/samza/pull/13.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #13
>
> 
> commit 893c9f8359fd17e48d018ddcfef669f1c17c8716
> Author: Navina Ramesh 
> Date:   2016-06-24T00:21:28Z
>
> removing git pull unsupported line from README
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>



-- 
Navina R.

Re: Review Request 49138: SAMZA-936: Add double serde as build-in default

2016-06-23 Thread Navina Ramesh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49138/#review139299
---


Ship it!




lgtm! +1

- Navina Ramesh


On June 23, 2016, 9:26 p.m., Yi Pan (Data Infrastructure) wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49138/
> ---
> 
> (Updated June 23, 2016, 9:26 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-936
> https://issues.apache.org/jira/browse/SAMZA-936
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> SAMZA-936: Add double serde as build-in default
> 
> 
> Diffs
> -
> 
>   docs/learn/documentation/versioned/jobs/configuration-table.html 
> 77907eb0a07989bbbf70d9b371e5223ef8bd9ff7 
>   samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala 
> PRE-CREATION 
>   samza-core/src/main/scala/org/apache/samza/util/Util.scala 
> 84166b4d6d0acc14188aae1bf6dd1bd8462e51b6 
>   
> samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala 
> PRE-CREATION 
>   samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 
> b5c212afe02b1318f75dcb01b9bde43f1ff556f2 
> 
> Diff: https://reviews.apache.org/r/49138/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yi Pan (Data Infrastructure)
> 
>

Review Request 49138: SAMZA-889: Change log not working properly with In memory Store

2016-06-23 Thread Yi Pan (Data Infrastructure) 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49138/
---

Review request for samza.


Bugs: SAMZA-936
https://issues.apache.org/jira/browse/SAMZA-936


Repository: samza


Description
---

SAMZA-936: Add double serde as build-in default


Diffs
-

  checkstyle/import-control.xml d0a5c6682aab1cd363c8e16d977f624857a096fc 
  docs/learn/documentation/versioned/jobs/configuration-table.html 
77907eb0a07989bbbf70d9b371e5223ef8bd9ff7 
  samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java 
5463648fd01e0cba52fa9bd9a33b247e7014cfde 
  samza-api/src/main/java/org/apache/samza/storage/StorageEngineFactory.java 
adb62643a311e25fb4fed91c39e1a75cd5664b17 
  samza-api/src/main/java/org/apache/samza/storage/StoreProperties.java 
PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 
5cbdb4b55cbb96fea15b299e5e2ab26710a19f7f 
  
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala.orig 
086531e4d72e88d21735db6a5afd1c7e84b6c2e5 
  samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala 
PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 
2a3535e8017e971ea01749709800cbfdfa254992 
  samza-core/src/main/scala/org/apache/samza/util/Util.scala 
84166b4d6d0acc14188aae1bf6dd1bd8462e51b6 
  samza-core/src/test/java/org/apache/samza/storage/MockStorageEngine.java 
b90ea87b7e575e646c58ddfb5a53ced9ed04a880 
  
samza-core/src/test/java/org/apache/samza/storage/MockStorageEngineFactory.java 
c00c4547307f5a8b401c6bb6438eaa7fb8a38651 
  samza-core/src/test/java/org/apache/samza/storage/TestStorageRecovery.java 
13f4fa97d42b02e54634c8de1575118ca0433fe8 
  samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala 
PRE-CREATION 
  
samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala 
e126481b4543111ac8b16106d41bc4c1d5f504d5 
  samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 
b5c212afe02b1318f75dcb01b9bde43f1ff556f2 
  
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala
 dae6e35d1ba75daf5c816bccbc625c623a44d3b2 
  
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
 38c8fa088112ad8e273d912719652f3b2e4e0432 
  
samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala
 391cf89b05f90ececae63160cd3cb9c811e4ab66 
  
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala 
e5a66a4770b9553a1cc48fbb505f52d123c6c754 
  
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 
23f8a1a6bee8ef38e0640a4e90778e53d982deeb 

Diff: https://reviews.apache.org/r/49138/diff/


Testing
---


Thanks,

Yi Pan (Data Infrastructure)

Re: Review Request 46287: Add a double serde.

2016-06-23 Thread Yi Pan (Data Infrastructure) 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46287/#review139219
---



In addition to the documentation changes, there is also a need to update 
Util.scala class to add the support for "double" as a build-in serde factory 
name.

- Yi Pan (Data Infrastructure)


On April 15, 2016, 11:17 p.m., Jon Bringhurst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46287/
> ---
> 
> (Updated April 15, 2016, 11:17 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-936
> https://issues.apache.org/jira/browse/SAMZA-936
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> Add a simple double serde.
> 
> 
> Diffs
> -
> 
>   samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala 
> PRE-CREATION 
>   
> samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46287/diff/
> 
> 
> Testing
> ---
> 
> A simple unit test was added.
> 
> 
> Thanks,
> 
> Jon Bringhurst
> 
>