Review Request 53826: added user document for Checkpoint callbacks

[Boris Shkolnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53826/
---

Review request for samza.


Bugs: SAMZA-1046
https://issues.apache.org/jira/browse/SAMZA-1046


Repository: samza


Description
---

added user documentation for Checkpoint callbacks


Diffs
-

  docs/learn/documentation/versioned/container/checkpointing.md 
6f8c6d694be92f973af456ddd518d70540abe5c3 

Diff: https://reviews.apache.org/r/53826/diff/


Testing
---


Thanks,

Boris Shkolnik

Re: SAMZA-469 - scala 2.11 / move to java?

[Navina Ramesh]

Thanks a lot ! Please let us know if you need any help :)

Cheers!
Navina

On Tue, Nov 15, 2016 at 8:45 PM, Thunder Stumpges 
wrote:

> OK! We are in a push for the next couple weeks, but I will look to put
> some time to this in the next month or there about.
>
> Thanks!
> Thunder
>
>
> -Original Message-
> From: Navina Ramesh [mailto:nram...@linkedin.com.INVALID]
> Sent: Thursday, November 10, 2016 2:19 PM
> To: dev@samza.apache.org
> Subject: Re: SAMZA-469 - scala 2.11 / move to java?
>
> Hi Thunder,
> Sorry about the late response. I was refreshing my memory of SAMZA-469 :)
>
> Is there something preventing this from getting into a release?
> > Seems to me like the main roadblock on upgrading to scala 2.11 was
> related to JDK6. We have already moved away from JDK6 and JDK7. So, I
> don't see anything blocking us from upgrading to scala 2.11, if someone can
> invest some time and push it out the door :)
>
> There is mention in that issue of going away from scala altogether.  Is
> there another issue which details this? When would that happen?
> > By going away, I believe we decided to not add more scala
> > code/dependency
> to the code base so that eventually, we can replace them all with jdk
> based lambdas. There is no concrete plan on when and how this will happen.
> So, imo, it wouldn't be anytime soon :D
>
> if some effort is needed to make the move to 2.11, we would be glad to
> help out!
> > That will be much appreciated! I don't think we have seen any strong
> motivation for doing this within LinkedIn. If you guys can help us
> upgrade, that will be awesome!!
>
> Thanks!
> Navina
>
> On Mon, Nov 7, 2016 at 11:30 AM, Thunder Stumpges 
> wrote:
>
> > Hi all,
> >
> > We are looking to get our projects upgraded to scala 2.11 as some of
> > our dependencies are dropping their compiling of 2.10 libraries. We
> > found
> > SAMZA-469 which looks to have had a patch for some time, however the
> > last couple comments seem pretty shaky about when (or if!?) support
> > will be available.
> >
> > Is there something preventing this from getting into a release?
> >
> > There is mention in that issue of going away from scala altogether.
> > Is there another issue which details this? When would that happen?
> >
> > Thanks, and if some effort is needed to make the move to 2.11, we
> > would be glad to help out!
> > Thunder Stumges
> >
> >
>
>
> --
> Navina R.
>



-- 
Navina R.

Re: Review Request 53297: Initial version of adding metrics into samza rest.

[Jake Maes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53297/#review156078
---


Ship it!




I'll try commiting it once the patch is posted on a JIRA

- Jake Maes


On Nov. 16, 2016, 5:44 a.m., Shanthoosh Venkataraman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53297/
> ---
> 
> (Updated Nov. 16, 2016, 5:44 a.m.)
> 
> 
> Review request for samza and Jake Maes.
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> This patch aims at enabling users to define custom reporters to send metrics 
> from the monitors. Configurations required for the definition of the metrics 
> reporters follows the same convention as of the samza jobs. 
>  Updated diff = 
> Adding monitorName in MonitorFactory getMonitor method to enable creation of 
> namespaced metrics from each of the monitor. monitorName can be used by 
> MonitorFactory implementations in the metrics that are created and reported 
> from them.
> 
> 
> Diffs
> -
> 
>   docs/learn/documentation/versioned/rest/monitors.md 
> 46678bbe5fed99f767c3324dc9578ee1a64cec66 
>   samza-core/src/main/java/org/apache/samza/util/MetricsReporterLoader.java 
> PRE-CREATION 
>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 
> e0468ee89c89fd720834461771ebb36475475bcb 
>   
> samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala
>  f24beb1e099dd44b15b475e0a4a7f70560c6965e 
>   samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java 
> c38a5d8f737ee5cf39a4876697025fa9cd300bff 
>   samza-rest/src/main/java/org/apache/samza/monitor/MonitorLoader.java 
> dcf9e5734b1d97e37e4fd0e89cc7f525a37a0d65 
>   samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 
> 754ad82af9ef0f2334ec629160be39d183df1b38 
>   samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 
> 2a3e83a24a5343bb53b93fc9d0a647c1b253714b 
>   samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 
> e75f4946f38523284921798578f2a3db9c02f599 
>   
> samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorFactory.java
>  ccc534efc8594837f83b9126ca3d4ee22d8fbb05 
>   
> samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitorFactory.java
>  af414b46dc5c2ff1579deb2c247cd94388a0b3ea 
>   
> samza-rest/src/test/java/org/apache/samza/monitor/mock/MockMonitorFactory.java
>  5b19001eb5db51b6cc4440cf74be92f285ab0209 
>   samza-rest/src/test/java/org/apache/samza/rest/TestSamzaRestService.java 
> PRE-CREATION 
>   
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala
>  8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca 
> 
> Diff: https://reviews.apache.org/r/53297/diff/
> 
> 
> Testing
> ---
> 
> Unit tests are done to verify the intended functionality.
> 
> 
> Thanks,
> 
> Shanthoosh Venkataraman
> 
>