Re: [SAMZA-423] Integrate Lucene into Samza

[Yan Fang]

Hi Robert,

Thank you for the contribution and very sorry for the late replay. :(

Left some comments in the JIRA in terms of the design doc. Hope that can
help you polish your design.

Thanks,

Fang, Yan
yanfang...@gmail.com

On Thu, Aug 13, 2015 at 12:29 AM, Robert Zuljevic 
wrote:

> Hello all,
>
>
>
> I’ve added a design document to task SAMZA-423. If anyone is interested
> please take a look : )
>
>
>
> I have some outstanding questions that I would like to resolve so I could
> continue working on this as soon as possible:
>
>
>
> 1.   Should the API support bulk indexing/removing/matching? (note
> that in some cases this might end up being only cosmetical)?
>
> 2.   Should the match API return the objects representing indexed
> elements or their wrappers (as suggested in the design document)?
>
> 3.   Should this task renamed to something like “Create Document
> Store” and create two other tasks dealing with concrete implementations in
> Luwak and Lucene (which is the endgoal).
>
>
>
> As stated in the ticket any and all suggestions/comments/criticisms are
> welcome : )
>
>
>
> Met vriendelijke groet / Kind regards,
>
> Robert Žuljević
>
> Software Developer
>
> [image: Title: Levi9 IT Services]
> --
>
> Address: Trifkovicev trg 6, 21000 Novi Sad, Serbia
>
> Tel.: +31 20 6701 947 | +381 21 2155 500
>
> Mobile: +381 64 428 28 46
>
> Skype: robert.zuljevic
>
> Internet: www.levi9.com
>
>
>
> Chamber of commerce Levi9 Holding: 34221951
>
> Chamber of commerce Levi9 IT Services BV: 34224746
> --
>
> This e-mail may contain confidential or privileged information. If you are
> not (one of) the intended recipient(s), please notify the sender
> immediately by reply e-mail and delete this message and any attachments
> permanently without retaining a copy. Any review, disclosure, copying,
> distribution or taking any action in reliance on the contents of this
> e-mail by persons or entities other than the intended recipient(s) is
> strictly prohibited and may be unlawful.
>
> The services of Levi9 are exclusively subject to its general terms and
> conditions. These general terms and conditions can be found on
> www.levi9.com and a copy will be promptly submitted to you on your
> request and free of charge.
>
>
>

[SAMZA-423] Integrate Lucene into Samza

[Robert Zuljevic]

Hello all,

I've added a design document to task SAMZA-423. If anyone is interested please 
take a look : )

I have some outstanding questions that I would like to resolve so I could 
continue working on this as soon as possible:


1.   Should the API support bulk indexing/removing/matching? (note that in 
some cases this might end up being only cosmetical)?

2.   Should the match API return the objects representing indexed elements 
or their wrappers (as suggested in the design document)?

3.   Should this task renamed to something like "Create Document Store" and 
create two other tasks dealing with concrete implementations in Luwak and 
Lucene (which is the endgoal).

As stated in the ticket any and all suggestions/comments/criticisms are welcome 
: )

Met vriendelijke groet / Kind regards,
Robert Žuljević
Software Developer
[Title: Levi9 IT Services]

Address: Trifkovicev trg 6, 21000 Novi Sad, Serbia
Tel.: +31 20 6701 947 | +381 21 2155 500
Mobile: +381 64 428 28 46
Skype: robert.zuljevic
Internet: www.levi9.com

Chamber of commerce Levi9 Holding: 34221951
Chamber of commerce Levi9 IT Services BV: 34224746

This e-mail may contain confidential or privileged information. If you are not 
(one of) the intended recipient(s), please notify the sender immediately by 
reply e-mail and delete this message and any attachments permanently without 
retaining a copy. Any review, disclosure, copying, distribution or taking any 
action in reliance on the contents of this e-mail by persons or entities other 
than the intended recipient(s) is strictly prohibited and may be unlawful.
The services of Levi9 are exclusively subject to its general terms and 
conditions. These general terms and conditions can be found on 
www.levi9.com and a copy will be promptly submitted to 
you on your request and free of charge.

Review Request 36767: SAMZA-423: Integrate Lucene into Samza

[Robert Zuljevic]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36767/
---

Review request for samza.


Repository: samza


Description
---

Initial commit to get feedback. Implemented skeleton for DocumentStore and an 
initial Luwak implementation.


Diffs
-

  build.gradle 0852adc4e8e0c2816afd1ebf433f1af6b44852f7 
  gradle/dependency-versions.gradle fb06e8ed393d1a38abfa1a48fe5244fc7f6c7339 
  
samza-ds-luwak/src/main/java/org/apache/samza/storage/document/luwak/engine/LuwakDocumentStorageEngineFactory.java
 PRE-CREATION 
  
samza-ds-luwak/src/main/java/org/apache/samza/storage/document/luwak/model/MonitorQueryElement.java
 PRE-CREATION 
  
samza-ds-luwak/src/main/java/org/apache/samza/storage/document/luwak/store/LuwakDocumentStore.java
 PRE-CREATION 
  
samza-ds/src/main/java/org/apache/samza/storage/document/engine/BaseDocumentStorageEngineFactory.java
 PRE-CREATION 
  
samza-ds/src/main/java/org/apache/samza/storage/document/engine/DocumentStorageEngine.java
 PRE-CREATION 
  samza-ds/src/main/java/org/apache/samza/storage/document/model/Element.java 
PRE-CREATION 
  
samza-ds/src/main/java/org/apache/samza/storage/document/store/CachedDocumentStore.java
 PRE-CREATION 
  
samza-ds/src/main/java/org/apache/samza/storage/document/store/DocumentStore.java
 PRE-CREATION 
  
samza-ds/src/main/java/org/apache/samza/storage/document/store/LoggedDocumentStore.java
 PRE-CREATION 
  
samza-ds/src/main/java/org/apache/samza/storage/document/store/MetricDocumentStore.java
 PRE-CREATION 
  
samza-ds/src/main/java/org/apache/samza/storage/document/store/metrics/DocumentStoreMetrics.java
 PRE-CREATION 
  settings.gradle 19bff971ad221084dac10d3f7f3facfa42b829a7 

Diff: https://reviews.apache.org/r/36767/diff/


Testing
---


Thanks,

Robert Zuljevic