Re: Review Request 35348: SAMZA-707 Remove dependency on samza-serializers in the samza.apache.org/startup/download page

2015-06-17 Thread Aleksandar Bircakovic

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35348/
---

(Updated June 17, 2015, 8:15 p.m.)


Review request for samza.


Changes
---

Updated the doc again saying that versions less than 0.9 should include 
additional dependency for serializers.


Repository: samza


Description
---

For issue described in 
[SAMZA-707](https://issues.apache.org/jira/browse/SAMZA-707)

removed dependency samza-serializers_2.10 in index.md.


Diffs (updated)
-

  docs/startup/download/index.md 37f948b 

Diff: https://reviews.apache.org/r/35348/diff/


Testing
---


Thanks,

Aleksandar Bircakovic



Re: Review Request 35348: SAMZA-707 Remove dependency on samza-serializers in the samza.apache.org/startup/download page

2015-06-17 Thread Navina Ramesh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35348/#review88287
---

Ship it!


Ship It!

- Navina Ramesh


On June 17, 2015, 8:15 p.m., Aleksandar Bircakovic wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35348/
 ---
 
 (Updated June 17, 2015, 8:15 p.m.)
 
 
 Review request for samza.
 
 
 Repository: samza
 
 
 Description
 ---
 
 For issue described in 
 [SAMZA-707](https://issues.apache.org/jira/browse/SAMZA-707)
 
 removed dependency samza-serializers_2.10 in index.md.
 
 
 Diffs
 -
 
   docs/startup/download/index.md 37f948b 
 
 Diff: https://reviews.apache.org/r/35348/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aleksandar Bircakovic
 




Re: Review Request 35348: SAMZA-707 Remove dependency on samza-serializers in the samza.apache.org/startup/download page

2015-06-12 Thread Navina Ramesh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35348/#review87782
---



docs/startup/download/index.md
https://reviews.apache.org/r/35348/#comment140198

Actually, this dependency is required if the samza version used is  0.9.
So, can you add a comment below the Artifacts section mentioning this 
additional dependency for samza  0.9 ?


- Navina Ramesh


On June 11, 2015, 8:49 a.m., Aleksandar Bircakovic wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35348/
 ---
 
 (Updated June 11, 2015, 8:49 a.m.)
 
 
 Review request for samza.
 
 
 Repository: samza
 
 
 Description
 ---
 
 For issue described in 
 [SAMZA-707](https://issues.apache.org/jira/browse/SAMZA-707)
 
 removed dependency samza-serializers_2.10 in index.md.
 
 
 Diffs
 -
 
   docs/startup/download/index.md 37f948b 
 
 Diff: https://reviews.apache.org/r/35348/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aleksandar Bircakovic