Re: Review Request 33219: [SAMZA-649] Create samza-sql-calcite module for Calcite SQL front end
On April 15, 2015, 6:20 p.m., Yi Pan (Data Infrastructure) wrote: samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/schema/AvroSchemaConverter.java, line 37 https://reviews.apache.org/r/33219/diff/1/?file=930371#file930371line37 I assume that this class is used to convert the data schema/types in samza-sql-core model to Calcite's RelDataType? In that case, can we use the generic Schema class in samza-sql-core instead of implementation specific for Avro? Please discard this comment. I just realized that this converter is probably used in query validation which will need to convert schemas in an available Avro schema repo to Calcite data model. - Yi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33219/#review80228 --- On April 15, 2015, 2:49 p.m., Milinda Pathirage wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33219/ --- (Updated April 15, 2015, 2:49 p.m.) Review request for samza, Chris Riccomini and Yi Pan (Data Infrastructure). Bugs: SAMZA-649 https://issues.apache.org/jira/browse/SAMZA-649 Repository: samza Description --- Moved Calcite based front-end to samza-sql-calcite module. Diffs - build.gradle a1c7133 samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/QueryPlanner.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaCalciteConnection.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaQueryPreparingStatement.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaSqlValidator.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/schema/AvroSchemaConverter.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/planner/SamzaStreamTableFactory.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/planner/TestQueryPlanner.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/schema/TestAvroSchemaConverter.java PRE-CREATION samza-sql-core/src/main/java/org/apache/samza/sql/metadata/AvroSchemaConverter.java 3dad046 samza-sql-core/src/main/java/org/apache/samza/sql/planner/QueryPlanner.java 1dfb262 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaCalciteConnection.java 63b1da5 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaQueryPreparingStatement.java 0721573 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaSqlValidator.java f46c1f0 samza-sql-core/src/test/java/org/apache/samza/sql/planner/QueryPlannerTest.java 022116e samza-sql-core/src/test/java/org/apache/samza/sql/planner/SamzaStreamTableFactory.java f757d8f samza-sql-core/src/test/java/org/apache/samza/sql/test/metadata/TestAvroSchemaConverter.java b4ac5f5 settings.gradle 5cbb755 Diff: https://reviews.apache.org/r/33219/diff/ Testing --- ./bin/check-all.sh passed. Thanks, Milinda Pathirage
Re: Review Request 33219: [SAMZA-649] Create samza-sql-calcite module for Calcite SQL front end
On April 15, 2015, 6:20 p.m., Yi Pan (Data Infrastructure) wrote: samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/QueryPlanner.java, line 61 https://reviews.apache.org/r/33219/diff/1/?file=930367#file930367line61 One quick question: do we need to implement all those rules? Or are we mainly re-using the rules implemented in Calcite? We don't have to implement all those rules. Just reusing existing rules from Calcite. On April 15, 2015, 6:20 p.m., Yi Pan (Data Infrastructure) wrote: samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaSqlValidator.java, line 29 https://reviews.apache.org/r/33219/diff/1/?file=930370#file930370line29 Add Java doc here. will add java docs. - Milinda --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33219/#review80228 --- On April 15, 2015, 2:49 p.m., Milinda Pathirage wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33219/ --- (Updated April 15, 2015, 2:49 p.m.) Review request for samza, Chris Riccomini and Yi Pan (Data Infrastructure). Bugs: SAMZA-649 https://issues.apache.org/jira/browse/SAMZA-649 Repository: samza Description --- Moved Calcite based front-end to samza-sql-calcite module. Diffs - build.gradle a1c7133 samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/QueryPlanner.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaCalciteConnection.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaQueryPreparingStatement.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaSqlValidator.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/schema/AvroSchemaConverter.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/planner/SamzaStreamTableFactory.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/planner/TestQueryPlanner.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/schema/TestAvroSchemaConverter.java PRE-CREATION samza-sql-core/src/main/java/org/apache/samza/sql/metadata/AvroSchemaConverter.java 3dad046 samza-sql-core/src/main/java/org/apache/samza/sql/planner/QueryPlanner.java 1dfb262 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaCalciteConnection.java 63b1da5 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaQueryPreparingStatement.java 0721573 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaSqlValidator.java f46c1f0 samza-sql-core/src/test/java/org/apache/samza/sql/planner/QueryPlannerTest.java 022116e samza-sql-core/src/test/java/org/apache/samza/sql/planner/SamzaStreamTableFactory.java f757d8f samza-sql-core/src/test/java/org/apache/samza/sql/test/metadata/TestAvroSchemaConverter.java b4ac5f5 settings.gradle 5cbb755 Diff: https://reviews.apache.org/r/33219/diff/ Testing --- ./bin/check-all.sh passed. Thanks, Milinda Pathirage
Re: Review Request 33219: [SAMZA-649] Create samza-sql-calcite module for Calcite SQL front end
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33219/#review80237 --- Ship it! +1 - Yi Pan (Data Infrastructure) On April 15, 2015, 2:49 p.m., Milinda Pathirage wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33219/ --- (Updated April 15, 2015, 2:49 p.m.) Review request for samza, Chris Riccomini and Yi Pan (Data Infrastructure). Bugs: SAMZA-649 https://issues.apache.org/jira/browse/SAMZA-649 Repository: samza Description --- Moved Calcite based front-end to samza-sql-calcite module. Diffs - build.gradle a1c7133 samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/QueryPlanner.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaCalciteConnection.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaQueryPreparingStatement.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaSqlValidator.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/schema/AvroSchemaConverter.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/planner/SamzaStreamTableFactory.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/planner/TestQueryPlanner.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/schema/TestAvroSchemaConverter.java PRE-CREATION samza-sql-core/src/main/java/org/apache/samza/sql/metadata/AvroSchemaConverter.java 3dad046 samza-sql-core/src/main/java/org/apache/samza/sql/planner/QueryPlanner.java 1dfb262 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaCalciteConnection.java 63b1da5 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaQueryPreparingStatement.java 0721573 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaSqlValidator.java f46c1f0 samza-sql-core/src/test/java/org/apache/samza/sql/planner/QueryPlannerTest.java 022116e samza-sql-core/src/test/java/org/apache/samza/sql/planner/SamzaStreamTableFactory.java f757d8f samza-sql-core/src/test/java/org/apache/samza/sql/test/metadata/TestAvroSchemaConverter.java b4ac5f5 settings.gradle 5cbb755 Diff: https://reviews.apache.org/r/33219/diff/ Testing --- ./bin/check-all.sh passed. Thanks, Milinda Pathirage
Re: Review Request 33219: [SAMZA-649] Create samza-sql-calcite module for Calcite SQL front end
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33219/ --- (Updated April 15, 2015, 6:56 p.m.) Review request for samza, Chris Riccomini and Yi Pan (Data Infrastructure). Changes --- Added a java doc comment to SamzaSqlValidator class. Bugs: SAMZA-649 https://issues.apache.org/jira/browse/SAMZA-649 Repository: samza Description --- Moved Calcite based front-end to samza-sql-calcite module. Diffs (updated) - build.gradle a1c7133 samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/QueryPlanner.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaCalciteConnection.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaQueryPreparingStatement.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/planner/SamzaSqlValidator.java PRE-CREATION samza-sql-calcite/src/main/java/org/apache/samza/sql/calcite/schema/AvroSchemaConverter.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/planner/SamzaStreamTableFactory.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/planner/TestQueryPlanner.java PRE-CREATION samza-sql-calcite/src/test/java/org/apache/samza/sql/calcite/schema/TestAvroSchemaConverter.java PRE-CREATION samza-sql-core/src/main/java/org/apache/samza/sql/metadata/AvroSchemaConverter.java 3dad046 samza-sql-core/src/main/java/org/apache/samza/sql/planner/QueryPlanner.java 1dfb262 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaCalciteConnection.java 63b1da5 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaQueryPreparingStatement.java 0721573 samza-sql-core/src/main/java/org/apache/samza/sql/planner/SamzaSqlValidator.java f46c1f0 samza-sql-core/src/test/java/org/apache/samza/sql/planner/QueryPlannerTest.java 022116e samza-sql-core/src/test/java/org/apache/samza/sql/planner/SamzaStreamTableFactory.java f757d8f samza-sql-core/src/test/java/org/apache/samza/sql/test/metadata/TestAvroSchemaConverter.java b4ac5f5 settings.gradle 5cbb755 Diff: https://reviews.apache.org/r/33219/diff/ Testing --- ./bin/check-all.sh passed. Thanks, Milinda Pathirage
