Re: Review Request 35723: SAMZA-720: fix bootstrap hangs when container number 1

2015-06-22 Thread Yi Pan (Data Infrastructure) 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35723/#review88820
---

Ship it!


+1. LGTM. Thanks for the quick fix, Yan.

- Yi Pan (Data Infrastructure)


On June 22, 2015, 8 a.m., Yan Fang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35723/
 ---
 
 (Updated June 22, 2015, 8 a.m.)
 
 
 Review request for samza.
 
 
 Bugs: SAMZA-720
 https://issues.apache.org/jira/browse/SAMZA-720
 
 
 Repository: samza
 
 
 Description
 ---
 
 remove the unregistered ssps in the laggingSsp set.
 
 
 Diffs
 -
 
   
 samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala
  dd500b9 
 
 Diff: https://reviews.apache.org/r/35723/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Yan Fang

Re: Review Request 35723: SAMZA-720: fix bootstrap hangs when container number 1

2015-06-22 Thread Yan Fang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35723/
---

(Updated June 23, 2015, 4:53 a.m.)


Review request for samza.


Changes
---

added the unit test.


Bugs: SAMZA-720
https://issues.apache.org/jira/browse/SAMZA-720


Repository: samza


Description
---

remove the unregistered ssps in the laggingSsp set.


Diffs (updated)
-

  
samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala
 dd500b9 
  
samza-core/src/test/scala/org/apache/samza/system/chooser/TestBootstrappingChooser.scala
 3c2693c 

Diff: https://reviews.apache.org/r/35723/diff/


Testing
---


Thanks,

Yan Fang