Re: Review Request 49138: SAMZA-889: Change log not working properly with In memory Store

2016-06-23 Thread Yi Pan (Data Infrastructure) 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49138/
---

(Updated June 23, 2016, 9:26 p.m.)


Review request for samza.


Changes
---

Rebased against lastest trunk head


Bugs: SAMZA-936
https://issues.apache.org/jira/browse/SAMZA-936


Repository: samza


Description
---

SAMZA-936: Add double serde as build-in default


Diffs (updated)
-

  docs/learn/documentation/versioned/jobs/configuration-table.html 
77907eb0a07989bbbf70d9b371e5223ef8bd9ff7 
  samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala 
PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/util/Util.scala 
84166b4d6d0acc14188aae1bf6dd1bd8462e51b6 
  samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala 
PRE-CREATION 
  samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 
b5c212afe02b1318f75dcb01b9bde43f1ff556f2 

Diff: https://reviews.apache.org/r/49138/diff/


Testing
---


Thanks,

Yi Pan (Data Infrastructure)

Re: Review Request 49138: SAMZA-889: Change log not working properly with In memory Store

2016-06-23 Thread Navina Ramesh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49138/#review139296
---




samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java (line 62)


This looks like a spill-over from SAMZA-889 . Can you rebase with master?


- Navina Ramesh


On June 23, 2016, 6:59 a.m., Yi Pan (Data Infrastructure) wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49138/
> ---
> 
> (Updated June 23, 2016, 6:59 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-936
> https://issues.apache.org/jira/browse/SAMZA-936
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> SAMZA-936: Add double serde as build-in default
> 
> 
> Diffs
> -
> 
>   checkstyle/import-control.xml d0a5c6682aab1cd363c8e16d977f624857a096fc 
>   docs/learn/documentation/versioned/jobs/configuration-table.html 
> 77907eb0a07989bbbf70d9b371e5223ef8bd9ff7 
>   samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java 
> 5463648fd01e0cba52fa9bd9a33b247e7014cfde 
>   samza-api/src/main/java/org/apache/samza/storage/StorageEngineFactory.java 
> adb62643a311e25fb4fed91c39e1a75cd5664b17 
>   samza-api/src/main/java/org/apache/samza/storage/StoreProperties.java 
> PRE-CREATION 
>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 
> 5cbdb4b55cbb96fea15b299e5e2ab26710a19f7f 
>   
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala.orig
>  086531e4d72e88d21735db6a5afd1c7e84b6c2e5 
>   samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala 
> PRE-CREATION 
>   samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 
> 2a3535e8017e971ea01749709800cbfdfa254992 
>   samza-core/src/main/scala/org/apache/samza/util/Util.scala 
> 84166b4d6d0acc14188aae1bf6dd1bd8462e51b6 
>   samza-core/src/test/java/org/apache/samza/storage/MockStorageEngine.java 
> b90ea87b7e575e646c58ddfb5a53ced9ed04a880 
>   
> samza-core/src/test/java/org/apache/samza/storage/MockStorageEngineFactory.java
>  c00c4547307f5a8b401c6bb6438eaa7fb8a38651 
>   samza-core/src/test/java/org/apache/samza/storage/TestStorageRecovery.java 
> 13f4fa97d42b02e54634c8de1575118ca0433fe8 
>   
> samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala 
> PRE-CREATION 
>   
> samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala
>  e126481b4543111ac8b16106d41bc4c1d5f504d5 
>   samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 
> b5c212afe02b1318f75dcb01b9bde43f1ff556f2 
>   
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala
>  dae6e35d1ba75daf5c816bccbc625c623a44d3b2 
>   
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
>  38c8fa088112ad8e273d912719652f3b2e4e0432 
>   
> samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala
>  391cf89b05f90ececae63160cd3cb9c811e4ab66 
>   
> samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala
>  e5a66a4770b9553a1cc48fbb505f52d123c6c754 
>   
> samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
>  23f8a1a6bee8ef38e0640a4e90778e53d982deeb 
> 
> Diff: https://reviews.apache.org/r/49138/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yi Pan (Data Infrastructure)
> 
>

Review Request 49138: SAMZA-889: Change log not working properly with In memory Store

2016-06-23 Thread Yi Pan (Data Infrastructure) 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49138/
---

Review request for samza.


Bugs: SAMZA-936
https://issues.apache.org/jira/browse/SAMZA-936


Repository: samza


Description
---

SAMZA-936: Add double serde as build-in default


Diffs
-

  checkstyle/import-control.xml d0a5c6682aab1cd363c8e16d977f624857a096fc 
  docs/learn/documentation/versioned/jobs/configuration-table.html 
77907eb0a07989bbbf70d9b371e5223ef8bd9ff7 
  samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java 
5463648fd01e0cba52fa9bd9a33b247e7014cfde 
  samza-api/src/main/java/org/apache/samza/storage/StorageEngineFactory.java 
adb62643a311e25fb4fed91c39e1a75cd5664b17 
  samza-api/src/main/java/org/apache/samza/storage/StoreProperties.java 
PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 
5cbdb4b55cbb96fea15b299e5e2ab26710a19f7f 
  
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala.orig 
086531e4d72e88d21735db6a5afd1c7e84b6c2e5 
  samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala 
PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 
2a3535e8017e971ea01749709800cbfdfa254992 
  samza-core/src/main/scala/org/apache/samza/util/Util.scala 
84166b4d6d0acc14188aae1bf6dd1bd8462e51b6 
  samza-core/src/test/java/org/apache/samza/storage/MockStorageEngine.java 
b90ea87b7e575e646c58ddfb5a53ced9ed04a880 
  
samza-core/src/test/java/org/apache/samza/storage/MockStorageEngineFactory.java 
c00c4547307f5a8b401c6bb6438eaa7fb8a38651 
  samza-core/src/test/java/org/apache/samza/storage/TestStorageRecovery.java 
13f4fa97d42b02e54634c8de1575118ca0433fe8 
  samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala 
PRE-CREATION 
  
samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala 
e126481b4543111ac8b16106d41bc4c1d5f504d5 
  samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 
b5c212afe02b1318f75dcb01b9bde43f1ff556f2 
  
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala
 dae6e35d1ba75daf5c816bccbc625c623a44d3b2 
  
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
 38c8fa088112ad8e273d912719652f3b2e4e0432 
  
samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala
 391cf89b05f90ececae63160cd3cb9c811e4ab66 
  
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala 
e5a66a4770b9553a1cc48fbb505f52d123c6c754 
  
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 
23f8a1a6bee8ef38e0640a4e90778e53d982deeb 

Diff: https://reviews.apache.org/r/49138/diff/


Testing
---


Thanks,

Yi Pan (Data Infrastructure)