Re: Review Request 49138: SAMZA-936: Add double serde as build-in default

2016-06-23 Thread Navina Ramesh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49138/#review139299
---


Ship it!




lgtm! +1

- Navina Ramesh


On June 23, 2016, 9:26 p.m., Yi Pan (Data Infrastructure) wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49138/
> ---
> 
> (Updated June 23, 2016, 9:26 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-936
> https://issues.apache.org/jira/browse/SAMZA-936
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> SAMZA-936: Add double serde as build-in default
> 
> 
> Diffs
> -
> 
>   docs/learn/documentation/versioned/jobs/configuration-table.html 
> 77907eb0a07989bbbf70d9b371e5223ef8bd9ff7 
>   samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala 
> PRE-CREATION 
>   samza-core/src/main/scala/org/apache/samza/util/Util.scala 
> 84166b4d6d0acc14188aae1bf6dd1bd8462e51b6 
>   
> samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala 
> PRE-CREATION 
>   samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 
> b5c212afe02b1318f75dcb01b9bde43f1ff556f2 
> 
> Diff: https://reviews.apache.org/r/49138/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yi Pan (Data Infrastructure)
> 
>



Re: Review Request 49138: SAMZA-936: Add double serde as build-in default

2016-06-23 Thread Yi Pan (Data Infrastructure)

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49138/
---

(Updated June 23, 2016, 9:26 p.m.)


Review request for samza.


Summary (updated)
-

SAMZA-936: Add double serde as build-in default


Bugs: SAMZA-936
https://issues.apache.org/jira/browse/SAMZA-936


Repository: samza


Description
---

SAMZA-936: Add double serde as build-in default


Diffs
-

  docs/learn/documentation/versioned/jobs/configuration-table.html 
77907eb0a07989bbbf70d9b371e5223ef8bd9ff7 
  samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala 
PRE-CREATION 
  samza-core/src/main/scala/org/apache/samza/util/Util.scala 
84166b4d6d0acc14188aae1bf6dd1bd8462e51b6 
  samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala 
PRE-CREATION 
  samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 
b5c212afe02b1318f75dcb01b9bde43f1ff556f2 

Diff: https://reviews.apache.org/r/49138/diff/


Testing
---


Thanks,

Yi Pan (Data Infrastructure)