Re: [sc-dev] Status of ooo-build patches

[Niklas Nebel]

Kohei Yoshida wrote:

Issue 35579 - sc-standard-filter-options.diff

Issue 26565 - sc-natural-sort.diff


I'm fully aware that the reason why the file format needs to be
extended in order for these patches to be included is because the
state of their corresponding UI control (i.e. checkbox, combo box
etc.) needs to be stored per named range etc.

But considering the immediate benefit of these two patches that a
large number of users will enjoy, perhaps a slight breakage in
functionality (not saving the state in the document) which the
majority of users will not even notice may be warranted?


Silently leaving out the new flags would mean that incomplete or even 
wrong information (in the case of filters) is stored. But I could 
imagine adding an extra check, so when the new features are used, no 
sort/filter criteria are saved at all.



Or we can perhaps choose a middle-ground; we put the patches in with
the UI bits hidden (by use of #ifdef ...#endif), which may be unlocked
with the right compiler switch (-D) or a environment variable.  That
way the patches get included, but the functionality is absent in the
default build (easier for ooo-build and good for the users).


Too much #ifdef always makes it easy to break the case you're not using, 
especially with warnings as errors, which is coming to sc soon.


Niklas

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [sc-dev] Status of ooo-build patches

[Kohei Yoshida]

Hi Niklas,

On 10/23/06, Niklas Nebel [EMAIL PROTECTED] wrote:


*Depending on file format changes*
For these issues we need file format extensions, so it will take a while
before they can be integrated.

Issue 35579 - sc-standard-filter-options.diff

Issue 26565 - sc-natural-sort.diff


I'm fully aware that the reason why the file format needs to be
extended in order for these patches to be included is because the
state of their corresponding UI control (i.e. checkbox, combo box
etc.) needs to be stored per named range etc.

But considering the immediate benefit of these two patches that a
large number of users will enjoy, perhaps a slight breakage in
functionality (not saving the state in the document) which the
majority of users will not even notice may be warranted?

Or we can perhaps choose a middle-ground; we put the patches in with
the UI bits hidden (by use of #ifdef ...#endif), which may be unlocked
with the right compiler switch (-D) or a environment variable.  That
way the patches get included, but the functionality is absent in the
default build (easier for ooo-build and good for the users).

What do you think?

Kohei

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[sc-dev] Status of ooo-build patches

[Niklas Nebel]

Hi,

Some people complain that a large number of Calc patches is piling up at 
ooo-build and we at Sun are ignoring or delaying them. To counter this 
impression, we (the core Calc team at Sun) went through the Calc section 
of the list at http://go-oo.org/ooo-build/patches/src680/apply, and 
sorted them by their state. Here's the grouped list:


*A solution is already in a child workspace*

Issue 64968 - sc-without-stlport.diff
- A different solution is in CWS dr50.

Issue 47442 - sc-insert-note-on-right-click.diff
- The feature is in CWS notecontext (issue 8101, for 2.2).

Issue 32269 - sc-seriessum.diff
- This is in CWS dr50.

Issue 20857 - sc-r1c1.diff
- The first part (issue 69883) is in CWS scr1c1.

*A solution can be expected soon*

Issue 15509 - sc-paste-dialog.diff, sc-paste-redraw.diff
- This didn't make it before 2.1 UI freeze, will go into 2.2.

Issue 47233 - sc-iteration.diff
- We'll try to get this into 2.2.

Issue 49351 - warning-uninitialized-variables-sc.diff
- A big solution for warnings in planned for 2.2 (issue 69284).

Issue 70041 - sc-optional.diff, sc-optional-addins.diff
- We'll try to get this into 2.2.

*Depending on file format changes*
For these issues we need file format extensions, so it will take a while 
before they can be integrated.


Issue 35579 - sc-standard-filter-options.diff

Issue 26565 - sc-natural-sort.diff

*Changed error codes in formulas*
Somewhat related to the file format changes, this should wait until we 
have an OpenDocument formula specification, instead of implementing such 
changes one-by-one.


Issue 47724 - sc-div.diff

Issue 47724 - sc-div-errs.diff

Issue 47644 - sc-xl-errors.diff

*Need definition of desired behavior*
I'll have to mention the s-word a few times here. Sometimes a less 
formal agreement on desired behavior may be enough, but without even 
that, we won't get far. Also note that this section does not contain the 
majority of the patches.


Issue 35578 - sc-autofilter-empty-nonempty.diff
- UI change that needs a specification.

Issue 33851 - sc-no-delete-filteredrows.diff
- The desired behavior with filtered cells is still unclear. Deleting of 
cells was changed for 2.0 (issue 33438).


Issue 23658 - sc-datapilot-dynamic-range.diff
- The dialog change needs a specification. The non-working 
implementation is secondary.


Issue 21923 - sc-save-password-minlength.diff
- Dialog change that needs a specification.

Issue 38108 - calc-new-acceleration.diff
- UI change that needs a specification.

Issue 20496 - sc-startformulawplus.diff
- The details of the desired behavior have to be agreed upon.

Issue 3687 - sc-preserve-imp-opts.diff
- Again, details of the desired behavior have to be agreed upon.

Issue 56202 - sc-toggle-formula.diff
- UI change that needs a specification, problems with other keyboard 
layouts.


Issue 67243 - sc-toggle-merge-center.diff
- Current behavior is as intended, change has to be agreed upon.

*Incomplete implementation*

Issue 63686 - sc-xls-pivot-optimization.diff
- operator== doesn't work, order isn't preserved.

Issue 45843 - sc-get-pivot-data.diff
- This probably needs a different approach, see comments in issue.

Issue 59082 - vba-sc-handleautoshapemacro-import.diff
- This must be adjusted to the new specification.

Issue 66550 - vba-sc-autoshapes-hyperlinks.diff
- This depends on issue 59082.

*Rejected*
Note that the patches that were rejected for technical reasons all had 
seen no activity for some time,


Issue 17965 - gui-sc-delete.diff
- This was rejected after consultation with User Experience.

Issue 45245 - sc-sheet-double-click-rename.diff
- The patch doesn't implement the feature as suggested by User Experience.

Issue 35581 - sc-filter-hide-filteredrows.diff
- This takes a wrong approach to implementation.

Issue 37388 - sc-datapilot-autoformat.diff
- Table AutoFormats don't work well with DataPilot tables. DataPilot 
AutoFormats should be separate.


Issue 44982 - sc-change-record-dnd.diff
- Uses a wrong action type, rejection isn't handled.

Issue 49011 (?) - sc-datapilot-cut-paste-disable.diff
- This takes a wrong approach to implementation.

Issue 47811 - sc-string-arg.diff
- The patch handles only some cases.

*No problem in plain OOo build*
These are primarily fixes to problems with other patches. They can't be 
integrated alone.


Issue 53261 - gcc4-visibility-sc.diff
Issue 47145 - sc-pv-crasher.diff
sc-datapilot-crash-fix.diff
sc-dp-database-crash.diff

*No issue submitted*
Some of these seem to be work in progress. Anyway, if they aren't 
submitted to us, we can't integrate them.


zoom-combobox.diff
sc-filters-fill-fix.diff
sc-autofilter-autotrim-choices.diff
sc-xls-builtin-name-scope.diff
sc-dp-hash-items.diff
sc-read-only-colrow-resize.diff

I hope this list helps to make clear that we do care about patches, we 
just can't integrate everything right away as it comes in.


Niklas

-
To unsubscribe, e-mail: [EMAIL