[GitHub] [incubator-sdap-nexus] RKuttruff merged pull request #174: CDMS-122 - Limited Zarr Proxy
RKuttruff merged PR #174: URL: https://github.com/apache/incubator-sdap-nexus/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [EXTERNAL] Re: [DISCUSS] Towards release 0.4.5a56
By the way, I wouldn't create a new RC for the vote. Just vote on the RC1 you already have. We know we'll need to iterate through a few RCs before we get a good one. On Wed, Dec 7, 2022 at 1:05 AM Julian Hyde wrote: > > Hey, that looks pretty good! In fact it looks a lot like an Apache release. > > A few things: > > 1. I saw you added dist/dev/incubator/sdap/KEYS; can you move that > file so that its path is dist/release/incubator/sdap/KEYS. Its main > purpose will be for people who download the release after it has been > released and want to verify the signatures. Putting it in 'release' > will ensure that it is automatically mirrored to > https://downloads.apache.org > > 2. I got the following output from gpg: > > gpg: Signature made Mon 05 Dec 2022 10:52:22 PM PST > gpg:using RSA key 1392A8A11801359247A803D8D2449E0EB5EF1E73 > gpg: Good signature from "Nga Chung (CODE SIGNING KEY) > " [unknown] > gpg: WARNING: This key is not certified with a trusted signature! > gpg: There is no indication that the signature belongs to the > owner. > > This means that the artifacts are signed correctly, but you are not in > my web of trust. Soon after the release, we should have a key-signing > party (or you should get your key signed by a colleague who has a > well-connected key). > > 3. At first glance, the contents of the .tar.gz files look pretty > good. I haven't checked the headers etc. yet. There seems to be a > LICENSE.txt and NOTICE in each, which is good. You should also add a > DISCLAIMER and/or DISCLAIMER-WIP file (required by the incubation > process [1]). I also recommend adding a top-level README in each > .tar.gz that describes the purpose of the file, and how to build it > (for example see Calcite's README [2]) > > A good next step would be to start a vote. Craft an email with the > same general structure as Apache Hop (incubating) 0.99-rc2 [3] and > send it to dev@. Then PPMC members should vote on the release, each > describing the checks that they made. Then finish the vote with an > email with a [RESULT][VOTE] or [CANCEL][VOTE] subject line. (We know > the vote will fail, due to the missing DISCLAIMER file, but it's good > to practice the process, and with many people scrutinizing the release > we will find issues faster.) > > You'll also want to craft release notes (they don't have to be in the > release, but they should be somewhere accessible for people to read). > > And you should be writing that "how to" guide as you go along, if > you're not already. > > Julian > > [1] https://incubator.apache.org/policy/incubation.html#disclaimers > [2] https://github.com/apache/calcite/blob/main/README > [3] https://lists.apache.org/thread/ncnok4clt6k491zv6c3v4kk2fc41qsz2 > > On Mon, Dec 5, 2022 at 11:06 PM Nga Chung wrote: > > > > Riley, thank you for adding all the missing ASF header and the NOTICE. > > > > Riley's changes have been merged and rc1 artifacts have been uploaded to > > https://dist.apache.org/repos/dist/dev/incubator/sdap/apache-sdap-1.0.0-rc1/ > > > > > > Has anyone had any success testing rc0? > > > > Julian, any suggestions on next steps? > > > > Thanks, > > Nga > > > > On Thu, Dec 1, 2022 at 1:03 PM Kuttruff, Riley K (US 398F-Affiliate) > > wrote: > > > > > It appears some of the source files are missing the ASF header. I did a > > > check for all the Python files across the repositories and added them > > > where > > > needed in a pair of PRs (nexus & ingester; nexusproto had no .py files > > > missing the header). > > > > > > I still have yet to check for any non-python source files. > > > > > > Riley > > > > > > On 11/30/22, 4:29 PM, "Nga Chung" wrote: > > > > > > Hi everyone, > > > > > > So this email thread probably needs renaming or we can start a new one > > > if > > > we're proceeding with a Version 1.0.0 release instead of 0.4.5a56. > > > > > > Anyways, with help from many folks we now have a release candidate > > > that can > > > be found here: > > > > > > https://urldefense.us/v3/__https://dist.apache.org/repos/dist/dev/incubator/sdap/apache-sdap-1.0.0-rc0/__;!!PvBDto6Hs4WbVuu7!aY2tIy4CD6wRO7JlwQ9_XSOpDkqvhu8QMq2ROLe907bKV-UqYPygNoR8NjtGjkf-Wmw$ > > > > > > > > > Instructions for building docker images from source can be found here: > > > > > > https://urldefense.us/v3/__https://incubator-sdap-nexus.readthedocs.io/en/latest/build.html__;!!PvBDto6Hs4WbVuu7!aY2tIy4CD6wRO7JlwQ9_XSOpDkqvhu8QMq2ROLe907bKV-UqYPygNoR8NjtGMdzQUnc$ > > > Instructions for deploying locally to test can be found here: > > > > > > https://urldefense.us/v3/__https://incubator-sdap-nexus.readthedocs.io/en/latest/quickstart.html__;!!PvBDto6Hs4WbVuu7!aY2tIy4CD6wRO7JlwQ9_XSOpDkqvhu8QMq2ROLe907bKV-UqYPygNoR8NjtG-tQ0nvg$ > > > Associated docker images can be found here: > > > > > >
Re: [EXTERNAL] Re: [DISCUSS] Towards release 0.4.5a56
Hey, that looks pretty good! In fact it looks a lot like an Apache release. A few things: 1. I saw you added dist/dev/incubator/sdap/KEYS; can you move that file so that its path is dist/release/incubator/sdap/KEYS. Its main purpose will be for people who download the release after it has been released and want to verify the signatures. Putting it in 'release' will ensure that it is automatically mirrored to https://downloads.apache.org 2. I got the following output from gpg: gpg: Signature made Mon 05 Dec 2022 10:52:22 PM PST gpg:using RSA key 1392A8A11801359247A803D8D2449E0EB5EF1E73 gpg: Good signature from "Nga Chung (CODE SIGNING KEY) " [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. This means that the artifacts are signed correctly, but you are not in my web of trust. Soon after the release, we should have a key-signing party (or you should get your key signed by a colleague who has a well-connected key). 3. At first glance, the contents of the .tar.gz files look pretty good. I haven't checked the headers etc. yet. There seems to be a LICENSE.txt and NOTICE in each, which is good. You should also add a DISCLAIMER and/or DISCLAIMER-WIP file (required by the incubation process [1]). I also recommend adding a top-level README in each .tar.gz that describes the purpose of the file, and how to build it (for example see Calcite's README [2]) A good next step would be to start a vote. Craft an email with the same general structure as Apache Hop (incubating) 0.99-rc2 [3] and send it to dev@. Then PPMC members should vote on the release, each describing the checks that they made. Then finish the vote with an email with a [RESULT][VOTE] or [CANCEL][VOTE] subject line. (We know the vote will fail, due to the missing DISCLAIMER file, but it's good to practice the process, and with many people scrutinizing the release we will find issues faster.) You'll also want to craft release notes (they don't have to be in the release, but they should be somewhere accessible for people to read). And you should be writing that "how to" guide as you go along, if you're not already. Julian [1] https://incubator.apache.org/policy/incubation.html#disclaimers [2] https://github.com/apache/calcite/blob/main/README [3] https://lists.apache.org/thread/ncnok4clt6k491zv6c3v4kk2fc41qsz2 On Mon, Dec 5, 2022 at 11:06 PM Nga Chung wrote: > > Riley, thank you for adding all the missing ASF header and the NOTICE. > > Riley's changes have been merged and rc1 artifacts have been uploaded to > https://dist.apache.org/repos/dist/dev/incubator/sdap/apache-sdap-1.0.0-rc1/ > > > Has anyone had any success testing rc0? > > Julian, any suggestions on next steps? > > Thanks, > Nga > > On Thu, Dec 1, 2022 at 1:03 PM Kuttruff, Riley K (US 398F-Affiliate) > wrote: > > > It appears some of the source files are missing the ASF header. I did a > > check for all the Python files across the repositories and added them where > > needed in a pair of PRs (nexus & ingester; nexusproto had no .py files > > missing the header). > > > > I still have yet to check for any non-python source files. > > > > Riley > > > > On 11/30/22, 4:29 PM, "Nga Chung" wrote: > > > > Hi everyone, > > > > So this email thread probably needs renaming or we can start a new one > > if > > we're proceeding with a Version 1.0.0 release instead of 0.4.5a56. > > > > Anyways, with help from many folks we now have a release candidate > > that can > > be found here: > > > > https://urldefense.us/v3/__https://dist.apache.org/repos/dist/dev/incubator/sdap/apache-sdap-1.0.0-rc0/__;!!PvBDto6Hs4WbVuu7!aY2tIy4CD6wRO7JlwQ9_XSOpDkqvhu8QMq2ROLe907bKV-UqYPygNoR8NjtGjkf-Wmw$ > > > > > > Instructions for building docker images from source can be found here: > > > > https://urldefense.us/v3/__https://incubator-sdap-nexus.readthedocs.io/en/latest/build.html__;!!PvBDto6Hs4WbVuu7!aY2tIy4CD6wRO7JlwQ9_XSOpDkqvhu8QMq2ROLe907bKV-UqYPygNoR8NjtGMdzQUnc$ > > Instructions for deploying locally to test can be found here: > > > > https://urldefense.us/v3/__https://incubator-sdap-nexus.readthedocs.io/en/latest/quickstart.html__;!!PvBDto6Hs4WbVuu7!aY2tIy4CD6wRO7JlwQ9_XSOpDkqvhu8QMq2ROLe907bKV-UqYPygNoR8NjtG-tQ0nvg$ > > Associated docker images can be found here: > > > > https://urldefense.us/v3/__https://hub.docker.com/search?q=apache*2Fsdap__;JQ!!PvBDto6Hs4WbVuu7!aY2tIy4CD6wRO7JlwQ9_XSOpDkqvhu8QMq2ROLe907bKV-UqYPygNoR8NjtG5KMpZEg$ > > > > Here's how I created rc0. I will get these instructions into github but > > wanted to get all this out first for your review. > > > > git clone --branch release/1.0.0 > > > > https://urldefense.us/v3/__https://github.com/apache/incubator-sdap-nexusproto.git__;!!PvBDto6Hs4WbVuu7!aY2tIy4CD6wRO7JlwQ9_XSOpDkqvhu8QMq2ROLe907bKV-UqYPygNoR8NjtGbmDU9OM$ > > > > cd incubator-sdap-nexusproto*/* > > > >
