[GitHub] [incubator-sdap-nexus] eamonford commented on a change in pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart
eamonford commented on a change in pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart URL: https://github.com/apache/incubator-sdap-nexus/pull/88#discussion_r369875545 ## File path: analysis/webservice/algorithms/doms/domsconfig.ini ## @@ -1,5 +1,5 @@ [cassandra] -host=127.0.0.1 +host=sdap-cassandra Review comment: I agree, this should be addressed in a separate PR... unfortunately without `docker-entrypoint.sh` these values are indeed hardcoded, but I had to remove docker-entrypoint because the Spark Operator controller now handles the submission of the of the webapp to the spark server. I think addressing this should be a top priority after this PR goes in This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-sdap-nexus] eamonford commented on a change in pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart
eamonford commented on a change in pull request #88: SDAP-215 Use k8s as Spark
scheduler and create helm chart
URL:
https://github.com/apache/incubator-sdap-nexus/pull/88#discussion_r369874390
##
File path: helm/templates/ingress.yaml
##
@@ -0,0 +1,26 @@
+apiVersion: extensions/v1beta1
+kind: Ingress
+metadata:
+ name: nexus-webapp
+ annotations:
+kubernetes.io/ingress.class: ingress-nginx
+nginx.ingress.kubernetes.io/rewrite-target: /$1
+nginx.ingress.kubernetes.io/proxy-read-timeout: "180"
+nginx.ingress.kubernetes.io/proxy-send-timeout: "180"
+spec:
+ rules:
+ - host: {{ .Values.host }}
+http:
+ paths:
+ - path: /
Review comment:
I'm going to leave the root-webpage route in there for now, because /onearth
is currently proxying to a node outside the EKS cluster so I don't want to move
the nexus webapp to the root path or nexus might try to pick up requests
intended for OnEarth. When OnEarth moves to a k8s deployment, we can revisit
this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
