[GitHub] [incubator-sdap-nexus] skorper commented on pull request #202: SDAP-402: Update matchOnce logic

2022-10-12 Thread GitBox


skorper commented on PR #202:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/202#issuecomment-1275745444

   @ngachung The duplicate primary issue seems to occur prior to these changes, 
so it shouldn't block moving forward with this PR. All conflicts have been 
resolved


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [incubator-sdap-nexus] skorper commented on pull request #202: SDAP-402: Update matchOnce logic

2022-09-29 Thread GitBox


skorper commented on PR #202:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/202#issuecomment-1262983746

   Note, L2 -> Saildrone is returning more matches than expected for both my 
changes and the version deployed to AWS (Riley correct me if I'm wrong) so this 
discrepancy is maybe unrelated to this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org