[GitHub] [incubator-sedona] Imbruced commented on pull request #484: [SEDONA-1] Make Sedona depend on a LocationTech JTS 1.16.1 fork

2020-10-05 Thread GitBox


Imbruced commented on pull request #484:
URL: https://github.com/apache/incubator-sedona/pull/484#issuecomment-703504794


   @jiayuasu I will take care of this today evening.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-sedona] netanel246 commented on a change in pull request #484: [SEDONA-1] Make Sedona depend on a LocationTech JTS 1.16.1 fork

2020-10-05 Thread GitBox


netanel246 commented on a change in pull request #484:
URL: https://github.com/apache/incubator-sedona/pull/484#discussion_r499519523



##
File path: core/pom.xml
##
@@ -32,10 +32,16 @@
jar
 
 
+
+org.locationtech.jts
+jts-core
+1.16.2-SNAPSHOT

Review comment:
   There is a special reason why you're using the SNAPSHOT version?
   Why we can't use deployable version 1.16.1?

##
File path: core/pom.xml
##
@@ -35,7 +35,7 @@
 
 org.wololo
 jts2geojson
-0.10.0
+0.13.0

Review comment:
   Why not using 
[0.14.3](https://github.com/bjornharrtell/jts2geojson/blob/0.14.3/pom.xml) 
(newest version)?. 
   It's also compatible with JTS version 1.16.1





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: Podling Sedona Report Reminder - October 2020

2020-10-05 Thread Felix Cheung
Thanks- it looks like the report is truncated? It seems to be missing some
text and section


On Sun, Oct 4, 2020 at 11:53 PM Jia Yu  wrote:

> Hi folks,
>
> I have submitted the draft of the report. Please take a look. Mentors,
> thank you very much for your help!
>
> Jia
>
> On Sat, Oct 3, 2020 at 5:31 PM Jia Yu  wrote:
>
> > Hi Felix,
> >
> > I will write the report tomorrow. I will let you guys know once I am
> done.
> >
> > Thanks,
> > Jia
> >
> > On Sat, Oct 3, 2020 at 5:18 PM Felix Cheung 
> > wrote:
> >
> >> Any volunteer for this report?
> >>
> >>
> >>
> >> On Sat, Sep 19, 2020 at 6:07 PM  wrote:
> >>
> >> > Dear podling,
> >> >
> >> > This email was sent by an automated system on behalf of the Apache
> >> > Incubator PMC. It is an initial reminder to give you plenty of time to
> >> > prepare your quarterly board report.
> >> >
> >> > The board meeting is scheduled for Wed, 21 October 2020.
> >> > The report for your podling will form a part of the Incubator PMC
> >> > report. The Incubator PMC requires your report to be submitted 2 weeks
> >> > before the board meeting, to allow sufficient time for review and
> >> > submission (Wed, October 07).
> >> >
> >> > Please submit your report with sufficient time to allow the Incubator
> >> > PMC, and subsequently board members to review and digest. Again, the
> >> > very latest you should submit your report is 2 weeks prior to the
> board
> >> > meeting.
> >> >
> >> > Candidate names should not be made public before people are actually
> >> > elected, so please do not include the names of potential committers or
> >> > PPMC members in your report.
> >> >
> >> > Thanks,
> >> >
> >> > The Apache Incubator PMC
> >> >
> >> > Submitting your Report
> >> >
> >> > --
> >> >
> >> > Your report should contain the following:
> >> >
> >> > *   Your project name
> >> > *   A brief description of your project, which assumes no knowledge of
> >> > the project or necessarily of its field
> >> > *   A list of the three most important issues to address in the move
> >> > towards graduation.
> >> > *   Any issues that the Incubator PMC or ASF Board might wish/need to
> be
> >> > aware of
> >> > *   How has the community developed since the last report
> >> > *   How has the project developed since the last report.
> >> > *   How does the podling rate their own maturity.
> >> >
> >> > This should be appended to the Incubator Wiki page at:
> >> >
> >> > https://cwiki.apache.org/confluence/display/INCUBATOR/October2020
> >> >
> >> > Note: This is manually populated. You may need to wait a little before
> >> > this page is created from a template.
> >> >
> >> > Note: The format of the report has changed to use markdown.
> >> >
> >> > Mentors
> >> > ---
> >> >
> >> > Mentors should review reports for their project(s) and sign them off
> on
> >> > the Incubator wiki page. Signing off reports shows that you are
> >> > following the project - projects that are not signed may raise alarms
> >> > for the Incubator PMC.
> >> >
> >> > Incubator PMC
> >> >
> >>
> >
>


Re: Podling Sedona Report Reminder - October 2020

2020-10-05 Thread Jia Yu
Yes, indeed. I am not sure why. I copied the content back and now it has
all sections and text.

On Mon, Oct 5, 2020 at 8:39 PM Felix Cheung  wrote:

> Thanks- it looks like the report is truncated? It seems to be missing some
> text and section
>
>
> On Sun, Oct 4, 2020 at 11:53 PM Jia Yu  wrote:
>
> > Hi folks,
> >
> > I have submitted the draft of the report. Please take a look. Mentors,
> > thank you very much for your help!
> >
> > Jia
> >
> > On Sat, Oct 3, 2020 at 5:31 PM Jia Yu  wrote:
> >
> > > Hi Felix,
> > >
> > > I will write the report tomorrow. I will let you guys know once I am
> > done.
> > >
> > > Thanks,
> > > Jia
> > >
> > > On Sat, Oct 3, 2020 at 5:18 PM Felix Cheung 
> > > wrote:
> > >
> > >> Any volunteer for this report?
> > >>
> > >>
> > >>
> > >> On Sat, Sep 19, 2020 at 6:07 PM  wrote:
> > >>
> > >> > Dear podling,
> > >> >
> > >> > This email was sent by an automated system on behalf of the Apache
> > >> > Incubator PMC. It is an initial reminder to give you plenty of time
> to
> > >> > prepare your quarterly board report.
> > >> >
> > >> > The board meeting is scheduled for Wed, 21 October 2020.
> > >> > The report for your podling will form a part of the Incubator PMC
> > >> > report. The Incubator PMC requires your report to be submitted 2
> weeks
> > >> > before the board meeting, to allow sufficient time for review and
> > >> > submission (Wed, October 07).
> > >> >
> > >> > Please submit your report with sufficient time to allow the
> Incubator
> > >> > PMC, and subsequently board members to review and digest. Again, the
> > >> > very latest you should submit your report is 2 weeks prior to the
> > board
> > >> > meeting.
> > >> >
> > >> > Candidate names should not be made public before people are actually
> > >> > elected, so please do not include the names of potential committers
> or
> > >> > PPMC members in your report.
> > >> >
> > >> > Thanks,
> > >> >
> > >> > The Apache Incubator PMC
> > >> >
> > >> > Submitting your Report
> > >> >
> > >> > --
> > >> >
> > >> > Your report should contain the following:
> > >> >
> > >> > *   Your project name
> > >> > *   A brief description of your project, which assumes no knowledge
> of
> > >> > the project or necessarily of its field
> > >> > *   A list of the three most important issues to address in the move
> > >> > towards graduation.
> > >> > *   Any issues that the Incubator PMC or ASF Board might wish/need
> to
> > be
> > >> > aware of
> > >> > *   How has the community developed since the last report
> > >> > *   How has the project developed since the last report.
> > >> > *   How does the podling rate their own maturity.
> > >> >
> > >> > This should be appended to the Incubator Wiki page at:
> > >> >
> > >> > https://cwiki.apache.org/confluence/display/INCUBATOR/October2020
> > >> >
> > >> > Note: This is manually populated. You may need to wait a little
> before
> > >> > this page is created from a template.
> > >> >
> > >> > Note: The format of the report has changed to use markdown.
> > >> >
> > >> > Mentors
> > >> > ---
> > >> >
> > >> > Mentors should review reports for their project(s) and sign them off
> > on
> > >> > the Incubator wiki page. Signing off reports shows that you are
> > >> > following the project - projects that are not signed may raise
> alarms
> > >> > for the Incubator PMC.
> > >> >
> > >> > Incubator PMC
> > >> >
> > >>
> > >
> >
>


[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #484: [SEDONA-1] Make Sedona depend on a LocationTech JTS 1.16.1 fork

2020-10-05 Thread GitBox


jiayuasu commented on a change in pull request #484:
URL: https://github.com/apache/incubator-sedona/pull/484#discussion_r500018075



##
File path: core/pom.xml
##
@@ -35,7 +35,7 @@
 
 org.wololo
 jts2geojson
-0.10.0
+0.13.0

Review comment:
   @netanel246 It looks like 0.14.3 was compiled by Java 11 and other 
components in Sedona was compiled by Java 8. So I didn't use 0.14.3.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #484: [SEDONA-1] Make Sedona depend on a LocationTech JTS 1.16.1 fork

2020-10-05 Thread GitBox


jiayuasu commented on a change in pull request #484:
URL: https://github.com/apache/incubator-sedona/pull/484#discussion_r500019542



##
File path: core/pom.xml
##
@@ -32,10 +32,16 @@
jar
 
 
+
+org.locationtech.jts
+jts-core
+1.16.2-SNAPSHOT

Review comment:
   @netanel246 Note that, this dependency is actually the JTS submodule of 
the git repo, rather than a standard JTS Maven release. It was compiled by 
Sedona "mvn install" and automatically added to Sedona, locally. The "SNAPSHOT" 
comes from here: 
https://github.com/jiayuasu/jts/blob/1.16.x/modules/core/pom.xml
   
   The git submodule is Sedona Maven submodule: 
https://github.com/apache/incubator-sedona/blob/jtsplus/pom.xml#L12





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org