Re: [VOTE] Release Apache Sedona 1.0.1-incubating-rc1
Hi Felix, Thanks for your time! 1. Actually the build instruction is already in the source.tar.gz because the build instruction is by default delivered together with the source code. And it is also git tagged together with the source code. Please see 1.0.1-rc1 git tag: https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/compile.md 2. All java artifacts had been staged on ASF maven repo when I created this vote email. 3. docs/archive is for the old GeoSpark docs. We keep it in the doc website for users who are still using GeoSpark, instead of Sedona. The generated docs are put here: http://sedona.apache.org/archive/download/overview/ Thanks, Jia On Thu, May 20, 2021 at 10:50 AM Felix Cheung wrote: > 1. You probably shouldn't put .md doc on release share - if I understand > the suggestion is to include it into the src.tar.gz (and into the source > repo) so that they are git tagged and packaged together > > 2. Do you have java artifacts that should be staged? > > 3. checklist > incubating in name > signature and hash fine > DISCLAIMER is fine > LICENSE and NOTICE are fine > No unexpected binary files > All source have ASF headers > > 4. what is /docs/archive for? > > > On Wed, May 19, 2021 at 2:41 PM Adam Binford wrote: > > > +1 (non-binding) > > > > On Wed, May 19, 2021 at 12:58 AM Jia Yu wrote: > > > > > Hi all, > > > > > > This is a call for vote on Apache Sedona 1.0.1-incubating-rc1. Please > > refer > > > to the changes listed at the bottom of this email. > > > > > > Release notes: > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/release-notes.md > > > > > > Build instructions: > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/compile.md > > > > > > GitHub tag: > > > > > > > > > https://github.com/apache/incubator-sedona/releases/tag/sedona-1.0.1-incubating-rc1 > > > > > > GPG public key to verify the Release: > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS > > > > > > Source code and binaries: > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ > > > > > > The vote will be open for at least 72 hours or until a majority of at > > least > > > 3 +1 PMC votes are cast > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove with the reason > > > > > > Checklist for reference (because of DISCLAIMER-WIP, other checklist > items > > > are not blockers): > > > > > > [ ] Download links are valid. > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > [ ] DISCLAIMER is included. > > > > > > [ ] Source code artifacts have correct names matching the current > > release. > > > > > > For a detailed checklist please refer to: > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > > Changes according to the comments of Justin Mclean on the > > 1.0.0-incubating > > > release > > > Original comment URL: > > > > > > > > > https://lists.apache.org/thread.html/r828873cbb2685dcfb0719680f3aac6dbf982720fcd9cd5f69a26ec55%40%3Cgeneral.incubator.apache.org%3E > > > > > > 1. There are some test files I think I like to know where they come > from > > > e.g. county_small_wkb.tsv and what license the contents are under. > > > > > > License for test data has been added to Sedona license > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > > > > > 2. The LICENSE here seems odd why does it have "Copyright (c) > 2019-2020, > > > Apache Sedona” in it? > > > > > > The issue has been fixed. The license for zeppelin plugin has been > added > > to > > > LICENSE as well. > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > > > > > 3. Please put instructions on how to build in the release, instructions > > can > > > change over time so pointing to a URL may not be helpful when trying to > > > build older versions. > > > > > > Build instruction has been added to svn/dist/dev > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ > > > > > > > > > -- > > Adam Binford > > >
[GitHub] [incubator-sedona] Imbruced commented on a change in pull request #528: [Sedona-27] Add ST_Subdivide and ST_SubdivideExplode functions.
Imbruced commented on a change in pull request #528: URL: https://github.com/apache/incubator-sedona/pull/528#discussion_r637096112 ## File path: sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/subdivide/implicits.scala ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.sql.sedona_sql.expressions.subdivide + +import org.locationtech.jts.geom.Geometry + Review comment: For sure, that's good idea, forgot about that class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on a change in pull request #528: [Sedona-27] Add ST_Subdivide and ST_SubdivideExplode functions.
Imbruced commented on a change in pull request #528: URL: https://github.com/apache/incubator-sedona/pull/528#discussion_r637103809 ## File path: sql/src/test/scala/org/apache/sedona/sql/functions/FunctionsHelper.scala ## @@ -0,0 +1,31 @@ +///* Review comment: ofc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on a change in pull request #528: [Sedona-27] Add ST_Subdivide and ST_SubdivideExplode functions.
Imbruced commented on a change in pull request #528:
URL: https://github.com/apache/incubator-sedona/pull/528#discussion_r637104231
##
File path:
sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala
##
@@ -1122,4 +1123,48 @@ case class ST_FlipCoordinates(inputExpressions:
Seq[Expression])
override def dataType: DataType = GeometryUDT
override def children: Seq[Expression] = inputExpressions
+}
+
+
+case class ST_SubDivide(inputExpressions: Seq[Expression])
+ extends Expression with CodegenFallback {
+ override def nullable: Boolean = true
+
+ override def eval(input: InternalRow): Any = {
+inputExpressions.validateLength(2)
+val geometryRaw = inputExpressions.head
+val maxVerticesRaw = inputExpressions(1)
+geometryRaw.toGeometry(input) match {
+ case geom: Geometry => ArrayData.toArrayData(
+GeometrySubDivider.subDivide(geom,
maxVerticesRaw.toInt(input)).map(_.toGenericArrayData)
+ )
+ case null => null
+}
+
+ }
+
+ override def dataType: DataType = ArrayType(GeometryUDT)
+
+ override def children: Seq[Expression] = inputExpressions
+}
+
+case class ST_SubDivideExplode(children: Seq[Expression]) extends Generator {
Review comment:
didnt know that, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-sedona] Imbruced commented on a change in pull request #528: [Sedona-27] Add ST_Subdivide and ST_SubdivideExplode functions.
Imbruced commented on a change in pull request #528:
URL: https://github.com/apache/incubator-sedona/pull/528#discussion_r637163575
##
File path:
sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala
##
@@ -1122,4 +1123,48 @@ case class ST_FlipCoordinates(inputExpressions:
Seq[Expression])
override def dataType: DataType = GeometryUDT
override def children: Seq[Expression] = inputExpressions
+}
+
+
+case class ST_SubDivide(inputExpressions: Seq[Expression])
+ extends Expression with CodegenFallback {
+ override def nullable: Boolean = true
+
+ override def eval(input: InternalRow): Any = {
+inputExpressions.validateLength(2)
+val geometryRaw = inputExpressions.head
+val maxVerticesRaw = inputExpressions(1)
+geometryRaw.toGeometry(input) match {
+ case geom: Geometry => ArrayData.toArrayData(
+GeometrySubDivider.subDivide(geom,
maxVerticesRaw.toInt(input)).map(_.toGenericArrayData)
+ )
+ case null => null
+}
+
+ }
+
+ override def dataType: DataType = ArrayType(GeometryUDT)
+
+ override def children: Seq[Expression] = inputExpressions
+}
+
+case class ST_SubDivideExplode(children: Seq[Expression]) extends Generator {
Review comment:
But as far i remember lateral view works with spark 2.4 and above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Release Apache Sedona 1.0.1-incubating-rc1
+1 Great On Fri, May 21, 2021 at 12:49 AM Jia Yu wrote: > Hi Felix, > > Thanks for your time! > > 1. Actually the build instruction is already in the source.tar.gz because > the build instruction is by default delivered together with the source > code. And it is also git tagged together with the source code. Please see > 1.0.1-rc1 git tag: > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/compile.md > > 2. All java artifacts had been staged on ASF maven repo when I created this > vote email. > > 3. docs/archive is for the old GeoSpark docs. We keep it in the doc website > for users who are still using GeoSpark, instead of Sedona. The generated > docs are put here: http://sedona.apache.org/archive/download/overview/ > > Thanks, > Jia > > > On Thu, May 20, 2021 at 10:50 AM Felix Cheung > wrote: > > > 1. You probably shouldn't put .md doc on release share - if I understand > > the suggestion is to include it into the src.tar.gz (and into the source > > repo) so that they are git tagged and packaged together > > > > 2. Do you have java artifacts that should be staged? > > > > 3. checklist > > incubating in name > > signature and hash fine > > DISCLAIMER is fine > > LICENSE and NOTICE are fine > > No unexpected binary files > > All source have ASF headers > > > > 4. what is /docs/archive for? > > > > > > On Wed, May 19, 2021 at 2:41 PM Adam Binford wrote: > > > > > +1 (non-binding) > > > > > > On Wed, May 19, 2021 at 12:58 AM Jia Yu wrote: > > > > > > > Hi all, > > > > > > > > This is a call for vote on Apache Sedona 1.0.1-incubating-rc1. Please > > > refer > > > > to the changes listed at the bottom of this email. > > > > > > > > Release notes: > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/release-notes.md > > > > > > > > Build instructions: > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/compile.md > > > > > > > > GitHub tag: > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/releases/tag/sedona-1.0.1-incubating-rc1 > > > > > > > > GPG public key to verify the Release: > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS > > > > > > > > Source code and binaries: > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ > > > > > > > > The vote will be open for at least 72 hours or until a majority of at > > > least > > > > 3 +1 PMC votes are cast > > > > > > > > Please vote accordingly: > > > > > > > > [ ] +1 approve > > > > > > > > [ ] +0 no opinion > > > > > > > > [ ] -1 disapprove with the reason > > > > > > > > Checklist for reference (because of DISCLAIMER-WIP, other checklist > > items > > > > are not blockers): > > > > > > > > [ ] Download links are valid. > > > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > > > [ ] DISCLAIMER is included. > > > > > > > > [ ] Source code artifacts have correct names matching the current > > > release. > > > > > > > > For a detailed checklist please refer to: > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > > > > > Changes according to the comments of Justin Mclean on the > > > 1.0.0-incubating > > > > release > > > > Original comment URL: > > > > > > > > > > > > > > https://lists.apache.org/thread.html/r828873cbb2685dcfb0719680f3aac6dbf982720fcd9cd5f69a26ec55%40%3Cgeneral.incubator.apache.org%3E > > > > > > > > 1. There are some test files I think I like to know where they come > > from > > > > e.g. county_small_wkb.tsv and what license the contents are under. > > > > > > > > License for test data has been added to Sedona license > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > > > > > > > 2. The LICENSE here seems odd why does it have "Copyright (c) > > 2019-2020, > > > > Apache Sedona” in it? > > > > > > > > The issue has been fixed. The license for zeppelin plugin has been > > added > > > to > > > > LICENSE as well. > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > > > > > > > 3. Please put instructions on how to build in the release, > instructions > > > can > > > > change over time so pointing to a URL may not be helpful when trying > to > > > > build older versions. > > > > > > > > Build instruction has been added to svn/dist/dev > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ > > > > > > > > > > > > > -- > > > Adam Binford > > > > > >
[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #521: [SEDONA-31] R interface for Apache Sedona
jiayuasu commented on a change in pull request #521:
URL: https://github.com/apache/incubator-sedona/pull/521#discussion_r637222020
##
File path: R/sparklyr.sedona/DESCRIPTION
##
@@ -0,0 +1,31 @@
+Type: Package
+Package: sparklyr.sedona
+Title: Sparklyr Extension for Apache Sedona
+Version: 0.1.0
+Authors@R:
+c(person(family = "Apache Sedona",
+ role = c("aut", "cre"),
+ email = "dev@sedona.apache.org"),
Review comment:
Oh I just realized the dev@s.a.o is open to the public and anyone has
access to it. Would you please change this to priv...@sedona.apache.org? This
way, only PMC members can control the publish of this doc. Once you are added
to Sedona PMC (after voting), you will have access to priv...@sedona.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #521: [SEDONA-31] R interface for Apache Sedona
jiayuasu commented on a change in pull request #521:
URL: https://github.com/apache/incubator-sedona/pull/521#discussion_r637222020
##
File path: R/sparklyr.sedona/DESCRIPTION
##
@@ -0,0 +1,31 @@
+Type: Package
+Package: sparklyr.sedona
+Title: Sparklyr Extension for Apache Sedona
+Version: 0.1.0
+Authors@R:
+c(person(family = "Apache Sedona",
+ role = c("aut", "cre"),
+ email = "dev@sedona.apache.org"),
Review comment:
Oh I just realized the dev@s.a.o is open to the public and anyone has
access to it. Would you please change this to priv...@sedona.apache.org? This
way, only PMC members can control how to publish the package. Once you are
added to Sedona PMC (after voting), you will have access to
priv...@sedona.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Release Apache Sedona 1.0.1-incubating-rc1
+1 On Tue, May 18, 2021 at 9:57 PM Jia Yu wrote: > Hi all, > > This is a call for vote on Apache Sedona 1.0.1-incubating-rc1. Please refer > to the changes listed at the bottom of this email. > > Release notes: > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/release-notes.md > > Build instructions: > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/compile.md > > GitHub tag: > > https://github.com/apache/incubator-sedona/releases/tag/sedona-1.0.1-incubating-rc1 > > GPG public key to verify the Release: > https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS > > Source code and binaries: > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ > > The vote will be open for at least 72 hours or until a majority of at least > 3 +1 PMC votes are cast > > Please vote accordingly: > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > Checklist for reference (because of DISCLAIMER-WIP, other checklist items > are not blockers): > > [ ] Download links are valid. > > [ ] Checksums and PGP signatures are valid. > > [ ] DISCLAIMER is included. > > [ ] Source code artifacts have correct names matching the current release. > > For a detailed checklist please refer to: > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > Changes according to the comments of Justin Mclean on the 1.0.0-incubating > release > Original comment URL: > > https://lists.apache.org/thread.html/r828873cbb2685dcfb0719680f3aac6dbf982720fcd9cd5f69a26ec55%40%3Cgeneral.incubator.apache.org%3E > > 1. There are some test files I think I like to know where they come from > e.g. county_small_wkb.tsv and what license the contents are under. > > License for test data has been added to Sedona license > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > 2. The LICENSE here seems odd why does it have "Copyright (c) 2019-2020, > Apache Sedona” in it? > > The issue has been fixed. The license for zeppelin plugin has been added to > LICENSE as well. > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > 3. Please put instructions on how to build in the release, instructions can > change over time so pointing to a URL may not be helpful when trying to > build older versions. > > Build instruction has been added to svn/dist/dev > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ >
