Re: [VOTE] Release Apache Sedona 1.0.1-incubating-rc1
+1 binding it looks good to me śr., 19 maj 2021 o 06:57 Jia Yu napisał(a): > Hi all, > > This is a call for vote on Apache Sedona 1.0.1-incubating-rc1. Please > refer to the changes listed at the bottom of this email. > > Release notes: > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/release-notes.md > > Build instructions: > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/compile.md > > GitHub tag: > > https://github.com/apache/incubator-sedona/releases/tag/sedona-1.0.1-incubating-rc1 > > GPG public key to verify the Release: > https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS > > Source code and binaries: > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ > > The vote will be open for at least 72 hours or until a majority of at > least 3 +1 PMC votes are cast > > Please vote accordingly: > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > Checklist for reference (because of DISCLAIMER-WIP, other checklist items > are not blockers): > > [ ] Download links are valid. > > [ ] Checksums and PGP signatures are valid. > > [ ] DISCLAIMER is included. > > [ ] Source code artifacts have correct names matching the current release. > > For a detailed checklist please refer to: > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > Changes according to the comments of Justin Mclean on the 1.0.0-incubating > release > Original comment URL: > https://lists.apache.org/thread.html/r828873cbb2685dcfb0719680f3aac6dbf982720fcd9cd5f69a26ec55%40%3Cgeneral.incubator.apache.org%3E > > 1. There are some test files I think I like to know where they come from > e.g. county_small_wkb.tsv and what license the contents are under. > > License for test data has been added to Sedona license > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > 2. The LICENSE here seems odd why does it have "Copyright (c) 2019-2020, > Apache Sedona” in it? > > The issue has been fixed. The license for zeppelin plugin has been added > to LICENSE as well. > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > 3. Please put instructions on how to build in the release, instructions > can change over time so pointing to a URL may not be helpful when trying to > build older versions. > > Build instruction has been added to svn/dist/dev > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ >
[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #528: [Sedona-27] Add ST_Subdivide and ST_SubdivideExplode functions.
jiayuasu commented on a change in pull request #528: URL: https://github.com/apache/incubator-sedona/pull/528#discussion_r637446975 ## File path: sql/src/test/scala/org/apache/sedona/sql/functions/FunctionsHelper.scala ## @@ -0,0 +1,31 @@ +/* +// * Licensed to the Apache Software Foundation (ASF) under one Review comment: @Imbruced You should use this comment style /* * * */ Just like what you did in other file header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[RESULT][VOTE] Release Apache Sedona 1.0.1-incubating RC1
Dear all, The vote closes now as 72hr have passed. The vote PASSES with +3 (PPMC): Felix, Netanel, Mohamed +1 (non-binding): Adam Binford No -1 votes The vote thread: https://lists.apache.org/thread.html/ra5f27cd5c9c3608205220c5d12a141c64681b7a5962785ce80fa73ec%40%3Cdev.sedona.apache.org%3E I will now bring the vote to gene...@incubator.apache.org to get approval by the IPMC. If this vote passes too, the release is accepted and will be published. Thanks, Jia
[GitHub] [incubator-sedona] netanelma-tr commented on pull request #516: [Sedona-28] shape&wkb ser de
netanelma-tr commented on pull request #516:
URL: https://github.com/apache/incubator-sedona/pull/516#issuecomment-846455295
Hi @jiayuasu ,
Unfortunately, I didn't have time for this till now.
There is a way to find which kryo serializer is used in runtime (without
using the spark conf which isn't available for the scopes that I need)? I tried
to search for that on the kryo docs but didn't find anything useful.
>
> .config("spark.kryo.registrator", classOf[SedonaKryoRegistrator].getName)
> .config("spark.kryo.registrator",
classOf[SedonaWKBKryoRegistrator].getName)
>
otherwise, I won't know which to use for the SQL module.
I think that I need to find which is used and apply the SQL serializer
according to this value.
What do you think about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Release Apache Sedona 1.0.1-incubating-rc1
+1 On Sat, 22 May 2021 at 07:34, Mo Sarwat wrote: > +1 > > On Tue, May 18, 2021 at 9:57 PM Jia Yu wrote: > > > Hi all, > > > > This is a call for vote on Apache Sedona 1.0.1-incubating-rc1. Please > refer > > to the changes listed at the bottom of this email. > > > > Release notes: > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/release-notes.md > > > > Build instructions: > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/compile.md > > > > GitHub tag: > > > > > https://github.com/apache/incubator-sedona/releases/tag/sedona-1.0.1-incubating-rc1 > > > > GPG public key to verify the Release: > > https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS > > > > Source code and binaries: > > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ > > > > The vote will be open for at least 72 hours or until a majority of at > least > > 3 +1 PMC votes are cast > > > > Please vote accordingly: > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > Checklist for reference (because of DISCLAIMER-WIP, other checklist items > > are not blockers): > > > > [ ] Download links are valid. > > > > [ ] Checksums and PGP signatures are valid. > > > > [ ] DISCLAIMER is included. > > > > [ ] Source code artifacts have correct names matching the current > release. > > > > For a detailed checklist please refer to: > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > Changes according to the comments of Justin Mclean on the > 1.0.0-incubating > > release > > Original comment URL: > > > > > https://lists.apache.org/thread.html/r828873cbb2685dcfb0719680f3aac6dbf982720fcd9cd5f69a26ec55%40%3Cgeneral.incubator.apache.org%3E > > > > 1. There are some test files I think I like to know where they come from > > e.g. county_small_wkb.tsv and what license the contents are under. > > > > License for test data has been added to Sedona license > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > > > 2. The LICENSE here seems odd why does it have "Copyright (c) 2019-2020, > > Apache Sedona” in it? > > > > The issue has been fixed. The license for zeppelin plugin has been added > to > > LICENSE as well. > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > > > 3. Please put instructions on how to build in the release, instructions > can > > change over time so pointing to a URL may not be helpful when trying to > > build older versions. > > > > Build instruction has been added to svn/dist/dev > > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ > > > -- Best regards, Netanel Malka.
