[PR] [SEDONA-466] Add new parameter `useGeometryExtent` to RS_AsRaster [sedona]
duhaode520 opened a new pull request, #1193: URL: https://github.com/apache/sedona/pull/1193 ## Did you read the Contributor Guide? - Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/) ## Is this PR related to a JIRA ticket? - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-466. The PR name follows the format `[SEDONA-XXX] my subject`. ## What changes were proposed in this PR? - Expose the `useGeometryExtent` parameter to user and RS_AsRaster support 6 parameters now. - A new `asRaster` function with 6 parameters. Old `asRaster` and `asRasterwithRasterExtent` functions are revised accordingly. - Add new tests to test the new parameter. - Add relative docs and example aboput the new parameter. ## How was this patch tested? - Passed added tests and old relevant tests ## Did this PR include necessary documentation updates? - Yes, I have updated the documentation update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SEDONA-464] Update ST_IsValid to take flag argument [sedona]
jiayuasu merged PR #1192: URL: https://github.com/apache/sedona/pull/1192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SEDONA-464] Update ST_IsValid to take flag argument [sedona]
prantogg opened a new pull request, #1192: URL: https://github.com/apache/sedona/pull/1192 ## Did you read the Contributor Guide? - Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/) ## Is this PR related to a JIRA ticket? - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-464. The PR name follows the format `[SEDONA-XXX] my subject`. ## What changes were proposed in this PR? Updates the ST_IsValid function to take integer flag as argument ## How was this patch tested? - Passes new and existing tests ## Did this PR include necessary documentation updates? - Yes, I am adding a new API. I am using the [current SNAPSHOT version number](https://github.com/prantogg/sedona/blob/26b39d8d2bfc5c23c5f181962bba76668f48a31f/pom.xml#L29) in since `vX.Y.Z` format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SEDONA-466) RS_AsRaster does not use the weight and height of the raster in its parameters.
[ https://issues.apache.org/jira/browse/SEDONA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804192#comment-17804192 ] Jia Yu commented on SEDONA-466: --- [~ade_hddu] Sounds great! Please go ahead and work on it. > RS_AsRaster does not use the weight and height of the raster in its > parameters. > --- > > Key: SEDONA-466 > URL: https://issues.apache.org/jira/browse/SEDONA-466 > Project: Apache Sedona > Issue Type: Bug >Reporter: Haode Du >Priority: Major > > RS_AsRaster does not use the width and height of the raster passed in its > parameters. Instead, it will use the bounding rectangle of the passed > geometry as the width and height of the generated raster. > ([RasterConstructors.java > 172|https://github.com/apache/sedona/blob/master/common/src/main/java/org/apache/sedona/common/raster/RasterConstructors.java#L172]) > The function only utilizes the Scale and Skew information of the parameter > raster. > This behavior can be confusing, and I think we should fix it to use the width > and height of the parameter raster. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SEDONA-466) RS_AsRaster does not use the weight and height of the raster in its parameters.
[ https://issues.apache.org/jira/browse/SEDONA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804185#comment-17804185 ] Haode Du commented on SEDONA-466: - [~jiayu] I agree. I want to try and complete this as the very first contribution. What do you think? > RS_AsRaster does not use the weight and height of the raster in its > parameters. > --- > > Key: SEDONA-466 > URL: https://issues.apache.org/jira/browse/SEDONA-466 > Project: Apache Sedona > Issue Type: Bug >Reporter: Haode Du >Priority: Major > > RS_AsRaster does not use the width and height of the raster passed in its > parameters. Instead, it will use the bounding rectangle of the passed > geometry as the width and height of the generated raster. > ([RasterConstructors.java > 172|https://github.com/apache/sedona/blob/master/common/src/main/java/org/apache/sedona/common/raster/RasterConstructors.java#L172]) > The function only utilizes the Scale and Skew information of the parameter > raster. > This behavior can be confusing, and I think we should fix it to use the width > and height of the parameter raster. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [SEDONA-459] Open-source Sedona Snowflake: fix the wrong version setting in Snowflake tester [sedona]
jiayuasu merged PR #1191: URL: https://github.com/apache/sedona/pull/1191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SEDONA-459] Open-source Sedona Snowflake: fix the wrong version setting in Snowflake tester [sedona]
jiayuasu opened a new pull request, #1191: URL: https://github.com/apache/sedona/pull/1191 ## Did you read the Contributor Guide? - Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/) ## Is this PR related to a JIRA ticket? - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-459. The PR name follows the format `[SEDONA-XXX] my subject`. ## What changes were proposed in this PR? Replaced the hard-coded `1.5.1-SNAPSHOT` with the project config ## How was this patch tested? Passed local tests ## Did this PR include necessary documentation updates? - No, this PR does not affect any public API so no need to change the docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SEDONA-465] Support reading legacy parquet files written by Apache Sedona <= 1.3.1-incubating [sedona]
jiayuasu merged PR #1190: URL: https://github.com/apache/sedona/pull/1190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Errors reading data written with sedona 1.3.1 [sedona]
jiayuasu closed issue #1031: Errors reading data written with sedona 1.3.1 URL: https://github.com/apache/sedona/issues/1031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SEDONA-466) RS_AsRaster does not use the weight and height of the raster in its parameters.
[ https://issues.apache.org/jira/browse/SEDONA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804163#comment-17804163 ] Jia Yu commented on SEDONA-466: --- [~ade_hddu] We can provide a variant that exposes `useGeometryExtent` to the end user. So the user can opt to use it or not. https://github.com/apache/sedona/blob/master/common/src/main/java/org/apache/sedona/common/raster/RasterConstructors.java#L139 > RS_AsRaster does not use the weight and height of the raster in its > parameters. > --- > > Key: SEDONA-466 > URL: https://issues.apache.org/jira/browse/SEDONA-466 > Project: Apache Sedona > Issue Type: Bug >Reporter: Haode Du >Priority: Major > > RS_AsRaster does not use the width and height of the raster passed in its > parameters. Instead, it will use the bounding rectangle of the passed > geometry as the width and height of the generated raster. > ([RasterConstructors.java > 172|https://github.com/apache/sedona/blob/master/common/src/main/java/org/apache/sedona/common/raster/RasterConstructors.java#L172]) > The function only utilizes the Scale and Skew information of the parameter > raster. > This behavior can be confusing, and I think we should fix it to use the width > and height of the parameter raster. -- This message was sent by Atlassian Jira (v8.20.10#820010)
