[PR] [DOCS] Add information on pre-commit to `docs/setup/compile.md` [sedona]
jbampton opened a new pull request, #1363: URL: https://github.com/apache/sedona/pull/1363 ## Did you read the Contributor Guide? - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/) ## Is this PR related to a JIRA ticket? - No, this is a documentation update. The PR name follows the format `[DOCS] my subject`. ## What changes were proposed in this PR? fixes #1361 ## How was this patch tested? ## Did this PR include necessary documentation updates? - No, this PR does not affect any public API so no need to change the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SEDONA-542] Add `pre-commit` hook `check-executables-have-shebangs` [sedona]
jbampton opened a new pull request, #1362: URL: https://github.com/apache/sedona/pull/1362 https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-executables-have-shebangs ## Did you read the Contributor Guide? - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/) ## Is this PR related to a JIRA ticket? - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-542. The PR name follows the format `[SEDONA-XXX] my subject`. ## What changes were proposed in this PR? Added another check or test to our pre-commit framework. https://en.wikipedia.org/wiki/Shebang_(Unix) ## How was this patch tested? When this test was added it found a number of files which failed the test. For one shell script I have added the shebang. For the rest of the files I used `chmod -x` on them. ## Did this PR include necessary documentation updates? - No, this PR does not affect any public API so no need to change the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SEDONA-542) Add `pre-commit` hook `check-executables-have-shebangs`
John Bampton created SEDONA-542: --- Summary: Add `pre-commit` hook `check-executables-have-shebangs` Key: SEDONA-542 URL: https://issues.apache.org/jira/browse/SEDONA-542 Project: Apache Sedona Issue Type: Test Reporter: John Bampton -- This message was sent by Atlassian Jira (v8.20.10#820010)
[I] Add documentation on `pre-commit` usage [sedona]
jbampton opened a new issue, #1361: URL: https://github.com/apache/sedona/issues/1361 ## Expected behavior We need some quick info and tips on pre-commit usage added to the documentation. ## Actual behavior We have no docs on pre-commit. ## Steps to reproduce the problem ## Settings Sedona version = master Apache Spark version = ? Apache Flink version = ? API type = Scala, Java, Python? Scala version = 2.11, 2.12, 2.13? JRE version = 1.8, 1.11? Python version = ? Environment = Standalone, AWS EC2, EMR, Azure, Databricks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Add `markdown-link-check` with `pre-commit` [sedona]
jbampton opened a new issue, #1360: URL: https://github.com/apache/sedona/issues/1360 ## Expected behavior We should have all valid and working links and test for broken links ## Actual behavior Without an automated link check sometimes broken links are added and others become out of date. ## Steps to reproduce the problem Setup config file https://github.com/tcort/markdown-link-check?tab=readme-ov-file#run-as-a-pre-commit-hook - install pre-commit - install the hooks - run `pre-commit run --all-files` ## Settings Sedona version = master Apache Spark version = ? Apache Flink version = ? API type = Scala, Java, Python? Scala version = 2.11, 2.12, 2.13? JRE version = 1.8, 1.11? Python version = ? Environment = Standalone, AWS EC2, EMR, Azure, Databricks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [DOCS] Resize images [sedona]
mebrein opened a new pull request, #1359: URL: https://github.com/apache/sedona/pull/1359 ## Did you read the Contributor Guide? - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/) ## Is this PR related to a JIRA ticket? - No, this is a documentation update. The PR name follows the format `[DOCS] my subject`. ## What changes were proposed in this PR? - I resized images using imagemagick so in the .md files it is no longer needed to specify width, and resulting images are smaller. - Fixed some minor typo's. ## How was this patch tested? - I visually checked github - I ran mkdocs serve and mkdocs build. ## Did this PR include necessary documentation updates? - No, this PR does not affect any public API so no need to change the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SEDONA-541] Allow concurrent snowflake testers: PR 2/2 [sedona]
jiayuasu opened a new pull request, #1358: URL: https://github.com/apache/sedona/pull/1358 ## Did you read the Contributor Guide? - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/) ## Is this PR related to a JIRA ticket? - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-541. The PR name follows the format `[SEDONA-541] my subject`. ## What changes were proposed in this PR? Make sure the snowclient no longer fetch db name from env ## How was this patch tested? Passed local tests ## Did this PR include necessary documentation updates? - No, this PR does not affect any public API so no need to change the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SEDONA-540] Fix failed ST_Buffer and ST_Snap Snowflake tests [sedona]
jiayuasu merged PR #1356: URL: https://github.com/apache/sedona/pull/1356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SEDONA-541] Allow concurrent snowflake testers [sedona]
jiayuasu merged PR #1357: URL: https://github.com/apache/sedona/pull/1357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SEDONA-541] Allow concurrent snowflake testers [sedona]
jiayuasu opened a new pull request, #1357: URL: https://github.com/apache/sedona/pull/1357 ## Did you read the Contributor Guide? - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/) ## Is this PR related to a JIRA ticket? - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-541. The PR name follows the format `[SEDONA-541] my subject`. ## What changes were proposed in this PR? Use a random string as the snowflake db name to allow concurrent testing ## How was this patch tested? Passed local tests ## Did this PR include necessary documentation updates? - No, this PR does not affect any public API so no need to change the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SEDONA-540] Fix failed ST_Buffer and ST_Snap Snowflake tests [sedona]
jiayuasu opened a new pull request, #1356: URL: https://github.com/apache/sedona/pull/1356 ## Did you read the Contributor Guide? - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/) ## Is this PR related to a JIRA ticket? - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-540. The PR name follows the format `[SEDONA-540] my subject`. ## What changes were proposed in this PR? Fixed the failed ST_Buffer and ST_Snap Snowflake tests ## How was this patch tested? Passed local tests ## Did this PR include necessary documentation updates? - No, this PR does not affect any public API so no need to change the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SEDONA-541) Allow concurrent snowflake testers
Jia Yu created SEDONA-541: - Summary: Allow concurrent snowflake testers Key: SEDONA-541 URL: https://issues.apache.org/jira/browse/SEDONA-541 Project: Apache Sedona Issue Type: New Feature Reporter: Jia Yu The current snowflake tester always uses the same snowflake db name which makes it impossible to have multiple concurrent testers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SEDONA-540) Fix failed ST_Buffer and ST_Snap Snowflake tests
Jia Yu created SEDONA-540: - Summary: Fix failed ST_Buffer and ST_Snap Snowflake tests Key: SEDONA-540 URL: https://issues.apache.org/jira/browse/SEDONA-540 Project: Apache Sedona Issue Type: Bug Reporter: Jia Yu See: https://github.com/wherobots/sedona-snowflake-tester/actions/runs/8795435059 -- This message was sent by Atlassian Jira (v8.20.10#820010)
