jiayuasu commented on code in PR #607:
URL: https://github.com/apache/incubator-sedona/pull/607#discussion_r962039035
##
sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/geoparquet/ParquetFileFormat.scala:
##
@@ -0,0 +1,545 @@
+/*
Review Comment:
@neontty My understanding is that the merged PR in Sedona already uses
Datasource v2 as Spark Parquet reader is using it. But Spark parquet reader is
designed in a way that most critical functions are private, so we have to copy
lots of their code for adding a few changes on our own.
The version that supports Spark 3.3 only is here:
https://github.com/ashar236/incubator-sedona/tree/geoparquet-spark3.3/sql/src/main/scala/org/apache/spark/sql/execution/datasources/parquet
In short, I believe your geoparquet predicate pushdown function will Not be
invalidated. But I would suggest that please minimize your change to the
codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org