Re: Review Request 47640: SENTRY-1260: ArrayIndexOutOfBoundsException in PathsUpdate.parsePath can cause MetastoreCacheInitializer startup to fail

[Hao Hao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47640/#review142453
---


Fix it, then Ship it!




Thanks Sravya! +1 with minor comments.


sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestMetastoreCacheInitializer.java
 


We are testing retry here. It would be good to configure retry time as 2.



sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestMetastoreCacheInitializer.java
 (line 195)


"malformed paths" instead of "wrong location"?



sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestMetastoreCacheInitializer.java
 (line 224)


same here


- Hao Hao


On May 24, 2016, 8:49 p.m., Sravya Tirukkovalur wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47640/
> ---
> 
> (Updated May 24, 2016, 8:49 p.m.)
> 
> 
> Review request for sentry, Hao Hao and Lenni Kuff.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> We should handle this gracefully. Instead of just throwing 
> ArrayIndexOutOfBound, logging the path would be helpful
> 
> 
> Diffs
> -
> 
>   
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java
>  5985756e910ee26dec026587bc78a6523db617ae 
>   
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/SentryMalformedPathException.java
>  PRE-CREATION 
>   
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestPathsUpdate.java
>  71618ab1b18c59c1400787c823cc0c40dde31fcb 
>   
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestUpdateableAuthzPaths.java
>  909ff3a7c6ae2f6f49e7f40d3e4e75912e687a08 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java
>  807e4e0fbc10e00dbc716be2befe66795d4936a7 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java
>  f37596df0d00c9be39e95695dbafde088ad474cb 
>   
> sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestMetastoreCacheInitializer.java
>  9e6072df23ca404cd500a940a1035dfdc03d6928 
> 
> Diff: https://reviews.apache.org/r/47640/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Sravya Tirukkovalur
> 
>

Re: Review Request 47640: SENTRY-1260: ArrayIndexOutOfBoundsException in PathsUpdate.parsePath can cause MetastoreCacheInitializer startup to fail

[Sravya Tirukkovalur]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47640/
---

(Updated May 24, 2016, 8:49 p.m.)


Review request for sentry, Hao Hao and Lenni Kuff.


Changes
---

Fixed failed tests


Repository: sentry


Description
---

We should handle this gracefully. Instead of just throwing 
ArrayIndexOutOfBound, logging the path would be helpful


Diffs (updated)
-

  
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java
 5985756e910ee26dec026587bc78a6523db617ae 
  
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/SentryMalformedPathException.java
 PRE-CREATION 
  
sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestPathsUpdate.java
 71618ab1b18c59c1400787c823cc0c40dde31fcb 
  
sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestUpdateableAuthzPaths.java
 909ff3a7c6ae2f6f49e7f40d3e4e75912e687a08 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java
 807e4e0fbc10e00dbc716be2befe66795d4936a7 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java
 f37596df0d00c9be39e95695dbafde088ad474cb 
  
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestMetastoreCacheInitializer.java
 9e6072df23ca404cd500a940a1035dfdc03d6928 

Diff: https://reviews.apache.org/r/47640/diff/


Testing
---

Added tests.


Thanks,

Sravya Tirukkovalur