Re: Review Request 54525: SENTRY-1541/SENTRY-1582: Additional comments to clarify the intent of string manipulation methods in SentryStore.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review160430 --- Ship it! Ship It! - Alexander Kolbasov On Jan. 3, 2017, 8:15 p.m., Vamsee Yarlagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54525/ > --- > > (Updated Jan. 3, 2017, 8:15 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar > kalvagadda. > > > Repository: sentry > > > Description > --- > > Provides more information on why some of the string conversions are required > in SentryStore.java > > > Diffs > - > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 868e67720196f443cd281ec4e80ad552bf86e569 > > Diff: https://reviews.apache.org/r/54525/diff/ > > > Testing > --- > > ```bash > vamsee-MBP:sentry-service-server vamsee$ mvn clean test > -Dtest=TestSentryStore -DfailIfNoTests=false > ... > --- > T E S T S > --- > Running org.apache.sentry.provider.db.service.persistent.TestSentryStore > 2016-12-08 00:08:59.772 java[5207:544535] Unable to load realm info from > SCDynamicStore > Tests run: 41, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 18.302 sec - > in org.apache.sentry.provider.db.service.persistent.TestSentryStore > > Results : > > Tests run: 41, Failures: 0, Errors: 0, Skipped: 2 > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 44.421s > [INFO] Finished at: Thu Dec 08 00:09:18 PST 2016 > [INFO] Final Memory: 67M/687M > [INFO] > > ``` > > > Thanks, > > Vamsee Yarlagadda > >
Re: Review Request 54525: SENTRY-1541/SENTRY-1582: Additional comments to clarify the intent of string manipulation methods in SentryStore.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Jan. 3, 2017, 8:02 p.m.) Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar kalvagadda. Changes --- Addressed Sasha's comments. Repository: sentry Description --- Provides more information on why some of the string conversions are required in SentryStore.java Diffs (updated) - sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 868e67720196f443cd281ec4e80ad552bf86e569 Diff: https://reviews.apache.org/r/54525/diff/ Testing --- ```bash vamsee-MBP:sentry-service-server vamsee$ mvn clean test -Dtest=TestSentryStore -DfailIfNoTests=false ... --- T E S T S --- Running org.apache.sentry.provider.db.service.persistent.TestSentryStore 2016-12-08 00:08:59.772 java[5207:544535] Unable to load realm info from SCDynamicStore Tests run: 41, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 18.302 sec - in org.apache.sentry.provider.db.service.persistent.TestSentryStore Results : Tests run: 41, Failures: 0, Errors: 0, Skipped: 2 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 44.421s [INFO] Finished at: Thu Dec 08 00:09:18 PST 2016 [INFO] Final Memory: 67M/687M [INFO] ``` Thanks, Vamsee Yarlagadda
Re: Review Request 54525: SENTRY-1541/SENTRY-1582: Additional comments to clarify the intent of string manipulation methods in SentryStore.java
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Jan. 3, 2017, 7:46 p.m.) Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar kalvagadda. Summary (updated) - SENTRY-1541/SENTRY-1582: Additional comments to clarify the intent of string manipulation methods in SentryStore.java Repository: sentry Description --- Provides more information on why some of the string conversions are required in SentryStore.java Diffs - sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 868e67720196f443cd281ec4e80ad552bf86e569 Diff: https://reviews.apache.org/r/54525/diff/ Testing --- ```bash vamsee-MBP:sentry-service-server vamsee$ mvn clean test -Dtest=TestSentryStore -DfailIfNoTests=false ... --- T E S T S --- Running org.apache.sentry.provider.db.service.persistent.TestSentryStore 2016-12-08 00:08:59.772 java[5207:544535] Unable to load realm info from SCDynamicStore Tests run: 41, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 18.302 sec - in org.apache.sentry.provider.db.service.persistent.TestSentryStore Results : Tests run: 41, Failures: 0, Errors: 0, Skipped: 2 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 44.421s [INFO] Finished at: Thu Dec 08 00:09:18 PST 2016 [INFO] Final Memory: 67M/687M [INFO] ``` Thanks, Vamsee Yarlagadda
