Re: Review Request 63704: SENTRY-1662 Constants java uses mutable collection

2017-11-09 Thread Alexander Kolbasov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63704/#review190635
---


Ship it!




Ship It!

- Alexander Kolbasov


On Nov. 9, 2017, 7:32 p.m., Steve Moist wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63704/
> ---
> 
> (Updated Nov. 9, 2017, 7:32 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-1662
> https://issues.apache.org/jira/browse/SENTRY-1662
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Changes the hash maps to be unmodifable maps.
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
>  2e71ce02 
> 
> 
> Diff: https://reviews.apache.org/r/63704/diff/2/
> 
> 
> Testing
> ---
> 
> Unit tests ran.
> 
> 
> Thanks,
> 
> Steve Moist
> 
>



Re: Review Request 63704: SENTRY-1662 Constants java uses mutable collection

2017-11-09 Thread Steve Moist via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63704/
---

(Updated Nov. 9, 2017, 7:32 p.m.)


Review request for sentry.


Bugs: SENTRY-1662
https://issues.apache.org/jira/browse/SENTRY-1662


Repository: sentry


Description
---

Changes the hash maps to be unmodifable maps.


Diffs (updated)
-

  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
 2e71ce02 


Diff: https://reviews.apache.org/r/63704/diff/2/

Changes: https://reviews.apache.org/r/63704/diff/1-2/


Testing
---

Unit tests ran.


Thanks,

Steve Moist