Re: Review Request 64392: SENTRY-2092: Drop Role log message shows Creating role

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64392/#review193061
---


Ship it!




Ship It!

- kalyan kumar kalvagadda


On Dec. 6, 2017, 11:42 p.m., Na Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64392/
> ---
> 
> (Updated Dec. 6, 2017, 11:42 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> fix the typo in log messages
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java
>  fed483f 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java
>  0f93b42 
> 
> 
> Diff: https://reviews.apache.org/r/64392/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Na Li
> 
>

Re: Review Request 64392: SENTRY-2092: Drop Role log message shows Creating role

[Alexander Kolbasov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64392/#review193060
---


Ship it!




Ship It!

- Alexander Kolbasov


On Dec. 6, 2017, 11:42 p.m., Na Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64392/
> ---
> 
> (Updated Dec. 6, 2017, 11:42 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> fix the typo in log messages
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java
>  fed483f 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java
>  0f93b42 
> 
> 
> Diff: https://reviews.apache.org/r/64392/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Na Li
> 
>

Re: Review Request 64392: SENTRY-2092: Drop Role log message shows Creating role

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64392/
---

(Updated Dec. 6, 2017, 11:42 p.m.)


Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.


Repository: sentry


Description
---

fix the typo in log messages


Diffs (updated)
-

  
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java
 fed483f 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java
 0f93b42 


Diff: https://reviews.apache.org/r/64392/diff/2/

Changes: https://reviews.apache.org/r/64392/diff/1-2/


Testing
---


Thanks,

Na Li

Re: Review Request 64392: SENTRY-2092: Drop Role log message shows Creating role

[Alexander Kolbasov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64392/#review193051
---




sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java
Line 147 (original), 147 (patched)


Change to `"Sentry failed to drop role: "`



sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java
Line 144 (original), 144 (patched)


Change to `"Sentry failed to drop role: "`


- Alexander Kolbasov


On Dec. 6, 2017, 10:20 p.m., Na Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64392/
> ---
> 
> (Updated Dec. 6, 2017, 10:20 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> fix the typo in log messages
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java
>  fed483f 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java
>  0f93b42 
> 
> 
> Diff: https://reviews.apache.org/r/64392/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Na Li
> 
>