Re: Review Request 65715: SENTRY-1720: Re-enable or remove TestHDFSIntegrationWithHA
> On Feb. 21, 2018, 6:16 p.m., Sergio Pena wrote: > > Why is the TestHDFSIntegration.java deleted? I see it has other tests in > > that class. I am not sure, if we still need it, I will resubmit the patch. - Xinran --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65715/#review197973 --- On Feb. 20, 2018, 8:37 p.m., Xinran Tinney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65715/ > --- > > (Updated Feb. 20, 2018, 8:37 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, Liam Sargent, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > The TestHDFSIntegrationWithHA test is disabled now. We need to either fix it > or remove if it is no longer applicable. > The TestHDFSIntegration test is disabled as well. > > > Diffs > - > > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 8852cbc0 > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java > 92c0693e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java > 96a2f901 > > > Diff: https://reviews.apache.org/r/65715/diff/1/ > > > Testing > --- > > mvn clean install all success > > > Thanks, > > Xinran Tinney > >
Re: Review Request 65715: SENTRY-1720: Re-enable or remove TestHDFSIntegrationWithHA
> On Feb. 21, 2018, 7:11 p.m., kalyan kumar kalvagadda wrote: > > Xinren, > > > > > > Can you hold on on this patch. I had a patch before which extends the HA > > functionality to sentry tests. That patch was not commiited because of test > > failures. > > Instead of deleteting it I would prefer fixing it to test HA. Sure, if we need to keep it, I will modify. - Xinran --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65715/#review198001 --- On Feb. 20, 2018, 8:37 p.m., Xinran Tinney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65715/ > --- > > (Updated Feb. 20, 2018, 8:37 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, Liam Sargent, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > The TestHDFSIntegrationWithHA test is disabled now. We need to either fix it > or remove if it is no longer applicable. > The TestHDFSIntegration test is disabled as well. > > > Diffs > - > > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 8852cbc0 > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java > 92c0693e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java > 96a2f901 > > > Diff: https://reviews.apache.org/r/65715/diff/1/ > > > Testing > --- > > mvn clean install all success > > > Thanks, > > Xinran Tinney > >
Re: Review Request 65715: SENTRY-1720: Re-enable or remove TestHDFSIntegrationWithHA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65715/#review198001 --- Xinren, Can you hold on on this patch. I had a patch before which extends the HA functionality to sentry tests. That patch was not commiited because of test failures. Instead of deleteting it I would prefer fixing it to test HA. - kalyan kumar kalvagadda On Feb. 20, 2018, 8:37 p.m., Xinran Tinney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65715/ > --- > > (Updated Feb. 20, 2018, 8:37 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, Liam Sargent, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > The TestHDFSIntegrationWithHA test is disabled now. We need to either fix it > or remove if it is no longer applicable. > The TestHDFSIntegration test is disabled as well. > > > Diffs > - > > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 8852cbc0 > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java > 92c0693e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java > 96a2f901 > > > Diff: https://reviews.apache.org/r/65715/diff/1/ > > > Testing > --- > > mvn clean install all success > > > Thanks, > > Xinran Tinney > >
Re: Review Request 65715: SENTRY-1720: Re-enable or remove TestHDFSIntegrationWithHA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65715/#review197973 --- Why is the TestHDFSIntegration.java deleted? I see it has other tests in that class. - Sergio Pena On Feb. 20, 2018, 8:37 p.m., Xinran Tinney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65715/ > --- > > (Updated Feb. 20, 2018, 8:37 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, Liam Sargent, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > The TestHDFSIntegrationWithHA test is disabled now. We need to either fix it > or remove if it is no longer applicable. > The TestHDFSIntegration test is disabled as well. > > > Diffs > - > > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 8852cbc0 > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java > 92c0693e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java > 96a2f901 > > > Diff: https://reviews.apache.org/r/65715/diff/1/ > > > Testing > --- > > mvn clean install all success > > > Thanks, > > Xinran Tinney > >
