Re: Review Request 47012: SENTRY-1222: Improve SentryIniPolicyFileFormatter to support user section in .ini file

2016-05-06 Thread Dapeng Sun

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47012/#review131995
---


Ship it!




Ship It!

- Dapeng Sun


On 五月 5, 2016, 9:59 p.m., Colin Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47012/
> ---
> 
> (Updated 五月 5, 2016, 9:59 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Sentry support grant role to user, for the import/export with the .ini file, 
> the user section should be supported.
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/SentryIniPolicyFileFormatter.java
>  06fe1fe 
>   
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryIniPolicyFileFormatter.java
>  0e7ee3d 
>   
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/PolicyFileConstants.java
>  dfe4fe0 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java
>  a52ad8f 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java
>  2665db1 
> 
> Diff: https://reviews.apache.org/r/47012/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colin Ma
> 
>



Re: Review Request 47012: SENTRY-1222: Improve SentryIniPolicyFileFormatter to support user section in .ini file

2016-05-05 Thread Colin Ma

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47012/
---

(Updated May 5, 2016, 1:59 p.m.)


Review request for sentry.


Repository: sentry


Description
---

Sentry support grant role to user, for the import/export with the .ini file, 
the user section should be supported.


Diffs (updated)
-

  
sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/SentryIniPolicyFileFormatter.java
 06fe1fe 
  
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryIniPolicyFileFormatter.java
 0e7ee3d 
  
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/PolicyFileConstants.java
 dfe4fe0 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java
 a52ad8f 
  
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java
 2665db1 

Diff: https://reviews.apache.org/r/47012/diff/


Testing
---


Thanks,

Colin Ma



Review Request 47012: SENTRY-1222: Improve SentryIniPolicyFileFormatter to support user section in .ini file

2016-05-05 Thread Colin Ma

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47012/
---

Review request for sentry.


Repository: sentry


Description
---

Sentry support grant role to user, for the import/export with the .ini file, 
the user section should be supported.


Diffs
-

  
sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/SentryIniPolicyFileFormatter.java
 06fe1fe 
  
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryIniPolicyFileFormatter.java
 0e7ee3d 

Diff: https://reviews.apache.org/r/47012/diff/


Testing
---


Thanks,

Colin Ma