Re: Review Request 66480: SENTRY-2140: Static Attribute Ingestion

2018-04-16 Thread Xinran Tinney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66480/#review201210
---



Is SENTRY-2140 titled: Attribute based access control?

- Xinran Tinney


On April 5, 2018, 9:20 p.m., Liam Sargent wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66480/
> ---
> 
> (Updated April 5, 2018, 9:20 p.m.)
> 
> 
> Review request for sentry, Na Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2189
> https://issues.apache.org/jira/browse/SENTRY-2189
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> - Example configuration file: example-definition.json
> - Attribute: plain old java object for string attribute.
> - Object: plain old java object for fully qualified sentry object.
> - AttributeMap: Bidirectional map type for quick lookup between Attribute -> 
> Object, Object -> Attribute.
> - AttributeMapAdapter: JSON deserializer for file-based attribute ingestion.
> 
> 
> Diffs
> -
> 
>   pom.xml 61e0f970017aa8ddf38a59c7c1334fadb97abe40 
>   sentry-abac/example-definition.json PRE-CREATION 
>   sentry-abac/example-delta.json PRE-CREATION 
>   sentry-abac/notes.txt PRE-CREATION 
>   sentry-abac/pom.xml PRE-CREATION 
>   sentry-abac/src/main/java/org/apache/sentry/abac/Attribute.java 
> PRE-CREATION 
>   sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMap.java 
> PRE-CREATION 
>   sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMapAdapter.java 
> PRE-CREATION 
>   
> sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMapKeyException.java
>  PRE-CREATION 
>   
> sentry-abac/src/main/java/org/apache/sentry/abac/GenericAttributeProvider.java
>  PRE-CREATION 
>   sentry-abac/src/main/java/org/apache/sentry/abac/SentryObject.java 
> PRE-CREATION 
>   
> sentry-abac/src/main/java/org/apache/sentry/abac/StaticAttributeProvider.java 
> PRE-CREATION 
>   sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttribute.java 
> PRE-CREATION 
>   
> sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java 
> PRE-CREATION 
>   
> sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestStaticProvider.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66480/diff/1/
> 
> 
> Testing
> ---
> 
> - Unittests for all useful functions.
> 
> 
> Thanks,
> 
> Liam Sargent
> 
>

Re: Review Request 66480: SENTRY-2140: Static Attribute Ingestion

2018-04-06 Thread Steve Moist via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66480/#review200653
---




sentry-abac/notes.txt
Lines 23 (patched)


Remove this.



sentry-abac/src/main/java/org/apache/sentry/abac/Attribute.java
Lines 27 (patched)


Remove navigator mentions.



sentry-abac/src/main/java/org/apache/sentry/abac/StaticAttributeProvider.java
Lines 81 (patched)


Deal with the different exception cases here.

File exists but not correct permissions.



sentry-abac/src/main/java/org/apache/sentry/abac/StaticAttributeProvider.java
Lines 82 (patched)


Again convert to FileUtils read into string.



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java
Lines 331 (patched)


Add if exists?



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java
Lines 333 (patched)


Again convert to FileUtils.



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java
Lines 362 (patched)


Use logger



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java
Lines 371 (patched)


Convert to FileUtils. readFileToString



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java
Lines 377 (patched)


Conver to logger.info/debug



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestStaticProvider.java
Lines 69 (patched)


File Utils


- Steve Moist


On April 5, 2018, 9:20 p.m., Liam Sargent wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66480/
> ---
> 
> (Updated April 5, 2018, 9:20 p.m.)
> 
> 
> Review request for sentry, Na Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2189
> https://issues.apache.org/jira/browse/SENTRY-2189
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> - Example configuration file: example-definition.json
> - Attribute: plain old java object for string attribute.
> - Object: plain old java object for fully qualified sentry object.
> - AttributeMap: Bidirectional map type for quick lookup between Attribute -> 
> Object, Object -> Attribute.
> - AttributeMapAdapter: JSON deserializer for file-based attribute ingestion.
> 
> 
> Diffs
> -
> 
>   pom.xml 61e0f970017aa8ddf38a59c7c1334fadb97abe40 
>   sentry-abac/example-definition.json PRE-CREATION 
>   sentry-abac/example-delta.json PRE-CREATION 
>   sentry-abac/notes.txt PRE-CREATION 
>   sentry-abac/pom.xml PRE-CREATION 
>   sentry-abac/src/main/java/org/apache/sentry/abac/Attribute.java 
> PRE-CREATION 
>   sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMap.java 
> PRE-CREATION 
>   sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMapAdapter.java 
> PRE-CREATION 
>   
> sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMapKeyException.java
>  PRE-CREATION 
>   
> sentry-abac/src/main/java/org/apache/sentry/abac/GenericAttributeProvider.java
>  PRE-CREATION 
>   sentry-abac/src/main/java/org/apache/sentry/abac/SentryObject.java 
> PRE-CREATION 
>   
> sentry-abac/src/main/java/org/apache/sentry/abac/StaticAttributeProvider.java 
> PRE-CREATION 
>   sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttribute.java 
> PRE-CREATION 
>   
> sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java 
> PRE-CREATION 
>   
> sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestStaticProvider.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66480/diff/1/
> 
> 
> Testing
> ---
> 
> - Unittests for all useful functions.
> 
> 
> Thanks,
> 
> Liam Sargent
> 
>

Review Request 66480: SENTRY-2140: Static Attribute Ingestion

2018-04-05 Thread Liam Sargent via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66480/
---

Review request for sentry, Na Li, Steve Moist, and Sergio Pena.


Bugs: SENTRY-2189
https://issues.apache.org/jira/browse/SENTRY-2189


Repository: sentry


Description
---

- Example configuration file: example-definition.json
- Attribute: plain old java object for string attribute.
- Object: plain old java object for fully qualified sentry object.
- AttributeMap: Bidirectional map type for quick lookup between Attribute -> 
Object, Object -> Attribute.
- AttributeMapAdapter: JSON deserializer for file-based attribute ingestion.
- Unittests for all useful functions.


Diffs
-

  pom.xml 61e0f970017aa8ddf38a59c7c1334fadb97abe40 
  sentry-abac/example-definition.json PRE-CREATION 
  sentry-abac/example-delta.json PRE-CREATION 
  sentry-abac/notes.txt PRE-CREATION 
  sentry-abac/pom.xml PRE-CREATION 
  sentry-abac/src/main/java/org/apache/sentry/abac/Attribute.java PRE-CREATION 
  sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMap.java 
PRE-CREATION 
  sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMapAdapter.java 
PRE-CREATION 
  
sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMapKeyException.java 
PRE-CREATION 
  
sentry-abac/src/main/java/org/apache/sentry/abac/GenericAttributeProvider.java 
PRE-CREATION 
  sentry-abac/src/main/java/org/apache/sentry/abac/SentryObject.java 
PRE-CREATION 
  sentry-abac/src/main/java/org/apache/sentry/abac/StaticAttributeProvider.java 
PRE-CREATION 
  sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttribute.java 
PRE-CREATION 
  sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java 
PRE-CREATION 
  
sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestStaticProvider.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/66480/diff/1/


Testing
---


Thanks,

Liam Sargent