[jira] [Closed] (SERF-170) Support VS 2015
[ https://issues.apache.org/jira/browse/SERF-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov closed SERF-170. > Support VS 2015 > --- > > Key: SERF-170 > URL: https://issues.apache.org/jira/browse/SERF-170 > Project: serf > Issue Type: Bug >Reporter: Serf Importer >Priority: Major > Labels: Priority-Medium, Type-Defect > Fix For: serf-1.3.9 > > > Building serf using VS 2015 and setting MSVC_VERSION to 14.0 currently > doesn't work. > Testing by modifying SConstruct and adding 14.0 to the list of allowed values > for MSVC_VERSION I was able to successfully build Serf 1.3.8. > Original issue reported by *luke1...@gmx.de* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SERF-167) Calling AcquireCredentialsHandle using unicode strings
[ https://issues.apache.org/jira/browse/SERF-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov updated SERF-167: - Fix Version/s: serf-1.3.9 > Calling AcquireCredentialsHandle using unicode strings > -- > > Key: SERF-167 > URL: https://issues.apache.org/jira/browse/SERF-167 > Project: serf > Issue Type: Bug >Reporter: Serf Importer >Priority: Major > Labels: Priority-Medium, Type-Defect > Fix For: serf-1.3.9 > > > According to [1], function AcquireCredentialsHandle should be called using > unicode strings: > ' #Remarks > ' > ' [...] > ' > ' - The two string parameters must be Unicode strings. > So instead of using a regular char*, shouldn't > `serf__spnego_create_sec_context() ` use a wchar_t pointer like this: > ``` > const wchar_t* sspi_package = L"Negotiate"; /* or L"NTLM" */ > ``` > [1] > https://msdn.microsoft.com/en-us/library/windows/desktop/aa374712(v=vs.85).aspx > Original issue reported by *benjamin.woester* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SERF-167) Calling AcquireCredentialsHandle using unicode strings
[ https://issues.apache.org/jira/browse/SERF-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov resolved SERF-167. -- Resolution: Fixed > Calling AcquireCredentialsHandle using unicode strings > -- > > Key: SERF-167 > URL: https://issues.apache.org/jira/browse/SERF-167 > Project: serf > Issue Type: Bug >Reporter: Serf Importer >Priority: Major > Labels: Priority-Medium, Type-Defect > Fix For: serf-1.3.9 > > > According to [1], function AcquireCredentialsHandle should be called using > unicode strings: > ' #Remarks > ' > ' [...] > ' > ' - The two string parameters must be Unicode strings. > So instead of using a regular char*, shouldn't > `serf__spnego_create_sec_context() ` use a wchar_t pointer like this: > ``` > const wchar_t* sspi_package = L"Negotiate"; /* or L"NTLM" */ > ``` > [1] > https://msdn.microsoft.com/en-us/library/windows/desktop/aa374712(v=vs.85).aspx > Original issue reported by *benjamin.woester* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SERF-167) Calling AcquireCredentialsHandle using unicode strings
[ https://issues.apache.org/jira/browse/SERF-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov closed SERF-167. > Calling AcquireCredentialsHandle using unicode strings > -- > > Key: SERF-167 > URL: https://issues.apache.org/jira/browse/SERF-167 > Project: serf > Issue Type: Bug >Reporter: Serf Importer >Priority: Major > Labels: Priority-Medium, Type-Defect > Fix For: serf-1.3.9 > > > According to [1], function AcquireCredentialsHandle should be called using > unicode strings: > ' #Remarks > ' > ' [...] > ' > ' - The two string parameters must be Unicode strings. > So instead of using a regular char*, shouldn't > `serf__spnego_create_sec_context() ` use a wchar_t pointer like this: > ``` > const wchar_t* sspi_package = L"Negotiate"; /* or L"NTLM" */ > ``` > [1] > https://msdn.microsoft.com/en-us/library/windows/desktop/aa374712(v=vs.85).aspx > Original issue reported by *benjamin.woester* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SERF-170) Support VS 2015
[ https://issues.apache.org/jira/browse/SERF-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov resolved SERF-170. -- Fix Version/s: serf-1.3.9 Resolution: Fixed > Support VS 2015 > --- > > Key: SERF-170 > URL: https://issues.apache.org/jira/browse/SERF-170 > Project: serf > Issue Type: Bug >Reporter: Serf Importer >Priority: Major > Labels: Priority-Medium, Type-Defect > Fix For: serf-1.3.9 > > > Building serf using VS 2015 and setting MSVC_VERSION to 14.0 currently > doesn't work. > Testing by modifying SConstruct and adding 14.0 to the list of allowed values > for MSVC_VERSION I was able to successfully build Serf 1.3.8. > Original issue reported by *luke1...@gmx.de* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (SERF-170) Support VS 2015
[ https://issues.apache.org/jira/browse/SERF-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov reopened SERF-170: -- > Support VS 2015 > --- > > Key: SERF-170 > URL: https://issues.apache.org/jira/browse/SERF-170 > Project: serf > Issue Type: Bug >Reporter: Serf Importer >Priority: Major > Labels: Priority-Medium, Type-Defect > > Building serf using VS 2015 and setting MSVC_VERSION to 14.0 currently > doesn't work. > Testing by modifying SConstruct and adding 14.0 to the list of allowed values > for MSVC_VERSION I was able to successfully build Serf 1.3.8. > Original issue reported by *luke1...@gmx.de* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SERF-153) CredHandle not freed when APR pool is destroyed
[
https://issues.apache.org/jira/browse/SERF-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Zhakov closed SERF-153.
> CredHandle not freed when APR pool is destroyed
> ---
>
> Key: SERF-153
> URL: https://issues.apache.org/jira/browse/SERF-153
> Project: serf
> Issue Type: Bug
>Reporter: Michael Osipov
>Priority: Major
> Labels: Priority-Medium, Type-Defect
> Fix For: serf-1.3.9
>
>
> In auth_spnego_sspi.c from line 97
> if (SecIsValidHandle(&ctx->sspi_credentials)) {
> FreeCredentialsHandle(&ctx->sspi_context);
> SecInvalidateHandle(&ctx->sspi_context);
> }
> I guess this should read
> if (SecIsValidHandle(&ctx->sspi_credentials)) {
> FreeCredentialsHandle(&ctx->sspi_credentials);
> SecInvalidateHandle(&ctx->sspi_credentials);
> }
> Shouldn't it?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (SERF-153) CredHandle not freed when APR pool is destroyed
[
https://issues.apache.org/jira/browse/SERF-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Zhakov reopened SERF-153:
--
> CredHandle not freed when APR pool is destroyed
> ---
>
> Key: SERF-153
> URL: https://issues.apache.org/jira/browse/SERF-153
> Project: serf
> Issue Type: Bug
>Reporter: Michael Osipov
>Priority: Major
> Labels: Priority-Medium, Type-Defect
>
> In auth_spnego_sspi.c from line 97
> if (SecIsValidHandle(&ctx->sspi_credentials)) {
> FreeCredentialsHandle(&ctx->sspi_context);
> SecInvalidateHandle(&ctx->sspi_context);
> }
> I guess this should read
> if (SecIsValidHandle(&ctx->sspi_credentials)) {
> FreeCredentialsHandle(&ctx->sspi_credentials);
> SecInvalidateHandle(&ctx->sspi_credentials);
> }
> Shouldn't it?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SERF-153) CredHandle not freed when APR pool is destroyed
[
https://issues.apache.org/jira/browse/SERF-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Zhakov resolved SERF-153.
--
Fix Version/s: serf-1.3.9
Resolution: Fixed
> CredHandle not freed when APR pool is destroyed
> ---
>
> Key: SERF-153
> URL: https://issues.apache.org/jira/browse/SERF-153
> Project: serf
> Issue Type: Bug
>Reporter: Michael Osipov
>Priority: Major
> Labels: Priority-Medium, Type-Defect
> Fix For: serf-1.3.9
>
>
> In auth_spnego_sspi.c from line 97
> if (SecIsValidHandle(&ctx->sspi_credentials)) {
> FreeCredentialsHandle(&ctx->sspi_context);
> SecInvalidateHandle(&ctx->sspi_context);
> }
> I guess this should read
> if (SecIsValidHandle(&ctx->sspi_credentials)) {
> FreeCredentialsHandle(&ctx->sspi_credentials);
> SecInvalidateHandle(&ctx->sspi_credentials);
> }
> Shouldn't it?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (SERF-167) Calling AcquireCredentialsHandle using unicode strings
[ https://issues.apache.org/jira/browse/SERF-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov reopened SERF-167: -- > Calling AcquireCredentialsHandle using unicode strings > -- > > Key: SERF-167 > URL: https://issues.apache.org/jira/browse/SERF-167 > Project: serf > Issue Type: Bug >Reporter: Serf Importer >Priority: Major > Labels: Priority-Medium, Type-Defect > > According to [1], function AcquireCredentialsHandle should be called using > unicode strings: > ' #Remarks > ' > ' [...] > ' > ' - The two string parameters must be Unicode strings. > So instead of using a regular char*, shouldn't > `serf__spnego_create_sec_context() ` use a wchar_t pointer like this: > ``` > const wchar_t* sspi_package = L"Negotiate"; /* or L"NTLM" */ > ``` > [1] > https://msdn.microsoft.com/en-us/library/windows/desktop/aa374712(v=vs.85).aspx > Original issue reported by *benjamin.woester* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SERF-151) SCons: env['LIBPATH'] sometimes is a string and that breaks RPATH
[ https://issues.apache.org/jira/browse/SERF-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov closed SERF-151. Resolution: Fixed > SCons: env['LIBPATH'] sometimes is a string and that breaks RPATH > - > > Key: SERF-151 > URL: https://issues.apache.org/jira/browse/SERF-151 > Project: serf > Issue Type: Bug >Reporter: Serf Importer >Priority: Major > Labels: Priority-Medium, Type-Defect > Fix For: serf-1.3.9 > > > Per 'man scons': >env.Append(key=val, [...]) >[...] If the values >of the construction variable and the keyword argument are the same > type, >then the two values will be simply added together. Otherwise, the >construction variable and the value of the keyword argument are > both coerced >to lists, and the lists are added together. (See also the Prepend > method, >below.) > The result is that under some circumstances (GSSAPI disabled, and possibly > more), LIBPATH is only modified by this single call before getting to setting > RPATH: > env.Append(LIBPATH='$OPENSSL/lib') > As a result, env['LIBPATH'] is a string and the following: > for d in env['LIBPATH']: > env.Append(RPATH=':'+d) > iterates over characters of that string rather than list elements. As a > result, RPATH ends up like '$:O:P:E:'... and that isn't really useful. > I'm attaching a patch that fixes the issue through consistently appending > lists to variables, except for RPATH. This way, SCons guarantees that the end > result will be a list and everything will work fine. > Original issue reported by *mgo...@gentoo.org* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SERF-151) SCons: env['LIBPATH'] sometimes is a string and that breaks RPATH
[ https://issues.apache.org/jira/browse/SERF-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov updated SERF-151: - Fix Version/s: serf-1.3.9 > SCons: env['LIBPATH'] sometimes is a string and that breaks RPATH > - > > Key: SERF-151 > URL: https://issues.apache.org/jira/browse/SERF-151 > Project: serf > Issue Type: Bug >Reporter: Serf Importer >Priority: Major > Labels: Priority-Medium, Type-Defect > Fix For: serf-1.3.9 > > > Per 'man scons': >env.Append(key=val, [...]) >[...] If the values >of the construction variable and the keyword argument are the same > type, >then the two values will be simply added together. Otherwise, the >construction variable and the value of the keyword argument are > both coerced >to lists, and the lists are added together. (See also the Prepend > method, >below.) > The result is that under some circumstances (GSSAPI disabled, and possibly > more), LIBPATH is only modified by this single call before getting to setting > RPATH: > env.Append(LIBPATH='$OPENSSL/lib') > As a result, env['LIBPATH'] is a string and the following: > for d in env['LIBPATH']: > env.Append(RPATH=':'+d) > iterates over characters of that string rather than list elements. As a > result, RPATH ends up like '$:O:P:E:'... and that isn't really useful. > I'm attaching a patch that fixes the issue through consistently appending > lists to variables, except for RPATH. This way, SCons guarantees that the end > result will be a list and everything will work fine. > Original issue reported by *mgo...@gentoo.org* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (SERF-151) SCons: env['LIBPATH'] sometimes is a string and that breaks RPATH
[ https://issues.apache.org/jira/browse/SERF-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov reopened SERF-151: -- Re-open to update Fix version. > SCons: env['LIBPATH'] sometimes is a string and that breaks RPATH > - > > Key: SERF-151 > URL: https://issues.apache.org/jira/browse/SERF-151 > Project: serf > Issue Type: Bug >Reporter: Serf Importer >Priority: Major > Labels: Priority-Medium, Type-Defect > > Per 'man scons': >env.Append(key=val, [...]) >[...] If the values >of the construction variable and the keyword argument are the same > type, >then the two values will be simply added together. Otherwise, the >construction variable and the value of the keyword argument are > both coerced >to lists, and the lists are added together. (See also the Prepend > method, >below.) > The result is that under some circumstances (GSSAPI disabled, and possibly > more), LIBPATH is only modified by this single call before getting to setting > RPATH: > env.Append(LIBPATH='$OPENSSL/lib') > As a result, env['LIBPATH'] is a string and the following: > for d in env['LIBPATH']: > env.Append(RPATH=':'+d) > iterates over characters of that string rather than list elements. As a > result, RPATH ends up like '$:O:P:E:'... and that isn't really useful. > I'm attaching a patch that fixes the issue through consistently appending > lists to variables, except for RPATH. This way, SCons guarantees that the end > result will be a list and everything will work fine. > Original issue reported by *mgo...@gentoo.org* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SERF-203) 1.3.9 is a stable release
[ https://issues.apache.org/jira/browse/SERF-203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zhakov resolved SERF-203. -- Resolution: Fixed Fixed. Thanks. > 1.3.9 is a stable release > - > > Key: SERF-203 > URL: https://issues.apache.org/jira/browse/SERF-203 > Project: serf > Issue Type: Bug >Affects Versions: serf-1.3.9 >Reporter: Ryan Schmidt >Priority: Trivial > > In this issue tracker's "Affects Version/s" and "Fix Version/s" menus, > "serf-1.3.9" is listed as an unreleased version. It was released in 2016. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SERF-173) serf_get crashes with segmentation fault on two requests and concurrent connections with SPNEGO auth
[
https://issues.apache.org/jira/browse/SERF-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791116#comment-14791116
]
Ivan Zhakov commented on SERF-173:
--
Yes, they are only exists on trunk. I'm not sure that such change can be
merged. But I'm pretty sure that 1.3.8 us also crashing. The bug was introduced
in Serf 1.3.4 if I remember correctly.
> serf_get crashes with segmentation fault on two requests and concurrent
> connections with SPNEGO auth
>
>
> Key: SERF-173
> URL: https://issues.apache.org/jira/browse/SERF-173
> Project: serf
> Issue Type: Bug
>Reporter: Michael Osipov
> Labels: Priority-Medium, Type-Defect
>
> Using FreeBSD 9.3-STABLE, Serf trunk@2500, MIT Kerberos 1.13.2.
> Calling {{./serf_get -d -c 2 -n 2 http://...}} gives me "Segmentation fault:
> 11 (Speicherabzug geschrieben)"
> Serf has been compiled with debug options, full logs, GDB stracktrace and
> core file can be send privately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SERF-173) serf_get crashes with segmentation fault on two requests and concurrent connections with SPNEGO auth
[
https://issues.apache.org/jira/browse/SERF-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727056#comment-14727056
]
Ivan Zhakov edited comment on SERF-173 at 9/16/15 9:00 PM:
---
I've added these options to trunk to reproduce this issue.
was (Author: ivan.z):
I've added these options to reproduce this issue.
> serf_get crashes with segmentation fault on two requests and concurrent
> connections with SPNEGO auth
>
>
> Key: SERF-173
> URL: https://issues.apache.org/jira/browse/SERF-173
> Project: serf
> Issue Type: Bug
>Reporter: Michael Osipov
> Labels: Priority-Medium, Type-Defect
>
> Using FreeBSD 9.3-STABLE, Serf trunk@2500, MIT Kerberos 1.13.2.
> Calling {{./serf_get -d -c 2 -n 2 http://...}} gives me "Segmentation fault:
> 11 (Speicherabzug geschrieben)"
> Serf has been compiled with debug options, full logs, GDB stracktrace and
> core file can be send privately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SERF-173) serf_get crashes with segmentation fault on two requests and concurrent connections with SPNEGO auth
[
https://issues.apache.org/jira/browse/SERF-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727056#comment-14727056
]
Ivan Zhakov commented on SERF-173:
--
I've added these options to reproduce this issue.
> serf_get crashes with segmentation fault on two requests and concurrent
> connections with SPNEGO auth
>
>
> Key: SERF-173
> URL: https://issues.apache.org/jira/browse/SERF-173
> Project: serf
> Issue Type: Bug
>Reporter: Michael Osipov
> Labels: Priority-Medium, Type-Defect
>
> Using FreeBSD 9.3-STABLE, Serf trunk@2500, MIT Kerberos 1.13.2.
> Calling {{./serf_get -d -c 2 -n 2 http://...}} gives me "Segmentation fault:
> 11 (Speicherabzug geschrieben)"
> Serf has been compiled with debug options, full logs, GDB stracktrace and
> core file can be send privately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SERF-173) serf_get crashes with segmentation fault on two requests and concurrent connections with SPNEGO auth
[
https://issues.apache.org/jira/browse/SERF-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727054#comment-14727054
]
Ivan Zhakov commented on SERF-173:
--
Subversion doesn't into this issue because it opens connections slowly
one-by-one. See libsvn_ra_serf/update.c:open_connection_if_needed():
{noformat}
/** Minimum nr. of outstanding requests needed before a new connection is
* opened. */
#define REQS_PER_CONN 8
/** This function creates a new connection for this serf session, but only
* if the number of NUM_ACTIVE_REQS > REQS_PER_CONN or if there currently is
* only one main connection open.
*/
static svn_error_t *
open_connection_if_needed(svn_ra_serf__session_t *sess, int num_active_reqs)
{
/* For each REQS_PER_CONN outstanding requests open a new connection, with
* a minimum of 1 extra connection. */
if (sess->num_conns == 1 ||
((num_active_reqs / REQS_PER_CONN) > sess->num_conns))
{
int cur = sess->num_conns;
apr_status_t status;
sess->conns[cur] = apr_pcalloc(sess->pool, sizeof(*sess->conns[cur]));
sess->conns[cur]->bkt_alloc = serf_bucket_allocator_create(sess->pool,
NULL, NULL);
sess->conns[cur]->last_status_code = -1;
sess->conns[cur]->session = sess;
status = serf_connection_create2(&sess->conns[cur]->conn,
sess->context,
sess->session_url,
svn_ra_serf__conn_setup,
sess->conns[cur],
svn_ra_serf__conn_closed,
sess->conns[cur],
sess->pool);
if (status)
return svn_ra_serf__wrap_err(status, NULL);
sess->num_conns++;
}
return SVN_NO_ERROR;
}
{noformat}
> serf_get crashes with segmentation fault on two requests and concurrent
> connections with SPNEGO auth
>
>
> Key: SERF-173
> URL: https://issues.apache.org/jira/browse/SERF-173
> Project: serf
> Issue Type: Bug
>Reporter: Michael Osipov
> Labels: Priority-Medium, Type-Defect
>
> Using FreeBSD 9.3-STABLE, Serf trunk@2500, MIT Kerberos 1.13.2.
> Calling {{./serf_get -d -c 2 -n 2 http://...}} gives me "Segmentation fault:
> 11 (Speicherabzug geschrieben)"
> Serf has been compiled with debug options, full logs, GDB stracktrace and
> core file can be send privately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
