[GitHub] codecov-io commented on issue #327: SCB-469 Create a new docker file for the release
codecov-io commented on issue #327: SCB-469 Create a new docker file for the release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/327#issuecomment-380343090 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=h1) Report > Merging [#327](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ecc69573695c6b988e09c662654dd0700cc9fed8?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #327 +/- ## === Coverage 69.46% 69.46% === Files 17 17 Lines3435 3435 === Hits 2386 2386 Misses883 883 Partials 166 166 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=footer). Last update [ecc6957...0e3b896](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #327: SCB-469 Create a new docker file for the release
coveralls commented on issue #327: SCB-469 Create a new docker file for the release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/327#issuecomment-380342981 [](https://coveralls.io/builds/16454771) Coverage decreased (-0.05%) to 72.972% when pulling **0e3b896023beb4b53dd63e8f76ee4fbf5abe40f0 on asifdxtreme:master** into **ecc69573695c6b988e09c662654dd0700cc9fed8 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asifdxtreme opened a new pull request #327: SCB-469 Create a new docker file for the release
asifdxtreme opened a new pull request #327: SCB-469 Create a new docker file for the release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/327 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] little-cui closed pull request #326: SCB-473 delete service, should delete dependency key
little-cui closed pull request #326: SCB-473 delete service, should delete
dependency key
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/326
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/service/util/dependency.go
b/server/service/util/dependency.go
index 66261163..3c912564 100644
--- a/server/service/util/dependency.go
+++ b/server/service/util/dependency.go
@@ -644,6 +644,18 @@ func (dep *Dependency) addConsumerOfProviderRule() {
}
func (dep *Dependency) UpdateProvidersRuleOfConsumer(conKey string) error {
+ if len(dep.ProvidersRule) == 0 {
+ _, err := backend.Registry().Do(context.TODO(),
+ registry.DEL,
+ registry.WithStrKey(conKey),
+ )
+ if err != nil {
+ util.Logger().Errorf(nil, "Upload dependency rule
failed.")
+ return err
+ }
+ return nil
+ }
+
dependency := &pb.MicroServiceDependency{
Dependency: dep.ProvidersRule,
}
diff --git a/server/service/util/instance_util.go
b/server/service/util/instance_util.go
index 5c373a95..c45845d7 100644
--- a/server/service/util/instance_util.go
+++ b/server/service/util/instance_util.go
@@ -279,4 +279,4 @@ func UpdateInstance(ctx context.Context, domainProject
string, instance *pb.Micr
return scerr.NewError(scerr.ErrInternal, err.Error())
}
return nil
-}
\ No newline at end of file
+}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] liubao68 commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation
liubao68 commented on a change in pull request #627: [SCB-292] chassis support
standard parameter validation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r180611794
##
File path:
demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
##
@@ -147,4 +168,73 @@ private static void testRawJsonParam(RestTemplate
template, String cseUrlPrefix)
TestMgr.check("hello Tom",
template.postForObject(cseUrlPrefix + "/compute/testrawjson",
jsonPerson, String.class));
}
+
+ private static void testValidatorAddFail(RestTemplate template, String
cseUrlPrefix) {
+Map params = new HashMap<>();
+params.put("a", "5");
+params.put("b", "3");
+boolean isExcep = false;
+try {
+ template.postForObject(cseUrlPrefix + "add", params, Integer.class);
+} catch (InvocationException e) {
+ isExcep = true;
+ TestMgr.check(490, e.getStatus().getStatusCode());
+}
+
+TestMgr.check(true, isExcep);
+ }
+
+ private static void testValidatorAddSuccess(RestTemplate template, String
cseUrlPrefix) {
+Map params = new HashMap<>();
+params.put("a", "5");
+params.put("b", "20");
+int result = template.postForObject(cseUrlPrefix + "add", params,
Integer.class);
+TestMgr.check(25, result);
+ }
+
+ private static void testValidatorSayHiFail(RestTemplate template, String
cseUrlPrefix) {
+boolean isExcep = false;
+try {
+ template.exchange(cseUrlPrefix + "sayhi/{name}", HttpMethod.PUT, null,
String.class, "te");
+} catch (InvocationException e) {
+ isExcep = true;
+ TestMgr.check(490, e.getStatus().getStatusCode());
+}
+TestMgr.check(true, isExcep);
+ }
+
+ private static void testValidatorSayHiSuccess(RestTemplate template, String
cseUrlPrefix) {
+ResponseEntity responseEntity =
+template.exchange(cseUrlPrefix + "sayhi/{name}", HttpMethod.PUT, null,
String.class, "world");
+TestMgr.check(202, responseEntity.getStatusCode());
+TestMgr.check("world sayhi", responseEntity.getBody());
+ }
+
+ private static void testValidatorExchangeFail(RestTemplate template, String
cseUrlPrefix) {
+HttpHeaders headers = new HttpHeaders();
+headers.add("Accept", MediaType.APPLICATION_JSON);
+Student student = new Student();
+student.setName("");
+student.setAge(25);
+boolean isExcep = false;
+try {
+ HttpEntity requestEntity = new HttpEntity<>(student, headers);
+ template.exchange(cseUrlPrefix + "/sayhello",
+ HttpMethod.POST,
+ requestEntity,
+ Student.class);
+} catch (InvocationException e) {
+ isExcep = true;
+ TestMgr.check(490, e.getStatus().getStatusCode());
Review comment:
490 error code exposes that consumer logic got some bad encapsulation. Maybe
we need to find out the cause or leave a comment here and submit an improvement
issue to fix later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation
wujimin commented on a change in pull request #627: [SCB-292] chassis support
standard parameter validation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r180609946
##
File path:
demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
##
@@ -147,4 +168,73 @@ private static void testRawJsonParam(RestTemplate
template, String cseUrlPrefix)
TestMgr.check("hello Tom",
template.postForObject(cseUrlPrefix + "/compute/testrawjson",
jsonPerson, String.class));
}
+
+ private static void testValidatorAddFail(RestTemplate template, String
cseUrlPrefix) {
+Map params = new HashMap<>();
+params.put("a", "5");
+params.put("b", "3");
+boolean isExcep = false;
+try {
+ template.postForObject(cseUrlPrefix + "add", params, Integer.class);
+} catch (InvocationException e) {
+ isExcep = true;
+ TestMgr.check(490, e.getStatus().getStatusCode());
Review comment:
can we got the correct validate message?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #627: [SCB-292] chassis support standard parameter validation
coveralls commented on issue #627: [SCB-292] chassis support standard parameter validation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#issuecomment-377222163 [](https://coveralls.io/builds/16441087) Coverage increased (+0.4%) to 87.787% when pulling **7ea56911fc2cdd8a35fdfa28e6ebfee21585c82e on acsukesh:master** into **ae28a9faff24e773520f3452dfd80b86dfbe7aa4 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin opened a new pull request #643: [SCB-445] Delete old metrics mechanism
wujimin opened a new pull request #643: [SCB-445] Delete old metrics mechanism URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/643  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #326: [SCB-473][sc]delete service, should delete dependency key
codecov-io commented on issue #326: [SCB-473][sc]delete service, should delete dependency key URL: https://github.com/apache/incubator-servicecomb-service-center/pull/326#issuecomment-380063602 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=h1) Report > Merging [#326](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7650f35df50d5350c5ed247082dd0d37e3352bbd?src=pr&el=desc) will **decrease** coverage by `0.24%`. > The diff coverage is `88.88%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #326 +/- ## == - Coverage 69.73% 69.49% -0.25% == Files 17 17 Lines3426 3435 +9 == - Hits 2389 2387 -2 - Misses871 883 +12 + Partials 166 165 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `47.75% <ø> (ø)` | :arrow_up: | | [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `56.68% <88.88%> (-1.11%)` | :arrow_down: | | [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `68.21% <0%> (-0.18%)` | :arrow_down: | | [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `77.25% <0%> (+0.42%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=footer). Last update [7650f35...aae3f88](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #326: [SCB-473][sc]delete service, should delete dependency key
coveralls commented on issue #326: [SCB-473][sc]delete service, should delete dependency key URL: https://github.com/apache/incubator-servicecomb-service-center/pull/326#issuecomment-380063520 [](https://coveralls.io/builds/16435433) Coverage decreased (-0.3%) to 73.074% when pulling **aae3f884eb07ef2efc1be9cffd9cd640e0ba904d on aseTo2016:aseTo** into **7650f35df50d5350c5ed247082dd0d37e3352bbd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aseTo2016 opened a new pull request #326: [SCB-473][sc]delete service, should delete dependency key
aseTo2016 opened a new pull request #326: [SCB-473][sc]delete service, should delete dependency key URL: https://github.com/apache/incubator-servicecomb-service-center/pull/326 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin
coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034081 [](https://coveralls.io/builds/16434632) Coverage decreased (-0.1%) to 73.247% when pulling **8c08233fbad9dcb0f5bdf695634c12909a15305a on little-cui:master** into **7650f35df50d5350c5ed247082dd0d37e3352bbd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin
codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034141 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=h1) Report > Merging [#325](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7650f35df50d5350c5ed247082dd0d37e3352bbd?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#325 +/- ## = - Coverage 69.73% 69.7% -0.03% = Files 17 17 Lines34263426 = - Hits 23892388 -1 Misses871 871 - Partials 166 167 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `68.21% <0%> (-0.18%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=footer). Last update [7650f35...8c08233](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[java-chassis and other]About naming conventions for Microservice Name, Schema Id and Operation Id
Hi All, Background: As many features depend on these name and frequently used in yamls, environment keys, and in program parsing, like in PR: https://github.com/apache/incubator-servicecomb-java-chassis/pull/577 If name conventions is not defined, this will cause a lot of compatible issue. e.g. when PR #577 has merged, following code will not work 1. RPC define @RpcSchema() class xxx 2. RPC Referent @RpcReference(microserviceName="xx') Service s Suggestions: 1. require Microservice Name, Schema Id and Operation Id to follow the naming convention: ^[a-zA-Z]+[a-zA-Z]* 2. validate names when startup. Do not support default schemaId features, users must specify it implicitly. 3. Given errors and suggestions(e.g. operation id not valid, use @ApiOpertion to give explicit id. Any suggestions and regards.
[GitHub] codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin
codecov-io commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034141 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=h1) Report > Merging [#325](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7650f35df50d5350c5ed247082dd0d37e3352bbd?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#325 +/- ## = - Coverage 69.73% 69.7% -0.03% = Files 17 17 Lines34263426 = - Hits 23892388 -1 Misses871 871 - Partials 166 167 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `68.21% <0%> (-0.18%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=footer). Last update [7650f35...d5112c6](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin
coveralls commented on issue #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325#issuecomment-380034081 [](https://coveralls.io/builds/16433463) Coverage decreased (-0.1%) to 73.247% when pulling **d5112c677b60a11ce9409050dfb2ff9733d1612c on little-cui:master** into **7650f35df50d5350c5ed247082dd0d37e3352bbd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] little-cui opened a new pull request #325: SCB-472 Null point reference in zipkin plugin
little-cui opened a new pull request #325: SCB-472 Null point reference in zipkin plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/325 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yangbor opened a new pull request #642: [SCB-468] Add notice for vertx 3.5.1
yangbor opened a new pull request #642: [SCB-468] Add notice for vertx 3.5.1 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/642 This is related to SCB-459 which upgraded vertx to 3.5.1. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong opened a new pull request #641: add spring boot starter provider archetype
zhengyangyong opened a new pull request #641: add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- add spring boot starter provider archetype it's a part of https://issues.apache.org/jira/browse/SCB-439 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Ask for Help of ServiceComb Saga
Hi Fengzheng, Thanks for you help, I'm really appreciate that. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Tue, Apr 10, 2018 at 2:36 PM, Zheng Feng wrote: > I'm working on the acceptance tests. > > 2018-04-10 11:23 GMT+08:00 Yang Bo : > > > Hi, > > > > I'll work on the SSL support of gRPC. > > > > [1]https://issues.apache.org/jira/browse/SCB-342 > > > > On Mon, Apr 9, 2018 at 6:15 PM, 李波 wrote: > > > > > Hi, > > > > > > I will take the second issue, add a demo using pack with java chassis > > > about *transfering > > > money* (*)[1] > > > > > > [1] https://issues.apache.org/jira/browse/SCB-244 > > > > > > > > > Best Regards! > > > Li Bo > > > > > > > > > 2018-04-09 17:54 GMT+08:00 Willem Jiang : > > > > > > > Hi, > > > > > > > > There are some small tasks which are easy for the newbee to take to > > > > understand better about ServiceComb Saga. Please feel free to take if > > you > > > > like. > > > > > > > > > > > > 1. secure gPRC transport (*) [1] > > > > We need to support SSL transport for gPRC , and also need to verify > the > > > > Alpha Server's identity > > > > > > > > 2. add demo to use pack with java chassis (*) [2] > > > > Current we just have some demo of spring boot, we may need to verify > > if > > > we > > > > can interceptor the invocation of java chassis > > > > > > > > 3. compact events to remove unnecessary fields(*) [3] > > > > It can help you know more about the events between the Omega and > Alpha > > > > > > > > 4. acceptance tests related issue (**) [4][5][6] > > > > It can help you know better about the acceptance test, we need to > > update > > > > the demo to let the transaction timeout > > > > > > > > [1]https://issues.apache.org/jira/browse/SCB-342 > > > > [2]https://issues.apache.org/jira/browse/SCB-244 > > > > [3]https://issues.apache.org/jira/browse/SCB-268 > > > > [4]https://issues.apache.org/jira/browse/SCB-301 > > > > [5]https://issues.apache.org/jira/browse/SCB-302 > > > > [6]https://issues.apache.org/jira/browse/SCB-303 > > > > > > > > > > > > Willem Jiang > > > > > > > > Blog: http://willemjiang.blogspot.com (English) > > > > http://jnn.iteye.com (Chinese) > > > > Twitter: willemjiang > > > > Weibo: 姜宁willem > > > > > > > > > > > > > > > -- > > Best Regards, > > Yang. > > >
[GitHub] wujimin closed pull request #639: [SCB-422] prometheus switch to new mechanism
wujimin closed pull request #639: [SCB-422] prometheus switch to new mechanism
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/639
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
index fa53abc16..da0765dce 100644
---
a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
+++
b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
@@ -109,13 +109,13 @@ public static void run() {
try {
String content =
restTemplate.getForObject("cse://springmvc/codeFirstSpringmvc/prometheusForTest",
String.class);
- TestMgr.check(true,
content.contains("servicecomb_invocation_springmvc_codeFirst_addDate"));
- TestMgr.check(true,
content.contains("servicecomb_invocation_springmvc_codeFirst_sayHello"));
- TestMgr.check(true,
content.contains("servicecomb_invocation_springmvc_codeFirst_fallbackFromCache"));
- TestMgr.check(true,
content.contains("servicecomb_invocation_springmvc_codeFirst_isTrue"));
- TestMgr.check(true,
content.contains("servicecomb_invocation_springmvc_codeFirst_add"));
- TestMgr.check(true,
content.contains("servicecomb_invocation_springmvc_codeFirst_sayHi2"));
- TestMgr.check(true,
content.contains("servicecomb_invocation_springmvc_codeFirst_saySomething"));
+ TestMgr.check(true,
content.contains("servicecomb_invocation{operation=\"springmvc.codeFirst.addDate"));
+ TestMgr.check(true,
content.contains("servicecomb_invocation{operation=\"springmvc.codeFirst.sayHello"));
+ TestMgr.check(true,
content.contains("servicecomb_invocation{operation=\"springmvc.codeFirst.fallbackFromCache"));
+ TestMgr.check(true,
content.contains("servicecomb_invocation{operation=\"springmvc.codeFirst.isTrue"));
+ TestMgr.check(true,
content.contains("servicecomb_invocation{operation=\"springmvc.codeFirst.add"));
+ TestMgr.check(true,
content.contains("servicecomb_invocation{operation=\"springmvc.codeFirst.sayHi2"));
+ TestMgr.check(true,
content.contains("servicecomb_invocation{operation=\"springmvc.codeFirst.saySomething"));
String[] metricLines = content.split("\n");
if (metricLines.length > 0) {
diff --git a/metrics/metrics-integration/metrics-prometheus/pom.xml
b/metrics/metrics-integration/metrics-prometheus/pom.xml
index dcaeb646d..3def8e768 100644
--- a/metrics/metrics-integration/metrics-prometheus/pom.xml
+++ b/metrics/metrics-integration/metrics-prometheus/pom.xml
@@ -16,8 +16,7 @@
~ limitations under the License.
-->
-http://maven.apache.org/POM/4.0.0";
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
metrics-integration
@@ -43,7 +42,10 @@
org.apache.servicecomb
metrics-core
-
+
+ org.apache.servicecomb
+ foundation-test-scaffolding
+
\ No newline at end of file
diff --git
a/metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/MetricsCollector.java
b/metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/MetricsCollector.java
deleted file mode 100644
index a99cce4c3..0
---
a/metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/MetricsCollector.java
+++ /dev/null
@@ -1,76 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.servicecomb.metrics.prometheus;
-
-import java.util.ArrayList
Re: Ask for Help of ServiceComb Saga
Hi YangBo， You can ask Wushen for help, as he just finish the work in the Skywalking side. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Tue, Apr 10, 2018 at 11:23 AM, Yang Bo wrote: > Hi, > > I'll work on the SSL support of gRPC. > > [1]https://issues.apache.org/jira/browse/SCB-342 > > On Mon, Apr 9, 2018 at 6:15 PM, 李波 wrote: > > > Hi, > > > > I will take the second issue, add a demo using pack with java chassis > > about *transfering > > money* (*)[1] > > > > [1] https://issues.apache.org/jira/browse/SCB-244 > > > > > > Best Regards! > > Li Bo > > > > > > 2018-04-09 17:54 GMT+08:00 Willem Jiang : > > > > > Hi, > > > > > > There are some small tasks which are easy for the newbee to take to > > > understand better about ServiceComb Saga. Please feel free to take if > you > > > like. > > > > > > > > > 1. secure gPRC transport (*) [1] > > > We need to support SSL transport for gPRC , and also need to verify the > > > Alpha Server's identity > > > > > > 2. add demo to use pack with java chassis (*) [2] > > > Current we just have some demo of spring boot, we may need to verify > if > > we > > > can interceptor the invocation of java chassis > > > > > > 3. compact events to remove unnecessary fields(*) [3] > > > It can help you know more about the events between the Omega and Alpha > > > > > > 4. acceptance tests related issue (**) [4][5][6] > > > It can help you know better about the acceptance test, we need to > update > > > the demo to let the transaction timeout > > > > > > [1]https://issues.apache.org/jira/browse/SCB-342 > > > [2]https://issues.apache.org/jira/browse/SCB-244 > > > [3]https://issues.apache.org/jira/browse/SCB-268 > > > [4]https://issues.apache.org/jira/browse/SCB-301 > > > [5]https://issues.apache.org/jira/browse/SCB-302 > > > [6]https://issues.apache.org/jira/browse/SCB-303 > > > > > > > > > Willem Jiang > > > > > > Blog: http://willemjiang.blogspot.com (English) > > > http://jnn.iteye.com (Chinese) > > > Twitter: willemjiang > > > Weibo: 姜宁willem > > > > > > > > > -- > Best Regards, > Yang. >
[GitHub] WillemJiang commented on a change in pull request #639: [SCB-422] prometheus switch to new mechanism
WillemJiang commented on a change in pull request #639: [SCB-422] prometheus
switch to new mechanism
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/639#discussion_r180329100
##
File path:
metrics/metrics-integration/metrics-prometheus/src/test/java/org/apache/servicecomb/metrics/prometheus/TestPrometheusPublisher.java
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.metrics.prometheus;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.HttpURLConnection;
+import java.net.URL;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.reflect.FieldUtils;
+import
org.apache.servicecomb.foundation.common.exceptions.ServiceCombException;
+import org.apache.servicecomb.foundation.test.scaffolding.config.ArchaiusUtils;
+import org.junit.AfterClass;
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+import com.netflix.spectator.api.CompositeRegistry;
+import com.netflix.spectator.api.Counter;
+import com.netflix.spectator.api.DefaultRegistry;
+import com.netflix.spectator.api.ManualClock;
+import com.netflix.spectator.api.Registry;
+import com.netflix.spectator.api.SpectatorUtils;
+import com.sun.net.httpserver.HttpServer;
+
+import io.prometheus.client.exporter.HTTPServer;
+
+@SuppressWarnings("restriction")
+public class TestPrometheusPublisher {
+ CompositeRegistry globalRegistry =
SpectatorUtils.createCompositeRegistry(new ManualClock());
+
+ PrometheusPublisher publisher = new PrometheusPublisher();
+
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ @AfterClass
+ public static void teardown() {
+ArchaiusUtils.resetConfig();
+ }
+
+ @Test
+ public void testBadPublishAddress() {
+thrown.expect(ServiceCombException.class);
+
+ArchaiusUtils.setProperty(PrometheusPublisher.METRICS_PROMETHEUS_ADDRESS,
"a:b:c");
+publisher.init(globalRegistry, null, null);
+ }
+
+ @Test
+ public void testBadPublishAddress_BadPort() {
+thrown.expect(ServiceCombException.class);
+
+ArchaiusUtils.setProperty(PrometheusPublisher.METRICS_PROMETHEUS_ADDRESS,
"localhost:");
+publisher.init(globalRegistry, null, null);
+ }
+
+ @Test
+ public void testBadPublishAddress_TooLargePort() {
+thrown.expect(ServiceCombException.class);
+
+ArchaiusUtils.setProperty(PrometheusPublisher.METRICS_PROMETHEUS_ADDRESS,
"localhost:999");
+publisher.init(globalRegistry, null, null);
+ }
+
+ @Test
+ public void collect() throws IllegalAccessException, IOException {
+ArchaiusUtils.setProperty(PrometheusPublisher.METRICS_PROMETHEUS_ADDRESS,
"localhost:0");
+publisher.init(globalRegistry, null, null);
+
+Registry registry = new DefaultRegistry(new ManualClock());
+globalRegistry.add(registry);
+
+Counter counter = registry.counter("count.name", "tag1", "tag1v", "tag2",
"tag2v");
+counter.increment();
+
+HTTPServer httpServer = (HTTPServer) FieldUtils.readField(publisher,
"httpServer", true);
Review comment:
Fine.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
