[GitHub] wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download
wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest
vertx file download
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182644564
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filter/inner/ServerRestArgsFilter.java
##
@@ -50,7 +54,7 @@ public Response afterReceiveRequest(Invocation invocation,
HttpServletRequestEx
}
@Override
- public void beforeSendResponse(Invocation invocation, HttpServletResponseEx
responseEx) {
+ public CompletableFuture asyncBeforeSendResponse(Invocation
invocation, HttpServletResponseEx responseEx) {
Review comment:
done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download
wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest
vertx file download
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182643228
##
File path:
demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.demo.springmvc.server;
+
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+
+import org.apache.servicecomb.provider.rest.common.RestSchema;
+import org.springframework.core.io.ByteArrayResource;
+import org.springframework.core.io.Resource;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+
+import io.swagger.annotations.ApiResponse;
+import io.swagger.annotations.ApiResponses;
+
+@RestSchema(schemaId = "download")
+@RequestMapping(path = "/download", produces =
MediaType.APPLICATION_OCTET_STREAM_VALUE)
+public class DownloadSchema {
+ @GetMapping(path = "/file")
Review comment:
yes, already declared in this commit comments
this PR just for producer
https://issues.apache.org/jira/browse/SCB-487 is for consumer
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] keepongjl opened a new issue #659: 是否考虑支持函数重载
keepongjl opened a new issue #659: 是否考虑支持函数重载 URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/659 现在的Provider不支持函数重载（契约生成会报错Caused by: java.lang.Error: OperationId must be unique），是否考虑支持函数重载？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port
coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-381932927 [](https://coveralls.io/builds/16590450) Coverage increased (+0.01%) to 87.453% when pulling **bc5e93da051954c1886cd03b43bab860506050e9 on weichao666:addDefaultPort** into **41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yangbor commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis
yangbor commented on a change in pull request #648: [SCB-482] Http2 support for
java-chassis
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182619742
##
File path:
transports/transport-rest/transport-rest-vertx/src/test/java/org/apache/servicecomb/transport/rest/vertx/TestRestServerVerticle.java
##
@@ -109,6 +109,38 @@ public void testRestServerVerticleWithRouterSSL(@Mocked
Transport transport, @Mo
server.start(startFuture);
}
+ @Test
+ public void testRestServerVerticleWithHttp2(@Mocked Transport transport,
@Mocked Vertx vertx,
+ @Mocked Context context,
+ @Mocked JsonObject jsonObject, @Mocked Future startFuture) throws
Exception {
+URIEndpointObject endpointObject = new
URIEndpointObject("http://127.0.0.1:8080?protocol=h2";);
+new Expectations() {
+ {
+transport.parseAddress("http://127.0.0.1:8080?protocol=h2";);
Review comment:
ALPN(h2) cannot be used for http schema, only https is allowed to use h2
protocol.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] weichao666 commented on issue #651: [SCB-498] Configuration Center ip address need to config default port
weichao666 commented on issue #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-382585058 modified This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liubao68 commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule
liubao68 commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382582463 I am using eclipse and all compile warnings fixed except https://github.com/apache/incubator-servicecomb-java-chassis/pull/652 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download
liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest
vertx file download
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182612283
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filter/inner/ServerRestArgsFilter.java
##
@@ -50,7 +54,7 @@ public Response afterReceiveRequest(Invocation invocation,
HttpServletRequestEx
}
@Override
- public void beforeSendResponse(Invocation invocation, HttpServletResponseEx
responseEx) {
+ public CompletableFuture asyncBeforeSendResponse(Invocation
invocation, HttpServletResponseEx responseEx) {
Review comment:
I think beforeSendResponseAsync is a better name
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download
liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest
vertx file download
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182611014
##
File path:
demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.demo.springmvc.server;
+
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+
+import org.apache.servicecomb.provider.rest.common.RestSchema;
+import org.springframework.core.io.ByteArrayResource;
+import org.springframework.core.io.Resource;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+
+import io.swagger.annotations.ApiResponse;
+import io.swagger.annotations.ApiResponses;
+
+@RestSchema(schemaId = "download")
+@RequestMapping(path = "/download", produces =
MediaType.APPLICATION_OCTET_STREAM_VALUE)
+public class DownloadSchema {
+ @GetMapping(path = "/file")
Review comment:
Are you going to provide a way to invoke download service by RestTemplate or
RPC style?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] WillemJiang closed pull request #175: SCB-505 Update to throw exception when the transaction timeout
WillemJiang closed pull request #175: SCB-505 Update to throw exception when
the transaction timeout
URL: https://github.com/apache/incubator-servicecomb-saga/pull/175
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/acceptance-tests/acceptance-pack/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
b/acceptance-tests/acceptance-pack/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
index 857bb9f5..4f2f729a 100644
---
a/acceptance-tests/acceptance-pack/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
+++
b/acceptance-tests/acceptance-pack/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
@@ -35,6 +35,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import io.restassured.response.Response;
import cucumber.api.DataTable;
import cucumber.api.java.After;
import cucumber.api.java8.En;
@@ -79,15 +80,20 @@ public PackStepdefs() {
bm.addRulesFromFiles(rules);
});
-When("^User ([A-Za-z]+) requests to book ([0-9]+) cars and ([0-9]+)
rooms$", (username, cars, rooms) -> {
+When("^User ([A-Za-z]+) requests to book ([0-9]+) cars and ([0-9]+) rooms
(success|fail)$", (username, cars, rooms, result) -> {
log.info("Received request from user {} to book {} cars and {} rooms",
username, cars, rooms);
- given()
+ Response resp = given()
.pathParam("name", username)
.pathParam("rooms", rooms)
.pathParam("cars", cars)
.when()
.post(System.getProperty("booking.service.address") +
"/booking/{name}/{rooms}/{cars}");
+ if (result.equals("success")) {
+resp.then().statusCode(is(200));
+ } else if (result.equals("fail")) {
+resp.then().statusCode(is(500));
+ }
});
Then("^Alpha records the following events$", (DataTable dataTable) -> {
diff --git
a/acceptance-tests/acceptance-pack/src/test/resources/pack_compensation_scenario.feature
b/acceptance-tests/acceptance-pack/src/test/resources/pack_compensation_scenario.feature
index fffcde24..64c58125 100644
---
a/acceptance-tests/acceptance-pack/src/test/resources/pack_compensation_scenario.feature
+++
b/acceptance-tests/acceptance-pack/src/test/resources/pack_compensation_scenario.feature
@@ -21,7 +21,7 @@ Feature: Alpha records transaction events
And Booking Service is up and running
And Alpha is up and running
-When User Sean requests to book 5 cars and 3 rooms
+When User Sean requests to book 5 cars and 3 rooms fail
Then Alpha records the following events
| serviceName | type |
diff --git
a/acceptance-tests/acceptance-pack/src/test/resources/pack_success_scenario.feature
b/acceptance-tests/acceptance-pack/src/test/resources/pack_success_scenario.feature
index cba7f5df..7132cbb8 100644
---
a/acceptance-tests/acceptance-pack/src/test/resources/pack_success_scenario.feature
+++
b/acceptance-tests/acceptance-pack/src/test/resources/pack_success_scenario.feature
@@ -21,7 +21,7 @@ Feature: Alpha records transaction events
And Booking Service is up and running
And Alpha is up and running
-When User Sean requests to book 2 cars and 1 rooms
+When User Sean requests to book 2 cars and 1 rooms success
Then Alpha records the following events
| serviceName | type |
diff --git
a/acceptance-tests/acceptance-pack/src/test/resources/pack_timeout_scenario.feature
b/acceptance-tests/acceptance-pack/src/test/resources/pack_timeout_scenario.feature
index 2a3e59de..a49d340f 100644
---
a/acceptance-tests/acceptance-pack/src/test/resources/pack_timeout_scenario.feature
+++
b/acceptance-tests/acceptance-pack/src/test/resources/pack_timeout_scenario.feature
@@ -23,7 +23,7 @@ Feature: Alpha records transaction events
Given Install the byteman script booking_timeout.btm to Booking Service
-When User Sean requests to book 1 cars and 1 rooms
+When User Sean requests to book 1 cars and 1 rooms fail
Then Alpha records the following events
| serviceName | type |
@@ -35,7 +35,7 @@ Feature: Alpha records transaction events
| pack-booking | TxAbortedEvent |
| pack-hotel | TxCompensatedEvent |
| pack-car | TxCompensatedEvent |
- | pack-booking | SagaEndedEvent |
+ | pack-car | SagaEndedEvent |
Then Car Service contains the following booking orders
| name | amount | confirmed | cancelled |
diff --git
a/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/TxConsistentService.java
b/alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/TxConsistentService.java
index c55090a4..968e5b78 100644
---
a/alpha/alpha-core/src/main/java
[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout
coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621 [](https://coveralls.io/builds/16579027) Coverage decreased (-0.7%) to 94.811% when pulling **6638eb65a9a1107196c701400da7578395ba98e2 on zhfeng:SCB-505** into **87949e488ea1ec51f26cd284fe90b6bc35891c8b on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout
coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621 [](https://coveralls.io/builds/16578966) Coverage decreased (-0.6%) to 94.919% when pulling **6638eb65a9a1107196c701400da7578395ba98e2 on zhfeng:SCB-505** into **87949e488ea1ec51f26cd284fe90b6bc35891c8b on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout
coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621 [](https://coveralls.io/builds/16578938) Coverage decreased (-0.9%) to 94.595% when pulling **6638eb65a9a1107196c701400da7578395ba98e2 on zhfeng:SCB-505** into **87949e488ea1ec51f26cd284fe90b6bc35891c8b on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration
WillemJiang commented on a change in pull request #658: [SCB-474] add endpoint
filter (only rest endpoints) for zuul integration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182465491
##
File path:
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseRibbonEndpointDiscoveryFilter.java
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.springboot.starter.discovery;
+
+import org.apache.servicecomb.core.filter.EndpointDiscoveryFilter;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryContext;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryTreeNode;
+
+public class CseRibbonEndpointDiscoveryFilter extends EndpointDiscoveryFilter {
Review comment:
Cse is not supposed to be use here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhfeng opened a new pull request #175: SCB-505 Update to throw exception when the transaction timeout
zhfeng opened a new pull request #175: SCB-505 Update to throw exception when the transaction timeout URL: https://github.com/apache/incubator-servicecomb-saga/pull/175 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration
wujimin commented on a change in pull request #658: [SCB-474] add endpoint
filter (only rest endpoints) for zuul integration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182439746
##
File path:
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/ServiceCombServerList.java
##
@@ -49,13 +49,11 @@ public ServiceCombServerList() {
RegistryUtils.getAppId(),
serviceId,
DefinitionConst.VERSION_RULE_ALL);
-Map servers = serversVersionedCache.data();
-List instances = new ArrayList<>(servers.size());
-for (MicroserviceInstance s : servers.values()) {
- for (String endpoint : s.getEndpoints()) {
-URIEndpointObject uri = new URIEndpointObject(endpoint);
-instances.add(new Server(uri.getHostOrIp(), uri.getPort()));
- }
+ArrayList endpoints = serversVersionedCache.data();
Review comment:
by previous comment, here will got List, not List
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration
wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182437916 ## File path: spring-boot-starter/spring-boot-starter-discovery/pom.xml ## @@ -73,7 +73,7 @@ org.apache.servicecomb - service-registry + java-chassis-core Review comment: why need change the dependency? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration
wujimin commented on a change in pull request #658: [SCB-474] add endpoint
filter (only rest endpoints) for zuul integration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182439425
##
File path:
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseRibbonEndpointDiscoveryFilter.java
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.springboot.starter.discovery;
+
+import org.apache.servicecomb.core.filter.EndpointDiscoveryFilter;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryContext;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryTreeNode;
+
+public class CseRibbonEndpointDiscoveryFilter extends EndpointDiscoveryFilter {
Review comment:
better extend from AbstractEndpointDiscoveryFilter
and createEndpoint return com.netflix.loadbalancer.Server
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Rajadeepan commented on issue #648: [SCB-482] Http2 support for java-chassis
Rajadeepan commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-382374604 commit added for UT and IT This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis
coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381568126 [](https://coveralls.io/builds/16575497) Coverage increased (+0.05%) to 87.492% when pulling **aae6f6d246d34e429fde5569334c93b3980b42de on Rajadeepan:master** into **41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration
coveralls commented on issue #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#issuecomment-382350160 [](https://coveralls.io/builds/16574872) Coverage increased (+0.0007%) to 87.441% when pulling **bf9f0fe450d992355e9bae7f34b4a5fc358c0b74 on zhengyangyong:SCB-474** into **41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong opened a new pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration
zhengyangyong opened a new pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- Add rest filter for spring-cloud-zuul module in order to screen highway endpoints. only XML and Faceted project problem warnings  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule
coveralls commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382318550 [](https://coveralls.io/builds/16573156) Coverage increased (+0.009%) to 87.449% when pulling **c612977f1a76180143b4a149847189cd4dba0426 on liubao68:config** into **41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule
wujimin commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382310371 paste compile warning check image please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liubao68 opened a new pull request #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule
liubao68 opened a new pull request #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download
coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382072555 [](https://coveralls.io/builds/16572229) Coverage increased (+0.04%) to 87.479% when pulling **dc36cf74e64448f812b2a28dc7845302bd786e08 on wujimin:springmvc-rest-vertx-file-download** into **41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on issue #653: [SCB-483] Springmvc rest vertx file download
wujimin commented on issue #653: [SCB-483] Springmvc rest vertx file download URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382290341 add a new commit: "set correct content-type for download" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
