[GitHub] coveralls commented on issue #330: SCB-510 Expire backup log files are not removed
coveralls commented on issue #330: SCB-510 Expire backup log files are not removed URL: https://github.com/apache/incubator-servicecomb-service-center/pull/330#issuecomment-383045642 [](https://coveralls.io/builds/16629328) Coverage increased (+0.1%) to 73.039% when pulling **0cd2ae4d2bc9b96a2730cf08ae5c8c6687a07784 on little-cui:logr** into **ee87190f9047244cc8e6f95852aa3518b5eff6fd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #330: SCB-510 Expire backup log files are not removed
codecov-io commented on issue #330: SCB-510 Expire backup log files are not removed URL: https://github.com/apache/incubator-servicecomb-service-center/pull/330#issuecomment-383045374 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=h1) Report > Merging [#330](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ee87190f9047244cc8e6f95852aa3518b5eff6fd?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #330 +/- ## == + Coverage 69.45% 69.48% +0.02% == Files 17 17 Lines3438 3438 == + Hits 2388 2389 +1 Misses884 884 + Partials 166 165 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `76.02% <0%> (+0.58%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=footer). Last update [ee87190...0cd2ae4](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #63: Update producer develop docs
WillemJiang commented on a change in pull request #63: Update producer develop
docs
URL:
https://github.com/apache/incubator-servicecomb-website/pull/63#discussion_r183188508
##
File path: _users/cn/develop-with-jax-rs.md
##
@@ -89,6 +108,24 @@ ServiceComb支持开发者使用JAX-RS注解，使用JAX-RS模式开发服务。
```
+* **步骤 4** 添加服务定义。
+
+
在resources目录中添加[microservice.yaml](http://servicecomb.incubator.apache.org/cn/users/service-definition/)。
+
+* **步骤 5** 添加Main启动类
+
+ ```java
+ import org.apache.servicecomb.foundation.common.utils.BeanUtils;
+ import org.apache.servicecomb.foundation.common.utils.Log4jUtils;
+
+ public class Application {
+ public static void main(String[] args) throws Exception {
+Log4jUtils.init();
Review comment:
Can you add some comments for these two lines?
BTW, we can use BeanUtils to get the instance of the bean.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #666: [SCB-506]服务治理相关的需要事件上报
WillemJiang commented on a change in pull request #666: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/666#discussion_r183067342 ## File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/event/CircutBreakerEvent.java ## @@ -0,0 +1,50 @@ +package org.apache.servicecomb.bizkeeper.event; Review comment: License header please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #666: [SCB-506]服务治理相关的需要事件上报
WillemJiang commented on a change in pull request #666: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/666#discussion_r183067126 ## File path: handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/event/IsolationServerEvent.java ## @@ -0,0 +1,32 @@ +package org.apache.servicecomb.loadbalance.event; Review comment: License header please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #666: [SCB-506]服务治理相关的需要事件上报
WillemJiang commented on a change in pull request #666: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/666#discussion_r183067239 ## File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/event/FallbackEvent.java ## @@ -0,0 +1,27 @@ +package org.apache.servicecomb.bizkeeper.event; Review comment: License header please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis
Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support
for java-chassis
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r183029954
##
File path:
foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/URIEndpointObject.java
##
@@ -47,6 +53,10 @@ public URIEndpointObject(String endpoint) {
setPort(uri.getPort());
querys = splitQuery(uri);
sslEnabled = Boolean.parseBoolean(getFirst(SSL_ENABLED_KEY));
+String httpversion = getFirst(HTTP2_ENABLED_KEY);
+if (httpversion != null && httpversion.compareTo(HTTP2) == 0) {
Review comment:
Fixed and comitted
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis
Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support
for java-chassis
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r183029850
##
File path:
foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/URIEndpointObject.java
##
@@ -33,8 +33,14 @@
public class URIEndpointObject extends IpPort {
private static final String SSL_ENABLED_KEY = "sslEnabled";
+ private static final String HTTP2_ENABLED_KEY = "protocol";
Review comment:
Fixed and comitted
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis
coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381568126 [](https://coveralls.io/builds/16616863) Coverage decreased (-4.0e-05%) to 87.441% when pulling **460aa99c434fef06ae53cd4ccc49db024cfd827e on Rajadeepan:master** into **41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis
Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support
for java-chassis
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r183010311
##
File path:
transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestServerVerticle.java
##
@@ -127,7 +127,9 @@ private HttpServerOptions createDefaultHttpServerOptions()
{
serverOptions.setIdleTimeout(TransportConfig.getConnectionIdleTimeoutInSeconds());
serverOptions.setCompressionSupported(TransportConfig.getCompressed());
serverOptions.setMaxHeaderSize(TransportConfig.getMaxHeaderSize());
-
+if (endpointObject.isHttp2Enabled()) {
Review comment:
for h2 mode we need to enable ALPN
but for h2c(with prior knowledge) no change is required on the server side
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis
Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support
for java-chassis
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r183009523
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
##
@@ -62,7 +77,16 @@ private static HttpClientOptions createHttpClientOptions() {
}
public void send(Invocation invocation, AsyncResponse asyncResp) throws
Exception {
-HttpClientWithContext httpClientWithContext =
clientMgr.findClientPool(invocation.isSync());
+URIEndpointObject endpoint = (URIEndpointObject)
invocation.getEndpoint().getAddress();
+HttpClientWithContext httpClientWithContext;
+if (endpoint.isHttp2Enabled()) {
+ httpClientWithContext =
clientMgrHttp2.findClientPool(invocation.isSync());
+ if (!endpoint.isSslEnabled()) {
+((HttpClientImpl)
httpClientWithContext.getHttpClient()).getOptions().setHttp2ClearTextUpgrade(false);
Review comment:
http2 + ssl = h2
http2 + without ssl = h2c
for the http2 client instance to work with h2c the http2ClearTextUpgrade
need to be set to false
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xuyiyun0929 opened a new pull request #666: [SCB-506]服务治理相关的需要事件上报
xuyiyun0929 opened a new pull request #666: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/666 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #330: SCB-510 Expire backup log files are not removed
coveralls commented on issue #330: SCB-510 Expire backup log files are not removed URL: https://github.com/apache/incubator-servicecomb-service-center/pull/330#issuecomment-383045642 [](https://coveralls.io/builds/16615128) Coverage increased (+0.05%) to 72.985% when pulling **7b3a7a5d4c2934539562f80dd59957cdd8b9efd7 on little-cui:logr** into **ee87190f9047244cc8e6f95852aa3518b5eff6fd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #330: SCB-510 Expire backup log files are not removed
codecov-io commented on issue #330: SCB-510 Expire backup log files are not removed URL: https://github.com/apache/incubator-servicecomb-service-center/pull/330#issuecomment-383045374 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=h1) Report > Merging [#330](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ee87190f9047244cc8e6f95852aa3518b5eff6fd?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #330 +/- ## === Coverage 69.45% 69.45% === Files 17 17 Lines3438 3438 === Hits 2388 2388 Misses884 884 Partials 166 166 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=footer). Last update [ee87190...7b3a7a5](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] little-cui opened a new pull request #330: SCB-510 Expire backup log files are not removed
little-cui opened a new pull request #330: SCB-510 Expire backup log files are not removed URL: https://github.com/apache/incubator-servicecomb-service-center/pull/330 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong opened a new pull request #63: Update producer develop docs
zhengyangyong opened a new pull request #63: Update producer develop docs URL: https://github.com/apache/incubator-servicecomb-website/pull/63 improve producer develop docs (springmvc,pojo and jaxrs) 1. add dependencies import chapter 2. remove hello interface for springmvc and jaxrs (no necessary) chapter 3. reorganize pojo service publish chapter 4. add microservice,yaml chapter This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liubao68 closed pull request #665: [SCB-509] Update jackson's version to 2.9.5
liubao68 closed pull request #665: [SCB-509] Update jackson's version to 2.9.5 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/665 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/java-chassis-dependencies/pom.xml b/java-chassis-dependencies/pom.xml index 92a00478a..47e205824 100644 --- a/java-chassis-dependencies/pom.xml +++ b/java-chassis-dependencies/pom.xml @@ -31,7 +31,7 @@ pom -2.9.4 +2.9.5 3.5.0 0.8 4.3.5.RELEASE diff --git a/java-chassis-distribution/src/release/LICENSE b/java-chassis-distribution/src/release/LICENSE index d4933ba15..62ff0963b 100644 --- a/java-chassis-distribution/src/release/LICENSE +++ b/java-chassis-distribution/src/release/LICENSE @@ -349,13 +349,13 @@ Guava: Google Core Libraries for Java (http://code.google.com/p/guava-libraries/ Hibernate Validator Engine (http://hibernate.org/validator/hibernate-validator) org.hibernate:hibernate-validator:jar:5.2.4.Final JBoss Logging 3 (http://www.jboss.org) org.jboss.logging:jboss-logging:jar:3.3.0.Final Jackson dataformat: CBOR (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:bundle:2.8.7 -Jackson dataformat: protobuf (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf:bundle:2.9.2 +Jackson dataformat: protobuf (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf:bundle:2.9.5 Jackson module: Afterburner (https://github.com/FasterXML/jackson-modules-base) com.fasterxml.jackson.module:jackson-module-afterburner:bundle:2.7.5 Jackson module: JAXB-annotations (http://github.com/FasterXML/jackson-module-jaxb-annotations) com.fasterxml.jackson.module:jackson-module-jaxb-annotations:bundle:2.8.7 -Jackson-annotations (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-annotations:bundle:2.9.2 -Jackson-core (https://github.com/FasterXML/jackson-core) com.fasterxml.jackson.core:jackson-core:bundle:2.9.2 -Jackson-dataformat-XML (http://wiki.fasterxml.com/JacksonExtensionXmlDataBinding) com.fasterxml.jackson.dataformat:jackson-dataformat-xml:bundle:2.9.2 -Jackson-dataformat-YAML (https://github.com/FasterXML/jackson-dataformats-text) com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:bundle:2.9.2 +Jackson-annotations (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-annotations:bundle:2.9.5 +Jackson-core (https://github.com/FasterXML/jackson-core) com.fasterxml.jackson.core:jackson-core:bundle:2.9.5 +Jackson-dataformat-XML (http://wiki.fasterxml.com/JacksonExtensionXmlDataBinding) com.fasterxml.jackson.dataformat:jackson-dataformat-xml:bundle:2.9.5 +Jackson-dataformat-YAML (https://github.com/FasterXML/jackson-dataformats-text) com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:bundle:2.9.5 Javassist (http://www.javassist.org/) org.javassist:javassist:bundle:3.18.1-GA Log4j Implemented Over SLF4J (http://www.slf4j.org) org.slf4j:log4j-over-slf4j:jar:1.7.7 Netty/Buffer (http://netty.io/netty-buffer/) io.netty:netty-buffer:jar:4.1.17.Final @@ -412,7 +412,7 @@ hystrix-core (https://github.com/Netflix/Hystrix) com.netflix.hystrix:hystrix-co hystrix-javanica (https://github.com/Netflix/Hystrix) com.netflix.hystrix:hystrix-javanica:jar:1.5.6 hystrix-metrics-event-stream (https://github.com/Netflix/Hystrix) com.netflix.hystrix:hystrix-metrics-event-stream:jar:1.5.6 hystrix-serialization (https://github.com/Netflix/Hystrix) com.netflix.hystrix:hystrix-serialization:jar:1.5.6 -jackson-databind (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-databind:bundle:2.9.2 +jackson-databind (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-databind:bundle:2.9.5 javax.inject (http://code.google.com/p/atinject/) javax.inject:javax.inject:jar:1 json-lib (http://json-lib.sourceforge.net) net.sf.json-lib:json-lib:jar:2.4 netflix-commons-util (https://github.com/Netflix/netflix-commons) com.netflix.netflix-commons:netflix-commons-util:jar:0.1.1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #665: [SCB-509] Update jackson's version to 2.9.5
coveralls commented on issue #665: [SCB-509] Update jackson's version to 2.9.5 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/665#issuecomment-383021893 [](https://coveralls.io/builds/16614023) Coverage decreased (-0.02%) to 87.394% when pulling **834a2aa20542786e97150f6d33a4ee85d6e6e54f on xuyiyun0929:updateJackson** into **8a5b9721374e36777376e5d0877adf072da7ea9a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #664: [SCB-509] Update jackson's version to 2.9.5
coveralls commented on issue #664: [SCB-509] Update jackson's version to 2.9.5 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/664#issuecomment-383009787 [](https://coveralls.io/builds/16613826) Coverage remained the same at 87.41% when pulling **a7beae51146d5de495dd92804f0f73d8685b36b0 on xuyiyun0929:upgradeJackson** into **8a5b9721374e36777376e5d0877adf072da7ea9a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin closed pull request #651: [SCB-498] Configuration Center ip address need to config default port
wujimin closed pull request #651: [SCB-498] Configuration Center ip address
need to config default port
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/NetUtils.java
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/NetUtils.java
index 3fbee2767..b7bac4d74 100644
---
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/NetUtils.java
+++
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/NetUtils.java
@@ -145,12 +145,25 @@ public static IpPort parseIpPortFromURI(String
uriAddress) {
try {
URI uri = new URI(uriAddress);
String authority = uri.getAuthority();
- return parseIpPort(authority);
+ return parseIpPort(uri.getScheme(), authority);
} catch (URISyntaxException e) {
return null;
}
}
+ private static IpPort parseIpPort(String scheme, String authority) {
+if (authority == null)
+ return null;
+int idx = authority.indexOf(':');
+if (idx != -1)
+ return parseIpPort(authority);
+if (scheme.equals("http"))
+ return new IpPort(authority, 80);
+if (scheme.equals("https"))
+ return new IpPort(authority, 443);
+return null;
+ }
+
/**
* 对于配置为0.0.0.0的地址，let it go
* schema, e.g. http
diff --git
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
index ce6cc081e..85eebe27a 100644
---
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
+++
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
@@ -46,9 +46,13 @@ public void testNetutils() {
Assert.assertEquals(8080,
NetUtils.parseIpPort("127.0.0.1:8080").getPort());
Assert.assertEquals(null, NetUtils.parseIpPort(null));
Assert.assertEquals(null, NetUtils.parseIpPort("127.0.0.18080"));
-Assert.assertEquals(NetUtils.parseIpPortFromURI(null), null);
-Assert.assertEquals(NetUtils.parseIpPortFromURI("ss"), null);
-
Assert.assertEquals(NetUtils.parseIpPortFromURI("rest://127.0.0.1:8080").getHostOrIp(),
"127.0.0.1");
+Assert.assertEquals(null, NetUtils.parseIpPortFromURI(null));
+Assert.assertEquals(null, NetUtils.parseIpPortFromURI("ss"));
+Assert.assertEquals("127.0.0.1",
NetUtils.parseIpPortFromURI("rest://127.0.0.1:8080").getHostOrIp());
+Assert.assertEquals(8080,
NetUtils.parseIpPortFromURI("http://127.0.0.1:8080";).getPort());
+Assert.assertEquals(80,
NetUtils.parseIpPortFromURI("http://127.0.0.1";).getPort());
+Assert.assertEquals(8080,
NetUtils.parseIpPortFromURI("https://127.0.0.1:8080";).getPort());
+Assert.assertEquals(443,
NetUtils.parseIpPortFromURI("https://127.0.0.1";).getPort());
}
@Test
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xuyiyun0929 opened a new pull request #665: [SCB-509] Update jackson's version to 2.9.5
xuyiyun0929 opened a new pull request #665: [SCB-509] Update jackson's version to 2.9.5 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/665 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #664: [SCB-509] Update jackson's version to 2.9.5
coveralls commented on issue #664: [SCB-509] Update jackson's version to 2.9.5 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/664#issuecomment-383009787 [](https://coveralls.io/builds/16613522) Coverage remained the same at 87.41% when pulling **a7beae51146d5de495dd92804f0f73d8685b36b0 on xuyiyun0929:upgradeJackson** into **8a5b9721374e36777376e5d0877adf072da7ea9a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xuyiyun0929 closed pull request #664: [SCB-509] Update jackson's version to 2.9.5
xuyiyun0929 closed pull request #664: [SCB-509] Update jackson's version to 2.9.5 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/664 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/java-chassis-dependencies/pom.xml b/java-chassis-dependencies/pom.xml index 92a00478a..47e205824 100644 --- a/java-chassis-dependencies/pom.xml +++ b/java-chassis-dependencies/pom.xml @@ -31,7 +31,7 @@ pom -2.9.4 +2.9.5 3.5.0 0.8 4.3.5.RELEASE diff --git a/java-chassis-distribution/src/release/LICENSE b/java-chassis-distribution/src/release/LICENSE index d4933ba15..225d9dcb5 100644 --- a/java-chassis-distribution/src/release/LICENSE +++ b/java-chassis-distribution/src/release/LICENSE @@ -349,13 +349,13 @@ Guava: Google Core Libraries for Java (http://code.google.com/p/guava-libraries/ Hibernate Validator Engine (http://hibernate.org/validator/hibernate-validator) org.hibernate:hibernate-validator:jar:5.2.4.Final JBoss Logging 3 (http://www.jboss.org) org.jboss.logging:jboss-logging:jar:3.3.0.Final Jackson dataformat: CBOR (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:bundle:2.8.7 -Jackson dataformat: protobuf (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf:bundle:2.9.2 +Jackson dataformat: protobuf (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf:bundle:2.9.5 Jackson module: Afterburner (https://github.com/FasterXML/jackson-modules-base) com.fasterxml.jackson.module:jackson-module-afterburner:bundle:2.7.5 Jackson module: JAXB-annotations (http://github.com/FasterXML/jackson-module-jaxb-annotations) com.fasterxml.jackson.module:jackson-module-jaxb-annotations:bundle:2.8.7 -Jackson-annotations (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-annotations:bundle:2.9.2 -Jackson-core (https://github.com/FasterXML/jackson-core) com.fasterxml.jackson.core:jackson-core:bundle:2.9.2 -Jackson-dataformat-XML (http://wiki.fasterxml.com/JacksonExtensionXmlDataBinding) com.fasterxml.jackson.dataformat:jackson-dataformat-xml:bundle:2.9.2 -Jackson-dataformat-YAML (https://github.com/FasterXML/jackson-dataformats-text) com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:bundle:2.9.2 +Jackson-annotations (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-annotations:bundle:2.9.5 +Jackson-core (https://github.com/FasterXML/jackson-core) com.fasterxml.jackson.core:jackson-core:bundle:2.9.5 +Jackson-dataformat-XML (http://wiki.fasterxml.com/JacksonExtensionXmlDataBinding) com.fasterxml.jackson.dataformat:jackson-dataformat-xml:bundle:2.9.5 +Jackson-dataformat-YAML (https://github.com/FasterXML/jackson-dataformats-text) com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:bundle:2.9.5 Javassist (http://www.javassist.org/) org.javassist:javassist:bundle:3.18.1-GA Log4j Implemented Over SLF4J (http://www.slf4j.org) org.slf4j:log4j-over-slf4j:jar:1.7.7 Netty/Buffer (http://netty.io/netty-buffer/) io.netty:netty-buffer:jar:4.1.17.Final This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xuyiyun0929 opened a new pull request #664: [SCB-509] Update jackson's version to 2.9.5
xuyiyun0929 opened a new pull request #664: [SCB-509] Update jackson's version to 2.9.5 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/664 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xuyiyun0929 closed pull request #664: [SCB-509] Update jackson's version to 2.9.5
xuyiyun0929 closed pull request #664: [SCB-509] Update jackson's version to 2.9.5 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/664 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/java-chassis-dependencies/pom.xml b/java-chassis-dependencies/pom.xml index 92a00478a..47e205824 100644 --- a/java-chassis-dependencies/pom.xml +++ b/java-chassis-dependencies/pom.xml @@ -31,7 +31,7 @@ pom -2.9.4 +2.9.5 3.5.0 0.8 4.3.5.RELEASE diff --git a/java-chassis-distribution/src/release/LICENSE b/java-chassis-distribution/src/release/LICENSE index d4933ba15..225d9dcb5 100644 --- a/java-chassis-distribution/src/release/LICENSE +++ b/java-chassis-distribution/src/release/LICENSE @@ -349,13 +349,13 @@ Guava: Google Core Libraries for Java (http://code.google.com/p/guava-libraries/ Hibernate Validator Engine (http://hibernate.org/validator/hibernate-validator) org.hibernate:hibernate-validator:jar:5.2.4.Final JBoss Logging 3 (http://www.jboss.org) org.jboss.logging:jboss-logging:jar:3.3.0.Final Jackson dataformat: CBOR (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:bundle:2.8.7 -Jackson dataformat: protobuf (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf:bundle:2.9.2 +Jackson dataformat: protobuf (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf:bundle:2.9.5 Jackson module: Afterburner (https://github.com/FasterXML/jackson-modules-base) com.fasterxml.jackson.module:jackson-module-afterburner:bundle:2.7.5 Jackson module: JAXB-annotations (http://github.com/FasterXML/jackson-module-jaxb-annotations) com.fasterxml.jackson.module:jackson-module-jaxb-annotations:bundle:2.8.7 -Jackson-annotations (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-annotations:bundle:2.9.2 -Jackson-core (https://github.com/FasterXML/jackson-core) com.fasterxml.jackson.core:jackson-core:bundle:2.9.2 -Jackson-dataformat-XML (http://wiki.fasterxml.com/JacksonExtensionXmlDataBinding) com.fasterxml.jackson.dataformat:jackson-dataformat-xml:bundle:2.9.2 -Jackson-dataformat-YAML (https://github.com/FasterXML/jackson-dataformats-text) com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:bundle:2.9.2 +Jackson-annotations (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-annotations:bundle:2.9.5 +Jackson-core (https://github.com/FasterXML/jackson-core) com.fasterxml.jackson.core:jackson-core:bundle:2.9.5 +Jackson-dataformat-XML (http://wiki.fasterxml.com/JacksonExtensionXmlDataBinding) com.fasterxml.jackson.dataformat:jackson-dataformat-xml:bundle:2.9.5 +Jackson-dataformat-YAML (https://github.com/FasterXML/jackson-dataformats-text) com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:bundle:2.9.5 Javassist (http://www.javassist.org/) org.javassist:javassist:bundle:3.18.1-GA Log4j Implemented Over SLF4J (http://www.slf4j.org) org.slf4j:log4j-over-slf4j:jar:1.7.7 Netty/Buffer (http://netty.io/netty-buffer/) io.netty:netty-buffer:jar:4.1.17.Final This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #663: Upgrade jackson
coveralls commented on issue #663: Upgrade jackson URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/663#issuecomment-383004728 [](https://coveralls.io/builds/16613302) Coverage remained the same at 87.405% when pulling **a7beae51146d5de495dd92804f0f73d8685b36b0 on xuyiyun0929:upgradeJackson** into **d9233abae64c1bdfbb16b6dbf8f98e2b24b51376 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xuyiyun0929 opened a new pull request #664: [SCB-509] Update jackson's version to 2.9.5
xuyiyun0929 opened a new pull request #664: [SCB-509] Update jackson's version to 2.9.5 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/664 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
