Re: [VOTE] Move github notifications to maillist "comm...@servicecomb.apache.org"

[Bin Ma]

+1 non binding

2018-05-11 21:12 GMT+08:00 wjm wjm :

> +1
>
> 2018-05-11 17:52 GMT+08:00 Willem Jiang :
>
> > +1 , it could make the dev discuss more focused.
> >
> >
> > Willem Jiang
> >
> > Blog: http://willemjiang.blogspot.com (English)
> >   http://jnn.iteye.com  (Chinese)
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Fri, May 11, 2018 at 4:51 PM, kirin wang 
> > wrote:
> >
> > > Hi  Community:
> > >
> > >   As we already discussed  in [1], this is a call for vote to move
> > > github notifications of Apache ServiceComb to maillist  "
> > > comm...@servicecomb.apache.org" .
> > >
> > > Voting will start now ( Friday, 11th May, 2018) and will remain open
> for
> > > next 72 hours.
> > >
> > > [ ] +1 Move Github notifications to maillist
> "commits@servicecomb.apache.
> > > org
> > > "
> > > [ ] +0 No Opinion
> > > [ ] -1 Do not move Github notifications to maillist "
> > > comm...@servicecomb.apache.org"
> > >
> > >
> > >
> > > [1]
> > > https://lists.apache.org/thread.html/95f538f676326bd2cb1a06cf278c40
> > > 76352b987bfbabad6c6ae247bc@%3Cdev.servicecomb.apache.org%3E
> > >
> >
>

[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown

[GitBox]

wujimin commented on issue #693: [SCB-548] support gracefully shutdown
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388522879
 
 
   and CI failed, it's about trace, i can find what happened, it seems that did 
not print error test case name?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown

[GitBox]

wujimin commented on issue #693: [SCB-548] support gracefully shutdown
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388522824
 
 
   ShutdownHookHandler is not so good, sometimes will block shutdown process 
cause of wrong statistics, must depend on timeout to make shutdown process 
continue.
   
   we should:
   1.prevent create new consumer invocation
   2.prevent other find me
   3.make accurate statistics


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #699: [SCB-532] Support recursive dependency

[GitBox]

wujimin commented on a change in pull request #699: [SCB-532] Support recursive 
dependency
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187761407
 
 

 ##
 File path: 
common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/JavassistUtils.java
 ##
 @@ -185,10 +185,47 @@ private static void addEnumValuesMethod(CtClass ctClass, 
List values) th
 }
   }
 
-  LOGGER.info("generate {} in classLoader {}.", config.getClassName(), 
classLoader);
-  return ctClass.toClass(classLoader, null);
+  LOGGER.info("create CtClass {} in classLoader {}.", 
config.getClassName(), classLoader);
+  return ctClass;
+} catch (Throwable e) {
+  throw new IllegalStateException(
+  String.format("Failed to create CtClass %s in classLoader %s.", 
config.getClassName(),
+  classLoader), e);
+}
+  }
+
+  public static Class createClass(ClassLoader classLoader, ClassConfig 
config) {
+if (classLoader == null) {
 
 Review comment:
   i have test for this
   because already throw exception with error context, invoker already print 
the exception
   if print in this place, then will print multi times.
   
   so i think it's better not log here.
   what's your suggestion?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency

[GitBox]

WillemJiang commented on a change in pull request #699: [SCB-532] Support 
recursive dependency
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187755431
 
 

 ##
 File path: 
common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/JavassistUtils.java
 ##
 @@ -185,10 +185,47 @@ private static void addEnumValuesMethod(CtClass ctClass, 
List values) th
 }
   }
 
-  LOGGER.info("generate {} in classLoader {}.", config.getClassName(), 
classLoader);
-  return ctClass.toClass(classLoader, null);
+  LOGGER.info("create CtClass {} in classLoader {}.", 
config.getClassName(), classLoader);
+  return ctClass;
+} catch (Throwable e) {
+  throw new IllegalStateException(
+  String.format("Failed to create CtClass %s in classLoader %s.", 
config.getClassName(),
+  classLoader), e);
+}
+  }
+
+  public static Class createClass(ClassLoader classLoader, ClassConfig 
config) {
+if (classLoader == null) {
+  classLoader = Thread.currentThread().getContextClassLoader();
+}
+
+CtClass ctClass = createCtClass(classLoader, config);
+return createClass(classLoader, ctClass);
+  }
+
+  public static Class createClass(ClassLoader classLoader, CtClass ctClass) 
{
+if (classLoader == null) {
+  classLoader = Thread.currentThread().getContextClassLoader();
 
 Review comment:
   Same issue here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #699: [SCB-532] Support recursive dependency

[GitBox]

WillemJiang commented on a change in pull request #699: [SCB-532] Support 
recursive dependency
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187755264
 
 

 ##
 File path: 
common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/JavassistUtils.java
 ##
 @@ -185,10 +185,47 @@ private static void addEnumValuesMethod(CtClass ctClass, 
List values) th
 }
   }
 
-  LOGGER.info("generate {} in classLoader {}.", config.getClassName(), 
classLoader);
-  return ctClass.toClass(classLoader, null);
+  LOGGER.info("create CtClass {} in classLoader {}.", 
config.getClassName(), classLoader);
+  return ctClass;
+} catch (Throwable e) {
+  throw new IllegalStateException(
+  String.format("Failed to create CtClass %s in classLoader %s.", 
config.getClassName(),
+  classLoader), e);
+}
+  }
+
+  public static Class createClass(ClassLoader classLoader, ClassConfig 
config) {
+if (classLoader == null) {
 
 Review comment:
   It's better to add a log here for tracking the classloader issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Move github notifications to maillist "comm...@servicecomb.apache.org"

[wjm wjm]

+1

2018-05-11 17:52 GMT+08:00 Willem Jiang :

> +1 , it could make the dev discuss more focused.
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
>   http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Fri, May 11, 2018 at 4:51 PM, kirin wang 
> wrote:
>
> > Hi  Community:
> >
> >   As we already discussed  in [1], this is a call for vote to move
> > github notifications of Apache ServiceComb to maillist  "
> > comm...@servicecomb.apache.org" .
> >
> > Voting will start now ( Friday, 11th May, 2018) and will remain open for
> > next 72 hours.
> >
> > [ ] +1 Move Github notifications to maillist "commits@servicecomb.apache.
> > org
> > "
> > [ ] +0 No Opinion
> > [ ] -1 Do not move Github notifications to maillist "
> > comm...@servicecomb.apache.org"
> >
> >
> >
> > [1]
> > https://lists.apache.org/thread.html/95f538f676326bd2cb1a06cf278c40
> > 76352b987bfbabad6c6ae247bc@%3Cdev.servicecomb.apache.org%3E
> >
>

Re: [VOTE] Move github notifications to maillist "comm...@servicecomb.apache.org"

[Willem Jiang]

+1 , it could make the dev discuss more focused.


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Fri, May 11, 2018 at 4:51 PM, kirin wang  wrote:

> Hi  Community:
>
>   As we already discussed  in [1], this is a call for vote to move
> github notifications of Apache ServiceComb to maillist  "
> comm...@servicecomb.apache.org" .
>
> Voting will start now ( Friday, 11th May, 2018) and will remain open for
> next 72 hours.
>
> [ ] +1 Move Github notifications to maillist "commits@servicecomb.apache.
> org
> "
> [ ] +0 No Opinion
> [ ] -1 Do not move Github notifications to maillist "
> comm...@servicecomb.apache.org"
>
>
>
> [1]
> https://lists.apache.org/thread.html/95f538f676326bd2cb1a06cf278c40
> 76352b987bfbabad6c6ae247bc@%3Cdev.servicecomb.apache.org%3E
>

Re: [VOTE] Move github notifications to maillist "comm...@servicecomb.apache.org"

[Yang Bo]

+1 (non-binding)

On Fri, May 11, 2018 at 4:51 PM, kirin wang  wrote:

> Hi  Community:
>
>   As we already discussed  in [1], this is a call for vote to move
> github notifications of Apache ServiceComb to maillist  "
> comm...@servicecomb.apache.org" .
>
> Voting will start now ( Friday, 11th May, 2018) and will remain open for
> next 72 hours.
>
> [ ] +1 Move Github notifications to maillist "commits@servicecomb.apache.
> org
> "
> [ ] +0 No Opinion
> [ ] -1 Do not move Github notifications to maillist "
> comm...@servicecomb.apache.org"
>
>
>
> [1]
> https://lists.apache.org/thread.html/95f538f676326bd2cb1a06cf278c40
> 76352b987bfbabad6c6ae247bc@%3Cdev.servicecomb.apache.org%3E
>



-- 
Best Regards,
Yang.

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

[GitBox]

zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388301667
 
 
   improve gracefully shutdown process order
   ```java
 private void gracefullyShutdown() {
   //Step 1: notify all component stop invoke via BEFORE_CLOSE Event
   triggerEvent(EventType.BEFORE_CLOSE);
   
   //Step 2: Unregister microservice instance from Service Center and close 
vertx
   RegistryUtils.destroy();
   VertxUtils.closeVertxByName("registry");
   
   //Step 3: wait all invocation finished
   try {
 ShutdownHookHandler.INSTANCE.ALL_INVOCATION_FINISHED.acquire();
 LOGGER.warn("all invocation finished");
   } catch (InterruptedException e) {
 LOGGER.error("invocation finished semaphore interrupted", e);
   }
   
   //Step 4: Stop vertx to prevent blocking exit
   VertxUtils.closeVertxByName("config-center");
   VertxUtils.closeVertxByName("transport");
   
   //Step 5: notify all component do clean works via AFTER_CLOSE Event
   triggerEvent(EventType.AFTER_CLOSE);
 }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

[GitBox]

coveralls commented on issue #693: [SCB-548] support gracefully shutdown
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16935269/badge)](https://coveralls.io/builds/16935269)
   
   Coverage decreased (-0.4%) to 87.003% when pulling 
**d66eb287ee4a5126e2455855e00792d4a75fe01d on zhengyangyong:SCB-548** into 
**5c29a7cd224e788cb357e8c640a5f3473ceb0209 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [Discussion] Move Gitbox Notifications from dev@servicecomb.apache.org to a new maillist

[kirin wang]

Thank you for all your advices!
I will start a VOTE to confirm that .

2018-05-09 19:04 GMT+08:00 Zen Lin :

> Hi
>
> I also gone through the commits mailing list about other project.
> It seems consistent with what Jean-Baptiste said, like an "umbrella"
> receiving any message related commit/code activity.
>
> Best Regards,
> ---
> Zen Lin
> zenlintechnofr...@gmail.com
> Focused on Micro Service and Apache ServiceComb
>
> 2018-05-09 17:58 GMT+08:00 Jean-Baptiste Onofré :
>
> > The suggestion was more a kind of "umbrella" mailing list receiving any
> > message related to commit/code activity.
> >
> > Regards
> > JB
> >
> >
> > On 09/05/2018 11:21, Willem Jiang wrote:
> >
> >> Hi JB,
> >>
> >> As GitBox also post some comments and PR request which could be only
> part
> >> of commits?
> >> I'm not sure if it is OK to keep them in the commits mailing list.
> >>
> >>
> >> Willem Jiang
> >>
> >> Blog: http://willemjiang.blogspot.com (English)
> >>http://jnn.iteye.com  (Chinese)
> >> Twitter: willemjiang
> >> Weibo: 姜宁willem
> >>
> >> On Wed, May 9, 2018 at 4:27 PM, Jean-Baptiste Onofré 
> >> wrote:
> >>
> >> What about comm...@servicecomb.apache.org ? Most of the Apache projects
> >>> use commits mailing list.
> >>>
> >>> Thoughts ?
> >>>
> >>> Regards
> >>> JB
> >>>
> >>>
> >>> On 09/05/2018 09:42, kirin wang wrote:
> >>>
> >>> Hi  community:
> 
> Currently,  Gitbox notifications are send via "
>  dev@servicecomb.apache.org" . And it's mixed with  our community
>  affaris
>  discussion. May be we can move gitbox  notifications to a new mailist
>  like "
>  notificat...@servicecomb.apache.org" to make the "dev" more "pure"
> : )
>  ..
> 
> 
> 
> >>
>

[GitHub] coveralls commented on issue #699: [SCB-532] Support recursive dependency

[GitBox]

coveralls commented on issue #699: [SCB-532] Support recursive dependency
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#issuecomment-388288890
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16934947/badge)](https://coveralls.io/builds/16934947)
   
   Coverage decreased (-0.02%) to 87.342% when pulling 
**b0a9c5ca3572d985e7af0b38cf7494b8819804a9 on 
wujimin:support-recursive-dependency** into 
**5c29a7cd224e788cb357e8c640a5f3473ceb0209 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

[GitBox]

zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388286655
 
 
   Rebase on latest master


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #693: [SCB-548] support gracefully shutdown

[GitBox]

coveralls commented on issue #693: [SCB-548] support gracefully shutdown
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387664923
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16934683/badge)](https://coveralls.io/builds/16934683)
   
   Coverage decreased (-0.3%) to 87.027% when pulling 
**5fd157edc955812d120e1dad4765527d3699316c on zhengyangyong:SCB-548** into 
**cd87c96310795e1e56a69a2d23cbfe3b2f65b28f on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin opened a new pull request #699: [SCB-532] Support recursive dependency

[GitBox]

wujimin opened a new pull request #699: [SCB-532] Support recursive dependency
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/699
 
 
   support create recursive dependency class
   ```
   1. class A {
 A a;
   }
   
   2. class A {
 B b;
   }
   class B {
 A a;
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

[GitBox]

zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388278489
 
 
   I had used a Semaphore in order to sync all invocation had finished.now 
gracefully shutdown had fixed below order :
   
   1. Unregister microservice instance from Service Center and close vertx
   2. Wait all invocation finished (delete timeout mechanism in ShutdownHandler)
   3. Notify all component do clean works via Event
   4. Stop transport and cc vertx to prevent blocking exit


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown

[GitBox]

zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388278489
 
 
   I had used a Semaphore in order to sync all invocation had finished.now 
gracefully shutdown had fixed below :
   
   1. Unregister microservice instance from Service Center and close vertx
   2. Wait all invocation finished (delete timeout mechanism in ShutdownHandler)
   3. Notify all component do clean works via Event
   4. Stop vertx to prevent blocking exit


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] little-cui closed pull request #348: SCB-491 Add the Test Schema Feature

[GitBox]

little-cui closed pull request #348: SCB-491 Add the Test Schema Feature
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/348
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/frontend/app/index.html b/frontend/app/index.html
index c6694f2d..406d6c97 100644
--- a/frontend/app/index.html
+++ b/frontend/app/index.html
@@ -62,15 +62,18 @@
 https://cdnjs.cloudflare.com/ajax/libs/angular-material-data-table/0.10.10/md-data-table.js";>
 https://rawcdn.githack.com/chartjs/Chart.js/v2.7.0/dist/Chart.js";>
 https://cdnjs.cloudflare.com/ajax/libs/angular-chart.js/1.1.1/angular-chart.js";>
-https://rawcdn.githack.com/Orange-OpenSource/angular-swagger-ui/0.5.4/dist/scripts/swagger-ui.js";>
+   
 https://rawcdn.githack.com/mmumshad/angular-yamljs/master/dist/angular-yamljs.js";>
+https://cdn.rawgit.com/asifdxtreme/angular-swagger-ui/565ed3ea/dist/scripts/swagger-ui.js";>
+
+https://cdnjs.cloudflare.com/ajax/libs/js-yaml/3.11.0/js-yaml.min.js";>
 https://cdnjs.cloudflare.com/ajax/libs/yamljs/0.1.5/yaml.js";>
-https://rawcdn.githack.com/Orange-OpenSource/angular-swagger-ui/0.5.4/dist/scripts/modules/swagger-yaml-parser.min.js";>
+https://cdn.rawgit.com/asifdxtreme/angular-swagger-ui/565ed3ea/dist/scripts/modules/swagger-yaml-parser.min.js";>
 https://fastcdn.org/FileSaver.js/1.1.20151003/FileSaver.min.js";>
 https://cdnjs.cloudflare.com/ajax/libs/jszip/3.1.4/jszip.js";>
 https://cdnjs.cloudflare.com/ajax/libs/swagger-ui/3.3.2/swagger-ui-bundle.js";>
 https://cdnjs.cloudflare.com/ajax/libs/swagger-ui/3.3.2/swagger-ui-standalone-preset.js";>
-https://cdnjs.cloudflare.com/ajax/libs/js-yaml/3.10.0/js-yaml.min.js";>
+https://cdn.rawgit.com/jeremyfa/yaml.js/v0.3.0/dist/yaml.js";>
 
 
 
diff --git a/frontend/app/scripts/languages/locale-cz.js 
b/frontend/app/scripts/languages/locale-cz.js
index a37d9a08..0036ee6d 100644
--- a/frontend/app/scripts/languages/locale-cz.js
+++ b/frontend/app/scripts/languages/locale-cz.js
@@ -86,6 +86,9 @@ angular.module('serviceCenter')
"areYouSureToDelete": "你确定删除吗？",
"cannotDeleteServiceWhenInstanceIsAvailable": "实例可用时无法删除服务",
"serviceDeletedSuccessfully": "服务已成功删除",
-   "unableToDeleteService": "无法删除服务 再试一次"
+   "unableToDeleteService": "无法删除服务 再试一次",
+   "back": "返回",
+   "highwayErr": "Highway目前不受支持",
+   "noInstanceTip": "实例不可用"
 
 });
diff --git a/frontend/app/scripts/languages/locale-en.js 
b/frontend/app/scripts/languages/locale-en.js
index 98d86ac3..16ce3a01 100644
--- a/frontend/app/scripts/languages/locale-en.js
+++ b/frontend/app/scripts/languages/locale-en.js
@@ -86,6 +86,8 @@ angular.module('serviceCenter')
"areYouSureToDelete": "Are you sure to delete ?",
"cannotDeleteServiceWhenInstanceIsAvailable": "Cannot delete service 
when instance is available",
"serviceDeletedSuccessfully": "Service Deleted Successfully",
-   "unableToDeleteService": "Unable to delete service..Try again"
-
+   "unableToDeleteService": "Unable to delete service..Try again",
+   "back": "back",
+"highwayErr": "Highway is not supported currently",
+"noInstanceTip": "Instance is not available"
 });
diff --git 
a/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js 
b/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
index aded9caf..4ff3e2b2 100644
--- a/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
+++ b/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
@@ -16,159 +16,177 @@
  */
 'use strict';
 angular.module('serviceCenter.sc')
-   .controller('schemaController',['$scope', 'apiConstant', 'httpService', 
'$stateParams', 'servicesList', '$q', '$mdDialog', 'YAML', '$http', '$state', 
'$document', '$interval',
-   function($scope, apiConstant, httpService, $stateParams, 
servicesList, $q, $mdDialog, YAML, $http, $state, $document, $interval) {
-   
-   var serviceId = $stateParams.serviceId;
-   $scope.schemaName = [];
-var addresses = [];
-var instances = [];
-var promises = [];
-   if(servicesList && servicesList.data && 
servicesList.data.services){
-   servicesList.data.services.forEach(function(services){
-   if(services.serviceId == serviceId){
-   $scope.schemaName = services.schemas || [];
-   }
-   });
-   }
+.controller('schemaController', ['$scope', 'apiConstant', 'httpService', 
'$stateParams',