Re: [DISCUSSION java-chassis]scan RestController to to make springmvc controller publish as ServiceComb Rest easier

2018-10-28 Thread yhs0092
This is a great idea! And I think we should explicitly tell users about the 
priority of @RequestMapping, @RestSchema, and @RestController, no matter on the 
release note or the gitbook. Since I've seen some users transform their 
SpringBoot/SpringCloud project into ServiceComb and leave all of these three 
annotations on their rest interface classes, it's necessary to declare this 
overwriting behavior.


Yours sincerely


Yao Haishi
yhs0...@163.com
On 10/27/2018 17:01,wjm wjm wrote:
ok

bismy  于2018年10月27日周六 下午3:14写道:

I am going to make it default to true. And add some release notes about
this change.
Our compatible rule is making things better by default, and users can
change to old feature when integration. Or we can not implement new
features due to users bad practices.




-- 原始邮件 --
发件人: "zzzwjm";
发送时间: 2018年10月27日(星期六) 中午11:05
收件人: "dev";

主题: Re: [DISCUSSION java-chassis]scan RestController to to make springmvc
controller publish as ServiceComb Rest easier



+1

but, what's default value of servicecomb.rest.service.scanRestController
if to be true, then can make spring mvc controller publish as ServiceComb
Rest easier, but maybe not compatible
but if to be false, then this feature is not so useful?

bismy  于2018年10月27日周六 上午10:57写道:

Hi all,


I am going to implement a feature that scan beans with @RestController
annotation, and taken it same as:
1. @RestSchema(schemaId = class.getName())
2. @RequestMapping("/")


Consider some users want to make use of both spring mvc controller and
ServiceComb REST, we add a configuration
servicecomb.rest.service.scanRestController
to turn off this feature.


Any suggestions?


Re: Release of ServiceComb 1.1.0

2018-10-28 Thread Willem Jiang
FYI, I fill a JIRA[1] for renaming the git repo.

[1]https://issues.apache.org/jira/browse/INFRA-17185

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem
On Sat, Oct 27, 2018 at 10:09 PM Willem Jiang  wrote:
>
> Oh,  I just forgot the github name issue which we faced when moving
> the servicecomb to apache incubator.
> I will fill a JIRA this weekend, it may take few days to do the
> transfer. Once we changed the github name, we could consider the
> release of ServiceCenter.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Sat, Oct 27, 2018 at 2:25 PM Mohammad Asif Siddiqui
>  wrote:
> >
> > Hi Willem,
> >
> > In my opinion since ServiceComb has already graduated so we can change the 
> > repository names first and migrate the SVN for the releases and then plan 
> > for the ServiceComb 1.1.0 release. In Service-Center after the change in 
> > the repository name we need to change the import statements of each file 
> > and also we need to update the Travis settings for each project and make 
> > new encryption keys for automatic snapshot deployment, for all these 
> > activities it might take 2-3 days so we can plan this first in coming week 
> > and then we can go ahead with the Service-Center 1.1.0 release.
> >
> > Just my 2 cents..
> >
> > Regards
> > Asif
> >
> > On 2018/10/22 03:39:02, Willem Jiang  wrote:
> > > Hi,
> > >
> > > The last ServiceComb java-chassis,service-center 1.0.0 release is
> > > three month ago. It's time to discuss the release of ServiceComb
> > > 1.1.0.
> > >
> > > As we add the TCC implementation in the Saga 0.3.0, we may need to
> > > create a separate git repo to support the Saga and TCC at the same
> > > time.  It may take sometime to do these change. We may do the Saga
> > > release after the release of java-chassis and service-center.
> > >
> > > Regards,
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >