There are 115 problems pointed out by CheckStyle. The problem distribution is
like below:
- service-registry: 69
- spring-boot2-starter-servlet: 9
- spring-boot2-starter-discovery: 1
- spring-boot-common: 3
- spring-boot-starter-registry: 1
- spring-boot-starter-transport: 1
- spring-cloud-zuul-zipkin: 3
- spring-boot-starter-discovery: 1
- foundation-common: 27
The problems are mainly about the name of consts, the constructor of utility
classes, the length of lines, redundant modifiers and magic numbers.
Other problems scanned by findbugs is not counted here. To fix these problems ,
there are too many files should be modified. I've created an issue[1] to track
it and wait the weak type work finished.
[1]: https://issues.apache.org/jira/browse/SCB-1354
Yours sincerely
Yao Haishi
yhs0...@163.com
On 7/7/2019 09:03，Willem Jiang wrote：
Hi Haishi,
Can you list the potential problems which you find?
If they are not the blocker issues, I think we can start to fix them
after the weak type work is finished.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Sat, Jul 6, 2019 at 11:46 AM wjm wjm wrote:
ohoh, lots of source files? maybe cause very difficult to merge weak type
branch?
yhs0092 于2019年7月5日周五 下午7:43写道：
Hi, guys. I've run code static checks for the source code of
ServiceComb-Java-Chassis and find several potential problems.
I want to raise an issue to fix these problems. The changes may be
distributed among a lot of source code files and they are all for code
style and complexity improvement.
Cause I've never handle such kind of issues, is there any thing I should
be aware of?
Yours sincerely
Yao Haishi
yhs0...@163.com
