Re: [VOTE] Release Apache ServiceComb Java-Chassis version 1.3.0

2019-11-04 Thread sen sun
+1

I checked :
Hashes and signature are good.
mvn clean install is ok

Bin Ma  于2019年10月29日周二 下午2:22写道:

> Got it.
>
> +1
>
> Wishes & Regards
> -- -
> Mabin
>
>
>
> Willem Jiang < willem.ji...@gmail.com >于2019年10月29日周二上午8:02写道:
>
> > Hi MaBin,
> >
> > You just need to
> > Please check out this link[1] for the release note of ServiceComb Java
> > Chassis 1.3.0.
> >
> > [1] https://issues.apache.org/ jira/secure/ReleaseNote.jspa? version=
> > 12345462&styleName=& projectId=12321626&Create= Create
> > <
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345462&styleName=&projectId=12321626&Create=Create
> >
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo:姜宁willem
> >
> > On Mon, Oct 28, 2019 at 11:13 PM Bin Ma < mabin1...@gmail.com > wrote:
> > >
> > > Hi bismy,
> > >
> > > I checked the Release Notes,but I could not find
> > > the issues lists for Java-Chassis version 1.3.0.
> > >
> > > Compared with the previous version ServiceComb Java-Chassis 1.2.1,
> > > version 1.3.0
> > > no solve any issues?
> > >
> > > Wishes & Regards
> > > -- -
> > > Mabin
> > >
> > >
> > >
> > >
> > > Willem Jiang < willem.ji...@gmail.com >于2019年10月28日周一下午2:28写道:
> > >
> > > > +1. (Binding)
> > > >
> > > > Checked the release candidate of source and binary,
> > > > Checked staging repo.
> > > >
> > > > Thanks for the LiuBao's hard work to cut the release kit.
> > > >
> > > > Willem Jiang
> > > >
> > > > Twitter: willemjiang
> > > > Weibo:姜宁willem
> > > >
> > >> On Sat, Oct 26, 2019 at 5 :33 PM bismy < bi...@qq.com> wrote:
> > > > >
> > > > > Hello All,
> > > > >
> > > > >
> > > > > This is a call for a Vote to release Apache ServiceComb
> Java-Chassis
> > > > version 1.3.0
> > > > >
> > > > >
> > > > > Release Notes :
> > > > > https:// issues.apache.org/ jira/secure/ReleaseNote.jspa?
> > projectId=12321626&
> > > > version=12345462
> > > > < https://issues.apache.org/ jira/secure/ReleaseNote .jspa?
> projectId=12321626&
> > version=12345462
> > <
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12345462
> >
> > >
> > > > >
> > > > >
> > > > > Release Candidate :
> > > > >https://dist.apache.org/ repos/ 
> > dist/dev/servicecomb/ servicecomb-java-chassis/1.3.
> > > > 0/rc01/
> > > > < https://dist.apache.org/ repos/dist/dev/servicecomb/
> servicecomb-java-chassis/1.3.
> > 0/rc01/
> > <
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-java-chassis/1.3.0/rc01/
> >
> > >
> > > > >
> > > > >
> > > > > Staging Repo :
> > > > > https://repository.apache.org/ content/repositories /
> > > > orgapacheservicecomb-1408
> > > > < https://repository.apache. org/content/repositories/
> > orgapacheservicecomb-1408
> > <
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1408
> >
> > >
> > > > >
> > > > >
> > > > > Release Tag :
> > > > > https://github.com/apache/ servicecomb-java-chassis/
> > releases/tag/1.3.0
> > > >  > releases/tag/1.3.0
> > 
> >
> > > > >
> > > > >
> > > > > Release CommitID : 3896be3afdfd51256e59ec8ceed0f1 aa04c3b035
> > > > >
> > > > >
> > > > > Keys to verify the Release Candidate :
> > > > > https://dist.apache.org /repos/ 
> > dist/dev/servicecomb/KEYS
> > > > < https://dist.apache.org/ repos/dist/dev/servicecomb/ KEYS
> >  >
> > > > >
> > > > >
> > > > > Voting will start now ( Friday, 26 October, 2019) and will remain
> > open
> > > > > for at-least 72 hours, Request all PMC members to give their vote.
> > > > >
> > > > >
> > > >> [ ] +1 Release this package as 1.3.0
> > > > > [ ] +0 No Opinion
> > > > > [ ] -1 Do not release this package because
> > > > >
> > > > >
> > > > > On the behalf of ServiceComb Team
> > > > > Liu Bao
> > > >
> >
>


Re: [DISCUSSION][Toolkit] Integrate oas-validator compliance functionality

2019-11-04 Thread Daniel Qian
Hi Ma, since we discussed about compatibility check sub command to be:
cc / checkcompatibility .[1]
So, we can also use cs / checkstyle here.

[1]: 
https://lists.apache.org/thread.html/c88cda03ec52182482679bd9be36b9ad57bc8d03ee43a4912ad38d90@%3Cdev.servicecomb.apache.org%3E

Daniel Qian  于2019年11月1日周五 下午5:11写道:
>
> PR[1] created
>
> [1] https://github.com/apache/servicecomb-toolkit/pull/42
>
> Willem Jiang  于2019年11月1日周五 下午12:26写道:
> >
> > Hi Daniel
> >
> > Yeah, I think it's a very good idea.
> > Looking forward your PR.
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Wed, Oct 30, 2019 at 10:31 AM Daniel Qian  wrote:
> > >
> > > I created an issue SCB-1553[1] to integrate oas-validator compliance
> > > check to toolkit cli.
> > >
> > > I suggest the usage like this:
> > >
> > > java -jar toolkit-cli-{version}.jar checkstyle /path/to/openapiv3.yaml
> > >
> > > I prefer checksytle because of it's clearer than compliance.
> > >
> > > oas-validator compliance doc could be found here[2]
> > >
> > > [1] https://issues.apache.org/jira/projects/SCB/issues/SCB-1553
> > > [2] 
> > > https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%90%88%E8%A7%84%E6%80%A7%E6%A0%A1%E9%AA%8C
> > >
> > > --
> > > Daniel Qian
> > >
> > > 博客:https://segmentfault.com/u/chanjarster
> > > github:https://github.com/chanjarster
>
>
>
> --
> Daniel Qian
>
> 博客:https://segmentfault.com/u/chanjarster
> github:https://github.com/chanjarster



-- 
Daniel Qian

博客:https://segmentfault.com/u/chanjarster
github:https://github.com/chanjarster


Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Daniel Qian
Hi Ma, got it.

Bin Ma  于2019年11月5日周二 上午11:19写道:
>
> Hi Daniel,
>
> Sorry, I misread the question.
>
> I think it's better to support both checkcompatibility and cc as
> subcommands.
>
> Wishes & Regards
> ---
> Mabin
>
>
>
> sen sun  于2019年11月5日周二 上午9:40写道:
>
> > I think Ma just made an example of the option naming style instead of the
> > subcommand.
> > I think it's a good idea to support both checkcompatibility and cc as
> > subcommands.
> >
> > Daniel Qian  于2019年11月5日周二 上午7:28写道:
> >
> > > Hello Ma, found current cli style is  .
> > > So if we do --check-compatability then which subcommand should we use?
> > >
> > > Bin Ma  于2019年11月5日周二 上午12:44写道:
> > > >
> > > > I recommend keeping the same as the current option naming style,
> > > > such as "-c", "-- check-compability "
> > > >
> > > >
> > > > Wishes & Regards
> > > > ---
> > > > Mabin
> > > >
> > > >
> > > >
> > > > Willem Jiang  于2019年11月1日周五 下午12:31写道:
> > > >
> > > > > I think we can support checkcompatibility and the short one cc at the
> > > same
> > > > > time.
> > > > > Any thoughts?
> > > > >
> > > > > Willem Jiang
> > > > >
> > > > > Twitter: willemjiang
> > > > > Weibo: 姜宁willem
> > > > >
> > > > > On Wed, Oct 30, 2019 at 10:37 AM Daniel Qian 
> > > > > wrote:
> > > > > >
> > > > > > I created an issue SCB-1555[1] to integrate oas-validator
> > > > > > compatibility check to toolkit cli.
> > > > > >
> > > > > > I suggest usage like this:
> > > > > > java -jar toolkit-cli-{version}.jar checkcompability
> > > > > > /path/to/openapiv3-1.yaml /path/to/openapiv3-2.yaml
> > > > > >
> > > > > > But the subcommand checkcompability is too long, maybe we can use a
> > > > > > abbr for it, such as cc?
> > > > > >
> > > > > > Any ideas?
> > > > > >
> > > > > > [1] https://issues.apache.org/jira/browse/SCB-1555
> > > > > > [2]
> > > > >
> > >
> > https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%85%BC%E5%AE%B9%E6%80%A7%E6%A3%80%E6%9F%A5
> > > > > >
> > > > > > --
> > > > > > Daniel Qian
> > > > > >
> > > > > > 博客:https://segmentfault.com/u/chanjarster
> > > > > > github:https://github.com/chanjarster
> > > > >
> > >
> > >
> > >
> > > --
> > > Daniel Qian
> > >
> > > 博客:https://segmentfault.com/u/chanjarster
> > > github:https://github.com/chanjarster
> > >
> >



-- 
Daniel Qian

博客:https://segmentfault.com/u/chanjarster
github:https://github.com/chanjarster


Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Bin Ma
Hi Daniel,

Sorry, I misread the question.

I think it's better to support both checkcompatibility and cc as
subcommands.

Wishes & Regards
---
Mabin



sen sun  于2019年11月5日周二 上午9:40写道:

> I think Ma just made an example of the option naming style instead of the
> subcommand.
> I think it's a good idea to support both checkcompatibility and cc as
> subcommands.
>
> Daniel Qian  于2019年11月5日周二 上午7:28写道:
>
> > Hello Ma, found current cli style is  .
> > So if we do --check-compatability then which subcommand should we use?
> >
> > Bin Ma  于2019年11月5日周二 上午12:44写道:
> > >
> > > I recommend keeping the same as the current option naming style,
> > > such as "-c", "-- check-compability "
> > >
> > >
> > > Wishes & Regards
> > > ---
> > > Mabin
> > >
> > >
> > >
> > > Willem Jiang  于2019年11月1日周五 下午12:31写道:
> > >
> > > > I think we can support checkcompatibility and the short one cc at the
> > same
> > > > time.
> > > > Any thoughts?
> > > >
> > > > Willem Jiang
> > > >
> > > > Twitter: willemjiang
> > > > Weibo: 姜宁willem
> > > >
> > > > On Wed, Oct 30, 2019 at 10:37 AM Daniel Qian 
> > > > wrote:
> > > > >
> > > > > I created an issue SCB-1555[1] to integrate oas-validator
> > > > > compatibility check to toolkit cli.
> > > > >
> > > > > I suggest usage like this:
> > > > > java -jar toolkit-cli-{version}.jar checkcompability
> > > > > /path/to/openapiv3-1.yaml /path/to/openapiv3-2.yaml
> > > > >
> > > > > But the subcommand checkcompability is too long, maybe we can use a
> > > > > abbr for it, such as cc?
> > > > >
> > > > > Any ideas?
> > > > >
> > > > > [1] https://issues.apache.org/jira/browse/SCB-1555
> > > > > [2]
> > > >
> >
> https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%85%BC%E5%AE%B9%E6%80%A7%E6%A3%80%E6%9F%A5
> > > > >
> > > > > --
> > > > > Daniel Qian
> > > > >
> > > > > 博客:https://segmentfault.com/u/chanjarster
> > > > > github:https://github.com/chanjarster
> > > >
> >
> >
> >
> > --
> > Daniel Qian
> >
> > 博客:https://segmentfault.com/u/chanjarster
> > github:https://github.com/chanjarster
> >
>


Re: [VOTE] Release Apache ServiceComb Service-Center version 1.3.0

2019-11-04 Thread Willem Jiang
If the vote is not closed, we can still keep voting it.
As Asif just update the artifacts without changing the release tag we
can still use the last vote thread.

Let's verify the kit as soon as possible.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Tue, Nov 5, 2019 at 1:06 AM Bin Ma  wrote:
>
> Hi Asif,
>
> Voting time has expired and no result,maybe we should
> start a new voting for Service-Center version 1.3.0?
>
>
> Wishes & Regards
> ---
> Mabin
>
>
>
> Liubao (A)  于2019年11月4日周一 下午4:14写道:
>
> > +1
> >
> > I have checked the release notes and binaries. Do some basic tests with
> > windows version.
> >
> > -邮件原件-
> > 发件人: Mohammad Asif Siddiqui [mailto:asifdxtr...@apache.org]
> > 发送时间: 2019年10月31日 22:06
> > 收件人: dev@servicecomb.apache.org
> > 主题: Re: [VOTE] Release Apache ServiceComb Service-Center version 1.3.0
> >
> > Hi All,
> >
> > I faced some network problem with my SVN client so the packages which were
> > uploaded were outdated, I have uploaded the correct rc in the svn now, hope
> > we can go ahead with the voting now.
> >
> > Here is my +1 (Binding)
> >
> > Checks Done:
> >  - verify hash and signature
> >  - ran the test cases on linux
> >  - check with RAT tool for ASF headers
> >
> > Regards
> > Asif
> >
> > On 2019/10/30 01:17:21, victor chan  wrote:
> > > Hi Asif,
> > > gpg --verify also fails, the following is the error message,
> > >
> > > root@chenzhu:~/chan/release# gpg --verify
> > > apache-servicecomb-service-center-1.3.0-src.zip.asc
> > > apache-servicecomb-service-center-1.3.0-src.zip
> > > gpg: Signature made Sun 27 Oct 2019 05:03:20 PM CST using RSA key ID
> > > BD7A4D69
> > > gpg: Good signature from "Mohammad Asif Siddiqui (ServiceComb Code
> > > Signing
> > > Key) "
> > > gpg: WARNING: This key is not certified with a trusted signature!
> > > gpg:  There is no indication that the signature belongs to the
> > > owner.
> > > Primary key fingerprint: 42C0 D794 0FCD E5E6 30E4  AAE3 DC93 F696 BD7A
> > > 4D69 root@chenzhu:~/chan/release# gpg --verify
> > > apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz.asc
> > > apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz
> > > gpg: Signature made Sun 27 Oct 2019 05:04:00 PM CST using RSA key ID
> > > BD7A4D69
> > > gpg: BAD signature from "Mohammad Asif Siddiqui (ServiceComb Code
> > > Signing
> > > Key) "
> > > root@chenzhu:~/chan/release# gpg --verify
> > > apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz.asc
> > > apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz
> > > gpg: Signature made Sun 27 Oct 2019 05:03:44 PM CST using RSA key ID
> > > BD7A4D69
> > > gpg: BAD signature from "Mohammad Asif Siddiqui (ServiceComb Code
> > > Signing
> > > Key) "
> > > root@chenzhu:~/chan/release# gpg --verify
> > > apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz.asc
> > > apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz
> > > gpg: Signature made Sun 27 Oct 2019 05:03:55 PM CST using RSA key ID
> > > BD7A4D69
> > > gpg: BAD signature from "Mohammad Asif Siddiqui (ServiceComb Code
> > > Signing
> > > Key) "
> > > root@chenzhu:~/chan/release# gpg --list-keys /root/.gnupg/pubring.gpg
> > > 
> > > pub   4096R/BD7A4D69 2018-03-11
> > > uid  Mohammad Asif Siddiqui (ServiceComb Code Signing
> > Key) <
> > > asifdxtr...@apache.org>
> > > sub   4096R/DF1487F5 2018-03-11
> > >
> > > pub   4096R/50764CEC 2019-08-23
> > > uid  mabin 
> > > sub   4096R/973DAB8F 2019-08-23
> > >
> > >
> > > root@chenzhu:~/chan/release# sha512sum -c
> > > apache-servicecomb-service-center-1.3.0-src.zip.sha512
> > > apache-servicecomb-service-center-1.3.0-src.zip: OK
> > > root@chenzhu:~/chan/release# sha512sum -c
> > > apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz.sha512
> > > apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz: FAILED
> > > sha512sum: WARNING: 1 computed checksum did NOT match
> > > root@chenzhu:~/chan/release# sha512sum -c
> > > apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz.sha512
> > > apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz: FAILED
> > > sha512sum: WARNING: 1 computed checksum did NOT match
> > > root@chenzhu:~/chan/release# sha512sum -c
> > > apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz.sha512
> > > apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz: FAILED
> > > sha512sum: WARNING: 1 computed checksum did NOT match
> > >
> > > Wishes & Regards
> > >
> > > Mohammad Asif Siddiqui  于2019年10月27日周日
> > > 下午5:14写道:
> > >
> > > > Hi All,
> > > >
> > > > This is a call for a Vote to release Apache ServiceComb
> > > > Service-Center version 1.3.0
> > > >
> > > > Release Notes :
> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=123
> > > > 21626&version=12345385
> > > >
> > > >
> > > > Release Candidate :
> > > > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-servi
> > > > ce-cen

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread sen sun
I think Ma just made an example of the option naming style instead of the
subcommand.
I think it's a good idea to support both checkcompatibility and cc as
subcommands.

Daniel Qian  于2019年11月5日周二 上午7:28写道:

> Hello Ma, found current cli style is  .
> So if we do --check-compatability then which subcommand should we use?
>
> Bin Ma  于2019年11月5日周二 上午12:44写道:
> >
> > I recommend keeping the same as the current option naming style,
> > such as "-c", "-- check-compability "
> >
> >
> > Wishes & Regards
> > ---
> > Mabin
> >
> >
> >
> > Willem Jiang  于2019年11月1日周五 下午12:31写道:
> >
> > > I think we can support checkcompatibility and the short one cc at the
> same
> > > time.
> > > Any thoughts?
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > > On Wed, Oct 30, 2019 at 10:37 AM Daniel Qian 
> > > wrote:
> > > >
> > > > I created an issue SCB-1555[1] to integrate oas-validator
> > > > compatibility check to toolkit cli.
> > > >
> > > > I suggest usage like this:
> > > > java -jar toolkit-cli-{version}.jar checkcompability
> > > > /path/to/openapiv3-1.yaml /path/to/openapiv3-2.yaml
> > > >
> > > > But the subcommand checkcompability is too long, maybe we can use a
> > > > abbr for it, such as cc?
> > > >
> > > > Any ideas?
> > > >
> > > > [1] https://issues.apache.org/jira/browse/SCB-1555
> > > > [2]
> > >
> https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%85%BC%E5%AE%B9%E6%80%A7%E6%A3%80%E6%9F%A5
> > > >
> > > > --
> > > > Daniel Qian
> > > >
> > > > 博客:https://segmentfault.com/u/chanjarster
> > > > github:https://github.com/chanjarster
> > >
>
>
>
> --
> Daniel Qian
>
> 博客:https://segmentfault.com/u/chanjarster
> github:https://github.com/chanjarster
>


Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Daniel Qian
Hello Ma, found current cli style is  .
So if we do --check-compatability then which subcommand should we use?

Bin Ma  于2019年11月5日周二 上午12:44写道:
>
> I recommend keeping the same as the current option naming style,
> such as "-c", "-- check-compability "
>
>
> Wishes & Regards
> ---
> Mabin
>
>
>
> Willem Jiang  于2019年11月1日周五 下午12:31写道:
>
> > I think we can support checkcompatibility and the short one cc at the same
> > time.
> > Any thoughts?
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Wed, Oct 30, 2019 at 10:37 AM Daniel Qian 
> > wrote:
> > >
> > > I created an issue SCB-1555[1] to integrate oas-validator
> > > compatibility check to toolkit cli.
> > >
> > > I suggest usage like this:
> > > java -jar toolkit-cli-{version}.jar checkcompability
> > > /path/to/openapiv3-1.yaml /path/to/openapiv3-2.yaml
> > >
> > > But the subcommand checkcompability is too long, maybe we can use a
> > > abbr for it, such as cc?
> > >
> > > Any ideas?
> > >
> > > [1] https://issues.apache.org/jira/browse/SCB-1555
> > > [2]
> > https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%85%BC%E5%AE%B9%E6%80%A7%E6%A3%80%E6%9F%A5
> > >
> > > --
> > > Daniel Qian
> > >
> > > 博客:https://segmentfault.com/u/chanjarster
> > > github:https://github.com/chanjarster
> >



-- 
Daniel Qian

博客:https://segmentfault.com/u/chanjarster
github:https://github.com/chanjarster


Re: [VOTE] Release Apache ServiceComb Service-Center version 1.3.0

2019-11-04 Thread Bin Ma
Hi Asif,

Voting time has expired and no result,maybe we should
start a new voting for Service-Center version 1.3.0?


Wishes & Regards
---
Mabin



Liubao (A)  于2019年11月4日周一 下午4:14写道:

> +1
>
> I have checked the release notes and binaries. Do some basic tests with
> windows version.
>
> -邮件原件-
> 发件人: Mohammad Asif Siddiqui [mailto:asifdxtr...@apache.org]
> 发送时间: 2019年10月31日 22:06
> 收件人: dev@servicecomb.apache.org
> 主题: Re: [VOTE] Release Apache ServiceComb Service-Center version 1.3.0
>
> Hi All,
>
> I faced some network problem with my SVN client so the packages which were
> uploaded were outdated, I have uploaded the correct rc in the svn now, hope
> we can go ahead with the voting now.
>
> Here is my +1 (Binding)
>
> Checks Done:
>  - verify hash and signature
>  - ran the test cases on linux
>  - check with RAT tool for ASF headers
>
> Regards
> Asif
>
> On 2019/10/30 01:17:21, victor chan  wrote:
> > Hi Asif,
> > gpg --verify also fails, the following is the error message,
> >
> > root@chenzhu:~/chan/release# gpg --verify
> > apache-servicecomb-service-center-1.3.0-src.zip.asc
> > apache-servicecomb-service-center-1.3.0-src.zip
> > gpg: Signature made Sun 27 Oct 2019 05:03:20 PM CST using RSA key ID
> > BD7A4D69
> > gpg: Good signature from "Mohammad Asif Siddiqui (ServiceComb Code
> > Signing
> > Key) "
> > gpg: WARNING: This key is not certified with a trusted signature!
> > gpg:  There is no indication that the signature belongs to the
> > owner.
> > Primary key fingerprint: 42C0 D794 0FCD E5E6 30E4  AAE3 DC93 F696 BD7A
> > 4D69 root@chenzhu:~/chan/release# gpg --verify
> > apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz.asc
> > apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz
> > gpg: Signature made Sun 27 Oct 2019 05:04:00 PM CST using RSA key ID
> > BD7A4D69
> > gpg: BAD signature from "Mohammad Asif Siddiqui (ServiceComb Code
> > Signing
> > Key) "
> > root@chenzhu:~/chan/release# gpg --verify
> > apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz.asc
> > apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz
> > gpg: Signature made Sun 27 Oct 2019 05:03:44 PM CST using RSA key ID
> > BD7A4D69
> > gpg: BAD signature from "Mohammad Asif Siddiqui (ServiceComb Code
> > Signing
> > Key) "
> > root@chenzhu:~/chan/release# gpg --verify
> > apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz.asc
> > apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz
> > gpg: Signature made Sun 27 Oct 2019 05:03:55 PM CST using RSA key ID
> > BD7A4D69
> > gpg: BAD signature from "Mohammad Asif Siddiqui (ServiceComb Code
> > Signing
> > Key) "
> > root@chenzhu:~/chan/release# gpg --list-keys /root/.gnupg/pubring.gpg
> > 
> > pub   4096R/BD7A4D69 2018-03-11
> > uid  Mohammad Asif Siddiqui (ServiceComb Code Signing
> Key) <
> > asifdxtr...@apache.org>
> > sub   4096R/DF1487F5 2018-03-11
> >
> > pub   4096R/50764CEC 2019-08-23
> > uid  mabin 
> > sub   4096R/973DAB8F 2019-08-23
> >
> >
> > root@chenzhu:~/chan/release# sha512sum -c
> > apache-servicecomb-service-center-1.3.0-src.zip.sha512
> > apache-servicecomb-service-center-1.3.0-src.zip: OK
> > root@chenzhu:~/chan/release# sha512sum -c
> > apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz.sha512
> > apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz: FAILED
> > sha512sum: WARNING: 1 computed checksum did NOT match
> > root@chenzhu:~/chan/release# sha512sum -c
> > apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz.sha512
> > apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz: FAILED
> > sha512sum: WARNING: 1 computed checksum did NOT match
> > root@chenzhu:~/chan/release# sha512sum -c
> > apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz.sha512
> > apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz: FAILED
> > sha512sum: WARNING: 1 computed checksum did NOT match
> >
> > Wishes & Regards
> >
> > Mohammad Asif Siddiqui  于2019年10月27日周日
> > 下午5:14写道:
> >
> > > Hi All,
> > >
> > > This is a call for a Vote to release Apache ServiceComb
> > > Service-Center version 1.3.0
> > >
> > > Release Notes :
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=123
> > > 21626&version=12345385
> > >
> > >
> > > Release Candidate :
> > > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-servi
> > > ce-center/1.3.0
> > >
> > >
> > > Release Tag :
> > > https://github.com/apache/servicecomb-service-center/releases/tag/1.
> > > 3.0
> > >
> > > Release CommitID : c2dc0caef7069ff38cd7395582cf0883d4172dc4
> > >
> > > Keys to verify the Release Candidate :
> > > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> > >
> > > Guide to build the release from source :
> > > https://github.com/apache/servicecomb-service-center/tree/master/scr
> > > ipts/release
> > >
> > >
> > > Voting will start now ( Sunday, 27th October, 2019) and will remain
> > > open

Re: [DISCUSSION][Toolkit] Integrate oas-validator compability check functionality

2019-11-04 Thread Bin Ma
I recommend keeping the same as the current option naming style,
such as "-c", "-- check-compability "


Wishes & Regards
---
Mabin



Willem Jiang  于2019年11月1日周五 下午12:31写道:

> I think we can support checkcompatibility and the short one cc at the same
> time.
> Any thoughts?
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Wed, Oct 30, 2019 at 10:37 AM Daniel Qian 
> wrote:
> >
> > I created an issue SCB-1555[1] to integrate oas-validator
> > compatibility check to toolkit cli.
> >
> > I suggest usage like this:
> > java -jar toolkit-cli-{version}.jar checkcompability
> > /path/to/openapiv3-1.yaml /path/to/openapiv3-2.yaml
> >
> > But the subcommand checkcompability is too long, maybe we can use a
> > abbr for it, such as cc?
> >
> > Any ideas?
> >
> > [1] https://issues.apache.org/jira/browse/SCB-1555
> > [2]
> https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%85%BC%E5%AE%B9%E6%80%A7%E6%A3%80%E6%9F%A5
> >
> > --
> > Daniel Qian
> >
> > 博客:https://segmentfault.com/u/chanjarster
> > github:https://github.com/chanjarster
>


Problem with implementing interface SagaMessageSender in the ServiceComb Pack

2019-11-04 Thread Zhang Lei
Hi, Team

In the ServiceComb Pack, Classes RetryableMessageSender.java
SagaLoadBalanceSender.java and GrpcSagaClientMessageSender.java implement
the interface SagaMessageSender.

I have two questions:
1. RetryableMessageSender.java unused
2. Both  SagaLoadBalanceSender.java and
GrpcSagaClientMessageSender.java implement interface MessageSender. I am
confused about why doing this.


Best regards,
Lei Zhang


答复: [VOTE] Release Apache ServiceComb Service-Center version 1.3.0

2019-11-04 Thread Liubao (A)
+1

I have checked the release notes and binaries. Do some basic tests with windows 
version. 

-邮件原件-
发件人: Mohammad Asif Siddiqui [mailto:asifdxtr...@apache.org] 
发送时间: 2019年10月31日 22:06
收件人: dev@servicecomb.apache.org
主题: Re: [VOTE] Release Apache ServiceComb Service-Center version 1.3.0

Hi All,  
  
I faced some network problem with my SVN client so the packages which were 
uploaded were outdated, I have uploaded the correct rc in the svn now, hope we 
can go ahead with the voting now.  
  
Here is my +1 (Binding)  
  
Checks Done:  
 - verify hash and signature
 - ran the test cases on linux
 - check with RAT tool for ASF headers  
  
Regards
Asif

On 2019/10/30 01:17:21, victor chan  wrote: 
> Hi Asif,
> gpg --verify also fails, the following is the error message,
> 
> root@chenzhu:~/chan/release# gpg --verify 
> apache-servicecomb-service-center-1.3.0-src.zip.asc
> apache-servicecomb-service-center-1.3.0-src.zip
> gpg: Signature made Sun 27 Oct 2019 05:03:20 PM CST using RSA key ID
> BD7A4D69
> gpg: Good signature from "Mohammad Asif Siddiqui (ServiceComb Code 
> Signing
> Key) "
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg:  There is no indication that the signature belongs to the
> owner.
> Primary key fingerprint: 42C0 D794 0FCD E5E6 30E4  AAE3 DC93 F696 BD7A 
> 4D69 root@chenzhu:~/chan/release# gpg --verify 
> apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz.asc
> apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz
> gpg: Signature made Sun 27 Oct 2019 05:04:00 PM CST using RSA key ID
> BD7A4D69
> gpg: BAD signature from "Mohammad Asif Siddiqui (ServiceComb Code 
> Signing
> Key) "
> root@chenzhu:~/chan/release# gpg --verify 
> apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz.asc
> apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz
> gpg: Signature made Sun 27 Oct 2019 05:03:44 PM CST using RSA key ID
> BD7A4D69
> gpg: BAD signature from "Mohammad Asif Siddiqui (ServiceComb Code 
> Signing
> Key) "
> root@chenzhu:~/chan/release# gpg --verify 
> apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz.asc
> apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz
> gpg: Signature made Sun 27 Oct 2019 05:03:55 PM CST using RSA key ID
> BD7A4D69
> gpg: BAD signature from "Mohammad Asif Siddiqui (ServiceComb Code 
> Signing
> Key) "
> root@chenzhu:~/chan/release# gpg --list-keys /root/.gnupg/pubring.gpg
> 
> pub   4096R/BD7A4D69 2018-03-11
> uid  Mohammad Asif Siddiqui (ServiceComb Code Signing Key) <
> asifdxtr...@apache.org>
> sub   4096R/DF1487F5 2018-03-11
> 
> pub   4096R/50764CEC 2019-08-23
> uid  mabin 
> sub   4096R/973DAB8F 2019-08-23
> 
> 
> root@chenzhu:~/chan/release# sha512sum -c
> apache-servicecomb-service-center-1.3.0-src.zip.sha512
> apache-servicecomb-service-center-1.3.0-src.zip: OK 
> root@chenzhu:~/chan/release# sha512sum -c
> apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz.sha512
> apache-servicecomb-service-center-1.3.0-darwin-amd64.tar.gz: FAILED
> sha512sum: WARNING: 1 computed checksum did NOT match 
> root@chenzhu:~/chan/release# sha512sum -c
> apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz.sha512
> apache-servicecomb-service-center-1.3.0-linux-amd64.tar.gz: FAILED
> sha512sum: WARNING: 1 computed checksum did NOT match 
> root@chenzhu:~/chan/release# sha512sum -c
> apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz.sha512
> apache-servicecomb-service-center-1.3.0-windows-amd64.tar.gz: FAILED
> sha512sum: WARNING: 1 computed checksum did NOT match
> 
> Wishes & Regards
> 
> Mohammad Asif Siddiqui  于2019年10月27日周日 
> 下午5:14写道:
> 
> > Hi All,
> >
> > This is a call for a Vote to release Apache ServiceComb 
> > Service-Center version 1.3.0
> >
> > Release Notes :
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=123
> > 21626&version=12345385
> >
> >
> > Release Candidate :
> > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-servi
> > ce-center/1.3.0
> >
> >
> > Release Tag :
> > https://github.com/apache/servicecomb-service-center/releases/tag/1.
> > 3.0
> >
> > Release CommitID : c2dc0caef7069ff38cd7395582cf0883d4172dc4
> >
> > Keys to verify the Release Candidate :
> > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> >
> > Guide to build the release from source :
> > https://github.com/apache/servicecomb-service-center/tree/master/scr
> > ipts/release
> >
> >
> > Voting will start now ( Sunday, 27th October, 2019) and will remain 
> > open for at-least 72 hours, Request all PMC members to give their vote.
> >
> > [ ] +1 Release this package as 1.3.0 [ ] +0 No Opinion [ ] -1 Do not 
> > release this package because
> >
> > On the behalf of ServiceComb Team
> > Mohammad Asif Siddiqui
> >
>