Re: [DISCUSS][JavaChassis] Specify a way to generate java.time.Clock

2019-12-14 Thread Willem Jiang
It think we may provide a way to set the zone by checking the System
variable such TZ[1], if we cannot find the variable, we could use the
system default as a fallback with some log information.

[1]https://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Thu, Dec 12, 2019 at 4:51 PM Ang Li  wrote:
>
> Hi Team,
> I am currently solving issue 
> [SBC-1559](https://issues.apache.org/jira/browse/SCB-1559). The core idea of 
> this issue is using java.time.Clock instead 
> of java.lang.System#currentTimeMillis to get time for mocking 
> purpose. 
> java.time.Clock provides many different ways to generate a clock. I am 
> wondering which one should we use and do we need to specify a zone?
> Thanks a lot if someone can help.
>
>
> --
> Ang Li


Re: [DISCUSS][JavaChassis] Specify a way to generate java.time.Clock

2019-12-14 Thread yhs0092
Hi, maybe use Clock.systemDefaultZone() is okay? Users will specify the JVM 
timezone if necessary.


Yours sincerely


Yao Haishi
yhs0...@163.com


On 12/12/2019 16:50??Ang Li wrote??
Hi Team,
I am currently solving issue 
[SBC-1559](https://issues.apache.org/jira/browse/SCB-1559). The core idea of 
this issue is using java.time.Clock instead 
of java.lang.System#currentTimeMillis to get time for mocking 
purpose. 
java.time.Clock provides many different ways to generate a clock. I am 
wondering which one should we use and do we need to specify a zone?
Thanks a lot if someone can help.


--
Ang Li

[DISCUSS] Use jackson afterburner to speed up jackson processing

2019-12-14 Thread Ang Li
Hi, team

Jackson Afterburner 
(https://github.com/FasterXML/jackson-modules-base/tree/master/afterburner) is 
a jackson accelerator module provided by jackson which is very convenient to be 
added to projects using Java to accelarate jackson processing. 


I have already created a PR to add the module to servicecomb-java-chassis. But 
I am not sure whether it can be added to other servicecomb projects (too many 
servicecomb subprojects). 


Please add comments to SCB-1662 
(https://issues.apache.org/jira/browse/SCB-1662) if the module can be used in 
other servicecomb subprojects besides servicecomb-java-chassis and I am happy 
to do the rest.



Ang Li