Re: Apache ServiceComb Pack emergency releases for wrong version
Hi, Willem I will push the following two files to https://github.com/apache/servicecomb-website/tree/master/_release saga_releaseGuide.md cn/saga_releaseGuide.md Lei Zhang Willem Jiang 于2022年8月5日周五 16:03写道： > I think you can just update the markdown file in the servicecomb > website here[1]. > > [1]https://github.com/apache/servicecomb-website/tree/master/_release > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Fri, Aug 5, 2022 at 3:20 PM Lei Zhang wrote: > > > > Hi, Willem > > > > This is a good suggestion, I will add a version number check script to > the > > release guide > > > > Also, the pack release guide contains a lot of how-to details > > There is a big difference between the servicecomb website > > Can we push the release guide to the pack repo and add a link on > > servicecomb website？ > > > > > > > > > > > > > > Willem Jiang 于2022年8月5日周五 10:55写道： > > > > > It would be great if we can update the release guide on the servicecomb > > > website. > > > BTW, it's strange that maven release plugin can allow the release > > > artifact as the dependency of SNAPSHOT. > > > Not sure if it relates to the flatten-maven plugin. > > > My suggestion is we should add a check script to avoid this mistake > > > just like below: > > > find ~/.m2/repository/org/apache/servicecomb/pack -name "0.7.0.pom" | > > > xargs grep "SNAPSHOT" > > > > > > > > > Willem Jiang > > > > > > Twitter: willemjiang > > > Weibo: 姜宁willem > > > > > > On Thu, Aug 4, 2022 at 9:39 PM Lei Zhang wrote: > > > > > > > > Hi, Zheng Feng > > > > > > > > In version 0.7.0, I introduced Maven CI Friendly Versions and > > > > flatten-maven-plugin to manage version numbers in pom. > > > > > > > > But I forgot to add flatten-maven-plugin configuration in the main > pom. > > > The > > > > version number in the main pom was not replaced with 0.7.0 (Still > > > > 0.7.0-SNAPSHOT) > > > > > > > > I have fixed this issue in the trunk and 0.7.x branch. > > > > > > > > I have rewritten the pack release guide[1] in my notes, which I will > > > push a > > > > PR to the pack repo later. > > > > > > > > [1] https://coolbeevip.github.io/posts/asf/apache-release-guide/ > > > > > > > > Zheng Feng 于2022年8月4日周四 18:27写道： > > > > > > > > > Is there any doc for the release processing? > > > > > > > > > > Willem Jiang 于2022年8月4日周四 17:00写道： > > > > > > > > > > > Yes, we need to cut a new release to fix this issue. > > > > > > BTW, we also need to verify the pom project version by running > some > > > > > > verification. > > > > > > > > > > > > Willem Jiang > > > > > > > > > > > > Twitter: willemjiang > > > > > > Weibo: 姜宁willem > > > > > > > > > > > > On Tue, Aug 2, 2022 at 8:21 PM Lei Zhang > > > wrote: > > > > > > > > > > > > > > Hello All, > > > > > > > > > > > > > > Our recently released 0.7.0 release contains the wrong version > > > > > > > 0.7.0-SNAPSHOT[1] > > > > > > > > > > > > > > I have pushed PR[2] to fix this in the 0.7.x branch and master > > > > > > > > > > > > > > I will be cutting the 0.7.1 release from the branch > > > > > > > https://github.com/apache/servicecomb-pack/tree/0.7.x > > > > > > > > > > > > > > @PMC/@Committers please let me know if I missed anything in > this > > > > > release. > > > > > > > > > > > > > > [1] https://github.com/apache/servicecomb-pack/issues/763 > > > > > > > [2] https://github.com/apache/servicecomb-pack/pull/766 > > > > > > > > > > > > > > Regards > > > > > > > > > > > > > > Lei Zhang > > > > > > > > > > > > > > >
Re: Apache ServiceComb Pack emergency releases for wrong version
I think you can just update the markdown file in the servicecomb website here[1]. [1]https://github.com/apache/servicecomb-website/tree/master/_release Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Aug 5, 2022 at 3:20 PM Lei Zhang wrote: > > Hi, Willem > > This is a good suggestion, I will add a version number check script to the > release guide > > Also, the pack release guide contains a lot of how-to details > There is a big difference between the servicecomb website > Can we push the release guide to the pack repo and add a link on > servicecomb website？ > > > > > > > Willem Jiang 于2022年8月5日周五 10:55写道： > > > It would be great if we can update the release guide on the servicecomb > > website. > > BTW, it's strange that maven release plugin can allow the release > > artifact as the dependency of SNAPSHOT. > > Not sure if it relates to the flatten-maven plugin. > > My suggestion is we should add a check script to avoid this mistake > > just like below: > > find ~/.m2/repository/org/apache/servicecomb/pack -name "0.7.0.pom" | > > xargs grep "SNAPSHOT" > > > > > > Willem Jiang > > > > Twitter: willemjiang > > Weibo: 姜宁willem > > > > On Thu, Aug 4, 2022 at 9:39 PM Lei Zhang wrote: > > > > > > Hi, Zheng Feng > > > > > > In version 0.7.0, I introduced Maven CI Friendly Versions and > > > flatten-maven-plugin to manage version numbers in pom. > > > > > > But I forgot to add flatten-maven-plugin configuration in the main pom. > > The > > > version number in the main pom was not replaced with 0.7.0 (Still > > > 0.7.0-SNAPSHOT) > > > > > > I have fixed this issue in the trunk and 0.7.x branch. > > > > > > I have rewritten the pack release guide[1] in my notes, which I will > > push a > > > PR to the pack repo later. > > > > > > [1] https://coolbeevip.github.io/posts/asf/apache-release-guide/ > > > > > > Zheng Feng 于2022年8月4日周四 18:27写道： > > > > > > > Is there any doc for the release processing? > > > > > > > > Willem Jiang 于2022年8月4日周四 17:00写道： > > > > > > > > > Yes, we need to cut a new release to fix this issue. > > > > > BTW, we also need to verify the pom project version by running some > > > > > verification. > > > > > > > > > > Willem Jiang > > > > > > > > > > Twitter: willemjiang > > > > > Weibo: 姜宁willem > > > > > > > > > > On Tue, Aug 2, 2022 at 8:21 PM Lei Zhang > > wrote: > > > > > > > > > > > > Hello All, > > > > > > > > > > > > Our recently released 0.7.0 release contains the wrong version > > > > > > 0.7.0-SNAPSHOT[1] > > > > > > > > > > > > I have pushed PR[2] to fix this in the 0.7.x branch and master > > > > > > > > > > > > I will be cutting the 0.7.1 release from the branch > > > > > > https://github.com/apache/servicecomb-pack/tree/0.7.x > > > > > > > > > > > > @PMC/@Committers please let me know if I missed anything in this > > > > release. > > > > > > > > > > > > [1] https://github.com/apache/servicecomb-pack/issues/763 > > > > > > [2] https://github.com/apache/servicecomb-pack/pull/766 > > > > > > > > > > > > Regards > > > > > > > > > > > > Lei Zhang > > > > > > > > > > >
Re: [VOTE] Release Apache ServiceComb Pack version 0.7.1
+1 (binding) I created a demo project[1] outside the servicecomb pack repo for testing 0.7.1, and it passed. [1] https://github.com/coolbeevip/tutorials/tree/master/distributed-transaction/servicecomb-pack-saga-demo Lei Zhang Willem Jiang 于2022年8月5日周五 10:38写道： > +1 (binding) > I checked the source kit and maven repo, they look good to me. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > > On Thu, Aug 4, 2022 at 2:11 AM Lei Zhang wrote: > > > > Hi all, > > > > This is a call for Vote to release Apache ServiceComb Pack version 0.7.1 > > > > Release Candidate: > > > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-pack/0.7.1/rc1/ > > > > Staging Repository: > > > https://repository.apache.org/content/repositories/orgapacheservicecomb-1509/ > > > > Release Tag: > > https://github.com/apache/servicecomb-pack/releases/tag/0.7.1 > > > > Release CommitID: > > 9edd26e2d6e246f9b11a48f646645bb610afafe6 > > > > Release Notes: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626=12352159 > > > > Keys to verify the Release Candidate: > > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS > > > > Voting will start now (Thursday, 4th Aug 2022) and will remain open for > > at-least 72 hours, Request all PMC members to give their vote. > > > > [ ] +1 Release this package as 0.7.1 > > [ ] +0 No Opinion > > [ ] -1 Do not release this package because... > > > > On behalf of the ServiceComb Team > > > > Lei Zhang >
Re: Apache ServiceComb Pack emergency releases for wrong version
Hi, Willem This is a good suggestion, I will add a version number check script to the release guide Also, the pack release guide contains a lot of how-to details There is a big difference between the servicecomb website Can we push the release guide to the pack repo and add a link on servicecomb website？ Willem Jiang 于2022年8月5日周五 10:55写道： > It would be great if we can update the release guide on the servicecomb > website. > BTW, it's strange that maven release plugin can allow the release > artifact as the dependency of SNAPSHOT. > Not sure if it relates to the flatten-maven plugin. > My suggestion is we should add a check script to avoid this mistake > just like below: > find ~/.m2/repository/org/apache/servicecomb/pack -name "0.7.0.pom" | > xargs grep "SNAPSHOT" > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Thu, Aug 4, 2022 at 9:39 PM Lei Zhang wrote: > > > > Hi, Zheng Feng > > > > In version 0.7.0, I introduced Maven CI Friendly Versions and > > flatten-maven-plugin to manage version numbers in pom. > > > > But I forgot to add flatten-maven-plugin configuration in the main pom. > The > > version number in the main pom was not replaced with 0.7.0 (Still > > 0.7.0-SNAPSHOT) > > > > I have fixed this issue in the trunk and 0.7.x branch. > > > > I have rewritten the pack release guide[1] in my notes, which I will > push a > > PR to the pack repo later. > > > > [1] https://coolbeevip.github.io/posts/asf/apache-release-guide/ > > > > Zheng Feng 于2022年8月4日周四 18:27写道： > > > > > Is there any doc for the release processing? > > > > > > Willem Jiang 于2022年8月4日周四 17:00写道： > > > > > > > Yes, we need to cut a new release to fix this issue. > > > > BTW, we also need to verify the pom project version by running some > > > > verification. > > > > > > > > Willem Jiang > > > > > > > > Twitter: willemjiang > > > > Weibo: 姜宁willem > > > > > > > > On Tue, Aug 2, 2022 at 8:21 PM Lei Zhang > wrote: > > > > > > > > > > Hello All, > > > > > > > > > > Our recently released 0.7.0 release contains the wrong version > > > > > 0.7.0-SNAPSHOT[1] > > > > > > > > > > I have pushed PR[2] to fix this in the 0.7.x branch and master > > > > > > > > > > I will be cutting the 0.7.1 release from the branch > > > > > https://github.com/apache/servicecomb-pack/tree/0.7.x > > > > > > > > > > @PMC/@Committers please let me know if I missed anything in this > > > release. > > > > > > > > > > [1] https://github.com/apache/servicecomb-pack/issues/763 > > > > > [2] https://github.com/apache/servicecomb-pack/pull/766 > > > > > > > > > > Regards > > > > > > > > > > Lei Zhang > > > > > > > >
