[DISCUSSION] Duplicate logs printed when calling RetryLoadBalancer#chooseServer method
Hi Team:
In servicecomb-java-chassis, when calling RetryLoadBalancer#chooseServer,
the method will call LoadBalancer#chooseServer and 17 duplicate logs may be
printed when all of the following happen:
1. There are 1 or more ServiceCombServer after getting servers from local
context;
2. There are no ServiceCombServer remained after getting filtered list of
servers.
Some code inLoadBalancer#chooseServer shown as following:
public ServiceCombServer chooseServer(Invocation invocation) {
List
Re: [VOTE] Release Apache ServiceComb Mesher version 1.6.3
+1 -- Original -- From: Xiaoliang Tian https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-mesher/1.6.3/rc-02/ Release Tag : https://github.com/apache/servicecomb-mesher/tree/v1.6.3 Release CommitID: c6a5e8af27470842a138da276c20223b31ab19bc Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626version=12346107 Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/servicecomb/KEYS Voting will start now ( Friday, 6nd September, 2019) and will remain open for at-least 72 hours, Request all PMC members to give their vote. [ ] +1 Release this package as 1.6.3 [ ] +0 No Opinion [ ] -1 Do not release this package because On the behalf of ServiceComb Team Best Wishes Regards Xiaoliang Tian | | yhs0092 | | ??yhs0...@163.com | ??
Re: [VOTE] Release Apache ServiceComb Mesher version 1.6.3
+1 --Original-- From:"victor chan"mailto:xiaoliang.t...@gmail.com] : 2019??9??3?? 19:27 ??: dev https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-mesher/1.6.3/rc-01/ Release Tag : https://github.com/apache/servicecomb-mesher/tree/v1.6.3 Release CommitID : 683ad1ee9a6d7e739146278d4173615913a7e81e Release Notes : https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626version=12346107 Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/servicecomb/KEYS Voting will start now ( Tuesday, 27nd August, 2019) and will remain open for at-least 72 hours, Request all PMC members to give their vote. [ ] +1 Release this package as 0.1.0 [ ] +0 No Opinion [ ] -1 Do not release this package because On the behalf of ServiceComb Team Best Wishes Regards
[DISCUSSION] Set all dependency version as properties in java-chasis-dependencies
Hi Team, In java-chasis-dependencies, some dependency versions are set as properties while others not. As DM, it is not very clear to show version informations and also not convenient for version updating. In spring-boot-dependencies and spring-cloud-dependencies, ALL version informations are set as properties in tag which is quite graceful. It is a boring job to move all version infos to properties, however, it may helpful for further development so I am willing to do that if needed. Ang Li
[DISCUSSION] WebSocket Supporting in Java-Chasis
Hi Team, Currently, ServiceComb Java-Chasis does not support websocket and some users are confused about that. WebSocket, as a communications protocol, can be used in many situations and websocket is supported by many other frameworks. So should we support websocket in ServiceComb Java-Chasis? I will be very glad to work for the task if needed. Ang Li
?????? [DISSCUSSIOIN] Adding 'Issues' module for servicecomb-fenceand other
+1. Most open source project users are more familiar with issue module than with JIRA. Best, Ang Li -- -- ??: "yhs0092"; : 2019??8??6??(??) 9:07 ??: "dev@servicecomb.apache.org"; : Re: [DISSCUSSIOIN] Adding 'Issues' module for servicecomb-fenceand other +1. Agree to enable the issue feature. Yours sincerely Yao Haishi yhs0...@163.com On 8/5/2019 21:08??Willem Jiang wrote?? I agree it could easy for the user to repo the bug or ask questions through issue. I think we can enable the issue feature of fence, toolkit, mesher, toolkit, by default. Willem Jiang Twitter: willemjiang Weibo: willem On Mon, Aug 5, 2019 at 6:44 PM Liubao (A) wrote: Hi Team, Recently, some servicecomb-fence users found not possible to ask questions in project "Issues" module. Although we recommend users to ask questions through JIRA, but it is not convenient and sometimes JIRA is very slow and can't be accessed. I suggest open "Issues" module for every servicecomb projects. Any suggestions? Servicecomb-fence : no servicecomb-java-chassis: yes servicecomb-service-center: yes servicecomb-pack: yes servicecomb-website: no servicecomb-mesher: yes servicecomb-docs: no servicecomb-samples: no servicecomb-toolkit: no servicecomb-kie : no
BeanUtils.getImplClassFromBean can not return correctly info in cglib proxy situation
Hey Guys,
I found a problem using
org.apache.servicecomb.foundation.common.utils.BeanUtils#getImplClassFromBean.
If the @param bean is a cgLib proxy subclass bean, the getImplClassFromBean
method will return null instead of super class which is expected. To make the
issure more clearly, I created a bean class as following:
static class TestBean{
}
static class TestBean$$TestBeanByCGLIB$$e1a36bab extends TestBean implements
SpringProxy {
}The case is to simulate a bean class proxied by cglib proxy.A test case
provided as following and the case is not past.@Test
public void testGetImplClassFromBeanfromCglib(){
TestBean testBeanByCGLIB = new TestBean$$TestBeanByCGLIB$$e1a36bab();
Assert.assertEquals(TestBean.class,
BeanUtils.getImplClassFromBean(testBeanByCGLIB));
}This matters because cglib proxy can be used while using serviceComb framework
and I think just a few lines of code changing can fix this
issue.-Best,
Ang Li
