[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown
wujimin commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388683495 in performance test, ShutdownHookHandler will always block shutdown process for many seconds (wait for timeout for wrong request/response count statistics) will change statistics from invocation handler to invocation event after change to invocation event, then reject in invocation handler is too late so shutdown hook will rewrite by new hook, even in performance test, we can shutdown normally in one or two second. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown
wujimin commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388522879 and CI failed, it's about trace, i can find what happened, it seems that did not print error test case name? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown
wujimin commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-388522824 ShutdownHookHandler is not so good, sometimes will block shutdown process cause of wrong statistics, must depend on timeout to make shutdown process continue. we should: 1.prevent create new consumer invocation 2.prevent other find me 3.make accurate statistics This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on issue #693: [SCB-548] support gracefully shutdown
wujimin commented on issue #693: [SCB-548] support gracefully shutdown URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-387991593 if ContextCloseEvent and handler/ShutdownHookHandler.java is random ordered, then it's not ok This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
