[RESULT] [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-04-03 Thread Mohammad Asif Siddiqui
Hello All,

We are glad to announce that ServiceComb community has approved the Apache
ServiceComb Service-Center 1.2.0 release with the following results:

+1 binding: 4 (Willem Jiang, Cuiyihua, Liubao, Mohammad Asif Siddiqui)

We will be publishing the release binaries soon.

Thanks All for your participation in this vote.

On the behalf of ServiceComb Team
Mohammad Asif Siddiqui


Re: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-04-03 Thread Mohammad Asif Siddiqui
+1 binding  
  
Checks Done :  
- Hashes and Signature is good  
- Archive matching the Git tag  
- LICENSE, NOTICE exist  
- ASF headers present in relevant files  
- Compiled code from source  
- Ran Test in Windows, Mac & Linux
  
Regards  
Asif

On 2019/03/29 07:35:01, Mohammad Asif Siddiqui  wrote: 
> Hi All,  
>   
> This is a call for a Vote to release Apache ServiceComb Service-Center 
> version 1.2.0  
>   
> Release Notes : 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12344562
>   
>   
> Release Candidate : 
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-service-center/1.2.0/rc-01/
>   
>   
> Release Tag : 
> https://github.com/apache/servicecomb-service-center/releases/tag/1.2.0  
>   
> Release CommitID : de7166e156ddb179429e8ac4739562513f95c21d  
>   
> Keys to verify the Release Candidate : 
> https://dist.apache.org/repos/dist/dev/servicecomb/KEYS  
>   
> Guide to build the release from source : 
> https://github.com/apache/servicecomb-service-center/tree/master/scripts/release
>   
>   
> Voting will start now ( Friday, 29th March, 2019) and will remain open for 
> at-least 72 hours, Request all PMC members to give their vote.  
>   
> [ ] +1 Release this package as 1.2.0  
> [ ] +0 No Opinion  
> [ ] -1 Do not release this package because  
>   
> On the behalf of ServiceComb Team  
> Mohammad Asif Siddiqui 
> 


Re: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-04-03 Thread Mohammad Asif Siddiqui
Hi All,

This vote is closed now and we will be announcing the results shortly.

Thanks All for helping to verify the release.

Regards
Asif

On Fri, Mar 29, 2019 at 1:05 PM Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Hi All,
>
> This is a call for a Vote to release Apache ServiceComb Service-Center
> version 1.2.0
>
> Release Notes :
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12344562
>
>
> Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-service-center/1.2.0/rc-01/
>
>
> Release Tag :
> https://github.com/apache/servicecomb-service-center/releases/tag/1.2.0
>
> Release CommitID : de7166e156ddb179429e8ac4739562513f95c21d
>
> Keys to verify the Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
>
> Guide to build the release from source :
> https://github.com/apache/servicecomb-service-center/tree/master/scripts/release
>
>
> Voting will start now ( Friday, 29th March, 2019) and will remain open for
> at-least 72 hours, Request all PMC members to give their vote.
>
> [ ] +1 Release this package as 1.2.0
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> On the behalf of ServiceComb Team
> Mohammad Asif Siddiqui
>


?????? [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-04-02 Thread Sure
Ok, I will follow this rule next time, and here are the bug fixes

Add grpc keepalive time

Should not show the shared microservices by default

Use the raw password if decrypt failed

Re-register instance does not keep alive the lease

Update the api doc

Unexpected events publish if error occurs in previous list-watch loop




--  --
??: "willem.jiang";
: 2019??4??2??(??) 4:04
??: "dev";"Sure";

????: Re: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0



It looks like little cui just using SCB-1059[1] to track all the bug
fix,  it causes us lots of trouble to list all the fix from the change
log.
I just updated the JIRA description with the information that I found
from Github PR.

@Sure  Could you add some description on the Bug fix change on the
SCB-1059 issue description?
Next time we just create one JIRA issue per PR.

[1]https://issues.apache.org/jira/browse/SCB-1059

Willem Jiang

Twitter: willemjiang
Weibo: willem

On Tue, Apr 2, 2019 at 3:47 PM wjm wjm  wrote:
>
> [SCB-1059] - Bug fixes for v1.1.0
>
> there are many fixes, it's better to list detail.
>
> Willem Jiang  ??2019??4??2?? 10:17??
>
> > +1 (binding)
> > I checked the signed key and the license files and run the binary server
> > on Mac.
> >
> > I just found a minor issue about the Notice file, we need to updated the
> > year.
> > It's not a blocker issue, I will submit a quick fix for it.
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: willem
> >
> > On Fri, Mar 29, 2019 at 3:35 PM Mohammad Asif Siddiqui
> >  wrote:
> > >
> > > Hi All,
> > >
> > > This is a call for a Vote to release Apache ServiceComb Service-Center
> > version 1.2.0
> > >
> > > Release Notes :
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12344562
> > >
> > > Release Candidate :
> > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-service-center/1.2.0/rc-01/
> > >
> > > Release Tag :
> > https://github.com/apache/servicecomb-service-center/releases/tag/1.2.0
> > >
> > > Release CommitID : de7166e156ddb179429e8ac4739562513f95c21d
> > >
> > > Keys to verify the Release Candidate :
> > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> > >
> > > Guide to build the release from source :
> > https://github.com/apache/servicecomb-service-center/tree/master/scripts/release
> > >
> > > Voting will start now ( Friday, 29th March, 2019) and will remain open
> > for at-least 72 hours, Request all PMC members to give their vote.
> > >
> > > [ ] +1 Release this package as 1.2.0
> > > [ ] +0 No Opinion
> > > [ ] -1 Do not release this package because
> > >
> > > On the behalf of ServiceComb Team
> > > Mohammad Asif Siddiqui
> >

Re: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-04-02 Thread Willem Jiang
It looks like little cui just using SCB-1059[1] to track all the bug
fix,  it causes us lots of trouble to list all the fix from the change
log.
I just updated the JIRA description with the information that I found
from Github PR.

@Sure  Could you add some description on the Bug fix change on the
SCB-1059 issue description?
Next time we just create one JIRA issue per PR.

[1]https://issues.apache.org/jira/browse/SCB-1059

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Tue, Apr 2, 2019 at 3:47 PM wjm wjm  wrote:
>
> [SCB-1059] - Bug fixes for v1.1.0
>
> there are many fixes, it's better to list detail.
>
> Willem Jiang  于2019年4月2日周二 上午10:17写道:
>
> > +1 (binding)
> > I checked the signed key and the license files and run the binary server
> > on Mac.
> >
> > I just found a minor issue about the Notice file, we need to updated the
> > year.
> > It's not a blocker issue, I will submit a quick fix for it.
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Fri, Mar 29, 2019 at 3:35 PM Mohammad Asif Siddiqui
> >  wrote:
> > >
> > > Hi All,
> > >
> > > This is a call for a Vote to release Apache ServiceComb Service-Center
> > version 1.2.0
> > >
> > > Release Notes :
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12344562
> > >
> > > Release Candidate :
> > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-service-center/1.2.0/rc-01/
> > >
> > > Release Tag :
> > https://github.com/apache/servicecomb-service-center/releases/tag/1.2.0
> > >
> > > Release CommitID : de7166e156ddb179429e8ac4739562513f95c21d
> > >
> > > Keys to verify the Release Candidate :
> > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> > >
> > > Guide to build the release from source :
> > https://github.com/apache/servicecomb-service-center/tree/master/scripts/release
> > >
> > > Voting will start now ( Friday, 29th March, 2019) and will remain open
> > for at-least 72 hours, Request all PMC members to give their vote.
> > >
> > > [ ] +1 Release this package as 1.2.0
> > > [ ] +0 No Opinion
> > > [ ] -1 Do not release this package because
> > >
> > > On the behalf of ServiceComb Team
> > > Mohammad Asif Siddiqui
> >


Re: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-04-02 Thread wjm wjm
[SCB-1059] - Bug fixes for v1.1.0

there are many fixes, it's better to list detail.

Willem Jiang  于2019年4月2日周二 上午10:17写道:

> +1 (binding)
> I checked the signed key and the license files and run the binary server
> on Mac.
>
> I just found a minor issue about the Notice file, we need to updated the
> year.
> It's not a blocker issue, I will submit a quick fix for it.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Fri, Mar 29, 2019 at 3:35 PM Mohammad Asif Siddiqui
>  wrote:
> >
> > Hi All,
> >
> > This is a call for a Vote to release Apache ServiceComb Service-Center
> version 1.2.0
> >
> > Release Notes :
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12344562
> >
> > Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-service-center/1.2.0/rc-01/
> >
> > Release Tag :
> https://github.com/apache/servicecomb-service-center/releases/tag/1.2.0
> >
> > Release CommitID : de7166e156ddb179429e8ac4739562513f95c21d
> >
> > Keys to verify the Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> >
> > Guide to build the release from source :
> https://github.com/apache/servicecomb-service-center/tree/master/scripts/release
> >
> > Voting will start now ( Friday, 29th March, 2019) and will remain open
> for at-least 72 hours, Request all PMC members to give their vote.
> >
> > [ ] +1 Release this package as 1.2.0
> > [ ] +0 No Opinion
> > [ ] -1 Do not release this package because
> >
> > On the behalf of ServiceComb Team
> > Mohammad Asif Siddiqui
>


Re: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-04-01 Thread Willem Jiang
+1 (binding)
I checked the signed key and the license files and run the binary server on Mac.

I just found a minor issue about the Notice file, we need to updated the year.
It's not a blocker issue, I will submit a quick fix for it.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Fri, Mar 29, 2019 at 3:35 PM Mohammad Asif Siddiqui
 wrote:
>
> Hi All,
>
> This is a call for a Vote to release Apache ServiceComb Service-Center 
> version 1.2.0
>
> Release Notes : 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12344562
>
> Release Candidate : 
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-service-center/1.2.0/rc-01/
>
> Release Tag : 
> https://github.com/apache/servicecomb-service-center/releases/tag/1.2.0
>
> Release CommitID : de7166e156ddb179429e8ac4739562513f95c21d
>
> Keys to verify the Release Candidate : 
> https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
>
> Guide to build the release from source : 
> https://github.com/apache/servicecomb-service-center/tree/master/scripts/release
>
> Voting will start now ( Friday, 29th March, 2019) and will remain open for 
> at-least 72 hours, Request all PMC members to give their vote.
>
> [ ] +1 Release this package as 1.2.0
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because
>
> On the behalf of ServiceComb Team
> Mohammad Asif Siddiqui


Re: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-03-31 Thread Sure
+1 binding

the gpg verify is PASS

the use cases run in windows and linux are PASS

licenses are OK

readme is OK





-- Original --
From: Mohammad Asif Siddiqui 
Date: Fri,Mar 29,2019 3:35 PM
To: dev 
Subject: Re: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0



Hi All,  
  
This is a call for a Vote to release Apache ServiceComb Service-Center version 
1.2.0  
  
Release Notes : 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12344562
  
  
Release Candidate : 
https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-service-center/1.2.0/rc-01/
  
  
Release Tag : 
https://github.com/apache/servicecomb-service-center/releases/tag/1.2.0  
  
Release CommitID : de7166e156ddb179429e8ac4739562513f95c21d  
  
Keys to verify the Release Candidate : 
https://dist.apache.org/repos/dist/dev/servicecomb/KEYS  
  
Guide to build the release from source : 
https://github.com/apache/servicecomb-service-center/tree/master/scripts/release
  
  
Voting will start now ( Friday, 29th March, 2019) and will remain open for 
at-least 72 hours, Request all PMC members to give their vote.  
  
[ ] +1 Release this package as 1.2.0  
[ ] +0 No Opinion  
[ ] -1 Do not release this package because  
  
On the behalf of ServiceComb Team  
Mohammad Asif Siddiqui

??????[VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-03-29 Thread bismy
+1


Checks done
1. Release Notes is ok. Some minor improvements suggestion: 

[SCB-1059] - Bug fixes for v1.1.0
maybe we can list all related bugs. 
2. Release Candidate downloaded and tested. 








--  --
??: "Mohammad Asif Siddiqui";
: 2019??3??29??(??) 3:35
??: "dev";

????: [VOTE] Release Apache ServiceComb Service-Center version 1.2.0



Hi All,  
  
This is a call for a Vote to release Apache ServiceComb Service-Center version 
1.2.0  
  
Release Notes : 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12344562
  
  
Release Candidate : 
https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-service-center/1.2.0/rc-01/
  
  
Release Tag : 
https://github.com/apache/servicecomb-service-center/releases/tag/1.2.0  
  
Release CommitID : de7166e156ddb179429e8ac4739562513f95c21d  
  
Keys to verify the Release Candidate : 
https://dist.apache.org/repos/dist/dev/servicecomb/KEYS  
  
Guide to build the release from source : 
https://github.com/apache/servicecomb-service-center/tree/master/scripts/release
  
  
Voting will start now ( Friday, 29th March, 2019) and will remain open for 
at-least 72 hours, Request all PMC members to give their vote.  
  
[ ] +1 Release this package as 1.2.0  
[ ] +0 No Opinion  
[ ] -1 Do not release this package because  
  
On the behalf of ServiceComb Team  
Mohammad Asif Siddiqui

[VOTE] Release Apache ServiceComb Service-Center version 1.2.0

2019-03-29 Thread Mohammad Asif Siddiqui
Hi All,  
  
This is a call for a Vote to release Apache ServiceComb Service-Center version 
1.2.0  
  
Release Notes : 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12344562
  
  
Release Candidate : 
https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-service-center/1.2.0/rc-01/
  
  
Release Tag : 
https://github.com/apache/servicecomb-service-center/releases/tag/1.2.0  
  
Release CommitID : de7166e156ddb179429e8ac4739562513f95c21d  
  
Keys to verify the Release Candidate : 
https://dist.apache.org/repos/dist/dev/servicecomb/KEYS  
  
Guide to build the release from source : 
https://github.com/apache/servicecomb-service-center/tree/master/scripts/release
  
  
Voting will start now ( Friday, 29th March, 2019) and will remain open for 
at-least 72 hours, Request all PMC members to give their vote.  
  
[ ] +1 Release this package as 1.2.0  
[ ] +0 No Opinion  
[ ] -1 Do not release this package because  
  
On the behalf of ServiceComb Team  
Mohammad Asif Siddiqui