Re: 回复： [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

2018-03-08 Thread Mohammad Asif Siddiqui 
Hi Willem,  
  
This is not an issue, this is more like a suggestion to handle the 
configuration in a better way, as the values of SC_IP can still be changed in 
js file as per our Readme.  
  
So IMO we don't need to add this in Known Issues list.
  
Anyhow I have created a JIRA for this [1] to track this issue in m2.  
  
[1] https://issues.apache.org/jira/browse/SCB-377  
  
Regards  
Asif  
  

On 2018/03/08 08:55:56, Willem Jiang  wrote: 
> Hi Asif，
> 
> Please create a JIRA for checking the apiList.js issue.
> Then we can add this known issue to the release note and address it in m2
> release.
> 
> 
> Willem Jiang
> 
> Blog: http://willemjiang.blogspot.com (English)
>   http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
> 
> On Thu, Mar 8, 2018 at 3:49 PM, Mohammad Asif Siddiqui <
> asifdxtr...@apache.org> wrote:
> 
> > Thanks YangBo and Cuiyihua for the suggestion.
> >
> > We will move the frontend configurations to the app.conf and add the
> > frontend starting guide in the main Readme, so from here on there will be
> > only 1 Readme and 1 conf which can be used by both frontend and
> > service-center.
> >
> > Coming back to configuration of SC api in frontend we will definitely move
> > this to configuration to the app.conf and it can be dynamically replaced
> > when frontend will start, this needs some time of testing in windows system
> > as in linux it's quite easy but in some windows OS version it fails, so
> > that was the reason we kept this conf in apiList.js. We will take this
> > issues in m2 release.
> >
> > Regards
> > Asif
> >
> >
> > On 2018/03/08 07:38:32, "Sure"  wrote:
> > > Suggestion: merge these configures in SC app.conf, and move the frontend
> > readme into main readme.
> > >
> > >
> > >
> > >
> > > -- 原始邮件 --
> > > 发件人: "Yang Bo";
> > > 发送时间: 2018年3月8日(星期四) 下午3:36
> > > 收件人: "dev";
> > >
> > > 主题: Re: [VOTE] Release Apache ServiceComb Service-Center
> > (incubating)version 1.0.0-m1
> > >
> > >
> > >
> > > Hi Asif,
> > >
> > > For the first issue, It's OK that we leave it as is in this release. But
> > in
> > > the long run, it's still better to put the configurations together(the
> > > frontend.conf file).
> > >
> > >
> > > On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui <
> > > asifdxtr...@apache.org> wrote:
> > >
> > > > Hi YangBo,
> > > >
> > > > Thanks for your vote.
> > > >
> > > > We will fix the 2nd and 3rd Issue.
> > > >
> > > > For 1st Issue I would like to clear that the hardcode values are in js
> > > > files which can be modifies easily afterwards in the release, which we
> > have
> > > > already mentioned in our Readme over here [1]
> > > >
> > > > [1] https://github.com/apache/incubator-servicecomb-service-
> > > > center/tree/master/frontend#note
> > > >
> > > > Regards
> > > > Asif
> > > >
> > > >
> > > > On 2018/03/08 07:20:17, Yang Bo  wrote:
> > > > > -1 Binding Vote.
> > > > >
> > > > > Below Checks Done:
> > > > > 1. Verified the md5sum, sha1sum and GPG signature for source and
> > binary
> > > > > release packages.
> > > > > 2. Verified the service-center linux release using Java Chassis BMI
> > > > sample.
> > > > > 3. Verified the frontend on both windows and linux.
> > > > > 4. Checked the bundled files, no fonts and images without proper
> > > > licensing
> > > > > bundled.
> > > > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> > > > > source release
> > > > > 6. RAT on source release is OK
> > > > >
> > > > > Some issues:
> > > > > 1. The service-center's address/port is hardcoded in frontend's js
> > file,
> > > > > which cause the frontend to not functioning if service center is not
> > > > > running on 127.0.0.1:30100.
> > > > > Bug report: https://issues.apache.org/jira/browse/SCB-375
> > > > >
> > > > > 2. The scripts in binary release does not contain the ASF header.
> > > > > start-frontend.sh
> > > > > start-service-center.sh
> > > > > stop-frontend.sh
> > > > > stop-service-center.sh
> > > > >
> > > > > 3. Scripts on source release have ASF header but the script shebang
> > is
> > > > not
> > > > > in the first line, which would cause problems if the script is not
> > called
> > > > > directy by bash. We should still put the shell shebang on the first
> > line
> > > > of
> > > > > scripts and followd by a blank line then the ASF header.
> > > > > For example:
> > > > > ===
> > > > > #!/bin/bash
> > > > >
> > > > > # Licensed to the Apache ...
> > > > >
> > > > >
> > > > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C 
> > wrote:
> > > > >
> > > > > > +1 Binding Vote.
> > > > > >
> > > > > > Below Checks Done:
> > > > > > 1. Verify the file signature.
> > > > > > 2. Verified windows release for service center using java chassis
> > demo.

Re: 回复： [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

2018-03-08 Thread Willem Jiang 
Hi Asif，

Please create a JIRA for checking the apiList.js issue.
Then we can add this known issue to the release note and address it in m2
release.


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Thu, Mar 8, 2018 at 3:49 PM, Mohammad Asif Siddiqui <
asifdxtr...@apache.org> wrote:

> Thanks YangBo and Cuiyihua for the suggestion.
>
> We will move the frontend configurations to the app.conf and add the
> frontend starting guide in the main Readme, so from here on there will be
> only 1 Readme and 1 conf which can be used by both frontend and
> service-center.
>
> Coming back to configuration of SC api in frontend we will definitely move
> this to configuration to the app.conf and it can be dynamically replaced
> when frontend will start, this needs some time of testing in windows system
> as in linux it's quite easy but in some windows OS version it fails, so
> that was the reason we kept this conf in apiList.js. We will take this
> issues in m2 release.
>
> Regards
> Asif
>
>
> On 2018/03/08 07:38:32, "Sure"  wrote:
> > Suggestion: merge these configures in SC app.conf, and move the frontend
> readme into main readme.
> >
> >
> >
> >
> > -- 原始邮件 --
> > 发件人: "Yang Bo";
> > 发送时间: 2018年3月8日(星期四) 下午3:36
> > 收件人: "dev";
> >
> > 主题: Re: [VOTE] Release Apache ServiceComb Service-Center
> (incubating)version 1.0.0-m1
> >
> >
> >
> > Hi Asif,
> >
> > For the first issue, It's OK that we leave it as is in this release. But
> in
> > the long run, it's still better to put the configurations together(the
> > frontend.conf file).
> >
> >
> > On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui <
> > asifdxtr...@apache.org> wrote:
> >
> > > Hi YangBo,
> > >
> > > Thanks for your vote.
> > >
> > > We will fix the 2nd and 3rd Issue.
> > >
> > > For 1st Issue I would like to clear that the hardcode values are in js
> > > files which can be modifies easily afterwards in the release, which we
> have
> > > already mentioned in our Readme over here [1]
> > >
> > > [1] https://github.com/apache/incubator-servicecomb-service-
> > > center/tree/master/frontend#note
> > >
> > > Regards
> > > Asif
> > >
> > >
> > > On 2018/03/08 07:20:17, Yang Bo  wrote:
> > > > -1 Binding Vote.
> > > >
> > > > Below Checks Done:
> > > > 1. Verified the md5sum, sha1sum and GPG signature for source and
> binary
> > > > release packages.
> > > > 2. Verified the service-center linux release using Java Chassis BMI
> > > sample.
> > > > 3. Verified the frontend on both windows and linux.
> > > > 4. Checked the bundled files, no fonts and images without proper
> > > licensing
> > > > bundled.
> > > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> > > > source release
> > > > 6. RAT on source release is OK
> > > >
> > > > Some issues:
> > > > 1. The service-center's address/port is hardcoded in frontend's js
> file,
> > > > which cause the frontend to not functioning if service center is not
> > > > running on 127.0.0.1:30100.
> > > > Bug report: https://issues.apache.org/jira/browse/SCB-375
> > > >
> > > > 2. The scripts in binary release does not contain the ASF header.
> > > > start-frontend.sh
> > > > start-service-center.sh
> > > > stop-frontend.sh
> > > > stop-service-center.sh
> > > >
> > > > 3. Scripts on source release have ASF header but the script shebang
> is
> > > not
> > > > in the first line, which would cause problems if the script is not
> called
> > > > directy by bash. We should still put the shell shebang on the first
> line
> > > of
> > > > scripts and followd by a blank line then the ASF header.
> > > > For example:
> > > > ===
> > > > #!/bin/bash
> > > >
> > > > # Licensed to the Apache ...
> > > >
> > > >
> > > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C 
> wrote:
> > > >
> > > > > +1 Binding Vote.
> > > > >
> > > > > Below Checks Done:
> > > > > 1. Verify the file signature.
> > > > > 2. Verified windows release for service center using java chassis
> demo.
> > > > > 3. Ran the Service-Center and Frontend, verified basic
> functionality of
> > > > > service center and frontend.
> > > > >
> > > > > Thanks,
> > > > > Sukesh.
> > > > >
> > > > > -Original Message-
> > > > > From: Mohammad Asif Siddiqui [mailto:asifdxtr...@apache.org]
> > > > > Sent: 07 March 2018 23:11
> > > > > To: dev@servicecomb.apache.org
> > > > > Subject: [VOTE] Release Apache ServiceComb Service-Center
> (incubating)
> > > > > version 1.0.0-m1
> > > > >
> > > > > Hi All,
> > > > >
> > > > > This is a call for Vote to release Apache ServiceComb
> Service-Center
> > > > > (Incubating) version 1.0.0-m1 (second release candidate).
> > > > >
> > > > > Release Notes : https://github.com/apache/
> > > incubator-servicecomb-service-
> > > > >

Re: 回复： [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

2018-03-07 Thread Mohammad Asif Siddiqui 
Thanks YangBo and Cuiyihua for the suggestion.  
  
We will move the frontend configurations to the app.conf and add the frontend 
starting guide in the main Readme, so from here on there will be only 1 Readme 
and 1 conf which can be used by both frontend and service-center.  
  
Coming back to configuration of SC api in frontend we will definitely move this 
to configuration to the app.conf and it can be dynamically replaced when 
frontend will start, this needs some time of testing in windows system as in 
linux it's quite easy but in some windows OS version it fails, so that was the 
reason we kept this conf in apiList.js. We will take this issues in m2 release. 
 
  
Regards  
Asif  


On 2018/03/08 07:38:32, "Sure"  wrote: 
> Suggestion: merge these configures in SC app.conf, and move the frontend 
> readme into main readme.
> 
> 
> 
> 
> -- 原始邮件 --
> 发件人: "Yang Bo";
> 发送时间: 2018年3月8日(星期四) 下午3:36
> 收件人: "dev";
> 
> 主题: Re: [VOTE] Release Apache ServiceComb Service-Center 
> (incubating)version 1.0.0-m1
> 
> 
> 
> Hi Asif,
> 
> For the first issue, It's OK that we leave it as is in this release. But in
> the long run, it's still better to put the configurations together(the
> frontend.conf file).
> 
> 
> On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui <
> asifdxtr...@apache.org> wrote:
> 
> > Hi YangBo,
> >
> > Thanks for your vote.
> >
> > We will fix the 2nd and 3rd Issue.
> >
> > For 1st Issue I would like to clear that the hardcode values are in js
> > files which can be modifies easily afterwards in the release, which we have
> > already mentioned in our Readme over here [1]
> >
> > [1] https://github.com/apache/incubator-servicecomb-service-
> > center/tree/master/frontend#note
> >
> > Regards
> > Asif
> >
> >
> > On 2018/03/08 07:20:17, Yang Bo  wrote:
> > > -1 Binding Vote.
> > >
> > > Below Checks Done:
> > > 1. Verified the md5sum, sha1sum and GPG signature for source and binary
> > > release packages.
> > > 2. Verified the service-center linux release using Java Chassis BMI
> > sample.
> > > 3. Verified the frontend on both windows and linux.
> > > 4. Checked the bundled files, no fonts and images without proper
> > licensing
> > > bundled.
> > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> > > source release
> > > 6. RAT on source release is OK
> > >
> > > Some issues:
> > > 1. The service-center's address/port is hardcoded in frontend's js file,
> > > which cause the frontend to not functioning if service center is not
> > > running on 127.0.0.1:30100.
> > > Bug report: https://issues.apache.org/jira/browse/SCB-375
> > >
> > > 2. The scripts in binary release does not contain the ASF header.
> > > start-frontend.sh
> > > start-service-center.sh
> > > stop-frontend.sh
> > > stop-service-center.sh
> > >
> > > 3. Scripts on source release have ASF header but the script shebang is
> > not
> > > in the first line, which would cause problems if the script is not called
> > > directy by bash. We should still put the shell shebang on the first line
> > of
> > > scripts and followd by a blank line then the ASF header.
> > > For example:
> > > ===
> > > #!/bin/bash
> > >
> > > # Licensed to the Apache ...
> > >
> > >
> > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C  wrote:
> > >
> > > > +1 Binding Vote.
> > > >
> > > > Below Checks Done:
> > > > 1. Verify the file signature.
> > > > 2. Verified windows release for service center using java chassis demo.
> > > > 3. Ran the Service-Center and Frontend, verified basic functionality of
> > > > service center and frontend.
> > > >
> > > > Thanks,
> > > > Sukesh.
> > > >
> > > > -Original Message-
> > > > From: Mohammad Asif Siddiqui [mailto:asifdxtr...@apache.org]
> > > > Sent: 07 March 2018 23:11
> > > > To: dev@servicecomb.apache.org
> > > > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating)
> > > > version 1.0.0-m1
> > > >
> > > > Hi All,
> > > >
> > > > This is a call for Vote to release Apache ServiceComb Service-Center
> > > > (Incubating) version 1.0.0-m1 (second release candidate).
> > > >
> > > > Release Notes : https://github.com/apache/
> > incubator-servicecomb-service-
> > > > center/blob/master/docs/release/releaseNotes.md
> > > >
> > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
> > > >
> > > > Release Tag : https://github.com/apache/incubator-servicecomb-service-
> > > > center/releases/tag/1.0.0-m1
> > > >
> > > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
> > > >
> > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > > > dist/dev/incubator/servicecomb/KEYS
> > > >
> > > > Release Source :

Re: 回复： [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

2018-02-13 Thread Mohammad Asif Siddiqui 
 Hi All,
We are cancelling this vote now as there as some issues with Service-Center 
which we are fixing, we will raise another Vote Mail in new thread once we are 
done with our testing.
Thanks all for your support.
RegardsAsif
On Monday, February 12, 2018, 2:59:14 PM GMT+5:30, Sure <sure_0...@qq.com> 
wrote:  
 
 ISSUE link: https://issues.apache.org/jira/browse/SCB-343


-- 原始邮件 --
发件人: "Sure"<sure_0...@qq.com>;
发送时间: 2018年2月12日(星期一) 下午5:27
收件人: "dev@servicecomb.apache.org"<dev@servicecomb.apache.org>;

主题: 回复： [VOTE] Release Apache ServiceComb Service-Center (incubating)version 
1.0.0-m1



-1


there is a major bug in this version, i have raise an ISSUE here.
and i will fix it as soon as possible.


-- 原始邮件 --
发件人: "Mahesh Raju Somalaraju"<maheshraju.o...@gmail.com>;
发送时间: 2018年2月12日(星期一) 下午2:42
收件人: "dev"<dev@servicecomb.apache.org>;

主题: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 
1.0.0-m1



+1
Tested build from source on linux/windows machine and tested user case 
to be OK

On 2018/02/09 03:26:16, Mohammad Asif Siddiqui wrote:
 > Hi All,>
 > This is a call for vote to release ServiceComb Service-Center 
(Incubating)  version 1.0.0-m1>
 > Release 
Notes: 
https://github.com/asifdxtreme/incubator-servicecomb-service-center/tree/master/docs/release-notes
 
  >
 >
 > Release 
Candidate: 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
   > 

 > Release 
Tag: 
https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1
   > 

 > Release CommitId: d34f6619d76667c038bd2e8f2ab5c00dc45c5cab  >
 >
 > Keys to Verify the Release 
Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  > 

 > For building the binary from the source you can refer 
to 
https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release
 > 

 >
 > Voting will start now (Firday, 9th Feburary, 2018) and will remain 
open for next 72 hours, Request all PPMC members to give their vote.>
 >
 > [ ] +1 Release this package as 1.0.0-m1 [ ] +0 No opinion[ ] -1 Do 
not release this package because>
 >
 >
 >
 > With RegardsMohammad Asif Siddiqui>
 >
 >

RE: 回复：[VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

2018-02-11 Thread Sukesh A C 
+1
Build success from source on linux/windows machine ,Basic user cases passed.

-Original Message-
From: Sure [mailto:sure_0...@qq.com] 
Sent: 09 February 2018 11:40
To: dev <dev@servicecomb.apache.org>; dev@servicecomb.apache.org
Subject: 回复：[VOTE] Release Apache ServiceComb Service-Center 
(incubating)version 1.0.0-m1

+1
Tested build from source on linux/windows machine and tested user case to be OK




-- 原始邮件 --
发件人: "Mohammad Asif Siddiqui"<asifdxtr...@yahoo.com.INVALID>; 
发送时间: 2018年2月9日(星期五) 中午11:26
收件人: "dev@servicecomb.apache.org"<dev@servicecomb.apache.org>; 
主题: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 
1.0.0-m1



Hi All,
This is a call for vote to release ServiceComb Service-Center (Incubating)  
version 1.0.0-m1
Release Notes: 
https://github.com/asifdxtreme/incubator-servicecomb-service-center/tree/master/docs/release-notes
   

Release Candidate: 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
   
Release Tag: 
https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1
   
Release CommitId: d34f6619d76667c038bd2e8f2ab5c00dc45c5cab  

Keys to Verify the Release Candidate: 
https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  
For building the binary from the source you can refer to 
https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release
 

Voting will start now (Firday, 9th Feburary, 2018) and will remain open for 
next 72 hours, Request all PPMC members to give their vote.

[ ] +1 Release this package as 1.0.0-m1 [ ] +0 No opinion[ ] -1 Do not release 
this package because



With RegardsMohammad Asif Siddiqui